Commit Graph

304 Commits (5413ee94316db3480eca5a233e732a55ada8f3c0)

Author SHA1 Message Date
James Cammarata 5e8918cb2c Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
11 years ago
James Cammarata ef02c6107a Minor fix to account for template service names in systemctl 11 years ago
James Cammarata f22ffab259 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
11 years ago
James Laska 5dc830c279 The required package for selinux is libselinux-python 11 years ago
Brian Coca 849d7b282b Added collection of user's env
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata 21ae255fb3 Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 11 years ago
James Cammarata 17f683aad7 Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
11 years ago
Serge van Ginderachter 129fa6689f Introduce open-iscsi module to manage targets on the initiator. 11 years ago
Raul Melo b0ffba472f Fix issue 3908. There was some ilegal operations over the sets 11 years ago
James Cammarata b4306920ce Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
11 years ago
Hiroaki Nakamura 2bef08705f Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split! 11 years ago
Hiroaki Nakamura bf21ba1521 Rewrite with "try ... finally" instead of "with" statement to support Python 2.4. 11 years ago
Hiroaki Nakamura 860cf75fdc Remove extra sysloggings. 11 years ago
Hiroaki Nakamura 14fde81ad5 Raise an error on unsupported platform/distributions. 11 years ago
Hiroaki Nakamura 557c25a794 Add a hostname module, which sets system's hostname. 11 years ago
Marcin Płonka 4a43bb3b00 Skipping facts not available on AIX WPARs 11 years ago
shirou 26e6ac4340 supports nested values of ohai. 11 years ago
Michael DeHaan 003c86e250 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 11 years ago
Andy Wilson 85e34cc107 docfix: grammar in docstring for sysctl module 11 years ago
Petr Svoboda 48b064b55b Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
11 years ago
Michael Scherer bb9d0a9493 Add urpmi as a package manager for mandriva-based distribution 11 years ago
James Cammarata 494030aa6c Removing skipped=True so the task is just marked as not-changed 11 years ago
James Cammarata f3384374b9 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
11 years ago
rishid fea38f44ac Verify groups string is not empty before trying add user to groups 11 years ago
Brian Coca e8e8779dfa fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 2c06418f6d whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca fe57037f84 now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Michael DeHaan 5b80299231 Make exceptions handling python 2.4 compatible. 11 years ago
Michael DeHaan ecf074865f Continue on mount errors, don't fail the setup module. 12 years ago
Brian Coca 220fe24d39 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 3f4c6affa3 Update CHANGELOG 12 years ago
Michael DeHaan 9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 12 years ago
Michael DeHaan 4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
12 years ago
Michael DeHaan 517c318989 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
12 years ago
Brian Coca 7132f7e792 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Florian Tham 865a663d05 fix fatal error when removing logical volumes 12 years ago
Antti Rasinen f9e9286b2c Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
12 years ago
Antti Rasinen 8bfe9f6942 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
12 years ago
trbs 98b284159f fix missing json module for issue #3363 print JSON error as string instead 12 years ago
Brian Coca dd1ffce0a0 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan b22428d87e Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
12 years ago
Michael DeHaan 7dfafc6ec4 Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
12 years ago
Michael DeHaan 38ac6c9abd Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
12 years ago
Michael DeHaan 03605484f8 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
12 years ago
Johan Wirén 3e765f7775 Updated GenericBsdIfconfigNetwork to collect gateway 12 years ago
Johan Wirén a03125e0cf Fix for populating default_ipv6 on BSD systems 12 years ago
Joshua Lund d75f73fffe Added a new with_file example to the authorized_key documentation 12 years ago
Patrick Callahan f37becb94a Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
12 years ago
Brian Coca e0e50b5936 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Casper Langemeijer 8727f0ce11 Only append non_unique parameter if a uid is provided as well 12 years ago
Aaron Brady 34617476d0 Make the CPU facts Hyperthreading aware 12 years ago
trbs 0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 12 years ago
Antti Rasinen c2a4645349 Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
12 years ago
Brian Coca b494d6d2ae updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Michael DeHaan 8d23df3576 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
12 years ago
Michael DeHaan da0e718698 Styling: semicolon 12 years ago
Michael DeHaan 936ad65726 Styling: blank lines 12 years ago
Serge van Ginderachter fc01f88228 add more support for different size formats 12 years ago
martin f. krafft 3b7b061b07 Expand usage of Python 2.6 if statement
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
martin f. krafft 22b30b9281 Let update-rc.d set changed flag properly
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
12 years ago
Michael DeHaan 997bf64f3f Fix up some module docs formatting errors. 12 years ago
Patrick Callahan d76151d47b bug fix: modify get_device_facts to handle servers with multiple pci domains
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
12 years ago
Michael DeHaan 0596f474cf Merge pull request #3147 from toshywoshy/setup_mtab_without_bind
changed get_mount_facts to ignore mount types 'none'
12 years ago
Michael DeHaan e4f3c4e286 Clarify module docs 12 years ago
Michael DeHaan f53bc323a5 Merge pull request #3230 from sayap/openrc
Add OpenRC support to the service module.
12 years ago
Brian Coca 930e524df1 now mount/unmount are searched for instead of hardcoded
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Yap Sok Ann ec265a98e0 Add OpenRC support to the service module. 12 years ago
Michael DeHaan 709d2aaa0d Merge pull request #3120 from chrisgardner/solaris-os-facts
Add Solaris O/S distribution facts
12 years ago
Michael DeHaan 3840c608da Resolve docs conflict. 12 years ago
Michael DeHaan 4a7f0eeccc Fix merge conflict. 12 years ago
Michael DeHaan 1ea46e814d Merge pull request #3228 from skvidal/facts.d
first cut and docs for facts.d mechanism for setup module
12 years ago
Michael DeHaan ae223ae10f Merge pull request #3181 from melodous/devel
HP-UX virtualization facts
12 years ago
trbs e711145ba4 fixed x-bits in git 12 years ago
Michael DeHaan 152db00ed9 Merge remote branch 'origin' into devel
Conflicts:
	library/web_infrastructure/django_manage
12 years ago
Michael DeHaan 9017919f16 Merge pull request #3176 from jpmens/sol-epoch
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
12 years ago
Seth Vidal 38b055143a cut and docs for facts.d mechanism for setup module 12 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Raul Melo 866903ebbc HP-UX virtualization facts 12 years ago
Jan-Piet Mens 8bce89a616 setup epoch time doesn't have tics on Python 2.6.4 (Solaris). 12 years ago
Jan-Piet Mens 846b48655b Protect None value in setup module 12 years ago
Michael DeHaan 30cab814e8 Use get_bin_path for blkid and add some aliases to the filesystem module. 12 years ago
Joshua Lund dcad99ca6b Updates to the authorized_key documentation
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
12 years ago
Toshaan Bharvani bf6bd10797 changed get_mount_facts to ignore mount types 'none' 12 years ago
Raul Melo 4c5d32f958 Facts for HP-UX 12 years ago
Chris Gardner 28cc0119a1 Use first line from /etc/release in "distribution_release" for consistency across Solaris and derivatives. 12 years ago
Michael DeHaan e5b14d7170 Merge branch 'devel' of git://github.com/trbs/ansible into more_users 12 years ago
Michael DeHaan 9de5ecbdfc These options to bypass the check code seem to need to occur before said checks. 12 years ago
Chris Gardner 3bdf742d50 Add Solaris O/S facts "distribution" and "distribution_*" 12 years ago
Michael DeHaan 3012d269ff pep8 fixes 12 years ago
Michael DeHaan fa2d027e33 Fix module labelled incorrectly. 12 years ago
Michael DeHaan 6503aea5fe Docs standardization 12 years ago
Michael DeHaan 64320fc662 Docs standardization 12 years ago
Michael DeHaan 7efe74d151 Warn when there is a space in the mount module opts parameter. 12 years ago
trbs a31ba582b4 Add support for Open and NetBSD platforms for user and group modules, including a new login_class parameter for FreeBSD, OpenBSD and NetBSD. 12 years ago
Michael DeHaan 373e4ee7d4 Merge pull request #3083 from mvo5/feature/facts-add-statvfs
add "size_{total,free}" to the "mount" facts
12 years ago
Michael DeHaan 3765f4e400 Merge pull request #3076 from mmoya/userspace-arch-facts
Provide userspace_{architecture,bits} facts
12 years ago
Michael DeHaan 82f319d717 Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel 12 years ago
Michael DeHaan 10c905e3e2 Remove debug statement in previous patch. 12 years ago
Michael DeHaan dc1242d7eb Merge branch 'devel' of git://github.com/trbs/ansible into groups 12 years ago
Stephen Fromm 44cdd2dc0f cleanup to dmi fact discovery
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts:  first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
12 years ago
Michael DeHaan f8f4eb8e9b Merge pull request #3068 from lorin/authkey-default
authorized_key: Set manage_dir default value
12 years ago
Michael DeHaan 291cd0b0c4 Merge pull request #3044 from chrisgardner/solaris_facts
Solaris facts
12 years ago
Michael DeHaan e6620cdb9a Refine error message. 12 years ago
Michael DeHaan da1738723a Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd 12 years ago
Michael Vogt fcfc9f5194 use statvfs.f_bavail to match the output of "df -B1" 12 years ago
Michael Vogt fc3631b684 add "size_{total,free}" to the "mount" facts 12 years ago
Maykel Moya e9a4741e36 Provide userspace_{architecture,bits} facts
When running inside a chroot userspace architecture might not
match that of the actual host.

This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
12 years ago
Chris Gardner 2d423ece52 Add Solaris network facts. IPv4 and IPv6 both working. 12 years ago
trbs 1f673450cd Fix for #3062 additional groups should only be added once.
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
12 years ago
Lorin Hochstein ec2fc7c983 authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Michael DeHaan 94c35df69c Merge pull request #3064 from sfromm/issue2990
Verify /proc/modules is readable (issue #2990)
12 years ago
Stephen Fromm c23ce83375 Verify /proc/modules is readable (issue #2990) 12 years ago
Stephen Fromm 44025024e9 Use get_bin_path to find mkfs command (issue #2983) 12 years ago
Chris Gardner 972545407c Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 12 years ago
Chris Gardner 3cf243ec3e TODO: Separate IPv4 and IPv6 12 years ago
Jiří Kubíček 626cbc4e8b Add some FreeBSD facts
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
12 years ago
Chris Gardner d5bb7188f0 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 12 years ago
Chris Gardner f05540cb48 Add clock speed to processor description for SPARC CPU. 12 years ago
Chris Gardner 35ee8a16de Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 12 years ago
Michael DeHaan da348cf079 Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 12 years ago
Guillaume Lasmayous fe484e5fd7 Implement NetBSD-specific subclass of Hardware in the setup module.
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
12 years ago
Chris Gardner 7d61180034 Use kstat for Solaris CPU info 12 years ago
Chris Gardner 50c3cf302c Use kstat for Solaris CPU info 12 years ago
Kristof Keppens f607ba09a4 change fix to lookup path with get_bin_path 12 years ago
Michael DeHaan b0f62209c6 Merge pull request #2992 from SirScott/service_pattern
Fixes #2991: Service module pattern argument ignored.
12 years ago
Scott Sturdivant ffb50dfb34 Fixes #2924: User creation always reports 'changed' 12 years ago
Scott Sturdivant 0110b616cb Fixes #2991: Service module pattern argument ignored. 12 years ago
Kristof Keppens dc20d63919 fix for facter being installed in a different location 12 years ago
Elan Ruusamäe 52643e2a4d no need to init None to None 12 years ago
Michael DeHaan 3ad9866124 Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
12 years ago
Michael DeHaan fc36695e7a Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
12 years ago
Ton Kersten 438ab750c3 Fix issue 2906 12 years ago
Brian Coca af745d0f9a no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt)
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
madema 973eb69911 -o and -r option don't exist on AIX 12 years ago
Michael DeHaan 911213f8d7 Style fix. 12 years ago
Michael DeHaan 4ef987736a Merge pull request #2866 from madema/patch-2
Fixed an error in the get_cpu_facts of the AIX class
12 years ago
Michael DeHaan 05fb9876d3 Merge pull request #2865 from madema/patch-1
Added AIX class in the service module to control AIX SRC processes.
12 years ago
Michael DeHaan a7521a9826 Merge pull request #2863 from lonerr/freebsd-group
FreeBSD group operations is now supported properly.
12 years ago
Michael DeHaan da6cb522ed Merge pull request #2862 from lonerr/freebsd-user
Fixed errors in FreeBSD user manipulations.
12 years ago
Michael DeHaan a9f5f86edb Change filesystem module message. 12 years ago
Michael DeHaan 9ca9b4cb29 Merge pull request #2853 from abulimov/module_mkfs
Module filesystem
12 years ago
Elan Ruusamäe 258cf60924 LinuxService: avoid enforcing systemd even if init.d script was found 12 years ago
madema 57fb97470c Update service 12 years ago
madema 54abf22c35 Fixed an error in the get_cpu_facts of the AIX class
assumed proc0 as the first processor but can be different in a LPAR environment
12 years ago
madema 88a4a56889 Added AIX class in the service module to control AIX SRC processes. 12 years ago
lonerr 384798145a FreeBSD group operations is now supported properly. 12 years ago
lonerr 2a8ef8a87c Fixed errors in FreeBSD user manipulations. 12 years ago
Oleg 6735ec6e9d fix for authorized_key: skip chown and chmod if authorized_key_file is link 12 years ago
Alexander Bulimov 6a644714a7 renamed mkfs and moved to system/filesystem 12 years ago
Luciano Cavalheiro da Silva 96d4225245 Fix #2836. Ensure proper handling of option "system=yes" in module "group". 12 years ago
rektide 351bcf24cf Duplicate pull #2803 in ipv6, fixing setup module's handling of venet & unknown interface types. 12 years ago
Michael DeHaan b0794ff5f6 Test for the existance of a file that might not be present on older RHEL. 12 years ago
James Mills ced36f3e81 Fixed setup module to accomodate venet interfaces (OpenVZ) 12 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago