Commit Graph

4721 Commits (52b0ef20d4862a1376b8a0a7cc06ff9f44de5434)

Author SHA1 Message Date
James Martin c8cc089de2 Fixes a regression in 1453f7b013 that would causes unecessary wait_timeouts in certain module operations when a given IP address could not be found. Now wait_timeouts are only active during address associations of newly provisioned EIPs.
Cleanup and comment of main().

s Added wait timeout.
10 years ago
Michael DeHaan ec8ff9ce42 Merge pull request #8415 from ebargtuo/patch-1
Fix a typo in gem module documentation
10 years ago
Michael DeHaan 542aa496fc Merge pull request #8409 from Jmainguy/hostname_8339
Fixes issue #8339 where Scientific Linux incorrectly tries to use Fedora...
10 years ago
Michael DeHaan 07bb7e5a3b Revert ""allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem"
This reverts commit cbdc9f1153.

Code needs to make allowances for particular python versions and try/except
around this block.
10 years ago
Michael DeHaan c5f92597e4 Add version_added attribute for regexp parameter. 10 years ago
Will Thames cc59760ac9 Improved handling of already terminated instances
It is possible to create an instance, terminate the instance and then
attempt to recreate the instance with the same parameters. In this case
`ec2.run_instances` returns a reservation list containing the instance ids
but the logic gets stuck waiting for the instance to exist in the call to
`ec2.get_all_instances`, even if wait is no).
10 years ago
Monty Taylor f3357099a7 Pass region_name to nova_keypair
Again, on things with regions, when we're configuring it, we should
actually pass it in to the compute constructor.
10 years ago
Monty Taylor b81a37ad9b Rename nova filters to include and exclude
jeblair says: "having 'flavor_filter' be inclusive, and 'image_filter'
be exclusive is kind of mind blowing" and I agree. Let's be more
explicit.
10 years ago
Monty Taylor 38beae3b19 Add nova config drive support
Config drive can be enabled on nova by passing config_drive=True.
That's a pretty easy feature to support.
10 years ago
ebargtuo 76aae48ea6 Fix a typo in gem module documentation 10 years ago
Monty Taylor a05804bf8d Update the nova inventory plugin with new ip code
The provisioning module knows more about how nova deals with IP
addresses now. Ensure that the inventory module is similarly as smart
by separating out the logic into the openstack/module_utils.
10 years ago
Monty Taylor a12086f1bf Update existing nova instances with current ip
During the state check, check IP address information. This gets us
two things. The most obvious is that for direct IP management, a
change to the config will reflect in the config of the instance. But
also, if we succeed in creating the instance but fail in adding an IP,
this should let us re-run and arrive in the state we were expecting.
10 years ago
Monty Taylor c6975552d7 Cleaned up nova_compute documentation
Added version_added tags as well as a few more examples.
10 years ago
Monty Taylor b80be42ed9 Add ability to filter on image and flavor names
The fun part about having multiple vendors providing the same cloud
is that while their APIs are the same, what they do with their metadata
tends to be ... fun. So in order to be able to express sanely what you
want without needing to stick tons of unreadable uuids in your config,
it turns out what sometimes you need to further filter image and flavor
names. Specific examples are (deprecated) images in HP Cloud and the
Standard and Performance flavors on Rackspace.
10 years ago
Monty Taylor 65adb6465b Specify nova image and flavor by name
Putting uuid and numberic identifies in playbooks is fragile, especially
with cloud providers who change them out from under you. Asking for
Ubuntu 14.04 is consistent, the UUID associated with that is not. Add
mutually exclusive parameters to allow for specifying images by name and
flavors by RAM amount.
10 years ago
Monty Taylor 3fe1083192 Use mutually exclusive on nova floating ip params
ansible knows how to deal with mutually exclusive parameters, so
instead of coding that ourselves, use it.
10 years ago
Monty Taylor d17a1b5c19 Add common auth handling across openstack modules
Taking a page out of the ec2 config, make sure that all of the
OpenStack modules handle the inbound auth config in the same way.
The one outlier is keystone wrt auth_url.
10 years ago
Monty Taylor ac420fd483 Consume standard OpenStack environment settings
The OpenStack client utilities consume a set of input environment
variables for things like username and auth_url, so it's very
common for OpenStack users to have such settings set in their
environment. Indeed, things like devstack also output a shell file
to be sourced to set them. Although in a playbook it's entirely
expected that variables should be used to pass in system settings
like api passwords, for ad-hoc command line usage, needing to pass
in five parameters which are almost certainly in the environment
already reduces the utility.

Grab the environment variables and inject them as default. Special care
is taken to ensure that in the case where the values are not found, the
behavior of which parameters are required is not altered.
10 years ago
Monty Taylor 2611246b89 Cleanup in nova after a failed floating ip
There is a potential leak of resources if there is somehow a failure
adding a floating ip to a server. Clean up after ourselves.
10 years ago
Monty Taylor 6045923cab Find IPs on OpenStack clouds without floating-ips
The floating-ip extension, while pretty ubiquitous, is not a
foregone conclusion. Specifically, Rackspace, while also
served by the rax module, is a valid OpenStack cloud and can
be interacted with directly via nova interfaces.

Add support for determining public and private IPs for
OpenStack clouds that don't use floating ips by reading
the public and private keys from the addresses dict.
10 years ago
Monty Taylor 1e0e7a6b28 Add support for nova availability zones
If a cloud has availability zone support, it's possible to specify
an availability zone via the nova client. Add that as a config param.
10 years ago
Monty Taylor 8938222029 Pass through nova region name
If the region name is specified in the config, we need to pass it
in to the nova client constructor. Since key_name is similarly optional,
go ahead and handle both parameters the same.
10 years ago
Monty Taylor 10a50b4a61 Split nova floating-ip pool logic
The desires around getting a floating ip associated with a pool and
getting a floating ip not associated with a pool is just different
enough that following it as one set of nested ifs is tricky. Split
the function into two, one for the pool and one for the non-pool logic.
10 years ago
CaptTofu 6da266f64c Added floating IP functionality to nova_compute 10 years ago
Jonathan Mainguy c0966eee7c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 10 years ago
Nico Cesar cbdc9f1153 "allow_no_value=True" for ini_file module so /etc/my.cnf can be read without a problem 10 years ago
Lorin Hochstein 42df1f890a ec2 module: document valid states 10 years ago
James Cammarata 22f3f2b74a Merge pull request #8174 from altruism/devel
Make ec2_group module not just fail
10 years ago
James Cammarata 745b28072a Check for the numeric "all" value (-1) for the rule protocol
Fixes #7832
10 years ago
James Cammarata 00ce87484b Merge pull request #8363 from greenmoss/devel
Fix Docker image name parsing
10 years ago
James Laska 7288a6095b Several azure fixes
Several azure fixes/improvements, including:
* Improve failure message when python-azure is not installed
* Improve required argument handling
* Fixes a traceback on instance termination when the variable
'deployment' was not set.
* Fixes a traceback (#8298) when creating instances using the newer SDK
10 years ago
Michael DeHaan 19bf388a17 Merge pull request #8353 from gdamjan/ec2-running-return-info
return the most up-to-date info about an instance when starting/stopping it
10 years ago
Dave Johnson 76c925c22a Parameters to disable_rollback are "true" or "false" 10 years ago
Kurt Yoder 8ee6906885 Fix Docker image name parsing
Fixes #8357
10 years ago
Damjan Georgievski 16e5b1b9e6 return the most up-to-date info about an instance when starting/stopping it
otherwise the module will return the info about the instance that it got prior to the action taken
So if you had a task to start an instance:

      ec2:
         instance_ids: ...
         state: running
      register: ec2_info

the registered data would have empty public_dns_name, public_ip, private_dns_name, private_ip
10 years ago
Michael DeHaan f61ba3d047 Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
10 years ago
James Cammarata 730e23fa07 Merge branch 'integration_mysql_user' of https://github.com/wrosario/ansible into wrosario-integration_mysql_user 10 years ago
James Cammarata e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting
Fixes #8338
10 years ago
Wayne Rosario eaf4571e42 Adding the following Test Coverage:
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
10 years ago
RomanDolejsi fcf7f03398 file: prevent replace failure when overwriting empty directory with hard/link (force=yes) 10 years ago
Michael DeHaan f948a94f51 Merge pull request #8313 from sivel/issue/8250
Make sure to assign pyrax.cloudservers to cs. Fixes #8250
10 years ago
Michael DeHaan 6300ded89c Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
10 years ago
Matt Martz 571f343e7d Make sure to assign pyrax.cloudservers to cs. Fixes #8250 10 years ago
Michael DeHaan 226dacc7e6 Cleaning up explanation of mount module states. 10 years ago
Bjorn Neergaard adcdbdf894 Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan b69f096e8a Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 10 years ago
Michael DeHaan 726a1a33e0 Update unarchive example. 10 years ago
Michael DeHaan f412d341e3 Merge pull request #8200 from geetotes/devel
[Docs] Added another example to demonstrate unarchive module working entirely on a remote machine
10 years ago
Michael DeHaan c8d3c0c654 Merge pull request #8244 from wrosario/mysql_user_doc
Update mysql_user doc and example
10 years ago
Michael DeHaan 8b77aa9843 Merge pull request #7949 from hacosta/apt_key
Check at most 16 characters of the key. Fixes #7936
10 years ago
Michael DeHaan 216f803aa5 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
10 years ago
Michael DeHaan a52cbdbced Merge pull request #8068 from trondhindenes/win_feature_improvements
Updates to the parameters of win_feature
10 years ago
Michael DeHaan e75964e206 Merge pull request #7969 from dedalusj/devel
Fixed bug with environment path for homebrew_cask
10 years ago
Michael DeHaan 58a23bc6d1 Merge pull request #7968 from bcoca/acl_fix_compare
acl module: now compares permissions correctly
10 years ago
James Cammarata d1d318b028 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
10 years ago
Robin Roth e91c318327 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth 7a09f87b8c Extended distributions list for hostname module
Implementations already present
10 years ago
James Laska d51e10a3f4 Correct BotoServerError typo in ec2 module
Resolves a traceback due to an undefined 'BotoSeverError' exception.
10 years ago
Lee Gillentine d631056f27 Pushing up correct example :( 10 years ago
James Cammarata 1134f6169c Minor indentation fixes on ec2_eip 10 years ago
James Cammarata 3281139981 Merge branch 'fix_ec2_eip' of https://github.com/jsmartin/ansible into jsmartin-fix_ec2_eip 10 years ago
James Cammarata 4a8e068855 Merge pull request #8292 from jimi-c/issue_7863_deb_with_items
Allow deb package installation via with_items
10 years ago
James Martin 1453f7b013 Fixes #8290. 10 years ago
Tom Lazar 146a0f1cb7 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
anatoly techtonik b28848eee3 acl: Remove obscurity in `state` description 10 years ago
Philip Jay 138fffb152 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Michael DeHaan c9a3b6c358 Pagerduty corrected misleading blog post, so no problems with them being in core now. Thank you guys! 10 years ago
Wayne Rosario d595fd00e9 updating doc to include revoke example for mysql_user docs 10 years ago
Michael DeHaan 1e427d4ace Merge pull request #7710 from brad/zounds
use the full list of available campfire sounds
10 years ago
Michael DeHaan 2e2a1d4bd1 Merge pull request #8270 from berenddeboer/mount-fstab
Default for fstab missing, causing KeyError: 'fstab'
10 years ago
James Cammarata 2cc602beea Fixes for module param counting and additional shell quoting issues 10 years ago
Berend de Boer 869cc7947e Default for fstab missing, causing KeyError: 'fstab' 10 years ago
James Cammarata 75e5b6401c Fixing up shell quoting issues 10 years ago
Trond Hindenes 387759ada6 win_setup improvements: Correcly outputs ansible_totalmem on computers with multiple ram chips 10 years ago
James Cammarata 593057515c Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
10 years ago
Sébastien Gross 48128ec0ab [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
10 years ago
Sébastien Gross f2e2337d07 [mount] Add documentation for fstab option 10 years ago
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
10 years ago
Michael DeHaan 2769b3d0b2 Update version_added attribute on recent GCE module additions. 10 years ago
Michael DeHaan 98c6688343 Merge pull request #6976 from clconway/gce-snapshots
Adds support for snapshots and extra persistent disks to the gce modules
10 years ago
Hector Acosta ec70bb01ef Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
10 years ago
Lee Gillentine 69337362e7 Adding another example to demonstrate unarchive working entirely on a remote machine 10 years ago
Michael DeHaan 9caa93c1cf Add note about useful quote filter. 10 years ago
Jonathan Mainguy 6789098bc5 This fixes 8173, if target was not defined it would break, now it wont 10 years ago
Will Angenent 0e33db837a Fix for issue #8152: Missing auth headers and a faulty JSON decode
Looks like this regressed in commit 9730157 due to fetch_url refactors.
10 years ago
Yasser Nabi 8a6bbfd3b5 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
10 years ago
Jacob Hickey ea9af2cbb1 Add missing params to get_target_from_rule
get_target_from_rule was extracted from main() without enough parameters for
all the local variables it took with it from the extraction site.
10 years ago
Michael DeHaan 515d10fd88 Merge pull request #8172 from phenomenes/channel-key-parameter
Adds channel key parameter
10 years ago
Michael DeHaan 3aa10d9db5 Merge pull request #8145 from amandolo/ec2_tag
Fix EC2_TAG module output structure when listing tags
10 years ago
Jimena Cabrera-Notari 7efd8b61a6 Adds channel key parameter 10 years ago
Michael DeHaan 64b874129f Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
10 years ago
Michael DeHaan ec874193fe Merge pull request #8143 from PinGwynn/feature
portage: default exit (not fail) if sync=yes in check mode
10 years ago
James Cammarata 68e59332c7 Merge branch 'patch-2' of https://github.com/napkindrawing/ansible into napkindrawing-patch-2 10 years ago
James Cammarata ac73822405 Expand target for mysql_db
Fixes #8128
10 years ago
James Cammarata d7469218a5 Merge pull request #8126 from dingus9/patch-1
Update lineinfile validate help
10 years ago
James Cammarata 02a6d5224f Merge pull request #8124 from dataxu/dev-asg-set-health-checks
Added setting of the health_check options on an existing ASG
10 years ago
Michael DeHaan 616d749ab3 Merge pull request #8156 from jirutka/fix-layman
layman: remove my email address
10 years ago
James Cammarata 3492e8748e Merge pull request #8146 from rmarchei/8102
fix get_distribution_version() on amazon linux
10 years ago
James Cammarata 19571d3f23 Merge pull request #7914 from hacosta/devel
Correctly handle .repo files in zypper_repository module
10 years ago
Ruggero Marchei 8904c61932 fix LooseVersion exception with empty distribution_version 10 years ago