Commit Graph

702 Commits (51b6b725cc70bc9ee4c0b488b85471e66c594c35)

Author SHA1 Message Date
Brian Coca 328b6b5a39 Merge pull request #1454 from grossws/patch-issue-530
Escape spaces, backslashes and ampersands in fstab
10 years ago
Brian Coca 2b209f8065 Merge pull request #1642 from sivel/core-fixups
Core module fix-ups
10 years ago
Toshio Kuratomi 1dc5074602 Merge pull request #1651 from verm666/issue-1515
fix authorized_keys in check_mode
10 years ago
Matt Martz b6b576abf6 Replaced tabbed indentation with spaces for group module 10 years ago
verm666 b00b3f2b3c fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
10 years ago
Brian Coca d59de3af63 Merge pull request #578 from sysadmin75/mount_dir_spaces
allows spaces in names for mount module
10 years ago
Brian Coca 6f6d7f5c18 updated docs to clarify use of exclusive 10 years ago
Brian Coca fed5ff04a6 Merge pull request #742 from aseigneurin/fix-remove-cron_file
Name parameter should not be marked as mandatory
10 years ago
Hagai Kariti 9d833d1d4c Hostname module should update ansible_hostname 10 years ago
Konstantin Gribov dadc1faebd Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
10 years ago
Greg DeKoenigsberg 2a5f0bde87 Proper author info for all remaining modules 10 years ago
Brian Coca 9acc7c402f Revert "added innitial daemon-reloaded support to service module"
This reverts commit 438d87d269.
10 years ago
Brian Coca 438d87d269 added innitial daemon-reloaded support to service module 10 years ago
Patrik Lundin fb41bdfc1e service: Fix comments in OpenBsdService class.
No functional change.
10 years ago
Brian Coca d02ef57815 minor doc fix 10 years ago
Brian Coca 0c9dd0e6a4 Merge pull request #751 from j2sol/service_must_exist
Add service option to avoid failure on missing service
10 years ago
Brian Coca 1736c8dfea Merge pull request #1399 from SUSE/devel
Add SLE12 support to hostname.py
10 years ago
Jonathan Mainguy 442b6a2067 fixes check mode for Ubuntu 14.04 10 years ago
Vladislav Lewin 771b369005 add SLE12 support to hostname.py 10 years ago
Brian Coca 150b71f11a removed executable bit 10 years ago
Toshio Kuratomi 59ea9003ea Merge pull request #1359 from Jmainguy/hostname_64_chars
added nice error for systemd hosts where name > 64 chars
10 years ago
Toshio Kuratomi 8d2fdf2aff Update the cron docs to specify that it takes a boolean value 10 years ago
Toshio Kuratomi 4106047e77 Fix documentation of the variable that backup file name is returned in 10 years ago
Jonathan Mainguy f7064c672c added nice error for systemd hosts where name > 64 chars 10 years ago
Brian Coca 78d84dc400 value should be string as that is what it compares against 10 years ago
Jonathan Mainguy ffbdd349b8 added openbsd to hostname module 10 years ago
Semyon Deviatkin 4e22a8039c Fix unused variable systemd_enabled
Removed declared but unused variable systemd_enabled
10 years ago
Toshio Kuratomi 60a66a544d Several cleanups to many modules:
* Fix docs to specify when python2.6+ is required (due to a library
  dep).  This helps us know when it is okay to use python2.6+ syntax in
  the file.
* remove BabyJson returns.  See #1211  This commit fixes all but the
  openstack modules.
* Use if __name__ == '__main__' to only run the main part of the module
  if the module is run as a program.  This allows for the potential to
  unittest the code later.
10 years ago
macbeth76 bb2fc14865 Update user.py
M in date format is minutes. m is for months.
10 years ago
James Cammarata c4f6e63117 Fix bug in service where upstart services incorrectly use init scripts
Fixes #1170
10 years ago
Evgenii Terechkov d1595b99bc Add ALT Linux support to hostname module 10 years ago
Michael Scherer a4d7ebc12a Name is a required parameter, fix https://github.com/ansible/ansible/issues/10335 10 years ago
Toshio Kuratomi b668ecc4a3 Merge pull request #1119 from ubergeek42/patch-1
Make link clickable
10 years ago
Brian Coca 727c9131c8 Merge pull request #1138 from bcoca/service_fix
simplified bad if chain
10 years ago
Brian Coca f1d72ea004 simplified bad if chain
hopefully fixes #1136
10 years ago
Brian Coca 61f664bc47 Merge pull request #251 from davidfritzsche/patch-1
Add working status detection for pf on FreeBSD
i'm going to merge this to give you a usable workaround, still I consider this a bug in the init script.
10 years ago
Keith Johnson 7dc1e77263 Make link clickable 10 years ago
James Cammarata 4558cb71f4 Merge branch 'osx_user_fix' of https://github.com/bambou42/ansible-modules-core into bambou42-osx_user_fix
Includes commits for:
* Don't return change if the password is not set
* Set the group to nogroup if none is specified
* Set an uid if none is specified
* Test if SHADOWFILE is set (for Darwin)
* remove unused uid
10 years ago
David Wittman 8d53ef2f60 [service] Fix bug with upstart detection
Upstart scripts are being incorrectly identified as SysV init scripts
due to a logic error in the `service` module.

Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`,
etc.) for managing service state, the codepath for upstart sets
`self.svc_cmd` to an empty string on line 451.

Empty strings are considered a non-truthy value in Python, so
conditionals which are checking the state of `self.svc_cmd` should
explicitly compare it to `None` to avoid overlooking the fact that
the service may be controlled by an upstart script.
10 years ago
Sam Thursfield 60397fae0f Fix authorized_key module crashing when given an invalid key
I tried a playbook with the following (accidentally wrong) task:

  tasks:
      - name: authorized key test
        authorized_key: key=/home/sam/.ssh/id_rsa.pub key_options='command="/foo/bar"' user=sam

I got the following traceback:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true, "parsed": false}
    Traceback (most recent call last):
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 2515, in <module>
        main()
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 460, in main
        results = enforce_state(module, module.params)
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 385, in enforce_state
        parsed_new_key = (parsed_new_key[0], parsed_new_key[1], parsed_options, parsed_new_key[3])
    TypeError: 'NoneType' object has no attribute '__getitem__'

With this fix, I see the expected error instead:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true}
    msg: invalid key specified: /home/sam/.ssh/id_rsa.pub
10 years ago
Mario Loria 30be06c971 Setting the actual passno and dump defaults, and warning user of consequences in nulling
Using ansible 1.8.4, I found that these two options actually work slightly different than advertised.
10 years ago
Dag Wieers 0a91ace6ad Update authorized_key.py
Fix a (common) error in the examples. This is something that may go unnoticed during troubleshooting when copy&pasting the example.
10 years ago
Toshio Kuratomi 939ecd33d4 In service_enable, the default of changed is True so we have to set it
to False explicitly if it is False.

Fixes #875
10 years ago
Carlo Mandelli 0029c960e4 Added HP-UX subclass 10 years ago
Oleg A. Mamontov fa19753707 On FreeBSD apply 'login_class' only if there is real change. 10 years ago
Edward Larkey 4db27877bf Fix typo in authorized key module documentation.
Added opening double quote
10 years ago
Stefan J. Betz dc470cc91f Create SSH Keys always after creating $HOME 10 years ago
Brian Coca 5df3058aab fix for mount w/o opts (bug introduced when fixing bind mounts) 10 years ago
Brian Coca 1bca815d37 Merge pull request #95 from Gamevy/use-insserv
Use insserv where available
10 years ago
Brian Coca ed8154bdc7 Merge pull request #759 from jonhadfield/systemd_enabled_check
use is-enabled to check systemd service status.
10 years ago