Commit Graph

92 Commits (50bd8a82faf1a4c3eee6f7be286e3c7be7af305f)

Author SHA1 Message Date
Michael DeHaan 7f4718bca4 Merge pull request #2490 from szinck/devel
Added SunOS (Solaris, illumos, etc) service management
12 years ago
Michael DeHaan 4f4ee3693f Merge pull request #2440 from jochu/service-chkconfig-add
attempt to add service to chkconfig when suggested
12 years ago
Shaun Zinck 8a6ef8c69a service: fix typo 'err' in SunOS service class 12 years ago
Paul Sbarra b545b4c5fc service: add systemd template support 12 years ago
Paul Sbarra 4cfda2a965 service: fix systemd compilation error with --check 12 years ago
Shaun Zinck 60bfd38820 Added SunOS (Solaris, illumos, etc) service management using svcadm and svcs commands 12 years ago
Stephen Fromm 5194a71a70 Limit scope of arguments to service_control() in service module
This fixes handling of arguments (module argument) in service_control().
It is now locally scoped such that modifications to it, in the case of a
systemd host, do not later impact subsequent calls to service_control().
See issue #2449.

Without patch:
ansible-service[6177]: Command /usr/bin/systemctl stop cups cups , daemonize True

With patch:
ansible-service[6475]: Command /usr/bin/systemctl start cups , daemonize True

I also updated the comments to reflect the case where systemd is really
being called.
12 years ago
Jeffrey Chu f1829a0f86 attempt to add service to chkconfig when suggested 12 years ago
Jeffrey Chu efc98a09fe fail when service cannot be found by chkconfig 12 years ago
Patrik Lundin 88a840e52f Dont exit in FreeBSD/NetBSD subclass in check mode
* As the FIXMEs note: only exit if enable state is going to change.
* This is already handled in service_enable_rcconf() being called by both subclasses.
12 years ago
Nikolay Panov 03c0b8dcb2 Fixed 'service'. Now it respect 'enabled=no' as well. 12 years ago
Stephen Fromm 6e35392f92 Consider service stopped if rc is 1
Per LSB spec, consider service stopped if rc from 'service status' is 1.
Added comment with url to LSB spec reference.
12 years ago
Ton Kersten 05c70ca712 Squashed commit of the following:
commit e057ea671395ec8847f920a63cf9524f5c8fde5f
Author: Ton Kersten <tonk@tonkersten.com>
Date:   Thu Feb 28 13:02:25 2013 +0100

    Fixed the service command not working

    On Ubuntu 1[02].04 the service name was not recognized because
    there is a SysV style init script, but not an upstart config file.

    Example: The `ntp` client.

    Also removed extra spaces at the end of the lines, while at it.
12 years ago
Daniel Hokka Zakrisson e33e84d24e Merge pull request #2213 from huberteff/devel
Work around hanging module.  Thanks to Daniel Hozac for the tip.
12 years ago
Hubert Feyrer acf8ee9d61 Work around hanging module. Thanks to Daniel Hozac for the tip. 12 years ago
Daniel Hokka Zakrisson 93f02d614b Merge pull request #2187 from dhozac/argument-type-check
Add type checking for module arguments, converting as much as possible
12 years ago
Michael DeHaan 3c40ce5700 Better detection of whether a service is managed by systemd or not. 12 years ago
Michael DeHaan 596c98320a Service module now knows a little more about systemd. This module is
really due for some refactoring, but telling how a service is managed is
a little fuzzy anyway.  on a systemd system typoing the service will now
give you a rather systemd specific error which is somewhat suboptimal.
12 years ago
Michael DeHaan 4be3b06842 Run chkconfig enable/disable only when needed. TODO, apply same logic to update-rc.d/systemd 12 years ago
Michael DeHaan 0380ba7177 If running is given as the state value instead of 'started', still return the correct end state. 12 years ago
Michael DeHaan 624a952c5c The service module made some assumptions about how a service should be managed based on what was installed on the system in terms of service
management tools, which meant upstart services on CentOS6 were not startable.  This tweak allows things like vmware-tools to be controlled
via the service module.  More testing on other distributions (particularly with systemd) is presumably needed.
12 years ago
Daniel Hokka Zakrisson df798d0688 Use argument type checking to convert to boolean 12 years ago
Michael DeHaan 8097fd18a2 'make pep8' is now clean 12 years ago
Michael DeHaan 4f249902b3 Taught service how to use --check mode 12 years ago
Michael DeHaan b63bf62b13 Remove debug print message 12 years ago
Michael DeHaan 931b9f41c8 Make note about enablement bit 12 years ago
Michael DeHaan 934f416387 Avoid the 'state=null' coming back from the service module. 12 years ago
Blair Zajac fa8e653011 Simplify and correct comparisons with None. 12 years ago
Hubert Feyrer 18d9fc581d Add support for NetBSD. Tested on NetBSD 6.0/i386. 12 years ago
Michael DeHaan 3d6993221e service status 4 should also be stopped 12 years ago
Daniel Hokka Zakrisson dab31116b3 Actually add stdout data to stdout buffer for daemon mode 12 years ago
Brendan Taylor f18446e7a5 service module 'state' parameter comments should be processed by RST 12 years ago
Daniel Hokka Zakrisson d4c0180494 Make service module daemonize for all the broken "daemons" out there 12 years ago
Michael DeHaan fa953ba6b3 Merge pull request #1867 from c0rner/devel
get_service_status() is now using self.service_control() to check status
12 years ago
Rune Kaagaard 27ab2e55d3 Service mod.: Proper(?) handling of return code 69
This adds "69" to the return codes from the status command that should be
considered as not running. At least "django-celery" uses this return code,
maybe others::

    /venv/bin/python /code/project/manage.py celeryctl status
    echo $? # 69 when not running.

A bit of googling let me to http://tldp.org/LDP/abs/html/exitcodes.html and
on a Ubuntu Server 12.10 I get::

    ~# cat /usr/include/sysexits.h | grep 69
    #define EX_UNAVAILABLE	69	/* service unavailable */

I'm not sure if the content of sysexits.h is the same on other OS'es.
12 years ago
root 471ee0c90d get_service_status() is now using self.service_control() to check status
Fixes a bug where init-scripts were not used
12 years ago
Stephen Fromm 3fb21a5281 Update modules to use run_command in module_common.py
This updates apt, apt_repository, command, cron, easy_install, facter,
fireball, git, group, mount, ohai, pip, service, setup, subversion,
supervisorctl, svr4pkg, user, and yum to take advantage of run_command
in module_common.py.
12 years ago
Patrik Lundin d4af9e4c5c Use shlex for rc.conf parsing.
This makes the line parsing a lot more robust (and easier to read).
Code supplied by @dhozac, thanks!

Remove re import because this is not used anywhere.
12 years ago
Patrik Lundin fde00327b0 Rework "enabled" implementation for FreeBSD.
When trying to perform enabled=yes followed by enabled=no
against FreeBSD the module would die with the following error:
TypeError: sub() takes at most 4 arguments (5 given)

The target FreeBSD client (8.2) is running python 2.6.6. It seems the
extra 'flags' argument was added to re.sub() in 2.7.

In fixing this issue I have attempted to create a general atomic method
for modifying a rc.conf file. Hopefully this will make it easier to add
other rc based platorms. The strip/split magic was inspired by the user
module.
12 years ago
Daniel Hokka Zakrisson 4679d8d6e5 Remove references to non-existant variable rc 12 years ago
Dag Wieers 18b797f096 The vars stop/start were intended as strings
This is a typo that was reported on IRC, because of this people got: "NameError: global name 'stop' is not defined".
12 years ago
Patrik Lundin 5b7aa494b2 Refactor module to use subclasses like user module.
* Basically the moving parts from the original service module arranged in
  subclasses.
* General structure and helper methods comes from the user module.
* Less forgiving to unsupported platforms: it requires a subclass per platform.
  (This makes it easier to work on one platform without having to think about.
  what other platform might be affected in unexpected ways).
* Now has basic OpenBSD support.
* Solaris support needs to be added.

Thanks to @dhozac for general advice and Linux testing.
Thanks to @bcoca for clearing up some FreeBSD questions.
12 years ago
Jan-Piet Mens caf003c813 DOCUMENTATION strings 12 years ago
Dag Wieers 118ccc68c9 Make the default an empty string
Seems a bit strange I have to set a default in two locations.
12 years ago
Michael DeHaan 663a8fef3f chmod -x for all module files in source checkout 12 years ago
Dag Wieers 3852b9918a Allow adding additional arguments to service module
Some services allow additional arguments to be provided on the command line. This patch makes it possible.
12 years ago
Michael DeHaan d639844923 Merge branch 'service_bsd' of git://github.com/bcoca/ansible into devel 12 years ago
Daniel Hokka Zakrisson 20775c0b73 Fix service module for varnish initscript in EPEL
It outputs 'dead but pid file exists'.
12 years ago
Brian Coca 13f75e5a8e Now can handle rc.conf and init.d/rc.d based systems
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
12 years ago
Jan-Piet Mens feab57e270 Reformat code: examples consistently
- added terse syntax to modules.rst
 - added description of special variables to template module
12 years ago