Commit Graph

124 Commits (5006ef973293eadb8b4cd0f44b8b29d7351ae427)

Author SHA1 Message Date
Scott Brown 34d960ef20 BUGFIX 1178: Adding better existence check in one place. db_import now fails fast if target does not exist b/c no point going further without the target. 10 years ago
Scott Brown 1853a3f565 BUGFIX 7811: Adding file existence check when performing mysql import on a .gz or .bz2 file, otherwise Ansible will not notice that the underlying *nix command silently died. 10 years ago
James Cammarata 8d0d2831e6 Fixing mysql master replication boolean
Fixes #7528
10 years ago
Josef Špak 1dbc069bcb Fix typo in CHANGE MASTER TO syntax 10 years ago
Mathieu Martin 9589ee2a41 Add example 'Specify grants composed of more than one word' to the mysql_user module. 10 years ago
Scott Sturdivant 40a6a6f911 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
11 years ago
Adam Chainz 29b10ac698 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
11 years ago
Cove Schneider ae0721d3da re-add idempotency check 11 years ago
Cove Schneider 428dead8cd add replicaset support to mongodb_user module 11 years ago
Michael DeHaan acd89f7a1f Merge pull request #6796 from mistaka0s/mysqldump_fix
Remove extra quote from the mysqldump password argument
11 years ago
Matt Martz a4078a4bf8 Use /usr/bin/python instead of /usr/bin/env python 11 years ago
Chao Luan 749e749c11 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
11 years ago
Michael DeHaan ff5560f00c Update comments about redis config. 11 years ago
Michael DeHaan fbb15ad52f Merge branch 'devel' of git://github.com/mleventi/ansible into devel 11 years ago
Michael DeHaan d10b3f9257 Merge pull request #5597 from laggyluke/mongodb_user_idempotence
Fix idempotence in mongodb_user module
11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Richard Isaacson 35b4cf001c Merge pull request #6461 from risaacson/modules_make_run_command_safer
Modules make run command safer
11 years ago
Richard C Isaacson 122917019c mysql_db module: typo fix
Tests clean.
11 years ago
Richard C Isaacson d9da5cf084 Shell updates. 11 years ago
James Martin 0a74cb484c Fixes various typos introduced in a9017af2bb.
Fixes odd encoding problem with wait_for_service.
11 years ago
Michael DeHaan 980653f20b More shell fixes 11 years ago
James Cammarata 72217c297d Adding validate_certs to all modules that use fetch_url 11 years ago
Richard C Isaacson 525e811d9b Bulk update of choices=BOOLEANS to type='bool' 11 years ago
James Cammarata b77ea4ed91 Merge pull request #4630 from mmoya/mysql_variables-fix2
Add support for string values
11 years ago
James Cammarata a1b1182662 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
11 years ago
Michael DeHaan 8e9f058214 Merge pull request #6305 from amree/fix-mysql-replication-port
Fixed SQL syntax error when running mysql_replication module
11 years ago
Jimena Cabrera-Notari 86e7555554 Don't use keyword `error` in encode
This is not supported in Python 2.6. Just use positional arguments.
11 years ago
amree 59f954b349 MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value 11 years ago
Guido Kollerie 314e621671 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
11 years ago
Kyle Kelley 70d8be5cc2 Fix expires 11 years ago
James Martin e312b0e5bf Properly fetching the riak version, and properly setting the python interpreter. 11 years ago
James Cammarata c85b7d868b Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 11 years ago
James Cammarata a570280b81 Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
11 years ago
Maykel Moya 5da6fcae4d Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
11 years ago
Arturs Vonda df853fa92e Added port documentation to postgresql_db and postgresql_user 11 years ago
George Miroshnykov 58e34edce3 Add idempotency to mongodb_user module 11 years ago
Matthew Jones 3ddfc8d471 Allow strings containing single and double quotes to be used as passwords for postgres_user 11 years ago
Timur Batyrshin 9ad52632c5 reword "except Error as e:" into "except Error, e:" to be compatible with Python 2.5 (#5852) 11 years ago
Matthew Leventi 1637438298 adding the ability to change redis configuration 11 years ago
jctanner 7bab8656a3 Merge pull request #5435 from jkleckner/fix-mysql-dump-import
mysql_db module: make dump and import to use port argument
11 years ago
David Busby ab8d5c5924 Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 11 years ago
Alan Fairless 927a30c404 Fix postgresql_user to understand PG namespaces
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
11 years ago
Jim Kleckner 8ba9019797 Add quotes to password argument for dump/import
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
11 years ago
Jinn Koriech 57dc4fbea2 postgresql_user module: Gracefully handle ALTER ROLE on read-only postgres servers. 11 years ago
Jim Kleckner 59396d38e2 Fix mysql_db dump and import to use port argument
The code for mysql_db did not pass the port argument when state=dump or
state=import.
11 years ago
jctanner 8b925e93e6 Merge pull request #5099 from tartansandal/postgresql_db_check_mode
postgres_db CHECKMODE changed status
11 years ago
Jinn Koriech fbb1018abe Fix postgresql_user documentation render 11 years ago
Jinn Koriech e1aa94896f Add documentation for usage of encrypted postgresql passwords. 11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago