Commit Graph

903 Commits (4f110e4fc68b7ddd9f9873983f747cc5780550ee)

Author SHA1 Message Date
Stephen Fromm 3fb21a5281 Update modules to use run_command in module_common.py
This updates apt, apt_repository, command, cron, easy_install, facter,
fireball, git, group, mount, ohai, pip, service, setup, subversion,
supervisorctl, svr4pkg, user, and yum to take advantage of run_command
in module_common.py.
12 years ago
Daniel Hokka Zakrisson a19a13ffa7 Add check for multiple keys in one invocation 12 years ago
Gert Goet f4dcb33ccc Prevent permission denied when cloning
Without read permission to the current working directory, git-clone will
fail:
root@host:~$ sudo -u git -H git clone \
  git://github.com/ansible/ansible.git /home/git/ansible
fatal: Could not change back to '/root': Permission denied

This commit ensures that the working directory is changed to the
parent-folder of the destination before doing the clone.
12 years ago
Michael DeHaan 1cbc9569b3 Merge pull request #1853 from jure/more_info_from_ec2
EC2 module should report back the public_dns_name too
12 years ago
Daniel Hokka Zakrisson 060266e291 Python 2.4 fixes for modules 12 years ago
Daniel Hokka Zakrisson 3bc6228b97 Handle unreadable /proc/xen/capabilities
Fixes #1854.
12 years ago
Jure Triglav 3f43ede70c Fix indentation 12 years ago
Jure Triglav 2ee05f0c96 EC2 module should report back the public_dns_name too. 12 years ago
Daniel Hokka Zakrisson b57b1f4cbe Correct name is login_user
Fixes #1848.
12 years ago
Daniel Hokka Zakrisson 4955587d8c Merge pull request #1798 from dagwieers/raw-executable
Allow to change executable (shell/interpreter) when using raw
12 years ago
Michael DeHaan 713ce4c0cf Merge pull request #1832 from legrostdg/devel
add encoding documentation in postgresql_db
12 years ago
Félix Sipma 0ba7cf58e9 add encoding documentation in postgresql_db 12 years ago
willthames 4e50478a05 Fix behaviour when file handles a path with tilde
Two problems here
* unchecked exception handling and erroneous assumption as to why
  an exception might fire
* although the file module expands the path, when using file_args
  the unexpanded path is passed.

Expected result: ~/path/to/file should work fine
Actual result: exception is because it doesn't find file with a message
about not being able to get the selinux context
12 years ago
Daniel Hokka Zakrisson 1fa83fa584 Merge pull request #1813 from legrostdg/devel
postgresql_db fails with owner containing a "-"
12 years ago
Félix Sipma 02f531c609 remove quotes in has_table_privilege and has_database_privilege 12 years ago
Daniel Hokka Zakrisson 451868630d Merge pull request #1817 from chrisberkhout/devel
git module documentation: removed incorrect use of term 'remote branch' ...
12 years ago
Félix Sipma 8a262c2b20 add documentation for "template" parameter in postgresql_db 12 years ago
Félix Sipma cd7fe9875c use double-quotes in postgresql commands (fix bug with "-") 12 years ago
willthames 411b2bf7d9 Added additional template variables
Added two additional template variables
* template_fullpath - absolute path to the template
* template_run_date - date that the template was rendered
Documented these additional variables in the module documentation
12 years ago
Chris Berkhout c01bc23f63 git module documentation: removed incorrect use of term 'remote branch' (should just be 'remote'). 12 years ago
Dag Wieers eb36ff45b9 Make script module use raw module so it does not require python 12 years ago
Dag Wieers 846161a1a4 Allow to change executable (shell/interpreter) when using raw
This patch adds an optional 'executable=' option to the raw command line to override the default shell (/bin/sh), much like the shell module does.
12 years ago
Michael DeHaan 3d3deb9797 Merge pull request #1795 from dagwieers/raw-enhanced
Add return code and error output to raw module
12 years ago
Dag Wieers 988db558b3 Add return code and error output to raw module
Since we use 'raw' heavily on equipment where 'command' and 'shell' are not (yet) working (and python may need to be installed first using raw) these improvements are necessary in order to write more complex scripts (with return code handling and separated stdout/stderr).

This change includes the following changes:

 - exec_command() now returns the return code of the command
 - _low_level_exec_command() now returns a dict, including 'rc', 'stdout' and 'stderr'
 - all users of the above interfaces have been improved to make use of the above changes
 - all connection plugins have been modified to return rc and stderr
 - fix the newline problem (stdout and stderr would have excess newlines)

In a future commit I intend to add assertions or error handling code to verify the return code in those places where it wasn't done. Since only the output was available, the return code was ignored, even though we expect them to be 0.
12 years ago
Jan-Piet Mens 85e0017a85 fix cron DOCUMENTATION 12 years ago
jkleint d732b25828 Clarify that lineinfile uses Python regexes. 12 years ago
Daniel Hokka Zakrisson eb57c9c430 Indicate the reboot option was added in 1.0
Fixes #1787.
12 years ago
Michael DeHaan 6fc6c37401 Merge pull request #1785 from TutoringAustralasia/devel
Add support for @reboot to cron module
12 years ago
Chelsea Robb 96e2805b31 Change check for date/time parts being set 12 years ago
Chelsea Robb 6a02e3d918 Added error message when reboot and extra params are passed, and added better boolean parsing on reboot 12 years ago
Chelsea Robb fc4ac70342 Add support for @reboot to cron module 12 years ago
Gregory Duchatelet 29f985aa2e do not conditionalize this for older Python, fix indentation, better use
of hash iteration.
12 years ago
Gregory Duchatelet e64de2ff88 Bugfix: in hosts with python-2.5, hash keys needs flatten string. 12 years ago
Daniel Hokka Zakrisson d4b1874d44 Merge pull request #1773 from jpmens/scriptdoc
fix and clarify 'script' docs
12 years ago
Jan-Piet Mens 4f8abd981a fix and clarify 'script' docs 12 years ago
Stephen Fromm ccca5fcd1c Ensure files created by authorized_key have correct selinux context
Three changes:
* Add set_default_selinux_context() to module_common that sets
  a file's context according to the defaults in the policy
* In atomic_replace(), set the default context for the file if
  selinux is enabled and the destination file does not exist.
* In authorized_key, set the default context when creating
  $HOME/.ssh and $HOME/.ssh/authorized_keys.  If these already
  exist, this won't touch them.
12 years ago
Michael DeHaan f2893b6418 Merge pull request #1746 from njharman/subversion
Subverion module improvements
12 years ago
Michael DeHaan 5d31e8d1fc Merge pull request #1752 from jpmens/mail2
mail module: add MIME attachments, port and addresses with phrases
12 years ago
Norman J. Harman Jr ddc0507f65 Passing in module instead of just fail_json per upstream request. 12 years ago
Michael DeHaan ea5d79a712 Merge pull request #1755 from lorin/patch-1
Fix ppa syntax in apt_repository module doc
12 years ago
Norman J. Harman Jr 19b84d0527 pip module improvements
- Do not silently ignore malformed pip requirements files.
- Properly reports changed when removing packages.
- "latest" i.e. --upgrade is *not* incompatible with requirements files.
- Less branchy, simpler logic.
- Removed pointless variable "initializations", Python doesn't need that.
  Other code simplifications.
- Fun fact; pip install is (kind of) case insensitive, pip freeze is not.
  So, 'sqlalchemy' will be reported as installed by install, but missing
  by freeze.

The perhaps controversial change and the one that led to finding /
fixing above issues...

Instead of adding command parameters 'index', and 'find', and 'mirrors',
and etc.  Added 'extra_args' which are passed onto pip.

The use case for --index-url is having a private pypi repo, like
http://pypi.python.org/pypi/localshop, to which you publish private
packages.  I'm sure most every pip option has a use case for someone.
extra_args handles all those. Can reserve ansible command parameters for
the most common.

Tested with pip 1.1.
12 years ago
Seth Vidal 165861dd2f if user has manually installed an intermediate version - don't ignore it: issue 1754 12 years ago
Jan-Piet Mens f9755ca36d mail module: add MIME attachments, port and addresses with phrases
Add HTML-escaping to code examples in rST tempate of module-formatter
 Add support for specifying port, addresses with phrases and attaching files
 Add support for custom headers and document version_added for new options
 X-Mailer header added :)
 protect empty address lists & attachment list, and add bcc
12 years ago
Lorin Hochstein f8821fa3d9 Fix ppa syntax in apt_repository module doc
The example for using a ppa had the wrong syntax.

Ironically, the correct syntax is illustrated in a comment on line 23.
12 years ago
Norman J. Harman Jr 2e6999dab9 Subverion module improvements
- Added username, password arguments.
  - Documented existing revision argument.
  - Corrected documentation/docstrings; removed git references, use svn
    nomenclature, etc.
  - Refactored duplicate code, redundant shell calls, filter abuse,
    inconsistent formating, etc.
  - Shell quoting so it doesn't break for one guy who has spaces in
    pathnames.
  - svn called with '--non-interactive' and '--no-auth-cache'.
12 years ago
Michael DeHaan 637883164e Merge pull request #1720 from bladypirat/devel
added support for scheduling downtime for all services on host
12 years ago
Alexandre Bourget 0b9cbcb270 supervisorctl: document the 'present' option 12 years ago
Dag Wieers ac2f396379 Fix "NameError: global name 'name' is not defined" exception 12 years ago
Daniel Hokka Zakrisson 11b64314df Select all fields from the user, as some of them are version-dependent 12 years ago
Stephen Fromm 1bcfdd94f3 Further refine remote branch tracking in b1ec6e8
Move operations that are dependant on a remote branch under a if
is_remote_branch() conditional.  While at it, remove assignment to cmd
string in same block that wasn't used when calling _run().
12 years ago