Commit Graph

40599 Commits (4b8f2c99d2f2e31f1c363fdf767a07136beced69)
 

Author SHA1 Message Date
Matt Clay c24c19594e
Enable pylint rules and fix exposed bugs. (#47219)
* Resolve invalid-unary-operand-type.

* Resolve raising-format-tuple.

* Resolve stop-iteration-return.

* Use disable comment instead of fixing logic.

The affected line in _find_address_range will only fail on Python 3.7
and later if the function is called with an empty address list. As an
internal method it is never called in this way, making it a non-issue
for use via public methods.

Using a comment to disable the rule in favor of an ignore.txt entry
since there are no plans to change the logic in the code itself. This
will also prevent any potential future issues being added in other
parts of the code when updating it based on upstream changes.
6 years ago
Alicia Cozine cd7232eeb7 refines vmware sample scenario page (#47320) 6 years ago
Daniel Shepherd c67ab296bb pamd: add delete=False to NamedTemporaryFile() (#47281)
* add delete=False to NamedTemporaryFile and remove print statement from module

* add changelog fragment
6 years ago
Joey c5a9b6acb7 Fix minor typos on variable names (#47165) 6 years ago
Allyson Bowles 21859c06b9 Add output for skipped tasks 6 years ago
Allyson Bowles 219f1b8380 Display output for loops on 'ok' result 6 years ago
Artem Zinenko 3fa33ce96b Fixed typos in winrm doc (#47351) 6 years ago
Christian Kotte dc2eb05491 VMware: Add check mode support to vmware_vmkernel_facts (#47286) 6 years ago
Anil Kumar Muraleedharan 0f943f7584 Adding full list of supported devices (#46949) 6 years ago
Abhijeet Kasurde a47b055ac7 Update profile_tasks docs (#46690)
Added configuration settings to enable profile_tasks via ansible.cfg

Fixes: #44555

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Ondra Machacek b177aff41b ovirt_vm: Fix initialization of cloud init (#47348)
Fixes: https://github.com/ansible/ansible/issues/45900

This PR fixes the case when the cloud_init_persist was used, but we
still sent use_cloud_init=False, which is in oVirt API evaluated as not
to use cloud_init in first VM execution. This patch is changing it to
send just None, instead of False.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
6 years ago
Eugene Zvyagintsev 4c2efa4b67 Documentation for docker_container: fix documentation for memory_swappiness. Default value will not equal 0, it will be inherited from the host machine (#47296) 6 years ago
Pluggi f13091d142 Add runtime option to docker_container module (#47247)
* Add runtime option to docker_container module

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add changelog fragment

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>

* Add idempotency test for docker_container.runtime

Signed-off-by: Antoine Bardoux <abardoux@nvidia.com>
6 years ago
Felix Fontein 131efcff9d docker_network: add basic integration tests (#46137)
* Adding very basic integration tests for docker_network.

* Fixing some details (review comments).
6 years ago
richardlock 39f3984ce4 azure_rm_cdnprofile: Add 'standard_microsoft' to sku (#47309)
##### SUMMARY
The azure_rm_cdnprofile module was missing a valid sku 'standard_microsoft'.  Added it to the list of valid choices.

##### ISSUE TYPE
- Bugfix Pull Request

##### COMPONENT NAME
azure_rm_cdnprofile

##### ANSIBLE VERSION
```
ansible 2.8.0.dev0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/home/user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/dist-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.15rc1 (default, Apr 15 2018, 21:51:34) [GCC 7.3.0]
```

##### ADDITIONAL INFORMATION
It was not possible to deploy using the 'standard_microsoft' sku previously.  This addition allows this.
6 years ago
Nijin Ashok 29c76c5a93 ovirt_vm: Add option to export the VMs (#47113)
The commit adds the feature to export the VM to export domain and as
OVA.
6 years ago
Nijin Ashok c5d0461561 ovirt_vm: Fix issue in SSO option (#47312)
Currently the module will disable the SSO if we didn't pass any
value for SSO option. The PR fixes the same.
6 years ago
Zim Kalinowski b0c88ddab1
Adding postgresql firewall rule facts (#45078)
* adding postgresql firewall rule facts

* fixed sanity

* fixed sanity

* updating tests

* firewall rule facts updated

* fixed test

* fix crash

* small updates

* updated postgresql firewall rule

* removed unnecessary type

* fixed postgresql facts

* fixed azure

* one more fix

* test fixes

* fix class name
6 years ago
Felix Fontein d2f524fb27 Use {{ ansible_python.executable }} instead of python in integration tests. (#47340) 6 years ago
Jordan Borean 013c44484a psexec: better error on import failure (#47327) 6 years ago
Jordan Borean e6a327fb82
ansible-test: add retry for Windows httptester download (#47334) 6 years ago
Paul Belanger e844bfe1d4 Force PEM SSH keys for paramiko
Trying to get ansible-test working on my fedora-28 system, I noticed I
was getting invalid keys from paramiko. It looks like this is because
ssh-keygen is now defaulting to RFC4716 format for private / public
keys.

For now, we can still use PEM based SSH keys, but the long term fix here
is to report a bug to paramiko and support RFC4716 for rsa keys.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
6 years ago
Jordan Borean c0546b4133
win httptester: add wait for endpoint in case it is still coming up (#47326) 6 years ago
Dag Wieers e758f69ce3 win_domain: Add missing functionality (#46552)
* win_domain: Add missing functionality

* Fix typo: Treshold -> Threshold

* Improvements based on feedback

* moved mode checks to after pre-reqs are installed
6 years ago
Abhijeet Kasurde bfc3ca1da1 Remove extra parameter in format_exc (#46251)
`traceback.format_exc()` does not take any argument, this fix remove
such occurances.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
6 years ago
Claude Dioudonnat 1a51b08875 Fix increase fake disk size for filesytem's tests 6 years ago
Pierre-Louis Bonicoli e016af3cc6 filesystem tests: enable LVM
Co-authored-by: Pierre-Louis Bonicoli <pierre-louis.bonicoli@libregerbil.fr>
6 years ago
Claude Dioudonnat 42730cffc4 Fix get_fs_size for LVM filesystem 6 years ago
Baptiste Mille-Mathias 3f8a0f6657 Use syntax loop instead of with_items in example (#47241) 6 years ago
Baptiste Mille-Mathias bac43eebe0 Use loop instead of obsolete with_items in example (#47246) 6 years ago
Martin Krizek 541255a2d8
Do not strip new lines in native jinja (#46751)
* Do not strip new lines in native jinja

* Add changelog/fragment
6 years ago
Toshio Kuratomi 4d9504e775 Remove runtime usage of pkg_resources.
This should provide a startup time speed boost at the expense of making
it harder to get ansible to use newer versions of packages than are
provided by the platform.
6 years ago
Baptiste Mille-Mathias 65bb6a5af3 Use loop instead of with_items in examples (#47318) 6 years ago
Baptiste Mille-Mathias 0b9c033abe Use loop instead of with_items in examples (#47319)
with_items is deprecated
6 years ago
Matt Clay 37b013aca3
Enable additional pylint rules and resolve issues found. (#47221)
* Resolve unneeded-not.
* Resolve global-at-module-level.
* Resolve useless-import-alias.
* Resolve bad-whitespace.
* Resolve global-variable-not-assigned.
* Resolve logging-not-lazy.
* Resolve comparison-with-itself.
6 years ago
Matt Martz 77d32b8f57
Don't use the task for a cache, return a special cache var (#47243)
* Don't use task to cache loop results, use hostvars. Fixes #47207

* Avoid a race condition, supply _ansible_loop_cache through get_vars directly

* Add tests

* Add changelog fragment

* Remove unnecessary copy

* Remove unnecessary host from _get_delegated_vars signature
6 years ago
Adam Miller 9e2c02455a add note about named tasks in blocks (#46984)
* add note about named tasks in blocks

Signed-off-by: Adam Miller <admiller@redhat.com>

* adds names to tasks within example block, removes 2nd example

* removes traces of bad rebase
6 years ago
Sean Cavanaugh 81d22dc304 adding additional example and clarification (#47224)
The kind: paramter is missing from the original example (which won't actually work).  The organization needs to be listed as required (if you don't list it, you will get an error).  Also adding additional example using the tower_username and tower_password method.
6 years ago
John Imison c809560385 Minor documentation fix. (#47276) 6 years ago
Bianca Henderson e52761fbd3 Making minor changes (#47311)
<!--- Your description here -->

+label: docsite_pr
6 years ago
Matt Clay f74f7b0373
Add constraint for requests on python 2.6. (#47306)
* Add constraint for requests on python 2.6.
* Use constraints in lookup_hashi_vault test.
6 years ago
Matt Martz 19416a1343 Fix versions in module.deprecate call to align with module deprecation. Fixes #45035 #45034 (#47211) 6 years ago
Nathaniel Case 7844a40046
Update some cliconf plugins (#47141)
* Add `check_all` to many community cliconf plugins
6 years ago
Martin Krizek 096717edc5 ansible-galaxy: fix searching with unicode 6 years ago
Dag Wieers 06eabc9783 reboot: Add timeout in error to help troubleshooting (#47216)
* reboot: Add timeout in error to help troubleshooting

So we've been hit by 'Timed out waiting for boot_time check' and it was
unclear what timeout was used for the boot_time check. By adding the
timeout value it is easier to understand the used value, and verify if a
change to the timeout is reflected in the output.

* Add changelog fragment
6 years ago
Matt Clay 14da4d66f2 Add constraints to pip install in setup_docker. 6 years ago
Nathaniel Case 3feb6c9e0f
Try to be more verbose with JSON decode errors (#47066)
* Try to be more verbose with JSON decode errors
6 years ago
Toshio Kuratomi bcd6dbcd65 Remove get_exception from the remainder of the modules 6 years ago
Ryan Brown 18a088c64e
GCP MagicModules bug fixes (#47285)
Closes: #46930 #46929 #46928 #46927 #46926 #46925 #46924 #46923 #46922 #46921 #46920 #46919 #46918 #46917 #46916 #46915 #46914 #46913 #46912 #46911 #46910 #46909 #46908 #46907 #46906 #46905 #46903 #46902 #46901 #46900 #46899 #46898 #46897 #46896 #46895 #46894 #46893 #46892 #46891 #46890 #46889 #46888 #46887 #46886 #46885 #46884 #46883 #46882 #46881 #46880 #46879 #46878 #46877 #46876 #46875 #46874 #46873 #46872 #46871 #46870 #46869 #46868 #46867 #46866 #46865 #46864 #46863 #46862 #46861 #46860 #46859 #46858 #46857 #46856 #46855 #46854 #46853 #46852
6 years ago
Nate Borener 3b5471a734 get_url: Updates documentation for proper use of headers (#47242)
* Fixes the example for headers in documentation

* remove whitespace

* missed a whitespace
6 years ago