David Wittman
8d53ef2f60
[service] Fix bug with upstart detection
...
Upstart scripts are being incorrectly identified as SysV init scripts
due to a logic error in the `service` module.
Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`,
etc.) for managing service state, the codepath for upstart sets
`self.svc_cmd` to an empty string on line 451.
Empty strings are considered a non-truthy value in Python, so
conditionals which are checking the state of `self.svc_cmd` should
explicitly compare it to `None` to avoid overlooking the fact that
the service may be controlled by an upstart script.
10 years ago
Sam Thursfield
60397fae0f
Fix authorized_key module crashing when given an invalid key
...
I tried a playbook with the following (accidentally wrong) task:
tasks:
- name: authorized key test
authorized_key: key=/home/sam/.ssh/id_rsa.pub key_options='command="/foo/bar"' user=sam
I got the following traceback:
TASK: [authorized key test] ***************************************************
failed: [localhost] => {"failed": true, "parsed": false}
Traceback (most recent call last):
File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 2515, in <module>
main()
File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 460, in main
results = enforce_state(module, module.params)
File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 385, in enforce_state
parsed_new_key = (parsed_new_key[0], parsed_new_key[1], parsed_options, parsed_new_key[3])
TypeError: 'NoneType' object has no attribute '__getitem__'
With this fix, I see the expected error instead:
TASK: [authorized key test] ***************************************************
failed: [localhost] => {"failed": true}
msg: invalid key specified: /home/sam/.ssh/id_rsa.pub
10 years ago
Mario Loria
30be06c971
Setting the actual passno and dump defaults, and warning user of consequences in nulling
...
Using ansible 1.8.4, I found that these two options actually work slightly different than advertised.
10 years ago
Dag Wieers
0a91ace6ad
Update authorized_key.py
...
Fix a (common) error in the examples. This is something that may go unnoticed during troubleshooting when copy&pasting the example.
10 years ago
Toshio Kuratomi
939ecd33d4
In service_enable, the default of changed is True so we have to set it
...
to False explicitly if it is False.
Fixes #875
10 years ago
Carlo Mandelli
0029c960e4
Added HP-UX subclass
10 years ago
Oleg A. Mamontov
fa19753707
On FreeBSD apply 'login_class' only if there is real change.
10 years ago
Edward Larkey
4db27877bf
Fix typo in authorized key module documentation.
...
Added opening double quote
10 years ago
Stefan J. Betz
dc470cc91f
Create SSH Keys always after creating $HOME
10 years ago
Brian Coca
5df3058aab
fix for mount w/o opts (bug introduced when fixing bind mounts)
10 years ago
Brian Coca
1bca815d37
Merge pull request #95 from Gamevy/use-insserv
...
Use insserv where available
10 years ago
Brian Coca
ed8154bdc7
Merge pull request #759 from jonhadfield/systemd_enabled_check
...
use is-enabled to check systemd service status.
10 years ago
Sébastien Gross
67ce4cf416
Add basic support for OSX groups.
10 years ago
Sébastien Gross
1555cfeea2
Add basic support for OS X (Darwin) user management.
10 years ago
Dagobert Michelsen
1f2ffb3900
Solaris SMF is already supported and should be mentioned in the docs,
10 years ago
Brian Coca
55b06568b0
added note that url src is only avaialable from 1.9 on
10 years ago
Brian Coca
b82055f021
Merge pull request #648 from bcoca/service_fix_update-rc.d
...
simplified update-rc.d enable/disable handling,
10 years ago
Toshio Kuratomi
b84f566ee7
Tabs to spaces
10 years ago
Brian Coca
8bccb27c41
Merge pull request #49 from Jmainguy/mount_bind_fix
...
Fixes bind mounts for some OSs, reproduced only on debian and ubuntu
10 years ago
Paul Geraghty
b42b0f49b9
Correct grammar of comment relating to example
10 years ago
Jesse Keating
e0c5b4340d
Add exclusive option to authorized_keys
...
This option allows the module to ensure that ONLY the specified keys
exist in the authorized_keys file. All others will be removed. This is
quite useful when rotating keys and ensuring no other key will be
accepted.
10 years ago
Jon Hadfield
b20b29bd17
use is-enabled to check systemd service status.
10 years ago
Philippe ALEXANDRE
ac1a64e62f
Add Linuxmint support in hostname module
10 years ago
Brian Coca
b9786835eb
Merge pull request #554 from likwid/devel
...
Added ability to use url as key source
10 years ago
Graham Hay
17c7d9c5d5
Use insserv where available
10 years ago
Jeff Gonzalez
27c046ae79
Refactored code to use module utility fetch_url function.
10 years ago
Brian Coca
543c45a15f
implemented account expiration as flag and not state, removed from unsupported platforms
10 years ago
Brian Coca
fc1045a1ee
Merge pull request #41 from billwanjohi/add_expired_state
...
user: add expired state
10 years ago
Jeff Gonzalez
e9ae165792
Added documentation for using url as key source
10 years ago
Jonathan Armani
645e0653a3
Merge branch 'devel' into openbsd_rcctl
10 years ago
Toshio Kuratomi
4f1f8e89c9
More information about distutils on Solaris in case we run into this again
10 years ago
Toshio Kuratomi
effdba95de
Merge pull request #639 from tgolly/devel
...
distutils is not available on some non-Linux OS's
10 years ago
Brian Coca
8c4b279552
Merge pull request #39 from kustodian/selinux_disable_fix
...
Set selinux state to 'permissive' for state=disabled
10 years ago
Brian Coca
d80e7438a6
Merge pull request #37 from mscherer/fix_old_7420
...
Add hostname to generated user SSH key comment
10 years ago
Brian Coca
6b784fb28a
Merge pull request #675 from bcoca/sysctl_nonstrings
...
now handles non string values for sysctl
10 years ago
Ben Konrath
347234b937
Add support for SL7 to hostname module.
10 years ago
Brian Coca
f85b7ee13c
now handles non string values for sysctl
10 years ago
Brian Coca
e957150f77
Merge pull request #189 from jarmani/openbsd_rcctl
...
Openbsd rcctl
10 years ago
Patrik Lundin
e8c328773a
Update OpenBSD rcctl handling to use new syntax.
...
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
10 years ago
Tim G
8f43a0a4fe
Load distutils on all platforms EXCEPT Solaris.
...
Solaris doesn't ship distutils with with the default Python package. This patch fixes "service" on Solaris since 30d6713
.
10 years ago
Brian Coca
9ac5ed2621
now allows for case in which someone removed the K* links and is trying
...
to reenable a service
10 years ago
Brian Coca
f4a709ad7c
simplified update-rc.d enable/disable handling, removed forced defaults
...
creation as that breaks local customizations
10 years ago
Toshio Kuratomi
4c50fbedf4
Merge pull request #632 from mscherer/fix_uneeded_echo
...
Do not use echo shell builtin for password
10 years ago
Tim G
68b5b7be72
distutils is not available on some non-Linux OS's
10 years ago
Michael Scherer
826d313aad
Do not use echo shell builtin for password
...
Using \t in a password may result in a different password
being set :
$ echo 'a\ta'
a a
Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
10 years ago
Brian Coca
8c8be0e48c
Merge pull request #572 from jrobeson/rename-fedora-hostname-strategy
...
[hostname] rename FedoraStratgy to SystemdStrategy
10 years ago
Toshio Kuratomi
2973bac72f
Clarify documented behaviour of user module's ssh_key_file parameter
...
Fixes #9873
10 years ago
Johnny Robeson
50011f13d6
[hostname] rename FedoraStratgy to SystemdStrategy
10 years ago
Jeff Gonzalez
54214f83b5
Added ability to use url as key source
10 years ago
Peter Oliver
18c429d016
Fix appending to a user's group on Solaris
...
Without this change, you get:
AttributeError: 'set' object has no attribute 'extend'
Tested on a Solaris 11.2 client with the included Python 2.6.8.
10 years ago