Commit Graph

20 Commits (4a0a9cd1fccb2be29850941554db2c10f221f1c7)

Author SHA1 Message Date
Donovan Jones 7c52ea58f1 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
9 years ago
David Shrewsbury e8abea25c7 Fix OpenStack module failure output
The exception message, when shade fails, will contain much more
specific information about the failure if the exception is treated
as a string. The 'message' attribute alone is usually not helpful.
9 years ago
Shobhit Srivastava 8ad072c96f checking remote_group_id while comparing os_security_group_rule 9 years ago
Monty Taylor dd9c292861 Update docstring to show port ranges as optional 9 years ago
David Shrewsbury 6933407cd4 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
9 years ago
David Shrewsbury 8664c88417 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
9 years ago
Monty Taylor 9f03302b68 Use int in the parameter list instead of casting 9 years ago
dagnello 2e8daa2330 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
9 years ago
David Shrewsbury f027e75976 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
9 years ago
David Shrewsbury 9d0c8b0507 Fix syntax error 9 years ago
Monty Taylor 0e5942d7e7 Return rule object 9 years ago
David Shrewsbury 16b3b72294 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
9 years ago
David Shrewsbury 5b6c6cac20 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
9 years ago
David Shrewsbury 5758b4ebdc Fix id value reference 9 years ago
David Shrewsbury 8f2e70a1c1 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
9 years ago
dagnello b98e6663e8 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
9 years ago
dagnello d35df1f217 Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
9 years ago
Davide Guerri a9301ba918 Fix invalid syntax in openstack_module_kwargs call 9 years ago
Monty Taylor 08b4bb42c4 Fix example code syntax 9 years ago
Monty Taylor 08b2f31915 Add OpenStack Security Group Rule module 9 years ago