Michael DeHaan
b5d64fdb36
Some notes/comment upgrades on split_args.
11 years ago
James Cammarata
43154e5101
Using custom splitting function for module param counting
11 years ago
Michael DeHaan
e143d7dab7
Merge pull request #7543 from yangliping/fix_local_facts_file_checking_portability
...
Fix portability issue when checking local facts file permission.
11 years ago
Michael DeHaan
635bea645c
Merge pull request #7992 from dehylton/devel
...
fix swap translation on 4.x openbsd with 2.5.4 python
11 years ago
James Cammarata
b21875d5a9
Make sure 'item' variable is set when using first_available_file
...
Fixes #8220
11 years ago
someda
1b1d5d0d3d
fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
...
- the issue was introduced by the commit 84759faa09
11 years ago
James Cammarata
2cc602beea
Fixes for module param counting and additional shell quoting issues
11 years ago
Benno Joy
ac85d8444b
fix for unarchive 8257
11 years ago
Nacho Coloma
57428c48a2
Bugfix: bulletproof unexpected_error_msg at gce.py
...
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:
```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```
I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
11 years ago
James Cammarata
84759faa09
Security fixes:
...
* Strip lookup calls out of inventory variables and clean unsafe data
returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
duplicate params from superseding previous params (CVE-2014-4967)
11 years ago
James Cammarata
00e089e503
Revert "Explicitly set the user option for ssh connections"
...
This reverts commit 0f91add86f
.
Fixes #8216
11 years ago
Joseph Benden
da5e32b316
Needs additional divisor.
11 years ago
Michael DeHaan
0fad9575e9
Refine error message about invalid ops since people forget to indent tasks fairly often.
11 years ago
James Cammarata
0e5b0a2e97
Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
...
This reverts commit 7a8eb0b670
.
11 years ago
Joseph Benden
b55791ef43
Support for OS X 10.10 DP3.
11 years ago
James Cammarata
62e9cf63b7
Merge pull request #8170 from sergevanginderachter/issue_8159
...
Load existing group_vars file for new group_by group
11 years ago
Serge van Ginderachter
4e9a253bef
Load existing group_vars file for new group_by group
...
if it was not loaded yet, which happens if that group
didn't exist yet in the inventory.
fixes #8159
11 years ago
James Cammarata
42b5294820
Merge branch 'devel' of https://github.com/leverich/ansible into leverich-devel
11 years ago
Felix Geyer
0ebd19e97b
Fix regression: Sanitize sudo success_key from stdout
...
Commit 7e3dd10
caused a regression with sanitizing the sudo success_key from stdout.
There is no newline in front of SUDO-SUCCESS when using sudo.
This change adapts the regex to make the line break optional.
Tested on Ubuntu 14.04.
11 years ago
Ruggero Marchei
909955f2e2
fix get_distribution_version() on amazon linux
11 years ago
Jacob Leverich
7a8eb0b670
Set Jinja2's keep_trailing_newline=True in template_from_string.
...
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
11 years ago
James Cammarata
e74853300a
Merge branch 'task-host-loop-bypass' of https://github.com/sivel/ansible into sivel-task-host-loop-bypass
11 years ago
James Cammarata
cdb9f13559
Merge pull request #7605 from sivel/delegate-callback-hint
...
Show delegate_to hint in callback output
11 years ago
James Cammarata
4fc8d4b6fe
Merge pull request #7649 from sivel/vault-password-script
...
Allow --vault-password-file to work with a script as well as a flat file
11 years ago
Serge van Ginderachter
e8b45a9ef7
Invalidate host/group variables cache when loading
...
extra varsiables based on playbook basedir.
11 years ago
Serge van Ginderachter
d39ff55688
Fix logic bug when loading vars for a new playbook basedir.
11 years ago
James Cammarata
db96344966
Re-fixing ability to have empty json files after inventory refactoring
11 years ago
James Cammarata
4e5eb7559e
Merge branch 'svg_and_inventory_refactor' into devel
11 years ago
Bjorn Neergaard
08f97c0b9d
Fix hostname when get_distribution_version() returns a string.
...
The distro version is a string ('jessie/sid') on Debian unstable and testing.
Because load_platform_subclass() evaluations every subclass as it loops,
comparing numbers when get_distribution_version() does not return a number will
break.
This patch fixes that by returning a number (`0`) when we have an invalid
version, instead of returning `None` or a string.
11 years ago
Dan Slimmon
307a3e8a9c
Fixed regex square-bracket bug.
...
Regexes were being parsed like ordinary ansible host patterns, so
square-bracket groups were getting interpolated wrongly.
11 years ago
James Cammarata
b8ac094eaa
Tweak to only show msg on assert failure if set
11 years ago
James Cammarata
16332b8488
Merge branch 'assert-with-msg' of https://github.com/darkk/ansible into darkk-assert-with-msg
11 years ago
James Cammarata
aa261bdd14
Optimizing groups_for_host() lookup in inventory
11 years ago
James Cammarata
fe892fccb1
Merge remote-tracking branch 'svg/varsplugins_refactor' into svg_and_inventory_refactor
11 years ago
James Cammarata
11a5fc85f4
Merge branch 'inventory_refactoring' into svg_and_inventory_refactor
11 years ago
James Cammarata
bcf83cbc24
Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor
11 years ago
Serge van Ginderachter
ff4119adc0
Performance optimization in resolving host patterns
...
Avoid resolving a pattern that is a plain host. When matching a hostname in the
hosts_cache, just use the host object from there.
When running a task on say 750 hosts, this yields a huge improvement.
11 years ago
Matt Martz
6591dd560d
Show delegate_to hint in callbacks
11 years ago
Leonid Evdokimov
d94395f48c
assert: add optional `msg` argument
...
Sample playbook when it may be useful:
```
- uri: return_content=yes url={{ api_base }}/action/{{ inventory_hostname }}
register: output
- assert:
msg: '{{ output.json | to_nice_json }}'
that:
- output.json.foo != "bar"
- output.json.boo == 42
```
11 years ago
James Cammarata
7f8de3a265
Merge pull request #8024 from kcghost/7941
...
removed port from domain name qualification, fixes #7941
11 years ago
James Cammarata
ff04b2b532
Allow empty yaml vars files
...
Fixes #7843
11 years ago
Michael DeHaan
51e014d915
Merge pull request #8012 from cchurch/callback_cleanup
...
Callback plugin cleanup
11 years ago
Michael DeHaan
c2ac8fda1e
Data from inventory scripts should be able to use nested Jinja2 expressions.
11 years ago
Henry Finucane
de64bbdc5f
Support a whitelisted subset of jinja2 template options
11 years ago
Casey Fitzpatrick
7115cb1f37
removed port from domain name qualification, fixes 7941
11 years ago
Marc Abramowitz
5b783e0bc6
Error if private_key_file is group/world readable
...
Currently, if you have this, ansible fails with a generic error and
suggests running again with `-vvvv`. This isn't bad but pinpointing the
specific problem immediately is even more user-friendly.
```
$ ls -l devops.pem
-rw-r--r--+ 1 marca staff 1679 Jul 2 11:25 devops.pem
$ ansible -m ping --private-key=devops.pem mt3-pyweb01
mt3-pyweb01 | FAILED => private_key_file (devops.pem) is group-readable or world-readable and thus insecure - you will probably get an SSH failure
```
11 years ago
James Cammarata
81f35323e9
Revert "Fix get_distribution() for platforms that may have spaces"
...
This reverts commit 2493020d9f
.
11 years ago
Chris Church
955dadf743
Remove runner_on_error callback that is never used.
11 years ago
Chris Church
4e98e3785a
Reset play attribute on callback plugins when a play fails.
11 years ago
Chris Church
30fae95efe
Change variable from pattern to name to correctly indicate what is being passed to the callback.
11 years ago
James Cammarata
8ed6350e65
When parsing json from untrusted sources, remove templating tags
11 years ago
James Cammarata
eeb597360e
Further safe_eval fixes
11 years ago
dewey hylton
379e1a49cb
fix swap translation on 4.x openbsd with 2.5.4 python
11 years ago
Michael Scherer
f0a7139290
Fix exec_command prototype for the plugin
11 years ago
mesk41in
488aec3936
Fix unsupported regexp parameter in assemble
11 years ago
James Cammarata
539426f612
Performance tuning inventory functions for large inventories
11 years ago
James Cammarata
35368e531b
Additional fixes for safe_eval
11 years ago
James Cammarata
5429b85b9f
Change safe_eval to a strict white list
11 years ago
James Cammarata
d8a7b49b59
Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree
11 years ago
Matt Martz
19f5ce2c9c
Allow --vault-password-file to work with a script as well as a flat file
11 years ago
James Cammarata
1adb6dfa05
Remove redundant 'self.user or' added by 0f91add
11 years ago
Thomas Mangin
0f91add86f
Explicitly set the user option for ssh connections
...
Fixes #7170
11 years ago
Paul Sokolovsky
f8bf9cdeec
Handle TemplateNotFound to render more helpful error message.
...
At the point the exception is handled, it is likely due to error loading
a sub-template included from main template. Besides file not found, it
can be caused also by include path failing Jinja2 checks. Now, when
rendering the exception from Jinja, it will include exception name. This
will give basic context or *what* the error is.
Fixes #7103
Fixes #7105
11 years ago
James Cammarata
5d65c1c4a4
Merge branch 'Mbosco-patch-1' into devel
11 years ago
James Cammarata
6bd0621037
Merge branch 'devel' of https://github.com/ansible/ansible into devel
11 years ago
James Cammarata
1702c2fd50
Merge branch 'patch-1' of https://github.com/Mbosco/ansible into Mbosco-patch-1
11 years ago
James Cammarata
9564818e1e
Merge branch 'fix_lineinfile_newlines' into devel
11 years ago
James Cammarata
59c5d6292b
Merge pull request #7902 from jirutka/filter-relpath
...
Add os relpath filter
11 years ago
James Cammarata
ce41b02300
Merge pull request #7887 from s0x/funtoo-gathering-facts
...
Check for empty os-release file, fixes #7885
11 years ago
Jakub Jirutka
726a61eb43
Add os relpath filter
11 years ago
Chris Church
6aaad5dc9b
Fix missing arg for _remote_chmod method.
11 years ago
Ivo Senner
f4fd9d366b
Check for empty os-release file, fixes #7885
11 years ago
Chris Hoffman
cf997beb07
Shell expand DEFAULT_ROLES_PATH fixes #4897
11 years ago
James Cammarata
94963290b9
Merge pull request #6981 from aliles/fix-localhost-executable-with-flags
...
Fix localhost tasks with complex executables
11 years ago
James Cammarata
3c3c710a58
Merge branch 'module_safe_eval' into fix_lineinfile_newlines
11 years ago
James Cammarata
d8bb116c1a
Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel
11 years ago
Michael DeHaan
5156794738
Merge pull request #7861 from cchurch/devel
...
Windows Remote Support
11 years ago
Chris Church
615f70e3f4
Fix missing space in script action plugin.
11 years ago
Chris Church
dd3f7c2dab
Fix trailing slash on returned temp path.
11 years ago
Chris Church
8a121fd6ae
Squeeze a few more bytes out of put_file script.
11 years ago
Chris Church
4e738e6fa9
Optimize buffer size for put_file.
11 years ago
Matt Martz
09dd535296
Make helper functions more robust against undefined powershell objects
11 years ago
Chris Church
43a7a5a990
Collapse extra whitespace in encoded powershell scripts.
11 years ago
Matt Martz
df8866b8bd
Add examples for how to use powershell common functions
11 years ago
Matt Martz
e4e610565c
Add convenience function (Get-Attr) for getting an attribute/member from a powershell psobject
11 years ago
Matt Martz
90c98ada7c
Add ConvertTo-Bool filter function in powershell common code
11 years ago
Chris Church
61c236be9e
Fix for creating temp dir with older powershell versions.
11 years ago
Chris Church
243cd877ae
Add integration tests for fetch/slurp, make powershell fetch/slurp work as close as possible to existing fetch/slurp modules.
11 years ago
Chris Church
a8ca579761
Fix host parameter to vvvvv.
11 years ago
Matt Martz
97f4f56286
Add Exit-Json and Fail-Json powershell helper functions
11 years ago
Chris Church
74c43c94cf
Allow specifying remote powershell version via environment variable.
11 years ago
Chris Church
8f762a7d15
Update logging based on verbosity, add vvvvv support to show details of put/fetch file.
11 years ago
Chris Church
21ba529fbe
Fixes/notes related to slashes in remote paths.
11 years ago
Chris Church
7e8cc65829
Refactor common args used for building PowerShell commands.
11 years ago
Matt Martz
e7e95721b9
powershell modules will have a .ps1 extension
11 years ago
Matt Martz
a25c441300
Add shared functions to module_utils/powershell.ps1 and refactor powershell modules to utilize the common powershell code
11 years ago
Michael DeHaan
bafa63b424
Revise documentation on powershell module replacer code.
11 years ago
Chris Church
f7af29680b
Add default license boilerplate, refactor common powershell code, fixes for raw/script modules.
11 years ago
Michael DeHaan
35a7c93c76
Added comment about implementation line.
11 years ago
Michael DeHaan
3ac86e57f4
FIXME comment cleanup
11 years ago
Michael DeHaan
80499346d1
Remove stray FIXME
11 years ago
Chris Church
5dcaa30476
Add shell_plugins to abstract shell-specific functions out of runner, add winrm connection plugin, add initial Windows modules.
11 years ago
James Cammarata
360d8b0fc2
Don't try to scan SSH signatures for non-ssh urls
...
Fixes #7812
11 years ago
James Cammarata
2493020d9f
Fix get_distribution() for platforms that may have spaces
...
The new CentOS 7 beta lists the distribution as "CentOS Linux", which
breaks the distribution detection and class loading. This patch fixes
that by taking just the first entry in the string when a space is
detected.
11 years ago
James Cammarata
3529b1cb33
Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763
11 years ago
Michael DeHaan
627ff30a6f
Add module replacer capability for powershell files.
11 years ago
Ruggero Marchei
e3f5af377f
move get_distribution_version() to basic.py
11 years ago
James Cammarata
cb13b30362
Use file documentation fragement for the copy module
11 years ago
James Cammarata
9b17e8a555
Merge pull request #7771 from jkramarz/issue-5761
...
Added missing fallback to hw_sector_size
11 years ago
James Cammarata
6d9cc64e0f
Add role_names to valid keys entry for plays
...
Prevents a "not a legal parameter" error for play ds structures that
may be passed into the Play() constructor, which really is mainly a
concern during tests.
11 years ago
Matt Bray
578e881142
fix for urls like ssh://git@github.com/ansible/ansible.git
11 years ago
Jakub Kramarz
df3188cef0
Added missing fallback from physical_block_size to hw_sector_size in sectorsize fact discovery for kernels older than May 2009.
...
References #5761
11 years ago
James Cammarata
3fb3e7e6dc
Properly parse urls for ssh-keyscan use
...
Previously, the get_fqdn() function in known_hosts.py only worked
with urls that started with git@, and ignored any urls that started
with a normal schema type (ie. http:// or ssh://). This patch corrects
that by using urlparse to parse the hostname portion out of urls that
have a proper schema.
Fixes #7474
11 years ago
James Cammarata
395192ffbc
Merge pull request #7740 from jkramarz/issue-5761
...
changed sector size fact source
11 years ago
James Cammarata
b4d130d086
Add a new password pattern to the run_command filter
11 years ago
Jakub Kramarz
4e4c9235e8
changed sector size fact source from hw_sector_size to physical_block_size, fixes issue 5761
11 years ago
Stefan Lapers
78f4842982
fix incorrect secondary ip handling, fixes #7724
11 years ago
Eri Bastos
a65fd06338
Added quotes around key path - Issue 7713
11 years ago
James Cammarata
e5ef0eca03
Merge pull request #6507 from brdo/patch-1
...
Set keepalive to 5 seconds in paramiko_ssh.py
11 years ago
smoothify
e3530dcbc2
Add environmentfilter to random filter, to ensure the result doesn't get cached. Mirrors default jinja filter.
11 years ago
Dag Wieers
fd6f0cb4b4
Update facts.py
11 years ago
Dag Wieers
14a9966984
Added cross-platform uptime fact
...
Having an uptime fact allows you to check after a reboot whether the system was effectively rebooted.
```yaml
- name: Safeguard - Was system properly rebooted ?
action: fail msg="System was not properly rebooted"
when: ansible_uptime > 900
```
This patch has been tested on Linux, Solaris and HP-UX.
11 years ago
James Cammarata
ad97c618cf
Add support for relative paths in the file lookup plugin for roles
...
Fixes #7628
11 years ago
James Cammarata
82a784931e
Fix error passing play vars to an included playbook with empty vars
...
Fixes #7658
11 years ago
James Cammarata
d9df607972
Fix order of merging variables for the combined cache
...
Fixes #7598
11 years ago
James Cammarata
74f20ebf79
Removing cruft leftover from the deprecation of include+with_items
...
Also cleaning up integration tests that had checks for the empty item
attribute in certain results.
Fixes #7535
11 years ago
James Cammarata
0fa5100a2c
Merge branch 'fix-7596' of https://github.com/kilburn/ansible into kilburn-fix-7596
11 years ago
James Cammarata
849b0f87ce
Fix error when using os.getlogin() without a tty
11 years ago
Brian Coca
ce8c8ab146
now unique actually works, all operations also now use it to return
...
unique lists.
11 years ago
Michael DeHaan
959af67fe3
Merge pull request #7608 from jjneely/lookup-function
...
template.py: Handle purposely raised exceptions in lookup()
11 years ago
James Cammarata
b94bde9711
Merge pull request #7609 from jimi-c/issue_7553_su_copy
...
Support checking for su user to atomic_move
11 years ago
Jack Neely
2fda9bc743
template.py: Handle purposely raised exceptions in lookup()
...
If a lookup plugin is run by the lookup() template method it should pass
along any AnsibleError (or child exception classes) rather than just eat
them. These exceptions are purposely raised by the plugin.
11 years ago
Marc Pujol
d0f82e94e8
Ensure there are no duplicates in the merged/intersected lists
11 years ago
Marc Pujol
f892cc798c
Merge and intersect lists without using sets.
...
Using sets for these operations is dangerous because sets cannot contain
certain object types (such as lists) and their iteration order is
undefined.
Fixes #7596
11 years ago
James Cammarata
188ab7b952
Check groupnames for None as well as an empty string in add_host
...
Fixes #7585
11 years ago
James Cammarata
feafc4cd8a
Merge branch 'fix_mutable_inventory_vars' of https://github.com/banterchat/ansible into banterchat-fix_mutable_inventory_vars
11 years ago
Isao Jonas
72524e1f3b
dont mutate inventory vars
11 years ago
James Cammarata
061911c9c2
Merge pull request #7558 from dermute/pkg_mgr
...
added solaris fact detection for ansible_pkg_mgr
11 years ago
James Cammarata
e99df21647
Support checking for su user to atomic_move
...
Fixes #7553
11 years ago
James Cammarata
fa86eef9f9
Make sure value in regex_replace is a string
...
Fixes #7551
11 years ago
James Cammarata
ca734fde8b
Merge pull request #7544 from rik2803/patch-2
...
Differentiate machinfo output key/val separator
11 years ago
James Cammarata
cfd8c685d1
Correct issue of handlers running on all hosts incorrectly
...
Also adds an integration test to catch this bug in the future.
Fixes #7559
11 years ago
Alexander Winkler
4980e76a3a
added solaris fact detection for ansible_pkg_mgr
11 years ago
Brian Coca
8f58ae3305
changed exception handling for hashable test
11 years ago
rik2803
cfcbc954f5
Differentiate machinfo output key/val separator
...
get_hw_facts for HP-UX: machinfo in HP-UX B.11.23 uses '=' as separator between key and value, while B.11.31 uses ':'.
11 years ago
Yang Liping
aedf134fc4
Fix portability issue when checking local facts file permission.
11 years ago
James Cammarata
92f16b3d6f
Merge pull request #7539 from jimi-c/issue_7503_freebsd_su_fixes
...
Fixes for su on freebsd
11 years ago
Brian Coca
0dce5dae26
set theory v2, now can handle non hashable items like dicts
11 years ago
James Cammarata
e0c4c51c1f
Merge pull request #7517 from amenonsen/double-error
...
Don't double (or triple) up common error messages
11 years ago
James Cammarata
d77a6965b3
Merge module_vars into inject during template instead of updating
...
This way we won't overwrite values that are stored in the inject
with module_vars that should be lower precedence.
Fixes #7510
11 years ago