Commit Graph

681 Commits (4902c063045458278146914b87638822785ed67a)

Author SHA1 Message Date
Toshio Kuratomi c752f012f7 Start converting asserts to self.assert*() so we get better error messages 10 years ago
Michael DeHaan ccd559137f add missing headers, rm the subtree of ansible/inventory as we wish to overhaul it. 10 years ago
James Cammarata fe5a7bcabf Fixing bad variable naming choices 10 years ago
James Cammarata 2eda9a3a47 Fixing item loop when undefined variable errors occur because of missing attributes
Fixes a case where the variable 'foo' may exist, but the with_items loop
was used on something like 'foo.results', where 'results' was not a valid
attribute of 'foo'. Prior to this patch, conditionals were not evaluated
until later, meaning there was no opportunity to allow a test to skip the
task or item based on it being undefined.
10 years ago
James Cammarata a50332fc8a Adding v2 error line support, and tests 10 years ago
Toshio Kuratomi 48a308a87c Allow both old-style and new-style role dependencies to be valid.
Fixes #9173
10 years ago
Michael DeHaan 79f41d9c1a This makes the module args parser more functional to eliminate side effects and eliminiates the 'return None' error path
to make sure we are handling more use cases.  Some paths are not yet complete, including most likely handling of the 'raw'
module.
10 years ago
Michael DeHaan 56b6cb5328 Teaching objects to load themselves, making the JSON/YAML parsing ambidexterous. 10 years ago
James Cammarata ad893ea867 Merge pull request #9286 from damncabbage/9008-undef-var-in-list
Makes listify_lookup_plugin_terms respect the global setting for undefined variables.
10 years ago
James Cammarata c83a833740 New v2 ModuleArgsParser code and fixing up tests/other task code 10 years ago
Rob Howard 2769098fe7 Make listify respect the global setting for undefined variables.
(Fixes #9008.)

With credit to jimi-c for the initial pass in this commit:
b18bd6b98e
10 years ago
James Cammarata bbd9921dbd Adding a negative test for new safe_load 10 years ago
Michael DeHaan 4cb7f654b6 Add stub tests for module args parsing. 10 years ago
James Cammarata 93e273333d Adding tests for new yaml parsing stuff and adjusting imports 10 years ago
Michael DeHaan ad9ab8e033 Stub class for mod arg parsing tests. 10 years ago
Michael DeHaan 21642c0fbf We need module args specific parsing classes. 10 years ago
Michael DeHaan d97b38ba83 Attribute defaults and optional accessors. 10 years ago
Michael DeHaan e66a0096a7 Work in progress on task loading. 10 years ago
Michael DeHaan f066e361f1 WIP on data structure processing patterns. 10 years ago
James Cammarata 05644686de Fix bug in plugin path caching
Fixes #9263
10 years ago
Michael DeHaan 94db7365b9 __getattr__ to hide some of the attribute magic. 10 years ago
Michael DeHaan b54434c1b2 WIP on Attributes. Getting closer. 10 years ago
Michael DeHaan 6db1b4dfd2 WIP on refactoring changes 10 years ago
Michael DeHaan 335221d79e This is an exceedingly rough sketch of what attributes might look like - metaclass implementations NOT complete. 10 years ago
James Cammarata 0c40c6c23c Fix order of resolving dependent role variables from vars files
Also adds a new class to the test_var_precedence test to check for
this type of error in the future.

Fixes #9178
10 years ago
Toshio Kuratomi e6fcd90342 Merge pull request #9224 from drawks/iss9223
Resolve #9223 Fix test for python 2.6
10 years ago
Toshio Kuratomi e00d657362 Make unittest compatible with python <= 2.6 10 years ago
James Cammarata 313f26f866 Fix issue with vars precedence from roles
Fixes #9219
10 years ago
Dave Rawks 5f54b57b6d Corrected indentation 10 years ago
Chris Church 997ea78b1f Add integration tests for the win_feature module. 10 years ago
Toshio Kuratomi 0af750e3e5 Merge pull request #9182 from bbasleeper/feature_sudo_exe_from_inventory
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command...
10 years ago
Dave Rawks c070ab69f7 Resolve #9223 Fix test for python 2.6
* trivial test refactor to allow for python 2.6 compat
10 years ago
Bruno BAILLUET a25da4af05 Add a new inventory parameter (ansible_sudo_exe) to specify sudo command path. 10 years ago
Michael DeHaan f35ed8a6c0 Update module test code to avoid pycs (that are not used) 10 years ago
James Cammarata 21dcfd7192 Adding integration tests for async fire-and-forget checking
Also updated the CHANGELOG for the feature
10 years ago
James Cammarata 889dfc4374 Merge pull request #8959 from willthames/galaxy_ssh_clone
Allow fairly common ssh repo clone path to work
10 years ago
James Cammarata 56954a200e Merge branch 'devel' of https://github.com/dmage/ansible into dmage-devel 10 years ago
Toshio Kuratomi f7b5b85743 Fix the name of the upstart service 10 years ago
Toshio Kuratomi d98e32e364 Fix the var we're checking in the upstart test 10 years ago
Toshio Kuratomi 6943ec11a5 Failure to enable a service now fails the task
Fixes: 8855
10 years ago
James Cammarata 28f6a18ef6 Allow git repo queries without a clone when update=no
This commit also makes the dest parameter optional, unless update=yes
(the default), since it is not required for queries without an update.

Fixes #8630
10 years ago
James Cammarata b376e208c7 Adding "follow" param for file/copy options
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
10 years ago
Toshio Kuratomi 49a6af1378 Test that file touch does not keep a new file if we failed to set its
attributes
10 years ago
James Cammarata dc9482d548 Fix quoting issues in lineinfile for individual single-quotes
Fixes #8806
10 years ago
James Cammarata 503f7afbd8 Merge branch 'hfinucane-gh-7432' into devel 10 years ago
James Cammarata 178075489b Merge branch 'gh-7432' of https://github.com/hfinucane/ansible into hfinucane-gh-7432 10 years ago
Michael DeHaan d6e6d2a6ca Remove regex related to baby-JSON parsing only. 10 years ago
Michael DeHaan 26cdddaebf Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 10 years ago
James Laska 6cd55a5e95 Correct mysql integration indentation 10 years ago
James Laska b7c7476359 Include el7 mariadb support in mysql integration test 10 years ago
James Cammarata 317ab06bc6 Fixing multiline parsing to preserve newlines
Fixes #8813
10 years ago
James Cammarata a571fd4efe Convert boolean strings from set_fact to proper boolean values
Also adds integration tests for booleanification of strings

Fixes #8629
10 years ago
Will Thames d6a725659e Allow github style ssh repo names 10 years ago
Toshio Kuratomi a9b5b1bf55 Test that we can override variables set in inventory when the vars_file name is templated
Fixes #8903
10 years ago
James Cammarata 8cc3543918 Re-allow templating of complex_args, but count params to prevent injection
Fixes #8810
10 years ago
Toshio Kuratomi 8233522a7a Reduce commenting as basic.py is copied to the remote host with every module transfer.
Move some comments to the unittest as we might look at that if we decide
to refactor the code.
10 years ago
Toshio Kuratomi d293a46994 Unittests to detect speed regressions in password obfuscation and that
the passwords are correctly hidden in the output.
10 years ago
James Cammarata cd99821f8a Fix py26 difference in ssl socket connect call from 99ba9d6 10 years ago
James Cammarata 14b8e2cf01 Make sure set_fact variables go into VARS_CACHE
Fixes #8758
10 years ago
Henry Finucane 9638ab973f Add integration test 10 years ago
Oleg Bulatov a7d38702d9 Fix #7711
Fix relative symlinks creation in file module

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
10 years ago
Chris Church dac11904cb Add tests for new windows facts. 10 years ago
James Cammarata e99db078b4 Additional fixes for the new omit parameter variable 10 years ago
Victor Lin 6260635c65 add new test case 10 years ago
Victor Lin 559c04f324 Implement omit for module args, also add tests for it 10 years ago
James Cammarata d99b835c3e Adding integration tests for symbolic modes 10 years ago
Will Thames ab8490d003 Added warnings to command module
Generate warnings when users are shelling out to commands
rather than using modules

Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.

Print out warnings using the standard playbook callbacks.

Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
10 years ago
Michael DeHaan 3871eebfbb Merge pull request #8441 from willthames/unarchive_dest_fix
Unarchive should work when parent directory is not writable
10 years ago
Michael DeHaan 3695c2bcab Remove galaxy CLI tests that hit bitbucket as bitbucket is hanging tests - maybe replace with nice github examples later :) 10 years ago
Michael DeHaan 8a0045baad Update tests for ansible-galaxy CLI additions. 10 years ago
Michael DeHaan d87830e1cc Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel
Conflicts:
	lib/ansible/utils/__init__.py
10 years ago
James Cammarata d01188033f Checking for localized versions of the su password prompt
Fixes #8681
10 years ago
Will Thames 850963790d Allow roles to be installed from archives on github
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.

Handling .zip archives is left as an exercise for the interested reader
10 years ago
Michael DeHaan bcb44276fe Assume github.com URLs are git protocol if not specified. 10 years ago
Will Thames 6e9abefc11 Corrected bug where role_path was wrong for roles in subdirectories
Fixed role name for
    - { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
10 years ago
Will Thames 31540246dd Handle older git archive commands
Older git archive commands create tar archives even with a tar.gz
extension. So change it to always create tar archives and have
the install_role method cope.

Removed ssh roles from the test case as they don't work unless
you can connect to bitbucket via ssh and have your key there.

Corrected a minor typo in error messages
10 years ago
Will Thames ada9074276 Allow installation of roles from yaml roles file
Added docs
Added more tests
Improved how roles are returned from the parsers
10 years ago
Will Thames 46b59b02ed Friendly Role Names and roles from URLs
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
10 years ago
Will Thames 4803e923ff Improved handling of role_version in repo_url_to_role_name 10 years ago
Will Thames 1803976a40 Ensured that role version can be specified in role dependencies 10 years ago
Will Thames c2fe33f9f4 Tidied up a little, added tests
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
10 years ago
James Cammarata 5e240fec71 Merge branch 'devel' of https://github.com/l1k/ansible into l1k-devel
Conflicts:
	test/integration/roles/test_copy/tasks/main.yml
10 years ago
James Cammarata 8a1fbed5d6 Correct variable blending from vars_files with hostvars in them
Fixes #8638
10 years ago
Michael DeHaan f2adee9fc9 Merge pull request #8665 from cchurch/winrm_timeout
WinRM test for long-running command.
10 years ago
James Cammarata d4ff0d125a Make sure password files from lookups are created with restrictive permissions
Also adds checks for the lookup integration test for passwords.

Fixes #8652
10 years ago
James Cammarata 3a7aca6066 Fix no_log value for content in common file args settings
Also adds a test to ensure the content value is not logged.

Related to #8647
10 years ago
Chris Church 90fc6c6881 Added winrm test for long-running command. 10 years ago
Lukas Wunner 677de07f44 Try optimistic chown, do not error out if not permitted to chown
Add unit test
10 years ago
Michael DeHaan 99c39b1ff3 By popular request, make the no_log attribute also censor tasks from callbacks. 10 years ago
James Cammarata 5a128ca286 Adding extra member to mock inventory for unittests 10 years ago
James Cammarata 783a1e3dfc Fixing broken patch 20957a1
Also adds integration tests for nested includes with conditionals
10 years ago
James Cammarata 66802169f5 Adding integration test based on #8535 10 years ago
Michael DeHaan 2629cd3fce Fix some copyrights, fix a misc test. 10 years ago
James Cammarata 25e9d1197e Merge branch 'optimise_utils_clean_data' of https://github.com/leth/ansible into leth-optimise_utils_clean_data 10 years ago
Marcus Cobden e3dbca9378 Test escaping strings with two variables 10 years ago
Michael DeHaan 3bead39c75 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
10 years ago
James Cammarata 63bf2f6d9a Preserve all line breaks in literal blocks
Fixes #8512
10 years ago
Michael DeHaan 8c4161d4a1 Merge branch 'retf_py' of git://github.com/berendt/ansible into devel
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	plugins/callbacks/mail.py
10 years ago
Michael Peters 3ba516ac25 adding min() and max() filters for use in Jinja templates 10 years ago
Will Thames d9b895b319 Unarchive should work when parent directory is not writable
Correct unarchive so that the checks for writeability are
sensible.

Added a test for when parent directory is not writable
10 years ago
James Cammarata 5c2c10987e Re-enable the ec2_eip test 10 years ago
James Laska d202616213 Merge pull request #8426 from jlaska/update_integration_Makefile
Include unicode and var_precedence tests in 'all' target
10 years ago
James Cammarata af0d8cda7b Fix literal block multiline parsing
Fixes #8394
10 years ago
James Cammarata 6d94ae64ec Remove unnecessary unicode conversions from parse_kv
Fixes #8425
10 years ago
James Laska d4a78dc951 Include unicode and var_precedence tests in 'all' target 10 years ago
Wayne Rosario 2957a8de44 Adding test Coverage for mysql_variable module
Use mysql_variable to query, set and update variables.
Assert using user and password to query, set and update  variables.
Assert using single quotes, double quotes and no quotes  when using variables
10 years ago
James Cammarata 80df2135e9 Fix parsing of tasks with variable module names
Also adding an integration test for same.
10 years ago
James Cammarata 730e23fa07 Merge branch 'integration_mysql_user' of https://github.com/wrosario/ansible into wrosario-integration_mysql_user 10 years ago
James Cammarata e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting
Fixes #8338
10 years ago
Wayne Rosario eaf4571e42 Adding the following Test Coverage:
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
10 years ago
James Cammarata b64a5ff73d Further enhancements for include params tests 10 years ago
James Cammarata c9bfcf40d3 Adding further integration tests for include params with quotes 10 years ago
James Cammarata aee940aaca Reworking _clean_data() to be smarter about replaces
Fixes #8228
10 years ago
James Cammarata 6e814566de Unquote params passed to an include statement
Fixes #8315
10 years ago
Michael DeHaan f814e4e463 Verify playbook includes can take params. 10 years ago
Michael DeHaan a1e4f826ca Add some more integration tests for the task and playbook include mechanism. 10 years ago
James Cammarata 5bcb715dc0 Fixing up previous include test 10 years ago
James Cammarata 4d659229ce Adding integration test to parsing for includes with params 10 years ago
James Cammarata a8c2d6acd5 Adding unittest for space preservation within quotes when splitting args 10 years ago
James Cammarata 8f694c7588 Fixing unittests based on previous patch for splitting 10 years ago
James Cammarata 57f89b85eb Merge pull request #8271 from tksmd/fix-copy-set-fs-attributes-issue
fix an issue that copying directory will fail when trying to change file attributes
10 years ago
James Cammarata 63bcbd0af2 Fix for unicode decoding error in new splitting code
Also adds a new unicode integration test
10 years ago
Michael DeHaan 8d42f5cbfa Smush ds removal 10 years ago
Michael DeHaan 3adddf4836 Add another negative test for the parser logic. 10 years ago
Michael DeHaan eeb51b6bf3 Moar split_args tests 10 years ago
Michael DeHaan 630f080cf0 Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far). 10 years ago
James Cammarata 43154e5101 Using custom splitting function for module param counting 10 years ago
James Cammarata cd6602475b Merge branch 'integration_mysql_db' of https://github.com/wrosario/ansible into wrosario-integration_mysql_db 10 years ago
someda 1b1d5d0d3d fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
- the issue was introduced by the commit 84759faa09
10 years ago
James Cammarata 091b76efaa Fixes to parsing tests to remove trailing space 10 years ago
Michael DeHaan 1064550b47 Add missing file. 10 years ago
Michael DeHaan a21092d7c2 Add missing role test file. 10 years ago
Michael DeHaan 5a763fb5b6 Add some negative tests on the same parsing infrastructure. 10 years ago
Michael DeHaan 02c63cee26 Add a lot of tests to verify parsing routines for scenarios that should pass. Some changes TBD, like stripping command spaces off end of expressions. 10 years ago
James Cammarata 75e5b6401c Fixing up shell quoting issues 11 years ago
James Cammarata 8e940004c2 Fix ec2_setup task param quoting 11 years ago
James Cammarata 84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
11 years ago
Michael DeHaan 98c6688343 Merge pull request #6976 from clconway/gce-snapshots
Adds support for snapshots and extra persistent disks to the gce modules
11 years ago
Wayne Rosario 24a3d55c78 Adding Integration Tests for mysql_db module
Adding the following Test Coverage for RedHat and Debian OS:

 - Use mysql_db module to create, delete databases using different encoding.
 - Backup/Restore databases using different file format: sql, gz and bz2.
 - Create and delete databases using different user privilege.
 - Assert database creation, deleting and content using system commands.
11 years ago
James Cammarata 0e5b0a2e97 Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
This reverts commit 7a8eb0b670.
11 years ago
Jacob Leverich 7a8eb0b670 Set Jinja2's keep_trailing_newline=True in template_from_string.
Without this setting, the newline idempotence of scalar strings changes depending on whether
or not they contain any Jinja2 template blocks.
11 years ago
James Cammarata a320c02c81 Correcting var blending integration test 11 years ago
James Cammarata 4e5eb7559e Merge branch 'svg_and_inventory_refactor' into devel 11 years ago
Dan Slimmon 6ad09f1825 Added test for regex grouping bug fixed in 307a3e 11 years ago
James Cammarata bcf83cbc24 Merge branch 'sergevanginderachter-inventorytree' into svg_and_inventory_refactor 11 years ago
Chris Church 12a0f4abd8 Add integration tests for win_service module. 11 years ago
James Cammarata d8a7b49b59 Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree 11 years ago
James Cammarata 9564818e1e Merge branch 'fix_lineinfile_newlines' into devel 11 years ago
Chris Church f59041871e Fix typo in powershell setup module. 11 years ago
James Cammarata 32aa948dd0 Exclude ps1 modules from the TestModules unittest
Fixes #7864
11 years ago