Commit Graph

2790 Commits (47015829c0e6d06f1c240691ac204df7644edabe)

Author SHA1 Message Date
Chris Houseknecht de0122fdaf
Set default log_driver to None to prevent config comparison when a log_driver is not specified. Fixes #4600. 8 years ago
Chris Houseknecht 0d43a01462 Purge networks using network name rather than ID. Fixes 4596. 8 years ago
Chris Houseknecht cac4e68090
Default restart_retries to None rather than 0. Fixes #4534. 8 years ago
Ryan Brown 819fe45864 Fix failure when powering on/off EC2 instances by tag only. (#4767)
If you apply `wait=yes` and use `instance_tags` as your filter for
stopping/starting EC2 instances, this stack trace happens:

```
An exception occurred during task execution. The full traceback is:                                                                          │~
Traceback (most recent call last):                                                                                                           │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module>                                                            │~
    main()                                                                                                                                   │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main                                                                │~
    (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags)                  │~
  File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances                                                 │~
    if len(matched_instances) < len(instance_ids):                                                                                           │~
TypeError: object of type 'NoneType' has no len()                                                                                            │~
                                                                                                                                             │~
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~
ack (most recent call last):\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n    main()\n  File \"/tmp/│~
ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n    (changed, instance_dict_array, new_instance_ids) = startstop_instances│~
(module, ec2, instance_ids, state, instance_tags)\n  File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~
nces\n    if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~
MODULE FAILURE", "parsed": false}
```

That's because the `instance_ids` variable is None if not supplied
in the task. That means the instances that result from the instance_tags
query aren't going to be included in the wait loop. To fix this, a list
needs to be kept of instances with matching tags and that list needs to
be added to `instance_ids` before the wait loop.
8 years ago
Abhijit Menon-Sen 55d51b3946 Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741)
Before this, all spot instance requests would fail because the code
_always_ called module.fail_json when the parameter was set (which it
always was, because the module parameter's default was set to 'stop').

As the comment said, this parameter doesn't make sense for spot
instances at all, so the error message was also misleading.
8 years ago
Florian Dambrine aac55fcc62 Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243) 8 years ago
Matt Ferrante 624f813f60 Properly support tag updates on CloudFormation stack-update actions (#3638) 8 years ago
David J Peacock 3bede24323 description expanded for 112, AKA VRRP protocol) (#4645)
* description expanded for 112, AKA VRRP protocol)

* corrected syntax for description for IP protocols
8 years ago
Kenny Woodson 269c06a4c9 Fix for validate rule. Ensure rule is a dict. (#4640) 8 years ago
Kenny Woodson 9b37dcb593 Getting rid of a None type error when no resource tags are defined. (#4638) 8 years ago
John R Barker 0c25e968ee digital_ocean_tag name is a required field
Spotted during final review of https://github.com/ansible/ansible-modules-core/pull/4218/files
Simple to change, so fixing post merge
8 years ago
Victor Volle c170107eef Digitalocean tags (replaces #4209) (#4218)
* Fixes #4117: Add DigitalOcean Tag support

* Add GPLv3 license header and RETURN documentation

* ansible.module_utils.urls instead of "requests"
8 years ago
Arun prasath 0d98760b49 Fixes bug #4546 - Made password optional (#4574) 8 years ago
David J Peacock 8f963a7028 Fix #4412: os_security_group_rule support numbered protocols (#4444) 8 years ago
Ryan Brown 0c37949941 Remove spurious `changed` state on iam_policy module (#4381)
Due to a mixup of the group/role/user and policy names, policies with
the same name as the group/role/user they are attached to would never be
updated after creation. To fix that, we needed two changes to the logic
of policy comparison:

- Compare the new policy name to *all* matching policies, not just the
  first in lexicographical order
- Compare the new policy name to the matching ones, not to the IAM
  object the policy is attached to
8 years ago
Rick Mendes 02c47f5b0c Fixes #3144 (#4305) 8 years ago
Matías Pizarro 521c9a2e20 Use named parameters in new_droplet method call (#4483)
This mirrors the original method signature and guards against any
change in order parameter
8 years ago
Ilja Bauer acb7d873f8 Replaced use of bare variables with full variable syntax (#4149) 8 years ago
chouseknecht 48941291c1
Fix container labels expected vs actual comparison. 8 years ago
Patrick Marques f3c0c09fb6 ssh_public_keys on Azure virtual machine is a list (#4350)
The ssh_public_keys must be a list otherwise will give the error:
"argument ssh_public_keys is of type <type 'dict'> and we were unable to convert to list"
8 years ago
Richard Adams c8ca1a6211 Add parameter to `ec2` module to control instance shutdown behavior (stop|terminate) 8 years ago
Karthik Suresh 64ded1bb5e Removing duplicate name: parameter possible typo (#4525)
Removed name:parameter in documentation. Possible typo.
8 years ago
chouseknecht 42540ae510 Fix doc strings. Use of > was breaking HTML generation on docs site module page. 8 years ago
nishiokay a24398d025 Add ipv6 paramater to digital_ocean module (#4447) 8 years ago
Linus Arver 74c8954d86 docker_service: fix files/project_files typo
The original decision to rename from `project_files' to `files' was in
3a5dd00076.
8 years ago
chouseknecht 95f69c55fa Exposing tcp and udp for same port fails. Fixes issue #4354. 8 years ago
Ryan Brown 8da5e2cb88 Merge pull request #4275 from shaunbrady/ec2_elb_lb_respect_vpc
Make ec2_elb_lb respect VPCs when resolving groups
8 years ago
PikachuEXE 997fa3b2b7 Allow specifying human readable value for option `memory_limit` again (#4049) 8 years ago
Ryan Brown a2a6b5247f Merge pull request #4286 from rickmendes/fix-issue-4227
Clarify docs that led to #4227
8 years ago
chouseknecht e7abbbf134 Fix network alias and network link comparison.
- Using set based comparison was not working consistently
  - With != operator worked locally but consistently failed on Travis
  - With 'not in' operator failed locally and on Travis
8 years ago
chouseknecht 4c3bf24ebf
If debug true, include actions and differences in output. 8 years ago
Chris Houseknecht 70806fcfe4 Some post merge clean up: (#4406)
- Removed required_if.
  - Fixed doc strings.
  - Removed debug output being appended to actions.
  - Put import of basics at bottom to be consistent with other docker modules
  - Added 'containers' alias to 'connected' param
  - Put facts in ansible_facts.ansible_docker_network
8 years ago
Brian Coca decb2ec9fa doc fix 8 years ago
Chris Houseknecht fdfdfe9017 Adding docker_network module. (#4404) 8 years ago
muxator 24fa1ab426 typo in the documentation of the "state" parameter (#4353) 8 years ago
Chris Houseknecht 0358dee095 Add buildargs parameter to support Dockerfile ARG directive. (#4349)
* Add buildargs parameter to support Dockerfile ARG directive.

* Fix doc_strings. Doc string for load_path was completely missing.
8 years ago
chouseknecht cc101164a8
Default repository tag value to tag parameter value or 'latest'. 8 years ago
chouseknecht d36f04e7f2 Always returns changed when state present and name includes :tag. 8 years ago
Chris Houseknecht c0d373f258 Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed (#4342)
mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.
8 years ago
chouseknecht c27054090a Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'. 8 years ago
Ryan Brown 95a7ee271a Merge pull request #3773 from jbaublitz/gce_net_nwmode
gce_net: Add ability to create new-style networks on Google Cloud
8 years ago
chouseknecht af177834af
Added implementation of ignore_image, which prevents recreation of containers on image change. 8 years ago
Chris Houseknecht ccd8cd014b Merge pull request #4313 from chouseknecht/devel
Bind published ports to specific host IP when one is available
8 years ago
chouseknecht 74dbb61b8d Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option. 8 years ago
Chris Houseknecht db66758125 Merge pull request #4308 from chouseknecht/devel
Add explicit image build
8 years ago
chouseknecht 18343c4e5a
Improved documentation for returned actions. 8 years ago
chouseknecht b9696a349f
When build true call docker-compose build, and add nocache option. 8 years ago
Chris Houseknecht 3b268eff79 Merge pull request #4307 from chouseknecht/devel
Adding pull option
8 years ago
chouseknecht 81b3022eb5
Set version_added 8 years ago
chouseknecht 7e93dbb264
Add pull option to pull images prior to evaluating service state. 8 years ago