ansible

Commit Graph

Author	SHA1	Message	Date
Sloane Hertel	910bc892c6	ec2_ami: Properly delete snapshots (#39606 )	7 years ago
Will Thames	412373ce8e	Improve ec2_ami tests (#38987 ) * Improve ec2_ami tests Ensure that ec2_ami_image_id fact gets set immediately after AMI creation so that they get torn down even if tests fail Use YAML anchor to simplify AWS credential passing Use aws_connection_info to reduce AWS credential boilerplate Improve exception handling when updating image attributes Error messages weren't correctly formatted to show image ids.	7 years ago
Sloane Hertel	e2aa1155ba	[ec2_ami] Ensure name or image_id is provided for state=present (#38972 ) Add integration tests for backward compatibility and ensuring name or image_id is provided	7 years ago
Will Thames	60b29cf57d	[cloud] Follow up on FIXMEs in ec2_ami & ec2_ami tests (#32337 ) * Several tests were marked as FIXME and should have been fixed with the boto3 move. * Improved tags output. Add purge_tags option (default: no) * Allow description and tags update * Return launch_permissions * Allow empty launch permissions for image creation * Empty launch permissions should work the same way for image creation as no launch permissions * Cope with ephemeral devices in AMI block device mapping * Ephemeral devices can appear in AMI block devices, and this information should be returned * Fix notation for creating sets from comprehensions	7 years ago
Prasad Katti	86141c3e03	[ec2_ami_facts] new boto3-based module as a replacement for ec2_ami_find (#32252 ) * [ec2_ami_facts] new boto3-based module as a replacement for ec2_ami_find - new boto3-based module to gather facts about ec2 images - intended to replace ec2_ami_find which uses boto - an ami find task (using new module) added to the ec2_ami integration test * [ec2_ami_facts] Use AnsibleAWSModule. Catch BotoCoreError. * add ec2_ami_facts alias to tests * [ec2_ami_facts] return ami launch permissions as well	7 years ago
Willem van Ketwich	310eb833a4	EC2 AMI boto3 modifications (#28506 ) Migrate ec2_ami module to boto3	7 years ago
Toshio Kuratomi	638de22b35	Update tests for required_if changes These tests are doing string matches on the error condition. Update them to match the new strings. This is probably okay to push out to old releases even though it's technically backwards incompatible because production playbooks won't be checking that a parameter was missing. Param missing is something detected and fixed while writing the playbook.	7 years ago
Prasad Katti	8a9a9b84dd	[ec2-ami] Use required_if with state parameter (#32009 ) * [ec2-ami] Use required_if with state parameter * Update failure msg on delete ami with no image_id task in integration test	7 years ago
Will Thames	5900fee67a	Fix ec2_snapshot_facts for python3 Avoid the following seen when running ec2_ami tests on python3, presumably because the return type of `map` is different between python2 and python3. ``` Traceback (most recent call last): File "/tmp/ansible_e44v27uj/ansible_module_ec2_snapshot_facts.py", line 242, in <module> main() File "/tmp/ansible_e44v27uj/ansible_module_ec2_snapshot_facts.py", line 238, in main list_ec2_snapshots(connection, module) File "/tmp/ansible_e44v27uj/ansible_module_ec2_snapshot_facts.py", line 193, in list_ec2_snapshots snapshots = connection.describe_snapshots(SnapshotIds=snapshot_ids, OwnerIds=owner_ids, RestorableByUserIds=restorable_by_user_ids, Filters=filters) File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 312, in _api_call return self._make_api_call(operation_name, kwargs) File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 575, in _make_api_call api_params, operation_model, context=request_context) File "/usr/local/lib/python3.5/dist-packages/botocore/client.py", line 630, in _convert_to_request_dict api_params, operation_model) File "/usr/local/lib/python3.5/dist-packages/botocore/validate.py", line 291, in serialize_to_request raise ParamValidationError(report=report.generate_report()) botocore.exceptions.ParamValidationError: Parameter validation failed: Invalid type for parameter OwnerIds, value: <map object at 0x7ff577511048>, type: <class 'map'>, valid types: <class 'list'>, <class 'tuple'> ``` https://github.com/ansible/ansible/pull/30435#issuecomment-330750498	7 years ago
Will Thames	37736ee87e	Allow AWS image and snapshot creation/deletion Provide all necessary permissions for AMI tests Allow tests to run in us-east-2 Ensure `always` section gets used Update tests to ensure that cleanup works better, and add deletion idempotency test	7 years ago
s-hertel	328fd307a2	Add integration tests for ec2_ami module.	7 years ago
Matt Clay	17e07a27b2	Enable cloud tests for use with ansible-test.	8 years ago

12 Commits (44a07cfe71f4eb7e6b4b80a847f7bfa58e9308dd)