15 Commits (439af1d4e1e2e4fe53646cb3364bec2e009a949d)

Author	SHA1	Message	Date
Matt Clay	ca13e678ae	Backport test infra fixes and updates to stable-2.5. (#46992) ... * Fix unit test parametrize order on Python 3.5. (cherry picked from commit 53b230ca74) * Fix ansible-test unit test execution. (#45772) * Fix ansible-test units requirements install. * Run unit tests as unprivileged user under Docker. (cherry picked from commit 379a7f4f5a) * Run unit tests in parallel. (#45812) (cherry picked from commit abe8e4c9e8) * Minor fixes for unit test delegation. (cherry picked from commit be199cfe90) * add support for opening shell on remote Windows host (#43919) * add support for opening shell on remote Windows host * added arg completion and fix sanity check * remove uneeded arg (cherry picked from commit 6ca4ea0c1f) * Block network access for unit tests in docker. (cherry picked from commit 99cac99cbc) * Make ansible-test available in the bin directory. (#45876) (cherry picked from commit f3d1f9544b) * Support comments in ansible-test flat files. (cherry picked from commit 5a3000af19) * Fix incorrect use of subprocess.CalledProcessError (#45890) (cherry picked from commit 24dd87bd0a) * Improve ansible-test match error handling. (cherry picked from commit 2056c981ae) * Improve error handling for docs-build test. (cherry picked from commit 2148999048) * Bug fixes and cleanup for ansible-test. (#45991) * Remove unused imports. * Clean up ConfigParser usage in ansible-test. * Fix bare except statements in ansible-test. * Miscellaneous cleanup from PyCharm inspections. * Enable pylint no-self-use for ansible-test. * Remove obsolete pylint ignores for Python 3.7. * Fix shellcheck issuers under newer shellcheck. * Use newer path for ansible-test. * Fix issues in code-smell tests. (cherry picked from commit ac492476e5) * Fix integration test library search path. This prevents tests from loading modules outside the source tree, which could result in testing the wrong module if a system-wide install is present, or custom modules exist. (cherry picked from commit d603cd41fe) * Update default container to version 1.2.0. (cherry picked from commit d478a4c3f6) (cherry picked from commit 21c4eb8db5) * Fix ansible-test docker python version handling. This removes the old name based version detection behavior and uses versions defined in the docker completion file instead, as the new containers do not follow the old naming scheme. (cherry picked from commit 54937ba784) * Reduce noise in docs-build test failures. (cherry picked from commit 4085d01617) * Fix ansible-test encoding issues for exceptions. (cherry picked from commit 0d7a156319) * Fix ansible-test multi-group smoke test handling. (#46363) * Fix ansible-test smoke tests across groups. * Fix ansible-test list arg defaults. * Fix ansible-test require and exclude delegation. * Fix detection of Windows specific changes. * Add minimal Windows testing for Python 3.7. (cherry picked from commit e53390b3b1) * Use default-test-container version 1.3.0. (cherry picked from commit 6d9be66418) * Add file exists check in integration-aliases test. (cherry picked from commit 33a8be9109) * Improve ansible-test environment checking between tests. (#46459) * Add unified diff output to environment validation. This makes it easier to see where the environment changed. * Compare Python interpreters by version to pip shebangs. This helps expose cases where pip executables use a different Python interpreter than is expected. * Query `pip.__version__` instead of using `pip --version`. This is a much faster way to query the pip version. It also more closely matches how we invoke pip within ansible-test. * Remove redundant environment scan between tests. This reuses the environment scan from the end of the previous test as the basis for comparison during the next test. (cherry picked from commit 0dc7f38787) * Add symlinks sanity test. (#46467) * Add symlinks sanity test. * Replace legacy test symlinks with actual content. * Remove dir symlink from template_jinja2_latest. * Update import test to use generated library dir. * Fix copy test symlink setup. (cherry picked from commit e2b6047514) * Fix parametrize warning in unit tests. (cherry picked from commit 1a28898a00) * Update MANIFEST.in (#46502) * Update MANIFEST.in: - Remove unnecessary prune. - Include files needed by tests. - Exclude botmeta sanity test. These changes permit sanity tests to pass on sdist output. (cherry picked from commit cbb49f66ec) * Fix unit tests which modify the source tree. (#45763) * Fix CNOS unit test log usage. * Use temp dir for Galaxy unit tests. * Write to temp files in interfaces_file unit test. * Fix log placement in netapp_e_ldap unit test. (cherry picked from commit 0686450cae) * Fix ansible-test custom docker image traceback. (cherry picked from commit 712ad9ed64) * ansible-test: Create public key creating Windows targets (#43760) * ansible-test: Create public key creating Windows targets * Changed to always set SSH Key for Windows hosts (cherry picked from commit adc0efe10c) * Fix and re-enable sts_assume_role integration tests (#46026) * Fix the STS assume role error message assertion when the role to assume does not exist. (cherry picked from commit 18dc928e28) * Fix ACI unit test on Python 3.7.0. The previous logic was only needed for pre-release versions of 3.7. (cherry picked from commit c0bf9815c9) * Remove placeboify from unit tests that are not calling AWS (i.e. creating a recording) (#45754) (cherry picked from commit 2167ce6cb6) * Update sanity test ignore entries.	7 years ago
Toshio Kuratomi	370a7ace4b	Split basic units (#33510) ... Split the one monolithic test for basic.py into several files * Split test_basic.py along categories. This is preliminary to get a handle on things. Eventually we may want to further split it so each file is only testing a single function. * Cleanup unused imports from splitting test_basic.py * Port atomic_move test to pytest. Working on getting rid of need to maintain procenv * Split a test of symbolic_mode_to_octal to follow unittest best practices Each test should only invoke the function under test once * Port test_argument_spec to pytest. * Fix suboptions failure	8 years ago
Toshio Kuratomi	cd36164239	Porting tests to pytest (#33387) ... * Porting tests to pytest * Achievement Get: No longer need mock/generator.py * Now done via pytest's parametrization * Port safe_eval to pytest * Port text tests to pytest * Port test_set_mode_if_different to pytest * Change conftest AnsibleModule fixtures to be more flexible * Move the AnsibleModules fixtures to module_utils/conftest.py for sharing * Testing the argspec code requires: * injecting both the argspec and the arguments. * Patching the arguments into sys.stdin at a different level * More porting to obsolete mock/procenv.py * Port run_command to pytest * Port known_hosts tests to pytest * Port safe_eval to pytest * Port test_distribution_version.py to pytest * Port test_log to pytest * Port test__log_invocation to pytest * Remove unneeded import of procenv in test_postgresql * Port test_pip to pytest style * As part of this, create a pytest ansiblemodule fixture in modules/conftest.py. This is slightly different than the approach taken in module_utils because here we need to override the AnsibleModule that the modules will inherit from instead of one that we're instantiating ourselves. * Fixup usage of parametrization in test_deprecate_warn * Check that the pip module failed in our test	8 years ago
Dag Wieers	4efec414e7	test/: PEP8 compliancy (#24803) ... * test/: PEP8 compliancy - Make PEP8 compliant * Python3 chokes on casting int to bytes (#24952) But if we tell the formatter that the var is a number, it works	9 years ago
Matt Clay	10d9318de7	PEP 8 indent cleanup. (#20800) ... * PEP 8 E121 cleanup. * PEP 8 E126 cleanup. * PEP 8 E122 cleanup.	9 years ago
Dag Wieers	d91df20620	Fix unit tests for module_name commit #16087	10 years ago
Toshio Kuratomi	186337db28	Ship constants to the modules via internal module params rather than a secondary dict.	10 years ago
Toshio Kuratomi	c730af5dc2	Remove reload from arg related tests. Changes to how ziploader passes args mean we don't need reload anymore. (#15782)	10 years ago
Toshio Kuratomi	44e21f7062	Allow AnsibleModules to be instantiated more than once in a module ... Fix SELINUX monkeypatch in test_basic	10 years ago
Toshio Kuratomi	03126f7097	Fix cut and paste error of test code	10 years ago
nitzmahone	5b336832af	add _load_params debug overrides for module args/file passed on cmdline ... Updated python module wrapper explode method to drop 'args' file next to module. Both execute() and excommunicate() debug methods now pass the module args via file to enable debuggers that are picky about stdin. Updated unit tests to use a context manager for masking/restoring default streams and argv.	10 years ago
Toshio Kuratomi	75546678d9	Fix unittests	10 years ago
Toshio Kuratomi	4b0aa1214c	Ziploader ... * Ziploader proof of concept (jimi-c) * Cleanups to proof of concept ziploader branch: * python3 compatible base64 encoding * zipfile compression (still need to enable toggling this off for systems without zlib support in python) * Allow non-wildcard imports (still need to make this recusrsive so that we can have module_utils code that imports other module_utils code.) * Better tracebacks: module filename is kept and module_utils directory is kept so that tracebacks show the real filenames that the errors appear in. * Make sure we import modules that are used into the module_utils files that they are used in. * Set ansible version in a more pythonic way for ziploader than we were doing in module replacer * Make it possible to set the module compression as an inventory var This may be necessary on systems where python has been compiled without zlib compression. * Refactoring of module_common code: * module replacer only replaces values that make sense for that type of file (example: don't attempt to replace python imports if we're in a powershell module). * Implement configurable shebang support for ziploader wrapper * Implement client-side constants (for SELINUX_SPECIAL_FS and SYSLOG) via environment variable. * Remove strip_comments param as we're never going to use it (ruins line numbering) * Don't repeat ourselves about detecting REPLACER * Add an easy way to debug * Port test-module to the ziploader-aware modify_module() * strip comments and blank lines from the wrapper so we send less over the wire. * Comments cleanup * Remember to output write the module line itself in powershell modules * for line in lines strips the newlines so we have to add them back in	10 years ago
Toshio Kuratomi	6e5055e786	Update the use of no_log values to cover everything that heuristic_log_sanitize does. ... Fixes #12792	10 years ago
Toshio Kuratomi	15d7f53846	AnsibleModules.log() fix for python3 ... Also add unittests for AnsibleModules.log() Fixes #12586	10 years ago