Commit Graph

26 Commits (42dab7bed8d8cebbb7beeaa38fc5de512d3a11e1)

Author SHA1 Message Date
Justin Ludwig bd9e6a74f7 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
11 years ago
James Tanner d62812b8ee Change s3 module to use shared ec2 authorization module snippet 11 years ago
dragon3 15b6dad3e3 Remove duplicate "download_s3file" execution when the destination path doesn't exist 11 years ago
Lorin Hochstein 87055995b9 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
11 years ago
James Tanner d03211cf6b Remove all sys.exit calls in the cloud/s3 module
Fixes #4458
11 years ago
Matthew Barrington e16e77249f Fixed crash when s3 bucket did not exist for put operation 11 years ago
James Tanner 613b6a2473 #4408 s3: add force alias for overwrite and set True by default 11 years ago
James Tanner 7aa187b413 Remove debug comment from s3 module 11 years ago
James Tanner 4b4b9551d0 4006: return s3 url even if file exists 11 years ago
Michael DeHaan 50d72d89c2 Fix documentation of default value in s3 module. Fixes #4289 11 years ago
Benno Joy 325b65b8c6 change "Changed" to changed 11 years ago
bennojoy 78d1af3607 minor fixes 11 years ago
Jeremy Price 14f67a4bf7 dest in s3 module does not work with ~username notation for home directories. Wrapped dest definition in os.path.expanduser() which will return the expanded path in case of successful tilde expansion and otherwise the original value 11 years ago
Bruce Pennypacker 11470fea04 Rebase attempt
No idea if I'm rebasing properly or not.  This is my first attempt.
11 years ago
Michael DeHaan 35c58b5fc2 Merge pull request #3772 from lorin/s3-docpatch
Minor doc update to s3 & ec2 modules
12 years ago
Michael DeHaan 42eda799c8 Merge pull request #3709 from lwade/devel
S3folder
12 years ago
Lorin Hochstein 2281cb66a3 Minor doc update to s3 & ec2 modules
Adds some additional docs about the module parameters for s3
and ec2 modules.
12 years ago
Michael DeHaan 74679c1c87 Slight docs tweak and remove redundant sys.exit call 12 years ago
lwade 9128f9f313 Added ability to create virtual directories. 12 years ago
Peter Hall 0517a104e6 Adding getstr mode to download an object into a variable 12 years ago
lwade 99ac050a43 Rewritten s3 module to allow for additional modes of operation. 12 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Michael DeHaan 901e73918a Doc standardization/style 12 years ago
Shahar Kedar f1638c5eea Issue #3079: Initializing key_exists in case the S3 bucket does not exist 12 years ago
Ralph Tice 0866fa5405 amended s3 plugin to support 'dest' parameter to allow uploading to custom location 12 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago