Commit Graph

18 Commits (417e408f596cbf48503f2240b8e2b9a97ed05d51)

Author SHA1 Message Date
Shachaf92 7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
5 years ago
cipress c1fc0ca4fd Found issue on different System architecture.
On x86 systems doesn't work so, starting by the line 63 we check if the architecture is x86 or x64.
10 years ago
nathansoz f0004b1604 $powershellpath is called as ".$powershellpath"
$powershell path is set to "C:\powershell" at line 27. This is fine, but on line 82 $powershellpath is called as ".$powershellpath\$filename". Because the path at line 27 is absolute, a period preceding the $powershellpath is not required at 82. It actually causes an error:

Start-Process : This command cannot be executed due to the error: Unknown error (0x80041002).
At C:\users\Nathan Sosnovske\Documents\ps2to3.ps1:81 char:14

Start-Process <<<< -FilePath ".$powershellpath\$filename" -ArgumentList /quiet
CategoryInfo : InvalidOperation: (:) [Start-Process], InvalidOperationException
FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand
Removing the period on line 82 before $powershellpath fixes this error.
10 years ago
Matt Martz 2316b7785c Make sure the doc stubs for windows modules have proper license headers 11 years ago
Chris Church 2654f7b200 Add copyright header to main winrm test playbook. 11 years ago
Chris Church 43236ca0ed Add basic tests for win_get_url and win_msi modules. 11 years ago
Don Schenck 618b47cd77 Added -Wait flag to Start-Process
Must wait in order for script to be available
11 years ago
Don Schenck 9c4220832a Start-Process
Debugging
11 years ago
Don Schenck 8012fdc448 Start-Process line was wrong
Fixed
11 years ago
Don Schenck e2f5d40a6b Changed launch
Using Start-Process
11 years ago
Chris Church 5b85252043 Add tests for windows setup module. 11 years ago
Paul Durivage bceaf96fd6 Add comments 11 years ago
Don Schenck e5399b12b9 Pipe Get-Process to see what's running 11 years ago
Craig Ackerman cd3edf1eba Added FW commands to allow access to HTTPS listener 11 years ago
Craig Ackerman f42905a9cc Added commands to allow Windows firewall access to WinRM HTTPS listener 11 years ago
Paul Durivage 7e055ec6cc Remove unnecessary obj 11 years ago
Michael DeHaan e621fec7d3 Add notes on powershell script source. 11 years ago
Michael DeHaan 128be9ea27 File rename. 11 years ago