Commit Graph

433 Commits (4028f55c041155950c6a3eaf3281f4dffca2a1fb)

Author SHA1 Message Date
Chris Church 09b076e39c Fix setup module to gather facts from PowerPC Macs. 11 years ago
James Cammarata 8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
Nils Pascal Illenseer 7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden c892f51002 Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca 01a1482f1a hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca 4b0c2d839e made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca 8a6a2aba75 changes names to name in example 11 years ago
Brian Coca ddb191f208 fixes as per feedback 11 years ago
Tom Dymond c9e7541e60 Reworked PR to avoid repeating the command 11 years ago
jctanner 4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond 16edbd3181 Add option to enable the sysctl -e option 11 years ago
kustodian 405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 931f8e4c5b Add move_home option to user module 11 years ago
Richard C Isaacson cc20868bfb Tested implementation adding action option for (add, delete, unique). 11 years ago
Richard C Isaacson 855154226e Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson 4e4ba1f695 Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson c677056dfe Change to dynamically pick up the command from the PATH. 11 years ago
Richard C Isaacson 9dc98d9b66 Formating and syntax fixes that were pointed out during code review. 11 years ago
Richard C Isaacson eb9831cf62 Added user option. 11 years ago
Richard C Isaacson 7e1361d0e0 First commit of the at module being very basic. 11 years ago
Brian Coca fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Jakub Jirutka 1dc5ee00b6 sysctl: parse bool value as 0/1 and refactor a little bit 11 years ago
Thoai Nguyen 220b0f87d9 reorder usermod options 11 years ago
jctanner f14f6ebd44 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Augustus Kling de19375d1b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 11 years ago
Augustus Kling eabc9cd775 Merge remote-tracking branch 'upstream/devel' into locale 11 years ago
Augustus Kling 00ee613446 Handle install/uninstall of locales for Ubuntu, too. 11 years ago
Simon Zimmermann be69ca4ead correctly compare the values, better func name 11 years ago
Simon Zimmermann 45728d739c Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Simon Zimmermann 624c563e43 fix str format error due to missing '%' in sysctl module 11 years ago
James Tanner f3b86abc30 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 49b0db9819 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 921ae2134b Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 03aba39b59 Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 4ef5b60f3d Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
Scott Gilbert df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner a9c5aa8f78 Remove unused variable from authorized_key 11 years ago
James Tanner 30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
James Tanner 272c3634cd sysctl module: append newline character to lines in the file 11 years ago
Michael DeHaan cb6f7748d5 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
11 years ago
jctanner da9cd8e018 Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
11 years ago
jctanner 9779206142 Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
11 years ago
James Tanner 1b712ec48d sysctl module: fail if reloading the file did not succeed 11 years ago
James Tanner f0b842b28b Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
11 years ago
Tyler 5ce664b499 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler c073438d40 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Joshua Lund e0a720b8b2 Improved the documentation for password generation 11 years ago
James Tanner 154a99529c Fixes #5353 create etc/hostname file in debian if it does not exist 11 years ago
Michael DeHaan 0fdcb8ea69 Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
11 years ago
Paul Beattie 31f81c3a1b Fixed typo in example documentation 11 years ago
rgbj fa5a448983 On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 11 years ago
jctanner 6f16ea6d49 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
11 years ago
James Tanner e2c7aeca4c Fixes #5040 setup module: do not add primary interface info to the secondary interface data 11 years ago
lichesser bab510f0c5 Partial fix for #4565. Works only for Debian 7 and later 11 years ago
Michael DeHaan 05c755f2dc Fix a documentation item. 11 years ago
Augustus Kling c850c0a76b Basic handling of locales. 11 years ago
Brian Coca 45872dfee7 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca ebba754ee6 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 72eba69175 did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Jasper N. Brouwer 9dab01c5e2 Swapped conditions of the changed if statements 11 years ago
Brian Coca ce72f27787 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 3587053119 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 564bd29eeb fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 0c2ec0d9d1 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
jctanner 76c3055986 Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
11 years ago
jctanner 0a2fd6f088 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
11 years ago
Dimos Alevizos 8cda18ec51 Minor changes to simplify code 11 years ago
David Hummel e329b23365 Fix issue #5214: hostname persistence on RedHat/CentOS 11 years ago
Dimos Alevizos 34ff7e00a9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 11 years ago
jeromew 5413ee9431 user module: force= and remove= should not be mutually exclusive 11 years ago
jctanner 5040665cd0 Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
11 years ago
gservat 38ec5b0058 This change is meant to replace distribution_release, not version! 11 years ago
gservat a8c9e2afd1 Oops... fixed an error 11 years ago
Alfons Zitterbacke f37a217a33 added AIX network facts 11 years ago
Alfons Zitterbacke f556151c56 added AIX network facts 11 years ago
James Tanner 3bb1a263cf Fixes #5169 Evaluate check_mode in the user module SunOS class 11 years ago
Jasper N. Brouwer 677f95294e Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
11 years ago
jctanner 5fb01db898 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
jctanner 4125713b6e Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
11 years ago
jctanner cd5c817a36 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
James Tanner 0242f10781 Fixes #4796 handle unicodedecode errors from dmidecode output 11 years ago
Michael DeHaan 4704dfefb0 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
11 years ago
Matthias Blaser 1e1def3fbd rewrite options to dict parser, fixes #5032 11 years ago
Michael DeHaan 4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan 9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
dragon3 b5eb3c41e3 hostname module: add support for Amazon Linux 11 years ago
gservat 3b6e9a07f6 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
11 years ago
Sam Hartsfield a8a6771b0e Fixed hostname module for RHEL6 Workstation 11 years ago
James Tanner fa4b30819a Fix comment yaml escaping in authorized_key module 11 years ago
James Tanner 999b04f7fa Save comment hashes in sshkeys 11 years ago
James Tanner 7de788f346 Cleanup debug statements 11 years ago
James Tanner d0c2b37688 Fixes #5032 escape and safely split key options in authorized_keys module 11 years ago