ansible

Commit Graph

Author	SHA1	Message	Date
Sloane Hertel	ec1287ca7e	Fix notifying handlers by using an exact match (#55624 ) * Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list * Enforce better type checking for listeners * Share code for validating handler listeners * Add test for handlers without names * Add test for templating in handlers * Add test for include_role * Add a couple notes about 'listen' for handlers * changelog * Add a test for handlers without names * Test templating in handlers * changelog * Add some tests for include_role * Add a couple notes about 'listen' for handlers * make more sense * move local function into a class method	5 years ago
Alicia Cozine	d4f0bc183e	removes last :doc: links in user guide (#58433 ) * removes last :doc: links in user guide	5 years ago
Jonathan Bride	db6407d6bf	Correct typo in playbooks_intro.rst (#56919 ) Typo in code block line: ansible-lint veryify-apache.yml should be ansible-lint verify-apache.yml	6 years ago
Sam Doran	f7ed194bc9	Clarify how to use variables with handlers (#54928 ) * Add clarification on handler names Add example on how to use variables in handlers * Update docs/docsite/rst/user_guide/playbooks_intro.rst	6 years ago
Matt Martz	445ff39f94	Become plugins (#50991 ) * [WIP] become plugins Move from hardcoded method to plugins for ease of use, expansion and overrides - load into connection as it is going to be the main consumer - play_context will also use to keep backwards compat API - ensure shell is used to construct commands when needed - migrate settings remove from base config in favor of plugin specific configs - cleanup ansible-doc - add become plugin docs - remove deprecated sudo/su code and keywords - adjust become options for cli - set plugin options from context - ensure config defs are avaialbe before instance - refactored getting the shell plugin, fixed tests - changed into regex as they were string matching, which does not work with random string generation - explicitly set flags for play context tests - moved plugin loading up front - now loads for basedir also - allow pyc/o for non m modules - fixes to tests and some plugins - migrate to play objects fro play_context - simiplify gathering - added utf8 headers - moved option setting - add fail msg to dzdo - use tuple for multiple options on fail/missing - fix relative plugin paths - shift from play context to play - all tasks already inherit this from play directly - remove obsolete 'set play' - correct environment handling - add wrap_exe option to pfexec - fix runas to noop - fixed setting play context - added password configs - removed required false - remove from doc building till they are ready future development: - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems * cleanup remove callers to removed func removed --sudo cli doc refs remove runas become_exe ensure keyerorr on plugin also fix backwards compat, missing method is attributeerror, not ansible error get remote_user consistently ignore missing system_tmpdirs on plugin load correct config precedence add deprecation fix networking imports backwards compat for plugins using BECOME_METHODS * Port become_plugins to context.CLIARGS This is a work in progress: * Stop passing options around everywhere as we can use context.CLIARGS instead * Refactor make_become_commands as asked for by alikins * Typo in comment fix * Stop loading values from the cli in more than one place Both play and play_context were saving default values from the cli arguments directly. This changes things so that the default values are loaded into the play and then play_context takes them from there. * Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH As alikins said, all other plugin paths are named DEFAULT_plugintype_PLUGIN_PATH. If we're going to rename these, that should be done all at one time rather than piecemeal. * One to throw away This is a set of hacks to get setting FieldAttribute defaults to command line args to work. It's not fully done yet. After talking it over with sivel and jimi-c this should be done by fixing FieldAttributeBase and _get_parent_attribute() calls to do the right thing when there is a non-None default. What we want to be able to do ideally is something like this: class Base(FieldAttributeBase): _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check']) class Play(Base): # lambda so that we have a chance to parse the command line args # before we get here. In the future we might be able to restructure # this so that the cli parsing code runs before these classes are # defined. class Task(Base): pass And still have a playbook like this function: --- - hosts: tasks: - command: whoami check_mode: True (The check_mode test that is added as a separate commit in this PR will let you test variations on this case). There's a few separate reasons that the code doesn't let us do this or a non-ugly workaround for this as written right now. The fix that jimi-c, sivel, and I talked about may let us do this or it may still require a workaround (but less ugly) (having one class that has the FieldAttributes with default values and one class that inherits from that but just overrides the FieldAttributes which now have defaults) * Revert "One to throw away" This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064. * Set FieldAttr defaults directly from CLIARGS * Remove dead code * Move timeout directly to PlayContext, it's never needed on Play * just for backwards compat, add a static version of BECOME_METHODS to constants * Make the become attr on the connection public, since it's used outside of the connection * Logic fix * Nuke connection testing if it supports specific become methods * Remove unused vars * Address rebase issues * Fix path encoding issue * Remove unused import * Various cleanups * Restore network_cli check in _low_level_execute_command * type improvements for cliargs_deferred_get and swap shallowcopy to default to False * minor cleanups * Allow the su plugin to work, since it doesn't define a prompt the same way * Fix up ksu become plugin * Only set prompt if build_become_command was called * Add helper to assist connection plugins in knowing they need to wait for a prompt * Fix tests and code expectations * Doc updates * Various additional minor cleanups * Make doas functional * Don't change connection signature, load become plugin from TaskExecutor * Remove unused imports * Add comment about setting the become plugin on the playcontext * Fix up tests for recent changes * Support 'Password:' natively for the doas plugin * Make default prompts raw * wording cleanups. ci_complete * Remove unrelated changes * Address spelling mistake * Restore removed test, and udpate to use new functionality * Add changelog fragment * Don't hard fail in set_attributes_from_cli on missing CLI keys * Remove unrelated change to loader * Remove internal deprecated FieldAttributes now * Emit deprecation warnings now	6 years ago
Sandra McCann	2c0897caf2	mention ansible-lint and editor tools that help with playbook development (#51769 ) * introduce ansible-lint in playbook docs, mention editors help playbook syntax Co-Authored-By: samccann <samccann@redhat.com>	6 years ago
Jeremy Booker	b787d8b23c	Remove "as mentioned above" (#51295 ) Remove "as mentioned above" because "variables" weren't mentioned anywhere above.	6 years ago
Simon Legner	33b9c880a4	Consistent typesetting of "GitHub" (#50929 )	6 years ago
Hans Melby	8487f2feb4	Update playbooks_intro.rst (#50187 )	6 years ago
Martin Krizek	d20d66dc2f	docs: try to clarify handlers a bit more (#49322 ) * docs: try to clarify handlers a bit more * docs: refines description of duplicate handler names	6 years ago
Simon Legner	5959158612	doc(user_guide): fix typos (#47425 )	6 years ago
Andreas Olsson	1a11cecaef	Prefer https:// links in the docs site All the changed urls are availible by way of https://. Most of them already redirect.	6 years ago
Taranjeet Singh	58d6044251	Docs: Update sentence structure in user guide (#42884 ) This commit fixes the information about become keyword in Introduction to Playbook part under User Guide.	6 years ago
Martin Krizek	f1e41cbb36	playbooks_intro.rst: remove duplicite playbook (#38521 )	7 years ago
scottb	381359a8f8	Doc build warning/broken link clean-a-palooza (#37382 ) * Doc build warning/broken link clean-a-palooza, WIP commit 1. * Fixed broken anchor * Fixing additional broken links; converting from doc to ref. * Fix anchor	7 years ago
scottb	373b1dcf59	Core Docs Refactor and Redesign (#36067 ) * Docs refactor as outlined in https://github.com/ansible/proposals/issues/79. Moves content into 'guides'; refactors TOC; fixes CSS; design tweaks to layout and CSS; fixes generated plugin, CLI and module docs to fix links accodingly; more. * Adding extra blank line for shippable	7 years ago

16 Commits (3f0479279e54c8603818a42455027e9c33358774)