Commit Graph

53727 Commits (3e2ce2d0737122d14827605c67fe3c18eb9bc12e)
 

Author SHA1 Message Date
Felix Fontein 2c847af5a5
Module docs fixes. (#81213) (#81236)
(cherry picked from commit dce51f4ff4)
1 year ago
Matt Clay f64067c62b
[stable-2.15] Update update-sanity-requirements.py script (#81424) (#81431)
Frozen requirements can now preserve any explicitly installed package that would normally be omitted, not just setuptools.
(cherry picked from commit dbb3feddaf)
1 year ago
Matt Clay af59d80a8a
[stable-2.15] Revert "define code owners to support branch-protection rules on docs (#81041)" (#81228) (#81428)
This reverts commit 9117762358.
(cherry picked from commit 7c6564ad0e)
1 year ago
Matt Clay 5265794b32
[stable-2.15] Clean up MANIFEST.in (#81414)
* Clean up MANIFEST.in (#80688)

* Remove unnecessary MANIFEST.in commands

This eliminates more setuptools warnings during build.

* Sort MANIFEST.in

Now that only include commands are used, the order of the commands no longer effects the build output.

(cherry picked from commit 6e325d9e4d)

* Omit hacking directory from MANIFEST.in (#81245)

* Omit `hacking` directory from `MANIFEST.in`

* Update package-data sanity test

(cherry picked from commit b93a628aed)
1 year ago
Matt Clay 3038fee209
[stable-2.15] Add changelog fragment for docs/examples removal (#81410) (#81411)
(cherry picked from commit 0c03a6bcf6)
1 year ago
Martin Krizek 7e63a85dd6
Remove BOTMETA.yml and sanity tests for it (#81198) (#81263)
(cherry picked from commit 39ef570e16)
1 year ago
Matt Clay 21243c5d05
[stable-2.15] Fix os.walk issues in package-data sanity test (#80703). (#81403)
(cherry picked from commit eea7137449)
1 year ago
Matt Clay 5d57a8e363
[stable-2.15] Omit pre-built man pages from sdist (#81395) (#81397)
Since man pages aren't accessible to users after a `pip install`, there's no need to include them in the sdist.
This change makes it trivial to build man pages from source, which makes them much easier to iterate on.
It also simplifies creation and testing of the sdist, since it no longer requires building man pages.

The new `packaging/cli-doc/build.py` script can generate both man pages and RST documentation.
This supports inclusion on the docs site without a dependency on `ansible-core` internals.
Having a single implementation for both simplifies keeping the two formats in sync..
(cherry picked from commit 691c8e8603)
1 year ago
Matt Clay b63bf6f840
[stable-2.15] Include subcommands in generated man pages (#81378) (#81382)
Sub commands of `ansible-galaxy role` and `ansible-galaxy collection` are now documented.
(cherry picked from commit 081c60b9d3)
1 year ago
Matt Clay bf09a9e2e0
[stable-2.15] Fix misrendered sections in manpage generation (#81379)
This change fixes bugs in the manpage generator that existed since it
was first added.

It exposes CLI `ARGUMENTS` value to manpage templates.

Before this change, the code contained a typo, causing the `for`-loop
iterate over individual characters of the `'ARGUMENTS'` string rather
than iterating over a tuple. A missing comma was at fault.

The updated code gets rid of the `for`-loop and conditionals since it
seems to have been a premature complexity increase and no other things
than `'ARGUMENTS'` were ever added into the broken iterable.

The functional change is that `arguments` is now always present in the
Jinja2 context, unlike being missing sometimes because of the previous
design (not that it was ever present, because of the bug! sigh...)

The Jinja2 templates perform an `{% if arguments %}` check, letting
the template engine silently ignore the missing variable. The clause
was always falsy, meaning that the arguments section was not included
in the manpages for at least the last 6 years. With this fix, it will
be.

This patch also deduplicates calling `opt_doc_list` @ generate_man.

It was called late in the execution, more times than necessary. This
patch makes sure it happens once by putting it at the top of the scope.

It fixes rendering library and inventory in manpages.

The corresponding Jinja2 templates have blocks wrapped with
conditionals like `{% if inventory %}` and `{% if library %}` but said
variables were never injected into the context, nor were they even
deduced on the Python side of the generator. This means that the
conditional clauses were always falsy, never showing the portions of
the manpages.

The Python script has hints for how the `inventory` variable was to be
calculated, which is confirmed through the Git paleontology efforts.

The block of code that references to the `inventory` bit was
incorrectly checking a variable with a list of nested objects for the
presence of a string which was never going to work.

This patch fixes this check by verifying the CLI flag against the
correct variable containing a list of options and exposes it to the
Jinja2 templates.
It also exposes the `library` variable in a similar way.

The block displaying other binaries in Sphinx CLI docs has been
synchronized with the manpage template.
Previously, the current binary was displayed also. This patch gets rid
of the unwanted trailing comma there too.

Finally, the CLI executables list in the manpage template now reuses
the same variable as the RST template that doesn't need any
post-processing in Jinja2.
Before, it was already used in the RST template so this patch aligns
both templates to use the same logic as they got out-of-sync over time.

PR #80450..
(cherry picked from commit a84b3a4e72)

Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
1 year ago
Matt Clay 89ec76033c
[stable-2.15] Fix missing command descriptions in manpages/docs (#81366). (#81370)
(cherry picked from commit 32b388b4ca)
1 year ago
Matt Clay 559f0f9a4e
[stable-2.15] Fix command doc lookup in man page generation (#81365) (#81369)
(cherry picked from commit f9d674fcfd)
1 year ago
Matt Clay 1388880149
[stable-2.15] Exclude internal options from man pages and docs (#81360) (#81361)
(cherry picked from commit fead654671)
1 year ago
Matt Clay 63b6dd2454
[stable-2.15] ansible-test: cloudstack: bump test container version (#81319) (#81322)
(cherry picked from commit 99eeaf7da8)

Co-authored-by: René Moser <mail@renemoser.net>
1 year ago
Matt Clay af1fd68cc0
[stable-2.15] ansible-test - update module_utils/urls.py unit test to support cryptography >= 41.0.0 (#81296) (#81316)
(cherry picked from commit d20a0c02cc)

Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
1 year ago
Matt Clay 5421a1304c
[stable-2.15] Remove `docs` and `examples` directories (#81011) (#81232)
* Remove docs dir

* Updates to reflect docs removal

* Fix integration test

* Remove examples dir

* Updates to reflect examples removal

* Remove build_library and build-ansible.py

* Remove refs to build_library and build-ansible.py

* Remove obsolete template

* Remove obsolete template reference

* Remove the now obsolete rstcheck sanity test.
(cherry picked from commit 72e038e823)
1 year ago
Matt Clay 4684debab5
[stable-2.15] Add missing skip entries for selinux module_util (#81305) (#81307)
(cherry picked from commit 18cbfc688b)
1 year ago
Matt Clay 70dc6d6866
[stable-2.15] Convert non-docs *.rst files to *.md (#81217) (#81222)
* [stable-2.15] Convert non-docs *.rst files to *.md (#81217)

* Rename README.rst to README.md

* Change README format from reStructuredText to Markdown

* Fix whitespace in README.md

* Update setup.cfg to use README.md

* Replace changelog placeholder with README.md

* Update package-data sanity test
(cherry picked from commit 38e50c9f81)

Co-authored-by: Matt Clay <matt@mystile.com>

* Remove README.rst from MANIFEST.in
1 year ago
Matt Clay 04e4280437
[stable-2.15] ansible-test - Fix sanity traceback with `-e` opt (#81271) (#81272)
Also remove redundant warning about missing programs.

Includes integration tests to verify `-e` does not traceback.
(cherry picked from commit 3f7bf0bcd4)
1 year ago
Matt Clay add8a968e8
[stable-2.15] ansible-test - Pre-build PyYAML wheels (#81300) (#81306)
This works around Cython failures when attempting to install PyYAML >= 5.4 <= 6.0..
(cherry picked from commit e964078a83)
1 year ago
Matt Clay c779af621e
[stable-2.15] Disable cron integration test on Alpine (#81301) (#81302)
The tests are now failing due to the lack of `libfaketime` in the Alpine repos.
(cherry picked from commit 261a12b8a9)
1 year ago
Matt Clay bf38eb57a3
Update Ansible release version to v2.15.2.post0. (#81286) 1 year ago
Matt Clay 3c8a3fa0af
New release v2.15.2 (#81283) 1 year ago
Sviatoslav Sydorenko a9c656f8f3
Replace `reboot_command` integration test with unit tests (#78956) (#81266)
Co-authored-by: Matt Clay <matt@mystile.com>

(cherry picked from commit b6ebb9d41a)
1 year ago
Matt Clay 2b2510b653
[stable-2.15] Use *.md instead of *.rst for test READMEs (#81009) (#81229)
(cherry picked from commit 6ac0ea3567)
1 year ago
Matt Clay 3cf87a9702
[stable-2.15] Reorganize CI sanity test matrix (#81004) (#81225)
(cherry picked from commit ff359fa8e1)
1 year ago
Matt Davis 9c348b71ac
Update Ansible release version to v2.15.2rc1.post0. (#81209) 1 year ago
Matt Davis a87aefeda4
New release v2.15.2rc1 (#81204) 1 year ago
Martin Krizek 0cd0788eac
Properly disable modularity tests for dnf5 only (#81195) (#81196)
(cherry picked from commit eb19692f48)
1 year ago
Martin Krizek 7b97a0232a
Re-introduce RHEL 9 modularity testing in CI (#81160) (#81192)
(cherry picked from commit 7b2647f3b2)
1 year ago
Martin Krizek 83c9bd8d25
dnf5: utilize automatic gpg check via transaction.run() (#81144) (#81200)
https://github.com/rpm-software-management/dnf5/pull/607
(cherry picked from commit c3af71a2c8)
1 year ago
Martin Krizek 94a6f6e0de
Register handlers immediately if currently iterating handlers (#80898) (#81059)
This fixes the issue where handlers notifying other handlers are
not properly run because the notification is not registered unless
another flush_handlers occurs. Instead, if the current host state
is iterating handlers we immediately register the handler to be
run so the notification is not lost.

Fixes #80880

(cherry picked from commit 660f1726c8)

Co-authored-by: James Cammarata <jimi@sngx.net>
1 year ago
Matt Martz 130fdcd50e
[stable-2.15] Don't mutate templar.environment, only overlay on local myenv (#81005). (#81054)
(cherry picked from commit 73e04ef2d6)
1 year ago
Martin Krizek 7a61d9fb11
dnf5 - enable env groups testing in CI (#81032) (#81056)
Implemented in https://github.com/rpm-software-management/dnf5/pull/585

(cherry picked from commit f13e35cbf9)
1 year ago
Felix Fontein 9f2b37ad39
Make sure that values that should be strings are actually strings. (#81029) (#81057)
(cherry picked from commit 440b5fd040)
1 year ago
Matt Martz 2c5856d7bc
[stable-2.15] Resolve issues on python pre-3.10.6 with collection dirs longer than 100 characters (#81061) (#81072)
(cherry picked from commit 56b67cc)
1 year ago
Matt Clay 2f7465969e
ansible-test - Add Fedora 38 remote (#81157)
Also record a known issue for Fedora 37 remotes.
1 year ago
Martin Krizek e5d4cb89f8
dnf5: enable now implemented cacheonly functionality (#81141) (#81145)
Note that this also fixes a traceback caused by backwards incompatible
change in dnf5 where cacheonly was changed from bool to string:
https://github.com/rpm-software-management/dnf5/pull/665/files#diff-ab65249ff7fccadfb2864b6826f6559f7f16fad43fd3bf2da0b4fe8db790d59aR179

(cherry picked from commit 0cc50e0673)
1 year ago
Sandra McCann 0766ad33eb
Core backportapalooza 06 22 (#81111)
* Fix typo in comment filter option (#80672)

(cherry picked from commit 40fd86c618)

* Documentation tweaks for apt repo key management. Fixes #78063 (#80872)

(cherry picked from commit 0775e991d5)

* Update split.yml (#80915)

typo in description

(cherry picked from commit 6011b7c4c1)

* Correct syntax error in the example (#80976)

* Update success.yml
* Update reachable.yml
* Update unreachable.yml

(cherry picked from commit d210260afc)

* Update manager.py (#80926)

(cherry picked from commit e91bf2248f)

* Added link to argument_spec (#80967)

(cherry picked from commit 9e14a85fe3)

* modules/find: param contains: Describe matching behavior (#80744)

(cherry picked from commit a473bb798d)

* Update example in apt_key module (#81017)

* Verify checksum of downloaded key

Fixes: #79892

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit ce55e0faf5)

* Fix typo in to_yaml filter examples (#81094)

(cherry picked from commit 1f9836fe9a)

---------

Co-authored-by: Chris van Meer <chris@van-meer.net>
Co-authored-by: Matt Martz <matt@sivel.net>
Co-authored-by: F-Baker <35278989+F-Baker@users.noreply.github.com>
Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
Co-authored-by: David-Ademola <131247654+David-Ademola@users.noreply.github.com>
Co-authored-by: tachyontec <92679798+tachyontec@users.noreply.github.com>
Co-authored-by: Felix Stupp <me+github/security-7XJy2od8@banananet.work>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Giovanni Toraldo <me@gionn.net>
1 year ago
Matt Clay 30f3fc2335
[stable-2.15] ansible-test - Avoid using atexit module (#81096) (#81097)
(cherry picked from commit c3926268e2)
1 year ago
Matt Martz e860820982
Update Ansible release version to v2.15.1.post0. (#81091) 1 year ago
Matt Martz 3d9a1cfdc6
New release v2.15.1 (#81088) 1 year ago
Matt Davis d4c10eea8e
[stable-2.15] define code owners to support branch-protection rules on docs (#81041) (#81043)
* during interim docs/ (and related dirs) split to separate repo, prevent merges that might require a rebase of the target repo
(cherry picked from commit 9117762358)
1 year ago
Matt Martz d3e26c5fb4
Update Ansible release version to v2.15.1rc1.post0. (#81039) 1 year ago
Matt Martz de8eb87110
New release v2.15.1rc1 (#81036) 1 year ago
Sviatoslav Sydorenko 37473cd99b
Bump azure-pipelines-test-container to v4.0.1 @ CI (#80937)
This patch updates the test container used in CI to the new v4 that
defaults to using Python 3.10 and is based on Ubuntu 22.04 Jammy[[1]].

[1]: https://github.com/ansible/azure-pipelines-test-container/pull/17
1 year ago
Matt Clay 25880be91b
[stable-2.15] Remove hacking dir dependency from build backend (#81025)
* Copy man generation files into build backend

* Use copied files in build backend
2 years ago
Matt Clay 85065d6b7d
[stable-2.15] Remove docs dir dependency from man page build (#81003). (#81022)
(cherry picked from commit b3f1290bcd)
2 years ago
Matt Martz 4536ef6303
[stable-2.15] Fix TypeError when installing subdir collections. Fixes #80943 (#80949) (#80950)
(cherry picked from commit 0982d5f)
2 years ago
Abhijeet Kasurde 6bddb3d3c1
[bp/2.15] deb822_repository: use http-agent with open_url (#80894)
* Use http-agent in open_url API while getting
  cloudflare content

Fixes: #80809

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2 years ago