6 Commits (3d614bfe84d7274b0042685625b5c5b5c27f50f1)

Author	SHA1	Message	Date
Matt Davis	206b6ebe0d	fix PS type conversion failure when using "all" profiles (#34383) ... * obscure type promotion issue in some versions of Powershell causes [int]::MaxValue to be promoted to [int64] when doing a COM property get or set. Since the "All" profiles value of 0x7FFFFFFF is [int]::MaxValue, it would trigger "Specified cast is not valid" when modifying a rule that's already set to All Profiles or trying to be. * Fixed catch-all error handler to include exception detail * Added test converage for this case	7 years ago
Matt Martz	4fe08441be	Deprecate tests used as filters (#32361) ... * Warn on tests used as filters * Update docs, add aliases for tests that fit more gramatically with test syntax * Fix rst formatting * Add successful filter, alias of success * Remove renamed_deprecation, it was overkill * Make directory alias for is_dir * Update tests to use proper jinja test syntax * Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax * Add conversion script, porting guide updates, and changelog updates * Update newly added uses of tests as filters * No underscore variable * Convert recent tests as filter changes to win_stat * Fix some changes related to rebasing a few integration tests * Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name * Add test for tests_as_filters_warning * Update tests as filters in newly added/modified tests * Address recent changes to several integration tests * Address recent changes in cs_vpc	7 years ago
Artem Zinenko	2b63ae61f2	minor updates + tests to win_firewall_rule as per jborean93 review (#29148) ... * Added warning for 'force' option * Changed 'profiles' type to list * Changed 'interfacetypes' type to list * Added deprecation warning and fixed doc * updated force parameter	7 years ago
Artem Zinenko	06fadefbdc	[18807] win_firewall_rule module uses HNetCfg.FwPolicy2 COM Object (#27381) ... * #18807 win_firewall_rule uses HNetCfg.FwPolicy2 COM object * Added missing tests * Added support for InterfaceTypes property * Added support for EdgeTraversalOptions property * Added SecureFlags property * Port ranges are not possible in W2K8 * Added windows version checks * Fixed doc: removed 'force' option and all notes * Fixed copirights and docs	7 years ago
Dag Wieers	d958440bcb	win_firewall_rule: Implement idempotency, check-mode and diff support (#23162) ... * win_firewall_rule: Small idempotency fix This PR includes the following changes: - an idempotency fix when `profile: any` - better difference output to debug idempotency issues - documentation fixes (remove `required: false`) - Parameter handling fixes - RDP example that matches default RDP rule - Renamed parameter 'enable' to 'enabled' (kept alias) - Renamed parameter 'profile' to 'profiles' (kept alias) * Rewrite module completely The logic is still intact, but various changes with a single goal: - Make the module idempotent - Implement check-mode - Implement diff-mode - Adapted integration tests This fixes #18807 and #23455. * Change casing to lowercase * Improve the logic wrt. diff	8 years ago
Artem Zinenko	f4b34a4c3b	win_firewall_rule doesn't fail when profile is "any" or remoteip is IPv4 and the task runs more than once. (#22555) ... * Fixed #22554 * Wrote tests for win_firewall_rule module * Fixed #22786 * Fixed review comments * Fixed #22799 * Added test when RemoteIP containt a netmask * Revert comment	8 years ago