Commit Graph

550 Commits (3a1ffa12f1e283b2166d92f5c7c06b09e821ac4e)

Author SHA1 Message Date
Brian Coca a268e5a119 Merge pull request #2647 from bertvv/issue_2498
Also show stdout when validation fails. This fixes #2498
9 years ago
Brian Coca c86a0ef84a fixed exit json 9 years ago
Matt Martz 07f29ecd7f Fix synchronize docs to indicate the correct default for use_ssh_args 9 years ago
Toshio Kuratomi 80543ee6f8 Merge pull request #3197 from dagwieers/unarchive-download-error-fix
unarchive: Ensure that download failure is properly raised before read fails
9 years ago
Brian Coca 94e66cb108 fixes to assemble
now uses atomic move to avoid data corruption
correclty cleans up temp files in every case
returns backup_file info if needed
validate validate before temp file gets created
backup AFTER validate
9 years ago
Dag Wieers 7cd47eb73a Ensure that a download failure is properly raised before the read fails
Without this change, a download failure may bail out with the message:

    "Failure downloading http://foo/bar, 'NoneType' object has no attribute 'read'"

whereas with this fix, you'd get a proper error like:

    "Failure downloading http://foo/bar, Request failed: <urlopen error [Errno 113] No route to host>"

or one of the many other possible download errors that can occur.
9 years ago
Toshio Kuratomi 2920658776 Change one param to be of type path 9 years ago
Toshio Kuratomi 832e81e691 Set some module parameters to type=path 9 years ago
Toshio Kuratomi a7cfa1c8cd Correct dest_port to be of type int 9 years ago
Toshio Kuratomi cfbe65f8c8 Set name to type path so that tilde and env vars are expanded 9 years ago
Brian Coca c50ca43d8d fixed typo, now correctly check isdir
fixes #3089
9 years ago
Brian Coca ab4c542b33 added missing checksum alias 9 years ago
Brian Coca cefdb9a494 Merge pull request #2896 from towolf/add_diff_to_lineinfile
Add diff to lineinfile.py for both file contents and file attributes
9 years ago
Brian Coca 81b827f869 fixed option name mismatch, added aliases
also removed empty aliases
9 years ago
Brian Coca 8c2ef29a7a added follow to specific modules that support it
was removed from common file docs
9 years ago
Jose Moreira cb712f2ba8 Fixed module doc typos 9 years ago
Brian Coca 191bf977f7 Merge pull request #3042 from lgp171188/patch-1
Fix typo in the copy module error message
9 years ago
Brian Coca 238c26c7e2 recursive copy is not available(yet) on remote_src 9 years ago
Guruprasad ea6c2573e3 Fix typo in the copy module error message
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
9 years ago
Brian Coca b89f4c7cab cleaner error on recursive remote copy
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
9 years ago
Brian Coca 6a42e54e57 removed 'overquoting' of example
fixes #3029
9 years ago
Toshio Kuratomi 93d02189f6 Remove duplicate documentation fields 9 years ago
Tobias Wolf 99ba594f0a Add diff for both file contents and file attributes to lineinfile
Using the difflist feature added in ansible/ansible@c337293 we can add
two diffs to the `diff` dict returned as JSON: A `before` and `after` pair of
changed file contents and the diff of the file attributes.

n.b.: the difflist handling from the above commit is logically broken.
PR will follow.

Example output:

    TASK [change line and mode] ************************************************************
    changed: [localhost]
    --- before: /tmp/sshd_config (content)
    +++ after: /tmp/sshd_config (content)
    @@ -65,21 +65,21 @@
     X11DisplayOffset 10
     PrintMotd no
     PrintLastLog yes
     TCPKeepAlive yes
     #UseLogin no

     #MaxStartups 10:30:60
     #Banner /etc/issue.net

     # Allow client to pass locale environment variables
    -AcceptEnv LANG LC_*
    +AcceptEnv        LANG LC_* GF_ENV_*

     Subsystem sftp /usr/lib/openssh/sftp-server

     # Set this to 'yes' to enable PAM authentication, account processing,
     # and session processing. If this is enabled, PAM authentication will
     # be allowed through the ChallengeResponseAuthentication and
     # PasswordAuthentication.  Depending on your PAM configuration,
     # PAM authentication via ChallengeResponseAuthentication may bypass
     # the setting of "PermitRootLogin without-password".
     # If you just want the PAM account and session checks to run without

    --- before: /tmp/sshd_config (file attributes)
    +++ after: /tmp/sshd_config (file attributes)
    @@ -1,3 +1,3 @@
     {
    -    "mode": "0700"
    +    "mode": "0644"
     }
9 years ago
Toshio Kuratomi c8d5fdaf27 Merge pull request #2891 from ansible/synchronize-better-error-missing-rsync
Better error message when rsync nad ssh aren't present where synchronize is run
9 years ago
Toshio Kuratomi cb1fefdf92 Better error message when rsync nad ssh aren't present where synchronize is run
Fixes https://github.com/ansible/ansible/issues/9305
9 years ago
Brian Coca 3239691e9e Merge pull request #2870 from towolf/add_diff_to_synchronize
Add custom diff field to synchronize module
9 years ago
Tobias Wolf cd3b9366fe Add custom or 'prepared' diff field to synchronize module
This PR depends on pull requeest ansible/ansible#14105

rsync has a custom diff output that cannot easily be expressed as
`/usr/bin/diff before after`
9 years ago
Toshio Kuratomi d9e29752c1 Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from 9 years ago
Matt Martz 76925ef613 Merge pull request #2858 from sivel/issue/14064
Add note about precautions of using become with fetch
9 years ago
Matt Martz 3f232beb0a Add note about precautions of using become with fetch. Addresses https://github.com/ansible/ansible/issues/14064 9 years ago
Toshio Kuratomi 0b7469fa90 Fix documentation build 9 years ago
Toshio Kuratomi 76a478a226 Document that synchronize in 2.0.0.x has broken sudo behaviour.
Part of the changes for #13825
9 years ago
Toshio Kuratomi 78b4eac6fc Merge pull request #2722 from mscherer/fix_2630
Fix 2630
9 years ago
Brian Coca 48bd80c9cb adds diff info for file info 9 years ago
Michael Scherer 948900f7fb Fix doc inconsistency (#2630) 9 years ago
Brian Coca f500a2ec53 added mime option to stat module
it uses file magic to now return mime_type and charset of a file as
per output of `file -i /path`
9 years ago
Adam Fields 27f561dca2 added a reference to the template module for clarity 9 years ago
quoing 877daf970d Fix: Default ACL parameters are not correctly handled 9 years ago
Brian Coca db66144386 simplified lowercasing 9 years ago
quoing c93de2f930 Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 9 years ago
Bert Van Vreckem 9556bcb9c2 Also show stdout when validation fails. This fixes #2498 9 years ago
Brian Coca 8a2459c643 Merge pull request #2590 from noseka1/devel
Fix ini_file module, avoid bracklets in key break idempotence
9 years ago
Ales Nosek 9c74272c9b Fix #2475 ini_file module: bracklets in key break idempotence
Escape the regex special characters in the option name.
9 years ago
krdlab 61a3625ed0 Fix 'stat' module document 9 years ago
Dylan Martin bfa7cdb5c4 improved error message when no handler found 9 years ago
Brian Coca c6fdd3809f fixed typo EEXISTS is actually EEXIST
fixes #2585
9 years ago
Brian Coca 9030ae996c Merge pull request #2569 from gerph/gerph-fix-docs-file
Update documentation for 'file' module to include 'diff_peek'.
9 years ago
Charles Ferguson 176b4103b6 Add documentation to 'file' AnsibleModule definition for internals.
The parameters 'diff_peek' and 'validate' are not expected to be used
by users. They are internal. To make it clear, this change adds the
comments 'Internal use only' to each of those definitions to make
it clear that they are actually used, just not by end-users.
9 years ago
Charles Ferguson 9325c0ae5f Update documentation for 'file' module to include 'diff_peek'.
The 'diff_peek' option isn't documented at all, and provides a
rudimentary check that the content isn't binary. Documentation is
added to explain the option.

The 'validate' option has a declaration, but isn't implemented.
Therefore it may as well be removed from the module.
9 years ago
Charles Paul 1bc0b6ee6a create non-existent ini file
fixing fail_json

more verbose fail msg
9 years ago