2 Commits (39d1794ed9d575d74092cf7a36641647a73daf69)

Author	SHA1	Message	Date
Kevin Subileau	09979e899f	win_nssm: refactor to fix issues, support check mode and add more features (#45693) ... * win_nssm: rename cmdlets to use approved verbs, rename service name parameters * win_nssm: improve code style and cmdlets ordering * win_nssm: always escape all command line parameters with Argv-ToString fix error when the service name contains quotes * win_nssm: use Fail-Json instead of exceptions and remove global try/catch * win_nssm: small refactoring, inline some functions * win_nssm: refactoring - add a generic cmdlet to idempotently set any nssm service parameter * win_nssm: refactoring - inline some functions To make the code more malleable for future changes * win_nssm: change application, stdout_file and stderr_file options type to path * win_nssm: deprecates app_parameters, rename app_parameters_free_form to arguments, and add support for list of parameters * win_nssm: add support of check mode * win_nssm: add working_directory option * win_nssm: add display_name and description options * win_nssm: minor changes * win_nssm: remove some sanity exclusions * win_nssm: avoid using aliases and minor style fixes * win_nssm: doc and ui improvements * win_nssm: remove sanity exclusions * win_nssm: minor revision * win_nssm: deprecates dependencies, start_mode, user and password parameters and some choices of state in favor of win_service * win_nssm: fix style * win_nssm: add executable option to specify the location of the NSSM utility * win_nssm: add missing parameter types * win_nssm: add diff mode support * win_nssm: avoid displaying depreciation warning if default value is assigned * win_nssm: fix variable scope * win_nssm: use the explicit -LiteralPath parameter name instead of -Path * win_nssm: fix documentation * win_nssm: add porting guide entries * win_nssm: add changelog fragment	6 years ago
Kevin Subileau	ac9d506a61	win_nssm: tests and several bug fixes (#44755) ... * win_nssm: add failing tests for issue #44079 * win_nssm: use Run-Command instead of Invoke-Expression to prevent interpretation issue Fix #44079 * win_nssm: add more failing tests These tests highlight several issues with this module: * Service not started when state=started * Errors with app_parameters (see #25265) * Exception when passing several dependencies separated by comma as specified in doc * win_nssm: fix service not started when state=started Nssm status returns a multiline output that doesn't match any of the strict patterns in the switch statement. * win_nssm: fix incorrect separator in doc for service dependencies The dependencies parameter works with space as separator, but not with comma as shown in the documentation * win_nssm: fix error with app_parameters parameter Fix #25265 * win_nssm: add idempotence tests * win_nssm: fix several idempotence issues and misbehaviors Add missing space between arguments when app_parameters contains several keys. Use Argv-ToString and Escape-Argument to improve arguments handling (parameters with quotes, backslashes or spaces). * win_nssm: test parameters with spaces, quotes or backslashes * win_nssm: restore comma as separator for service dependencies Revert commit ddd4b4b * win_nssm: restore support of string as dict form for app_parameters and remove support of literal YAML dict * win_nssm: wrong variable in tests	6 years ago