Commit Graph

844 Commits (3979faf3e51027fc2aeaabf517427afc0f39e987)

Author SHA1 Message Date
davidobrien1 b33320d3f1 Restore filter on Windows and version reference for Windows facts. 9 years ago
David O'Brien e4c2cb96ea Add documentation to setup.py and remove use of $params.fact_path in setup.ps1 9 years ago
Ton Kersten d43d2bc219 Fix facter path
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
9 years ago
Matt Martz c7845456a6 Various simple linting type cleanups on modules 9 years ago
jjshoe c18afbc1ab List which version it was added
fixes https://github.com/ansible/ansible-modules-core/issues/2605
9 years ago
Brian Coca 3d4b5d165c avoid chmod in check mode 9 years ago
Brian Coca 4e49df7b88 revamped checkmode support in user module
- defaulted to commands not executing in checkmode
- added force run for info gathering (for setting changed)
- added debug for what would have been run in check mode
- added check mode for spots that made changes using system calls instead of command
- removed now redundant checkmode checks

better failure now, if i missed anything, it will misreport changed value
instead of old default of actually making the change in checkmode
9 years ago
James Cammarata b175b11a63 Merge pull request #2954 from mattclay/user-check-mode-aix
Make modify_user_usermod honor check mode on AIX.
9 years ago
Matt Clay 151f981ce5 Make modify_user honor check mode on OS X. 9 years ago
Matt Clay 2645113eda Make modify_user_usermod honor check mode on AIX. 9 years ago
Luca Berruti d820be81e5 Typo. 9 years ago
Matt Clay 8bb538aeb1 Make modify_user honor check mode on FreeBSD. 9 years ago
Toshio Kuratomi 93d02189f6 Remove duplicate documentation fields 9 years ago
Toshio Kuratomi 09e2457eb0 Fix documentation build in hostname 9 years ago
Brian Coca 1ab46f1e79 Merge pull request #2795 from hnakamur/add_warning_to_hostname_doc
Doc: Add NOTE about hostname modules does not modify /etc/hosts
9 years ago
Brian Coca 493f06435c Merge pull request #2768 from quinot/topic/abs_cron_file
Allow cron_file to be an absolute path
9 years ago
Luca Berruti 933a44ba78 cron module: add enviroment variables management 9 years ago
Brian Coca 7a0b488244 reverse order of cron commands
does not affect linux but fixes issue with busybox caring about order
fixes #2807
9 years ago
Jeroen Seegers 1a362cdff0 Update cron.py
Minor update to documentation for the cron module to reflect the required "name" parameter when the value of "state" is "absent".
9 years ago
Hiroaki Nakamura 9f2bd22a3d Doc: Add NOTE about hostname modules does not modify /etc/hosts 9 years ago
Thomas Quinot 0b38e4b407 Allow cron_file to be an absolute path
Support specifying an absolute path (typically /etc/crontab) rather than
a path relative to /etc/cron.d, to allow modifying the main system crontab.
Particularly useful for target systems that have /etc/crontab but no
/etc/cron.d.
9 years ago
Brian Coca 827b9596da service goes back to failing when absent
if no tools and no init script, this should always fail
9 years ago
Brian Coca f3ed819241 added missing version_added 9 years ago
Brian Coca 76b926a9e8 Merge pull request #1941 from badpass/devel
Add support for selinux user when adding a new user
9 years ago
Michael Scherer 8ccfdb874e Remove a unneeded use of use_unsafe_shell
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
9 years ago
nitzmahone f2b72e62c0 fixed disappearing groups on OSX user module
Ensure that we don't try to modify the groups collection if groups are not specified
9 years ago
Dominique Barton 6128845b69 bugfix for issue #2537 9 years ago
Sina Sadeghi ae582adce6 Update hostname.py
Added support for FreeBSD. (http://www.freebsd.org)
9 years ago
Brian Coca 660b47f62d minor doc fixes and reformating
updated validate_certs feature to be 2.1
9 years ago
Brian Coca aad6e044e6 Merge pull request #2519 from vmindru/validate_key_auth_module
add  validate_certs  option #2518
9 years ago
Veaceslav (Slava) Mindru 19abe233fe Squashed commit of the following:
commit 406214fad214359fcf13fe8c7cd3f8f8faac5386
commit 85d1c9b0a41dd075eb2683b1a7de595ca3119614
commit 4aa5049b5ae25dee71a248238201611a466a13c4
commit 65a96974c80aea1fef88d78e218ecb665d8113e1
commit 22ea5863d1dfd628735b46cc7de51c0fd33251de

Refactoring
9 years ago
Martin André 129bac3649 Fix typo in ping module short description 9 years ago
Jordi De Groof 6584b59d91 Update facts when hostname is changed
ansible_hostname contains the unqualified hostname
9 years ago
Greg DeKoenigsberg a76184ad1f @bradobro stepping down as maintainer 9 years ago
Brian Coca 4072bc1da0 rearranged systemd check, removed redundant systemctl check
fixed unused cmd and state var assignements
9 years ago
Brian Coca dae3718e79 Merge pull request #2341 from reactormonk/devel
simpler way to check if systemd is the init system
9 years ago
Simon Hafner 6233e72001 added earlier paths to systemd
2b583ce657
b925e72633
9 years ago
chriskarel 32a21a9b61 Update hostname.py
Added support for Oracle Linux.  (http://www.oracle.com/linux)
9 years ago
Simon Hafner e65c0f896a simpler way to check if systemd is the init system
According to
http://www.freedesktop.org/software/systemd/man/sd_booted.html
check if the directory /run/systemd/system/ exists.
9 years ago
Brian Coca 83b5220068 clarified ping module purpose 9 years ago
Toshio Kuratomi dc51e1ae41 Mark a few parameters as no_log 9 years ago
Brian Coca ccbcff8c8e better handling of checkmode for solaris
fixes #2296
9 years ago
Brian Coca 0307e3e649 Merge pull request #2209 from gekmihesg/devel
Support sysctl on OpenBSD
9 years ago
Achilleas Pipinellis 1499288c64 Add missing documentation: cron_file requires user to be set 9 years ago
gekmihesg cdf0c8a560 Support sysctl on OpenBSD
Fixes #1233
9 years ago
Simon Li d616fd12da Fix incorrect variable in group.py: user -> group 9 years ago
Brian Coca a15aa09251 removed typo 9 years ago
Brian Coca f6bbd2ac5b removed syslog in favor of common module logging functions 9 years ago
Brian Coca 3e42527fde revert must_exist 9 years ago
Mike Boone 539c996ede Updated link to the FAQ. 9 years ago
Brian Coca 81a7243bbb changed chmod to 2.4 compat 9 years ago
Brian Coca 813053c51c Merge pull request #986 from ssssam/cron-permissions-fix
Fix permissions issue with 'cron' module
9 years ago
tobbe 75fed6e6d8 Merge remote-tracking branch 'upstream/devel' into devel 9 years ago
tobbe 30576ad0c7 add text to the description, more user friendly 9 years ago
Brian Coca e278f285aa partially reverted previous change to deal with systemctl show status not returning errors on missing service
Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states.
fixes #12216
9 years ago
Brian Coca bbcfb1092a check systemctl status before show as show will not return antyhing other than rc=0 even when it fails. 9 years ago
Marius Gedminas 5595a9f81d authorized_key: fix example in documentation
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
9 years ago
Tim Rupp 48f522455d Add hostname support for Kali linux 2.0
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
9 years ago
Benno Joy 8bf800d5c5 Merge pull request #1973 from mgedmin/user-no-ssh-keygen-in-check-mode
user: don't generate SSH keys in check mode
9 years ago
Marius Gedminas 4ae4331a6b user: don't generate SSH keys in check mode
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
9 years ago
Simon Li 428550e179 Don't fail in check_mode if user exists
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
9 years ago
tobbe 8fa1e9515b Add suport for selinux user when adding a new user on selinux enabled
systems
9 years ago
Александр Костырев 31ec203583 Fix documentation of authorized_key.py
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
9 years ago
Brian Coca 5d7cb981d3 made continue into a pass (there was no loop) 9 years ago
Brian Coca 6d7428527d minor doc fixes 9 years ago
Brian Coca 2fd171a5e1 Merge pull request #878 from EvanK/system-cron--disabled
cron module: Add disabled option for commented jobs
9 years ago
Brian Coca cd0a1947c2 Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines
Service module incorrectly handles lines not ending in a newline
9 years ago
Brian Coca 7a2687178e avoid shlex exceptions in rc parsing (happens with multiline entries)
fixes #1898
9 years ago
Brian Coca 0c403781a7 Merge pull request #1905 from evverx/fix-legacy-services-enabled
Fix service.enabled on: Debian 8, Ubuntu 15.04
9 years ago
Evgeny Vereshchagin 55e8863cb4 Fix service.enable on: Debian 8, Ubuntu 15.04
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
9 years ago
Brian Coca 072c4f38ea Merge pull request #62 from 0x46616c6b/user-add-skeleton-support
Add support for skeleton directory (useradd -k) in user module
9 years ago
Austin Hyde 5c25057868 Always end rc.conf entries with a new line 9 years ago
Brian Coca 0e9fccd098 changed verbose override variable 9 years ago
James Cammarata bc60c893f5 Prefer non-zero rc's over text analyis in service status checks
Fixes ansible/ansible#10441
9 years ago
saito-hideki e91ad2ab6c Add Solaris support in hostname module
feature_pull_request: #1804
9 years ago
saito-hideki b991a2708b Add Solaris support in hostname module 9 years ago
Brian Coca a2b713edad Merge pull request #1790 from renard/allow-star-password-on-openbsd-2015-07-24
[user] Allow '*' as empty password.
9 years ago
KIKUCHI Koichiro a3b9fb58bf Fix service enabled check failure on FreeBSD 9 years ago
Sébastien Gross 349195e689 [user] Allow '*' as empty password.
If `password` is defined as `*` `useradd` or `usermod` returns an error:

    msg: usermod: Invalid password: `*'

This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
9 years ago
fti7 6a872469fc mount: Support for Check-Mode 9 years ago
Brian Coca 718fd1f891 prevent usless assignment of home 9 years ago
Brian Coca 045b8e8cff Merge pull request #1733 from tersmitten/the-tilde-expansion-doesnt-work-with-userhome
The tilde expansion doesn't work with user.home
9 years ago
bambou e04f75d872 Check if the gid is set 9 years ago
Mischa ter Smitten 0ca732baaf The tilde expansion doesn't work with user.home 9 years ago
Brian Coca 8546744418 Merge pull request #1286 from 0tmc/freebsd_mount_fix
Use of proper fstab file on FreeBSD
9 years ago
Sean Chittenden c57d70ad20 Fix group mod and group add for FreeBSD 9 years ago
Brian Coca 03d4805074 Merge pull request #1279 from no2a/devel
Not use "is" to compare strings
9 years ago
Brian Coca 328b6b5a39 Merge pull request #1454 from grossws/patch-issue-530
Escape spaces, backslashes and ampersands in fstab
9 years ago
Brian Coca 2b209f8065 Merge pull request #1642 from sivel/core-fixups
Core module fix-ups
9 years ago
Toshio Kuratomi 1dc5074602 Merge pull request #1651 from verm666/issue-1515
fix authorized_keys in check_mode
9 years ago
Matt Martz b6b576abf6 Replaced tabbed indentation with spaces for group module 9 years ago
verm666 b00b3f2b3c fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
9 years ago
Brian Coca d59de3af63 Merge pull request #578 from sysadmin75/mount_dir_spaces
allows spaces in names for mount module
9 years ago
Evan Kaufman 1187399ffa Add disabled option to cron module 9 years ago
Brian Coca 6f6d7f5c18 updated docs to clarify use of exclusive 9 years ago
Brian Coca fed5ff04a6 Merge pull request #742 from aseigneurin/fix-remove-cron_file
Name parameter should not be marked as mandatory
9 years ago
Hagai Kariti 9d833d1d4c Hostname module should update ansible_hostname 9 years ago
Konstantin Gribov dadc1faebd Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
9 years ago
Greg DeKoenigsberg 2a5f0bde87 Proper author info for all remaining modules 9 years ago
Brian Coca 9acc7c402f Revert "added innitial daemon-reloaded support to service module"
This reverts commit 438d87d269.
9 years ago