Commit Graph

7089 Commits (378bde8729a6cf28666db3b6bb3665939e77489f)
 

Author SHA1 Message Date
Brian Coca b8c19e6531 Merge pull request #1039 from indrajitr/homebrew-update
homebrew: Improve 'argument_spec' handling
9 years ago
Brian Coca 30e7f4a934 Merge pull request #1066 from jhawkesworth/documentation_win_environment_limitations
Document win_environment limitations
9 years ago
Luis Rodriguez 6e80ed57d2 Fix bug #1067 9 years ago
= 576b5e2fc3 Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 9 years ago
Brian Coca 6336838354 Merge pull request #1059 from sivel/sys-exit-removal
sys.exit removal from various modules
9 years ago
Dreamcat4 ece9c2b43a fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
9 years ago
James Cammarata 0ff1776a84 Updating version for 2.0.0-0.3.beta1 release 9 years ago
Matt Martz 32bdecef9a Merge pull request #1060 from sivel/open-iscsi-examples
Fix open_iscsi EXAMPLES section
9 years ago
Dreamcat4 dcaa794949 fix: update documentation with new module name "win_firewall_rule" 9 years ago
Dreamcat4 469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
9 years ago
Dreamcat4 6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
9 years ago
Dreamcat4 2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
9 years ago
Matt Martz 9d015665b8 Fix open_iscsi EXAMPLES section 9 years ago
Matt Martz e68d9315c1 sys.exit removal for system/capabilities.py 9 years ago
Matt Martz eac4493421 sys.exit removal for notification/mail.py 9 years ago
Matt Martz abf7ee579e sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 9 years ago
Matt Martz 55dab7cd1b sys.exit removal for cloud/misc/ovirt.py 9 years ago
Matt Martz b82ebdde19 sys.exit removal for cloud/xenserver_facts.py 9 years ago
Matt Martz d89ca8cc01 Merge pull request #1058 from sivel/xenserver-imports
Switch from old style replacer code to new style for ansible.module_utils.basic
9 years ago
Matt Martz 1b0f9d5fd9 Merge pull request #1057 from sivel/fix-vmware-interpreter
Fix interpreter line in a few vmware modules
9 years ago
Matt Martz 6732181a39 Switch from old style replacer code to new style for ansible.module_utils.basic 9 years ago
Matt Martz 1a76f4cc22 Fix interpreter line in a few vmware modules 9 years ago
Brian Coca 432ca0fa99 Merge pull request #1056 from rickmendes/add-gpl-to-winpass
added missing license

Thanks!
9 years ago
Rick Mendes 2cc18b8780 added missing license 9 years ago
Charles Paul f4be5c6382 allow floating point input for size vale 9 years ago
Brian Coca ebbd7748b1 doc formatting fixes 9 years ago
Toshio Kuratomi da426da308 Change documented requirement from dnf to python-dnf as dnf could be taken to mean the command line tool.
Fixes #1032
9 years ago
Indrajit Raychaudhuri 02c17c023a homebrew: Also add 'formula' as alias for 'name' and reformat 9 years ago
Indrajit Raychaudhuri 791967485b homebrew: Improve 'argument_spec' handling
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
9 years ago
Brian Coca 02b68be09d Merge pull request #854 from nitzmahone/win_updates_rewrite
win_updates rewrite for 2.0
9 years ago
Brian Coca 9f5420e459 Merge pull request #1047 from bcoca/use_common_logging
switched to use module loggigng
9 years ago
Brian Coca 5eff47c6f1 changed use_sudo to system_lib (kept alias) and expanded description to explain how it works 9 years ago
Brian Coca e768a98bf3 Merge pull request #1017 from milad-soufastai/devel
Adding the --sudo flag for CPANM use since the sudo: yes on the task …
9 years ago
Brian Coca baf32cedd1 Merge pull request #1049 from trondhindenes/#984
win_package bugfix
9 years ago
Trond Hindenes 7c48fe617d added module author 9 years ago
Matt Martz 70883852ed Merge pull request #1048 from sivel/znode-py26
znode requires a minimum of python2.6
9 years ago
Trond Hindenes 161b3cf1e1 fixes #984 9 years ago
Matt Martz e6b6bac820 znode requires a minimum of python2.6 9 years ago
Matt Martz 5b8c2237a7 Merge pull request #1045 from mjschultz/sns-baby-json
sns: remove BabyJSON
9 years ago
Brian Coca 3564c48f3c switched to use module loggigng 9 years ago
Toshio Kuratomi 962afeed54 Make the znode module a valid ansible module 9 years ago
Toshio Kuratomi 255666a09d Fix doc build 9 years ago
Michael J. Schultz c61d430191 sns: remove BabyJSON 9 years ago
Greg DeKoenigsberg b69362647a Merge pull request #1011 from resmo/feature/args_specs
cloudstack: implement common argument spec handling
9 years ago
Greg DeKoenigsberg beb362dd11 Merge pull request #633 from loia/feature/aws_sqs
Add new Amazon SQS module
9 years ago
Greg DeKoenigsberg a4c2928712 Merge pull request #783 from wimnat/feature/ec2_vpc_subnet_facts
New module - ec2_vpc_subnet_facts
9 years ago
Greg DeKoenigsberg 8221a651d8 Merge pull request #1009 from ToBeReplaced/dnf-exit-json
Fix fail_json call in _mark_package_install
9 years ago
Greg DeKoenigsberg 750754f0d9 Merge pull request #976 from kovacsbalu/fix-push_type
Use push_type and send link with push_link.
9 years ago
Greg DeKoenigsberg 9447bf9c6f Merge pull request #1008 from privateip/vca_vapp
cleaned up vca_vapp module to focus on managing vapps
9 years ago
Greg DeKoenigsberg 2e588d8fc5 Merge pull request #1014 from resmo/for_ansible
cloudstack: fix redundant security_group return
9 years ago