Commit Graph

59 Commits (377e94f77fc31ef97df85a8cf4b303ec970c307e)

Author SHA1 Message Date
Bryan Larsen 69ff43d253 digital_ocean: don't run update_attr if wait=no
Sometimes when using digital_ocean with wait=no I get the error "No ip is found".  But with wait=no I wouldn't expect there to be any IP, that gets allocated later.   However, looking at the code, it turns out that with even with wait=no it waits up to 10 seconds for an IP to be allocated.  We could wait longer, but with wait=no that seems like the wrong choice; it's easy enough to grab an IP later with a wait=yes command.

To make this change I removed the call to update_attr in @classmethod add.  An add is always followed by an ensure_powered_on which will do the update_attr if wait=yes.   It would be possible to instead do a call to update_attr with no retries and ignore the errors but I figured it would be better to be consistently not return an IP than to sometimes return it and sometimes not.   Inconsistent behaviour makes debugging deployment scripts very difficult.
11 years ago
Benjamin Schwarze 7cc00f9a03 fix wrong argument_spec in digital_ocean module
as 'required' and 'default' are mutually exclusive removed 'required' in preference of 'default'
11 years ago
Michael DeHaan 0ed5d18d60 Fixup versions of newly added modules. 11 years ago
Michael DeHaan 997bf64f3f Fix up some module docs formatting errors. 11 years ago
Michael DeHaan e6bc5ce124 YAML fix 11 years ago
Michael DeHaan f986665c5d Merge branch 'ocean' into devel
Conflicts:
	library/cloud/digital_ocean
11 years ago
Michael DeHaan a85c97edfb Reformat examples 11 years ago
Vincent Viallet a8e6e7c312 Rename digital ocean module to digital_ocean, add documentation. 11 years ago
Vincent Viallet fe7fcf2d15 Rename digital ocean module to digital_ocean, add documentation. 11 years ago