Commit Graph

76 Commits (375edbd087afa41a7331a2638c37509bade1af1a)

Author SHA1 Message Date
trbs d5fa690aaf In check mode if a symlink does not exist there is no need to check the ownership properties (which causes an exception) 11 years ago
James Cammarata 43f96a636b Fix issue with symlink path detection
Fixes #7627
Fixes #7664
11 years ago
James Cammarata 7483acde5d Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
11 years ago
Brian Coca 202ac68995 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
11 years ago
James Cammarata 062e82937f Fixing absolute path calculation for file module when linking
Fixes #7403
11 years ago
telsacolton 06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton 0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 11 years ago
James Cammarata b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
11 years ago
Brian Coca f079d022a3 now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi 036c7a7759 Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
James Tanner 68cd7258b6 Fixes #6894 create docs fragment for files 11 years ago
Michael DeHaan 1fa19e29e8 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
11 years ago
James Tanner 9fe2bcd076 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
11 years ago
Michael DeHaan 2ddb251538 Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
11 years ago
Steve Smith e157355fd6 Only unlink the symlink tempfile on error if it was created in the
previous operation.
11 years ago
Brian Coca 1b38bd8a40 fixed issue with tmp file (path can include filename) and added missing
else which made it try to link x2
11 years ago
Brian Coca 6e6ad97239 now correctly checks absolute path for src= existance for links
also updated docs to be a bit clearer on symlink behaviour
11 years ago
Brian Coca f6a75ebaf1 fixed issue with directory permissions on copy #6552 11 years ago
James Cammarata 5d8c9d3f0f Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean 11 years ago
Cristian Ciupitu 0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Brian Coca 2d25577e11 Fixes and cleanup to file functions and module
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
11 years ago
Sven Schliesing f62cc1e351 Fix link in documentation
c(dest) -> c(path)
11 years ago
Michael DeHaan 6c43e0e010 Simplify file module parameter description. 11 years ago
Mike Grozak f386e137fe Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths 11 years ago
Mike Grozak d3b544e842 Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files 11 years ago
Mike Grozak 2b4688a0bd Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix 11 years ago
jctanner 9ed379b7f8 Merge pull request #5282 from rhaido/hard_link_fix
file module: Added to the file module the functionality to force conversion hard link...
11 years ago
jctanner aa1f9f24c3 Merge pull request #5264 from drewlll2ll/file-fix
file module: Fixed missing prev_state == 'directory' in file
11 years ago
Maykel Moya 0711447d3a Missing "is" in file module description 11 years ago
Jens Rantil 1b6019f6e0 module(file): Fail instead of exit on exception 11 years ago
Jens Rantil f4aa808b8d module(file): state what went wrong on exception 11 years ago
Mike Grozak ed7c9a1fbb Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes' 11 years ago
drewlll2ll 54a28eb45b Added prev_state for directory 11 years ago
Jens Rantil 705316e303 `file` module: Don't catch `SystemExit`
This fixes issue #5159.
11 years ago
James Tanner ad837709bd Addresses #5023 Fix import comments 11 years ago
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Michael DeHaan f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
11 years ago
James Tanner 33242cacf3 Merge pull request #4375 from pfalcon/ansible
copy: Implement recursive copying if src is a directory.
11 years ago
James Tanner 5a3032a950 Fixes #4884 Do not prematurely exit from file module if src not defined 11 years ago
James Tanner 934ec1c0b6 Addresses #4801 Update file module docs to indicate behavior for relative src paths 11 years ago
sspans 904a129ac1 skip absolute path creation for old_src, not needed with the new relative links 11 years ago
sspans 684921c1c1 only require absolute paths for hardlinks 11 years ago
James Tanner f4b59fe285 Fixes #4516 file module: check prev_state earlier and use that if state is not specified 11 years ago
Michael DeHaan 99d6726114 Revert "fix conversion from file to hardlink when force=yes"
This reverts commit 4d4518ed52.
11 years ago
Dave Simons 4d4518ed52 fix conversion from file to hardlink when force=yes
Signed-off-by: Dave Simons <dave@inuits.eu>
11 years ago
jctanner c737f222d5 Merge pull request #4480 from joemaller/absent_path_fix
ignore src when file module state=absent
11 years ago
Paul Sokolovsky 2e668f14f7 copy: Handle "no copy/propagate attrs only" for recursive mode well.
For this, add internal "original_basename" param to file module,
similar to copy module. (Param name is a bit misnormer now, should
be treated as "original basepath").
11 years ago
Joe Maller 8597bf6bba ignore src when file module state=absent 11 years ago
Julian Yap 76cec9d360 Assume state='directory' if recurse is set and previous state was 'directory'
Resolves this issue: https://github.com/ansible/ansible/issues/2067
11 years ago