885 Commits (3637ce45385e92a3d96095464d752c43a6fdf775)

Author	SHA1	Message	Date
Toshio Kuratomi	5fb416ae34	Add a script to generate twitter and mailing list announcements ... Announcements taken from https://github.com/ansible/community/wiki/RelEng:-ReleaseProcess and then cleaned up: * Update issue reporting blurb from feedback from acozine and gundalow * Add a subject and to line for email output * Ignore long line tests on the jinja templates (as jinja doesn't give enough control to get rid of newlines when text wrapping) * Skip shebang and compile tests for older pythons since this is a release engineer-only script. (ok'd by mattclay)	6 years ago
Matt Clay	ade6977d66	Fix typo in doc_fragments path.	6 years ago
Ben Carter	f99f88b034	fixing status option in documentation (#53785) ... changing status option to statuses in the documentation Adding choices to the argument spec to match the documentation from AWS. Adding 'REVOKED', 'FAILED' to statuses documentation to match implementation. Removing E322, E323 ignores for aws_acm_facts	6 years ago
Matt Clay	39bbadb2fd	Replace no-underscore-variable test with pylint. (#54140) ... * Replace no-underscore-variable test with pylint. * Update orphan handling for sanity test docs. * Update command for listing tests.	6 years ago
Matt Clay	47f2101e8d	Fix no-underscore-variable test. (#54137) ... * Ignore lines with comments. * Detect variables at the start of the line.	6 years ago
Jordan Borean	0bf14d61d0	Add PSCustomUseLiteralPath and update PSSA for pslint (#54080)	6 years ago
Toshio Kuratomi	f5f4948480	Remove nose from unittests (#54055) ... * Remove nose from unittests This PR migrates the last of our unittests from using nose to using pytest. We don't need to install nose in our testing environments anymore	6 years ago
Matt Clay	63ce588382	Update pylint and split runs more to avoid hangs.	6 years ago
David Passante	ef6da8ec5c	cloudstack: streamline modules doc (part 4) (#53874) ... * cloudstack: streamline modules doc (part 4) * Parameter types added * Copyright format fixes * Doc style fixes * Examples format fixes * validate-module errors fixes * cs_network_offering: Rollback of the deletion of the choice list for supported_services param	6 years ago
David Passante	244a9a83aa	cs_iso: fix missing param "is_public" (#53740) ... * cs_iso: fix missing param "is_public" * add changelog fragment	6 years ago
David Passante	495c197770	cloudstack: streamline modules doc (part 3) (#53412) ... * cloudstack: streamline modules doc (part 3) * Parameter types added * Copyright format fixes * Doc style fixes * Examples format fixes * Remove cs_loadbalancer_rule from ignore.txt * cs_loadbalancer_rule: add "version_added" for params added into the documentation * cs_loadbalancer_rule: ignore E309 for now * cs_loadbalancer_rule: remove E309 from ignore.txt	6 years ago
Jordan Borean	f297229b52	Add arg and doc validation for PowerShell modules (#53615) ... * Add arg and doc validation for PowerShell modules * Verify if pwsh exists before running it	6 years ago
Jordan Borean	830a11dd38	test: optimize win_psmodule tests (#53431)	6 years ago
Matt Clay	40318b49b2	Check extensions on changelog fragments.	6 years ago
Matt Clay	7c0bc9e4ac	Fix no-assert code-smell regex.	6 years ago
Brian Coca	b94bfed1a6	scan_packages: made adding package managers easier (#49079) ... * made adding package managers easier added portage support * moar pkg mgrs and moar info - added 'pkg' pkg manager (freebsd) - added pip - more apt info * updated clgo * Updates from feedback Co-Authored-By: bcoca <bcoca@users.noreply.github.com> * incorporated more feedback and added docstrings * moar from feedback - made manager list dynamic and names based on class - better not found msg - made abstract metaclass again - test is now init exception - module to global - better dedupe comments * more targetted errors/warnings * added strategy, reordered to conserve priority * rpm > apt * move break to top * fix trate * piping it * lines and meta * refactored common functions - moved pip into it's own module - cleaned up base clases - ensure 'lower' match in package_facts * missing license * avoid facts * update clog * addressed feedback * fix clog * cleanup * upd * removed pip as that was removed * renamed cpan * added a single line since 2 lines are needed to be readabnle instead of just 1 line, it is a huge problem otherwise * fix internal ref * not intended in this round * updated as per fb	6 years ago
Dag Wieers	c44e83ee13	rhevm: Fix validate-modules issues (#52436) ... This PR includes: * Adding parameter types * Fix validate-modules issue * Improve parameter types and resulting changes This PR needs to be verified and tested by maintainer(s).	6 years ago
Wojciech Sciesinski	8136e2e4fe	Extend win_psmodule - the second attempt, the previous was #46516 (#50621) ... * Extend win_psmodule - rebased at 2019-01-07 * Change a way how defined parameters are added to the list * Correct registering a repository * Change way how tests for the check_mode: true are run * Post-review updates * Post-review updates -2 * Post-review updates -3 * Switch to PowerShell loop * Minor updates * Remove variants of an exception handling * Change error handling	6 years ago
Jordan Borean	6b294eab4d	win_dsc - Add argument validation and other fixes (#53093) ... * win_dsc - Add argument validation and other fixes * Fix doc issues	6 years ago
Matt Martz	a639dc6d88	Add a new check to ensure that module arguments are valid python identifiers (#53278) ... * Add a new check to ensure that module arguments are valid python identifiers * Move the check up higher, out of the if docs block * Skip validate-modules on py2 * Remove errant alias	6 years ago
Viktor Utkin	b2a7561a7f	[win_get_url] feature: Add support `checksum` to module win_get_url (#51986) ... * set valid_until equal to current time + spot_wait_timeout * Add checksum check for downloaded file. * refactoring * fix typo * add fixes * mart try,catch handling * revert lib/ansible/modules/cloud/amazon/ec2.py from upstream * refactoring * remove empty lines * add checksum verification for existing file * fix current file check * refactoring destination file check * add handling exceptions * refactoring * Added download file hash data from url * fix string aligning * fix bug with uri * Added get hash from multy-string file * Added URI support for checksum file location * refactoing * Remove any non-alphanumeric characters for hash from url * fix discussions; add support for PS3 * refactoring * add size return value * checkout from upstream for lib/ansible/modules/cloud/amazon/ec2.py * add Ansible.ModuleUtils.Legacy support; refactoring * Copyright added * Checking files size before and after downloading added. * remove unused code * Corrected regexp for dotted slashed file name prefix in hash-file * hotfix typo error; add int tests * remove legacy module support; split checksum to checksum, checksum_algorithm, checksum_url * changed default hash algorithm * Fixed case for ContentLength = -1 * Old comment removed * fix typo * Remove file size check before downloading * add alias to ; fix tests * adjust tests; fix lint warnings from PSScritpAnalyzer * workaround for bug in win_chocolatey module on win2008 * remove win_get_url.ps1 from /test/sanity/pslint/ignore.txt * add checksum_algorithm as retuen value * first normalise before return Result * resolve discussions Signed-off-by: Viktor Utkin <viktor.utkin7@yandex.ru> * fix discussions fix http tests as discussed * fix last discussions * Reduce code duplication and add idempotency check * fix sanity issue and remove testing code * move back to using tmp file for checksum comparison	6 years ago
Matt Martz	f0a63e783d	validate-modules improve empty version_added handling (#53177) ... * Improve empty version_added handling * Remove unrelated ignore	6 years ago
Matt Clay	29c9b4001d	Remove invalid validate-modules ignore entry.	6 years ago
Mariusz Mazur	fb4d0d84ec	Add kubevirt_cdi_upload module (#52990)	6 years ago
Matt Martz	35f5ca8295	Don't allow an empty version_added	6 years ago
Matt Martz	7f2e724203	Don't document a type for an argument which uses a callable (#53008) ... * Don't document a type for an argument which uses a callable * Update ignore.txt.	6 years ago
Dag Wieers	3ced545d06	validate-modules: Fix some files modules (#52440) ... This PR includes: - fixes to validate-modules issues All modules already include parameter types. The remaining files-modules have action plugins, so comparing to the arg_spec only is incorrect.	6 years ago
Dag Wieers	4670e41a30	validate-modules: Fix net_tools modules (#52489) ... This PR includes: * Fixes to open validate-modules issues * Adding parameter types	6 years ago
Rhys Campbell	7f50f467fe	mongodb_replicaset module and test exception (#49690) ... * Clean up from previous fork * Minor doc update * Fix doc string return type * Minor doc updates * Keeping fresh * Various changes to documentation, cosmetics and code logic Please test :-) * Fix typo * Various small changes as requested * Remove traceback ref * try catch changes * Tidy description * Correct data type in documentation * Fix for 4.0	6 years ago
Matt Martz	df5b8f65ca	Don't worry with type changes, just compare strings (#52827)	6 years ago
John R Barker	f6c2104d79	Update validate-modules/ignore to make devel green (#52820) ... Need to fix the modules, though need CI green first	6 years ago
Dag Wieers	cd77ea3eb3	serverless: Fix validate-modules issues (#52435) ... This PR includes: * Adding parameter types * Fix validate-modules issue * Improve parameter types and resulting changes This PR needs to be verified and tested by maintainer(s).	6 years ago
Dag Wieers	365ded2df6	nmcli: Fix known validate-modules issues (#52493) ... This PR includes: - Adding parameter types - Fix validate-modules issue - Improve parameter types and resulting changes This PR needs to be verified and tested by maintainer(s).	6 years ago
Dag Wieers	1f9da61bce	cyberark_user: Fix validate-modules issue (#52515) ... This PR includes: - validate-modules fixes - fix parameter types - code bugfix	6 years ago
Dag Wieers	0d1aebe064	kubernetes: Clean up parameter types (#52543) ... This PR includes: - Parameter types added - Copyright format fixes - Short license statement This breaks out PR #52182	6 years ago
Matt Martz	b54086ef02	Merge doc fragments in earlier (#52193) ... * Merge doc fragments in earlier * Move it even higher * Remove errant docs key * Fix type	6 years ago
Dag Wieers	8c74df5e67	validate-modules: Fix all system modules (#52384) ... This PR includes validate-modules fixes for all system modules. Except a few that are deliberately implemented like this.	6 years ago
Matt Martz	60255efc32	Don't error on type changes, cast to string and compare (#52505)	6 years ago
Alex Stephen	6ae04017d8	GCE deprecation warning (#52116) ... * GCE deprecation warning * porting guide typo * fixing ignores * moving error code back * underscore marking on gce * forgot to change status	6 years ago
Dag Wieers	d3bebb661c	validate-modules: Harmonize error messages (#52385) ... When fixing known errors, the error messages did not make it easy to find what parameter was having issues (because it was not in the errpr). Now it consistently starts with the parameter name, and then shows first the argspec and then the documentation values. This helps quick assessments.	6 years ago
Felix Fontein	ef3d86255d	docker_* modules: remove from validate-modules ignore list (#52402) ... * Remove docker_* modules from validate-modules ignore list. * Adjust types of cacert_path, cert_path and key_path. * Fix type of update_failure_action in docker_swarm_service.	6 years ago
Abhijeet Kasurde	e0d8d9c2bf	validate-modules: Documentation bool (#50085) ... * validate-modules: Documentation bool This check allows to catch cases where type of argument is different than documentation does. Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Wrong comparison for 'str' Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Add ignore.txt Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> * Fix logic and clean up ignore.txt	6 years ago
Dag Wieers	677c04c01d	Sanity fixes to parameter types (#52325)	6 years ago
Dag Wieers	f9ab9b4d68	Assorted pylint fixes	6 years ago
Dag Wieers	203caf2570	Fix module issues (#52209)	6 years ago
Dag Wieers	cedd9d9926	crypto: Fix known issues in modules (#52302) ... * crypto: Fix known issues in modules This fixes a few issues reported by 'validate-modules'. * Fix whitespace	6 years ago
Dag Wieers	27dfdb6a6a	doc_fragments: Clean up parameter types (database) (#52178) ... * module_utils: Clean up parameter types (database) This PR includes: - Parameter types added - Copyright format fixes - Short license statement - Description fixes (only for a few files, then I stopped :-)) * Fix validate-modules test ignores	6 years ago
Dag Wieers	cd9471ef17	Introduce new 'required_by' argument_spec option (#28662) ... * Introduce new "required_by' argument_spec option This PR introduces a new **required_by** argument_spec option which allows you to say *"if parameter A is set, parameter B and C are required as well"*. - The difference with **required_if** is that it can only add dependencies if a parameter is set to a specific value, not when it is just defined. - The difference with **required_together** is that it has a commutative property, so: *"Parameter A and B are required together, if one of them has been defined"*. As an example, we need this for the complex options that the xml module provides. One of the issues we often see is that users are not using the correct combination of options, and then are surprised that the module does not perform the requested action(s). This would be solved by adding the correct dependencies, and mutual exclusives. For us this is important to get this shipped together with the new xml module in Ansible v2.4. (This is related to bugfix https://github.com/ansible/ansible/pull/28657) ```python module = AnsibleModule( argument_spec=dict( path=dict(type='path', aliases=['dest', 'file']), xmlstring=dict(type='str'), xpath=dict(type='str'), namespaces=dict(type='dict', default={}), state=dict(type='str', default='present', choices=['absent', 'present'], aliases=['ensure']), value=dict(type='raw'), attribute=dict(type='raw'), add_children=dict(type='list'), set_children=dict(type='list'), count=dict(type='bool', default=False), print_match=dict(type='bool', default=False), pretty_print=dict(type='bool', default=False), content=dict(type='str', choices=['attribute', 'text']), input_type=dict(type='str', default='yaml', choices=['xml', 'yaml']), backup=dict(type='bool', default=False), ), supports_check_mode=True, required_by=dict( add_children=['xpath'], attribute=['value', 'xpath'], content=['xpath'], set_children=['xpath'], value=['xpath'], ), required_if=[ ['count', True, ['xpath']], ['print_match', True, ['xpath']], ], required_one_of=[ ['path', 'xmlstring'], ['add_children', 'content', 'count', 'pretty_print', 'print_match', 'set_children', 'value'], ], mutually_exclusive=[ ['add_children', 'content', 'count', 'print_match','set_children', 'value'], ['path', 'xmlstring'], ], ) ``` * Rebase and fix conflict * Add modules that use required_by functionality * Update required_by schema * Fix rebase issue	6 years ago
Matt Clay	1f3a74c0c8	Improve import sanity test output handling. (#52136) ... Handling of unexpected output for the following is improved: - stdout - stderr - warnings	6 years ago
Matt Clay	6cba471958	Remove unnecessary validate-modules ignore entry.	6 years ago