Commit Graph

58 Commits (35679e0093398c1abf89bde4f863ec73d8732c49)

Author SHA1 Message Date
Dag Wieers fe0c70fe9d Make module output more consistent wrt. changed/failed
- Make sure exit_json() always returns a changed= value
- Modify the yum module to not return failed=False
- Modify install() and latest() similar to remove() in yum module
- Changed exit_json(failed=True, **res) into a fail_json(**res)
- Make sure yum rc= value reflects loop (similar to how we fixed remove())
12 years ago
Seth Vidal 49dce05cdd fix up remove and fix fixme checking to see if pkg was removed 12 years ago
Seth Vidal 7c1e0de141 fix removal case where first pkg in a list is not installed at all
and the next one gets ignored despite being installed.

also clean up unnecessary second check.
12 years ago
Seth Vidal 0a153c6798 add comments that enablerepo/disablerepo are new in 0.9 12 years ago
Seth Vidal d8337dab06 tested and verified yum enable/disablerepo option for yum module 12 years ago
Seth Vidal d89d07550f first cut at yum module with enable/disable repo 12 years ago
Jan-Piet Mens feab57e270 Reformat code: examples consistently
- added terse syntax to modules.rst
 - added description of special variables to template module
12 years ago
Seth Vidal 326b160241 when a pkg is installed, but not from any repo, don't error out
that it is not installed.

Also when a pkg is both installed and in a repo do not look it up
more than once
12 years ago
Jan-Piet Mens a040807fd0 Module DOCUMENTATION for template, wait_for, and yum 12 years ago
Daniel Hokka Zakrisson 56b1a8ceed Invoke is_installed correctly from rpm path 12 years ago
Seth Vidal 5dbc85e8ad fix up local_nvra 12 years ago
Michael DeHaan ded0c61750 meaningless whitespace changes 12 years ago
Michael DeHaan de4b8dc53a Can use fail JSON here, remove debug statement 12 years ago
Michael DeHaan 58c975d621 Fix aliases, package not found is not an error 12 years ago
Seth Vidal 3175eacfc4 fixes to yum module
include local_nvra
change the remove behavior to pretty much NEVEr error out if the pkg is not there (or anywhere)
12 years ago
Seth Vidal 14479e6adc cover all of the edge cases with and without yum-utils installed.
it is possible those folks w/o yum-utils installed but with rhn-plugin
installed but w/o any rhn-certificates will still see an error msg.
they have 3 options:
1. remove rhn-plugin
2. enable some channels w/rhn certs
3. install yum-utils
12 years ago
Seth Vidal 2e3926d13f subprocess is already imported in module_common - no need for it here 12 years ago
Michael DeHaan 67301c1015 rename variable 'pkg' in yum module such that the auto-handled error messages use the same key. 12 years ago
Michael DeHaan 1e4d45af1e Add module common code to allow it to be easier to indicate whether arguments are mutually exclusive, required in conjunction, or whether one of a list of arguments is required. This simplifies writing Python modules. 12 years ago
Michael DeHaan 477ca2ed1a Make pep8 tests run against the library directory as well, and associated tweaks (mostly to indentation) in the library
directory.
12 years ago
Michael DeHaan ef18f9d953 Fix a scoping issue that was fixing some non-repoquery-installed cases 12 years ago
Michael DeHaan 63641da225 Merge branch 'yum-wo-repoquery' of https://github.com/dhozac/ansible into devel
Conflicts:
	library/yum
12 years ago
Seth Vidal 5c458b9761 make yum module work with list=pkgspec 12 years ago
Daniel Hokka Zakrisson 5a7d271759 Allow using the yum module without repoquery
It is still required to use list=..., but the typical install and remove
won't need it.
12 years ago
Michael DeHaan c82f06258c Only run yum,apt through the with_items loop if there is a list of items. Just a cosmetic fix on return values
for the most part.
12 years ago
Seth Vidal 61e02d508c add show-duplicates to reqpoquery to keep people who
want to install an old package happy.
12 years ago
Seth Vidal ca63173bf0 missed the quotes 12 years ago
Seth Vidal 70eea69e79 fix up yum state=latest with pkg groups 12 years ago
Michael DeHaan faed4b5a33 whitespace + remove deprecated YAML parser (migration script lives in examples/scripts and warning was added
in 0.6 release)
12 years ago
Michael DeHaan 7e9e29011e Add encoding lines to python modules such that they can take unicode options if they are fed them, since the
AnsibleModule stuff no longer base64 encodes for simplicity and speed reasons.
12 years ago
Seth Vidal fd492bebc6 - add a check for repoquery so we can abort politely
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
12 years ago
Michael DeHaan fa79d57d13 changelog / remove a failed=False 12 years ago
Michael DeHaan b7c3fd1246 failed should not be in the result returns for a module upon success 12 years ago
Seth Vidal c91befda5c redo of yum module - uses more system calls but should handle
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
12 years ago
Michael DeHaan 25acfa8170 Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases 12 years ago
Michael DeHaan 8700de964c Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
that code doesn't have to do a lot of params.get('foo', None) everywhere.
12 years ago
Michael DeHaan ce5f3dd148 Port the file module over to the new common code infrastructure + cleanup some redundant imports since the module code already imports those things. 12 years ago
Michael DeHaan 487c826700 Tweak alias consistency a bit. 'package' has never been documented, but since it works, make it work in both places.
'name' is the preferred form.  Similarly, take 'name' for the 'guest' argument to the 'virt' module.
12 years ago
Michael DeHaan 2030f82bf2 Further standardize the yum module 12 years ago
Nikhil Singh b47bed9601 Standardizing the yum module 12 years ago
Stephen Fromm aea022b002 Apply logging of arguments to modules (issue #122)
The ohai and facter modules use /usr/bin/logger to log the fact that
they have been invoked.  I added 'import os' to the ping module
so that it could have the same syslog statements as the other modules.
I separated the condensed:
    shlex.split(open(argfile, 'r').read())
into two separate statements similar to the other modules.
13 years ago
Seth Vidal a3ab793ba8 fixes for yum module for rhel5 and issue 269 13 years ago
Martijn Koster f936616f91 comment typos 13 years ago
Michael DeHaan ff5d329374 Yum package state defaults to installed 13 years ago
Michael DeHaan b418632a8d Allow yum module to use package or name as an alias for 'pkg' 13 years ago
Michael DeHaan f92760de6c If missing state or name or list parameter on yum module, raise error explaining what is up. 13 years ago
Seth Vidal 08163c6251 catch all exceptions and emit sensible errors - if we have a config file error this lets us know about it 13 years ago
Michael DeHaan 5764ccdb0e Eliminate possible race condition in async_wrapper where ansible deletes the argsfile while the module
is still kicking off.  Should not happen except in modules that are somewhat slow to load and probably
can be fixed better than the included sleep, i.e. some IPC communication that the process has
launched and is ok to exit.  This works pretty well for now though.
13 years ago
Seth Vidal 37f599efc3 make sure latest outputs an error if the thing you've listed as 'latest'
is not there at all or even updateable
13 years ago
Seth Vidal 1d04ec89b7 fix up latest so it behaves like latest should
if installed and updated available: apply update
if not installed and available: install
13 years ago