Commit Graph

7718 Commits (353f6be273dcdc09e13d94de4885071afc51fbed)

Author SHA1 Message Date
Toshio Kuratomi bf29961947 Fixes to the controller text model (#17527)
* Fixes to the controller text model

* Change command line args to text type
* Make display replace undecodable bytes with replacement chars.  This
  is only a problem on pyhton3 where surrogates can enter into the msg
  but sys.stdout doesn't know how to handle them.
* Remove a deprecated playbook syntax in unicode.yml

* Fix up run_cmd to change its parameters to byte string at appropriate times.
9 years ago
Toshio Kuratomi 9868117d1f Update submodule ref for core to fix broken service module 9 years ago
Toshio Kuratomi 499b13d649 Update submodule refs 9 years ago
Senthil Kumar Ganesan 1c7c3cc878 Addressed review comments from @gundalow 9 years ago
Senthil Kumar Ganesan 3e18676af4 Addded support for dnos9_command module 9 years ago
Nathaniel Case 060ed665f6 Cleanup nxos
closes #17414
9 years ago
Peter Sprygada 5aa83041bf Merge pull request #17474 from skg-net/dnos6_command
Add module_utils/dnos6.py
9 years ago
Peter Sprygada cc45506006 Merge pull request #17521 from privateip/fix-4797
raise exception when src file is not found in net_config
9 years ago
Nathaniel Case fcd4be28ee Cleanup openswitch
Also bump get_config in vyos, to pick up the addition of **kwargs

Closes #17415
9 years ago
Senthil Kumar Ganesan 05e016e4aa Addressed @gundalow review comments 9 years ago
Senthil Kumar Ganesan 94df740ca3 Added support for dnos6_command module 9 years ago
Toshio Kuratomi 6117e1946e Check controlpersist (#17443)
* Add a new config option to cache the check for controlpersist on the
control machine.

Fixes #15844

* Remove the option and make the behavior the default

* Make the check for controlpersist cache its status per-ssh executable
9 years ago
Nathaniel Case 2077e32ddd Vyos cleanup
Addresses #17416
9 years ago
Peter Sprygada 16d6274276 raise exception when src file is not found in net_config
This will now raise an exception if the file path specified in src is not
found and the module will gracefully error.

ref #4797
9 years ago
Peter Sprygada 4e325274d6 Merge pull request #17512 from privateip/nxos
roll up of updates to nxos shared module
9 years ago
Peter Sprygada 7777c38b95 Merge pull request #17508 from privateip/sros
updates sros shared module
9 years ago
Peter Sprygada e83567a8ec Merge pull request #17509 from privateip/vyos
roll up of updates to vyos shared module
9 years ago
Peter Sprygada 560984d282 Merge pull request #17511 from privateip/junos
updates junos shared module methods
9 years ago
Peter Sprygada 7c4dad4275 Merge pull request #17513 from privateip/eos
cleans up load_config() in eos shared module
9 years ago
Peter Sprygada ebe2400af8 Merge pull request #17510 from privateip/iosxr
clean up iosxr shared module
9 years ago
John R Barker 8a3b520f70 Add missing space in loop variable reuse message (#17516) 9 years ago
Peter Sprygada f4af154bef Merge pull request #17506 from privateip/openswitch
minor clean of openswitch shared module
9 years ago
Peter Sprygada db744e1233 Merge pull request #17507 from privateip/netcfg
removes unneeded message in netcfg
9 years ago
nitzmahone 8d1f96dd82 bump core submodule ref for win_user fixes 9 years ago
Peter Sprygada d2e4ddf0b0 roll up of updates to nxos shared module
* combine same functions into NxapiConfigMixin class
* update Cli and Nxapi to use mixin
9 years ago
Peter Sprygada e9f804614d removes unneeded message in netcfg
removes old warning message in netcfg that is no longer used
9 years ago
Peter Sprygada 815a683e9c minor clean of openswitch shared module
* updates regexp entries
* removes legacy 2.1 code for get_module()
9 years ago
Peter Sprygada 75f1573ed5 roll up of updates to vyos shared module
* cleans up method signature
* removes save_config method in favor of super class
9 years ago
Peter Sprygada a6cf394ebc updates sros shared module
* adds rollback to load_config() method
* updates error regexp list
9 years ago
Peter Sprygada e5d931de6b updates junos shared module methods
* cleans up load_config() arguments to simply
* removes unused methods in Cli transport
* updates error regexp
9 years ago
Peter Sprygada a8daff1590 clean up iosxr shared module
fixes up method signatures in iosxr shared module removing unneeded **kwargs
9 years ago
Peter Sprygada 456fbf011e cleans up load_config() in eos shared module
cleans up the load_config() method
9 years ago
James Cammarata f5cff2ced5 Revert "Flush the queued items in linear periodically"
This reverts commit d3418fd658.
9 years ago
Robin Schneider d76dd56ca3
Use addresses and names reserved for documentation
Trying to preserve the meaning of the examples. Not all occurrences in
`docsite/rst/playbooks_lookups.rst` have been changed for instance to
allow the unchanged examples to be used for testing.

Related to: #17479
9 years ago
James Cammarata d3418fd658 Flush the queued items in linear periodically 9 years ago
James Cammarata 6b206f5d00 Re-adding processing of results inline with queuing tasks for linear 9 years ago
Chris Houseknecht 39aa740531
Use LooseVersion comparison. Default docker_api_version to 'auto'. 9 years ago
Peter Oliver c87d84f5b8 Filesystem blocks are of size `f_frsize` (#17493)
The statvfs(3) manpage on Linux states that `f_blocks` is the "size of fs in `f_frsize` units".  The manpages on Solaris and AIX state something similar.

With ext4 on Linux, I suspect that `f_bsize` and `f_frsize` are always identical, masking this error.  On Solaris, the sizes differ for each of ufs, vxfs and zfs causing the `size_available` and `size_total` facts to be set incorrectly on this OS.
9 years ago
Brian Coca a3028783d4 removed previously deprecated ';' host separator 9 years ago
Brian Coca 0aaee0272a using delegated host's facts when delegating (#17489)
fixes #17313
9 years ago
jctanner af2ce7725b Iterate through role paths when installing roles (#17487)
* Iterate through role paths when attempting to install roles
9 years ago
Alvaro Aleman e8897a9b91 Fix from_yaml for non-string_types. This resolves #17397 (#17398) 9 years ago
Peter Sprygada 19e00cf160 Merge pull request #17481 from privateip/junos
minor update to catch expection if trying close a non existent session
9 years ago
Brian Coca cd2f60e11a take delegated vars before removing them
fixes #17455
9 years ago
Dag Wieers 2daf527e63 Fix fileglob filter to work just like fileglob lookup plugin (#17480)
The fileglob lookup plugin only returns files, not directories.
This is to be expected, as a mixed list would not be very useful in with_fileglob.
However the fileglob filter does return anything glob.glob() returns.

This change fixes this, so that fileglob returns files (as the name indicates).

PS We could also offer a glob filter for thos that would need it ?

This relates to comments in issue #17136 and fixes confusion in #17269.
9 years ago
Peter Sprygada 1dac6edbe4 minor update to catch expection if trying close a non existent session
This will prevent the junos shared module from throwing an exception if
the session is trying to be closed when it doesn't exist
9 years ago
Dag Wieers d52a9cee46 Support late evaluation, suppress warnings on SyntaxError (#17462)
See #14304 comments (https://github.com/ansible/ansible/pull/14304#issuecomment-245453209) for more information.
9 years ago
Matt Martz eefe359d6b Don't use the shell to catch output, catch output in python. Fixes #17137 (#17449) 9 years ago
Dag Wieers 1df924e1d5 Clean up unarchive action plugin (#17429) 9 years ago
Maciej Delmanowski f5a4677680 Allow for no prefix in the comment filter (#17421)
In the 'comment' filter, if the 'prefix' parameter is set as empty,
don't add an empty line before the comment. To get the previous
behaviour (empty line before comment), set the prefix to '\n'.
9 years ago
Matt Clay d317560914 Update submodule refs. 9 years ago
Peter Sprygada 686d79a515 Merge pull request #17467 from privateip/netcfg
fixes issue with netcfg not working with match=line and path
9 years ago
Peter Sprygada 457a6ca03e fixes issue with netcfg not working with match=line and path
The difference() method now checks this condition and doesn't filter
the path when match=line
9 years ago
Tobias Wolf 9838d6420a Re-fix the per-item diff output, (#17458)
which got lost in recent big 'performance improvements' merge by @jimi-c.

I had made a previous PR to fix this, then @bcoca had committed an
improved fix. Now it's lost again.

cf: d2b3b2c03e (lost here)
cf:  25e9b5788b (previous fix)

Earlier PR #14849
Earlier issue #14843

Please note that jimi-c broke this last time as well ... seeing a
pattern here.
9 years ago
Edward Marshall 1ec9ac4b70 Defined children for get_vm (#15904) 9 years ago
Abhijit Menon-Sen 032bd1dacf Fix typo 9 years ago
Peter Sprygada 982db58aff Merge pull request #17452 from privateip/netcfg
adds context to diff functions based on config path
9 years ago
Peter Sprygada d64eaae232 Merge pull request #16553 from ericchou1/devel
Added axapi_authenticate_v3 and axapi_call_v3 for AXAPIv3
9 years ago
Peter Sprygada 08eeb1518a adds context to diff functions based on config path
* difference() now accepts a path keyword to specify comparision domain
9 years ago
Andrea Tartaglia ba28f1a2da Make ssh_executable available as ansible_ssh_* variable (#17450) 9 years ago
James Cammarata d1a7e07ccc Fixing another logic issue related to include_role changes 9 years ago
Peter Sprygada 715b800ef1 Merge pull request #17447 from privateip/eos
minor fix in eos shared module returning diff
9 years ago
Peter Sprygada 675e87f68d minor fix in eos shared module returning diff
The diff returned from eos when the transport was set to eapi was as
a dict but is expected to be a str.  This change extracts the diff string
from the dict object and returns it.  The behavior is now consistent
between cli and eapi transports.
9 years ago
Brian Coca 65c373c55a fixed bad condition hiding results 9 years ago
@skg_net e5b8a177d7 Support files for dnos10_template module (#17399) 9 years ago
Brian Coca a4abf8da79 Flush cache (#17445)
* transfer module based on pipelining, not tmp

fixes #17381

* added missing flush cache option back
9 years ago
Andrea Tartaglia dd71469bb7 Added option to change ssh executable path (#17377) 9 years ago
Adrian Likins 07e713e7c6 Fix NameError on 'ansible-vault view' (#17440) 9 years ago
Toshio Kuratomi 8c43750a3e Update submodule refs 9 years ago
Peter Sprygada d67af04c45 Merge pull request #17431 from privateip/eos
minor roll up of fixes to eos shared module
9 years ago
Toshio Kuratomi 4ed88512e4 Move uses of to_bytes, to_text, to_native to use the module_utils version (#17423)
We couldn't copy to_unicode, to_bytes, to_str into module_utils because
of licensing.  So once created it we had two sets of functions that did
the same things but had different implementations.  To remedy that, this
change removes the ansible.utils.unicode versions of those functions.
9 years ago
Peter Sprygada ca95b2ae4f minor roll up of fixes to eos shared module
* added back import of Command object
* fixed eapi requests to handle output format correctly
* get_config() now honors include_defaults kwargs
9 years ago
Matt Davis f239e1e61f windows async changes and tests (#17400) 9 years ago
nitzmahone 056a7cb957 bump core submodule ref for async_wrapper.ps1 bugfix 9 years ago
Matt Clay 94a0d2afb4 Add partially backwards compatible version of _fixup_perms. (#17427)
Also added a deprecation notice for _fixup_perms.

Resolves issue #17352 (assumes custom actions use recursive=False).
9 years ago
Toshio Kuratomi 1d412059a0 Fix UnicodeError loading plugins with non-ascii in them on python3 9 years ago
Peter Sprygada 113dfc5562 Merge pull request #17426 from privateip/nxos
fixes issue when piping commands through json with output not specifed
9 years ago
Peter Sprygada 52d1187f5c Merge pull request #17425 from privateip/netcli
removes command caching on retrieve from netcli
9 years ago
Peter Sprygada 666b19869b Merge pull request #17424 from privateip/fix-17408
removes unneeded code from netcli
9 years ago
Peter Sprygada 5730c97f9e Merge pull request #17422 from privateip/fix-17407
bug fix for AttributeError: 'str' object has no attribute 'get'
9 years ago
Peter Sprygada c228dfe692 fixes issue when piping commands through json with output not specifed
There is an issue when piping cli commands through json but the output
is specified as either text or the output is none and the transport is
cli.  The results would not be loaded properly for conditional
evaluation.  This is similar to #17422
9 years ago
Peter Sprygada da931b04ad removes command caching on retrieve from netcli
The caching of commands in CommandRunner is providing no useful feature
and causing problems.  This removes the code and simply returns the
requested command results.
9 years ago
Peter Sprygada fbda7d127f removes unneeded code from netcli
Some old remnants of code from the refactor of netcli was left over as
reported in #17408.  This commit removes the old code as it isn't need
and in fact wasnt doing anything
9 years ago
nitzmahone abbb93e117 bump core submodule ref for windows async 9 years ago
Matt Davis b860b2d258 windows environment support (#17402) 9 years ago
Peter Sprygada 7fe64ef9b8 bug fix for AttributeError: 'str' object has no attribute 'get'
Exception thrown when using cli transport in eos but piping the command
through json

* eos now checks for `| json` and automatically changes the output type
* adds back import of Command object

tested on EOS 4.15.4F
9 years ago
Toshio Kuratomi b6d24be09e Update submodule refs 9 years ago
James Cammarata 37f721f315 Remove debug lock 9 years ago
Nathaniel Case 972dc3fc97 Network module cleanup (#17334)
* Clean up EOS, IOS, IOS-XR, Junos, NX-OS, and OpenSwitch

* Cleanup net* files

* Re-add NetworkModule import to network module_utils files

This will trick modules into importing code from module_utils code, thus
including it in the final Ansiballz zipfile.

* Give asa a look over, too
9 years ago
James Cammarata 7a0b25d5fa Fixing incorrect 'task' variable bug in strategy/__init__.py 9 years ago
Marc-André Gatien d56b0aa813 typo fix for variable ANSIBLE_ETCD_VERSION (#17373) 9 years ago
Michael Scherer 02d9f14b8b Do not crash if current dir do not exist, fix #17369 (#17379)
Do not crash if current dir do not exist
9 years ago
Brian Coca ff34f5548d Dynamic role include (#17401)
* dynamic role_include

* more fixes for dynamic include roles

* set play yfrom iterator when dynamic

* changes from jimi-c

* avoid modules that break ad hoc

TODO: should really be a config
9 years ago
Peter Sprygada 439aa353f1 fixes bug when template is missing src argument
adds AttributeError to exception handling to change missing src argument

fixes #17391
9 years ago
Peter Sprygada 9c5bcda4fe Merge pull request #17388 from privateip/asa
fix up asa shared module
9 years ago
Peter Sprygada 06c76034dc Merge pull request #17385 from privateip/shell
minor optimizations and clean up in shell.py
9 years ago
Peter Sprygada 1b1c1fe992 Merge pull request #17386 from privateip/netcli
clean up method signatures in netcli
9 years ago
Peter Sprygada d976c80a22 roll up of updates to junos shared module
* adds implementation for Network methods
* adds action plugin junos_config
* removes _log() and raises exceptions instead to be handled by the module
9 years ago
Peter Sprygada a839acfa33 clean up method signatures in netcli
removes unneeded **kwargs from methods in netcli
9 years ago
Peter Sprygada a40515524f minor optimizations and clean up in shell.py
* cleans up method signatures
* drops checking for Command properties that no longer exist
9 years ago