Commit Graph

802 Commits (340ff310757f133ac47b8bcbc68e610982cd0b7a)

Author SHA1 Message Date
Peter Sprygada 340ff31075 catches exception if conditional cannot be parsed (#5067)
If the conditional cannot be parsed, the module will now catch the exception
and return a well formed failed message.

fixes #5060
8 years ago
Peter Sprygada a1c3ce0ad1 fixes error when 'delete ...' config command is specified but doesn't exist (#5064)
The junos_config module will generate an exception if a 'delete ...' config
command is attempted to be loaded into a device configuration.  This change
will first check to see if the delete command is valid and filter it out
of the change set if it is not valid.

fixes #5040
8 years ago
Nathaniel Case 9a0add286f Network module code cleanup (#5061)
* Fix imports in junos_template

* Python 3 compatibility in eos_command

* Python 3 compatibility for ios_command

* Clean up issues with ios_facts

* Python 3 compatibility for ios_facts

* Import shuffle in ios_template

* Python 3 compatibility for iosxr_command

* Clean up iosxr_facts.py

* Python 3 compatibility for iosxr_facts

* Python 3 compatibility for junos_command

* Python 3 compatibility for ops_command

* Cleanup issues with ops_facts

* Python 3 compatibility for ops_facts

* Cleanup issues with ops_template

* Python 3 compatibility for vyos_command

* Cleanup issues with vyos_facts

* Python 3 compatibility for vyos_facts
8 years ago
Nathaniel Case cb29cbf6bc Fix imports in junos_template (#5059) 8 years ago
Nathaniel Case bdab56efa8 eos_facts cleanup (#5057)
* dict.iteritems does not exist in Python 3

Now just dict.items
six.iteritems handles the change

* Addresses point 1

Unsure if this is a good idea or not.

* Addresses point 2

This shouldn't have any particular change, just marks load_comments as abstract

* Remove unused import

Addresses point 3

* Clarify invalid subset error message

Addresses point 4
8 years ago
Peter Sprygada 87f47a44c9 fixes exception being raised when show configuration command issued (#5047)
The junos_command expects commands to be returned as xml by default but
`show configuration [options]` will return text not xml.  This fix
will set the output format for any command that starts with `show
configuration` to text

fixes #4628
8 years ago
Peter Sprygada 57350f84cd fixes return passing output from command through jxmlease in junos_command (#5044)
The return string from the commands was not being passed through the
jxmlease library and therefore being returned as a string instead of a
json data structure.  This also adds back the missing xml key in the
return that includes the raw xml string.

fixes #5001
8 years ago
Senthil Kumar Ganesan cf243860ff Update minimum required version and ssh rate limit (#4995) 8 years ago
Peter Sprygada 13c7288aea fixes exception raised when nxos_facts uses nxapi transport (#4988)
This fixes a condition where an exception is raised when collecting `interface`
facts and the transport is set to nxapi in the nxos_nxapi module.

fixes ansible/ansible#17691
8 years ago
Peter Sprygada 1dd2b849dc fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
8 years ago
Peter Sprygada a923689182 fixes bug where setting state=absent in nxos_nxapi is not idempotent (#4984)
When setting state=absent the nxos_nxapi module would always try to remove
the configuration regardless of the current state of the device.  This will
fix that problem.

This also updates the docstring to correctly reflect https as default=no

fixes #4955
depends on ansible/ansible#17728
8 years ago
John R Barker a829ca29ee Force is not a 2.2 feature
9b5e6bbfa1 incorrectly chopped some text around
8 years ago
Peter Sprygada 3a2cfadb31 fixes junos_config to be idempotent when confirming a commit (#4946)
The junos_config module would always return true when confirming a commit
This changes the module to now check first making the feature idempontent
8 years ago
Peter Sprygada 4c8e32ee27 fixes import statements in junos_package module (#4929)
This fixes the import statement to import NetworkModule from network instead
of from junos
8 years ago
Peter Sprygada df4a9dabd5 fix up junos_facts import statements (#4928)
This fixes the junos_facts import statements and removes importing
NetworkModule from the junos shared module.
8 years ago
Peter Sprygada a3807eee10 fix import in junos_command module (#4927)
This fixes the import statements in the junos_command module to be
consistent with all junos_* modules
8 years ago
Peter Sprygada 16f298138c roll up of bug fixes for junos_config module (#4925)
* fixed docstring referencing old arguments
* changed out lxml for xml library to avoid import errors
* fixed issue when trying to confirm a commit will end up a NOOP
* fixed issue for passing replace argument to load_config method
8 years ago
Peter Sprygada 446c7de239 bug fixes in junos_netconf module (#4924)
* fixes exception thrown when sending commands to device
* fixes exception thrown when retrieving current resource instance
* fixes issue where netconf would be configured in some instances when state
  was set to absent
* now returns the command string sent to the remote device
* fixes argument name to be netconf_port with alias to listens_on
8 years ago
Josh Lothian 6950e79cde Fix YAML syntax in NXOS documentation (#4922)
* Fix YAML syntax in NXOS documentation

Use ':' and not '=' to ensure valid YAML
in the EXAMPLES

* Correcting introduced syntax error
8 years ago
Peter Sprygada 539e39df8d Merge pull request #4910 from GGabriele/feature_fix
Fix nxos_feature 2.2
8 years ago
Matt Clay f2c2dddc01 Remove duplicate keys from module docs. (#4920) 8 years ago
Peter Sprygada e3b6f52bf5 Merge pull request #4914 from privateip/eos_command
bug fix that now catches FailedConditionalError when specifying conditionals
8 years ago
GGabriele 169b722d73 Add feature mappings 8 years ago
Peter Sprygada 3714b30a9f bug fix that now catches FailedConditionalError when specifying conditionals
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
8 years ago
Peter Sprygada 2e357e262c adds exception handling to nxos_command for FailedConditionalError
This adds exception handling as per ansible/ansible#17638 to the
nxos_command module.
8 years ago
Peter Sprygada 318c115e9b Merge pull request #4906 from GGabriele/portchannel_fix
Fixing nxos_portchannel
8 years ago
Peter Sprygada 773063f88c Merge pull request #4907 from privateip/fix-4905
eos_eapi module allows independent configuration of protocol and port
8 years ago
Peter Sprygada 4ff0fd3910 eos_eapi module allows independent configuration of protocol and port
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905.  This changes the behavior to now allow
the port to be configured independently

fixes #4905
8 years ago
GGabriele d632cce546 Fixed docstring 8 years ago
GGabriele 5174e3f31f Fixing nxos_portchannel 8 years ago
Senthil Kumar Ganesan 7362b8d08f Addressed review comments, given as part of other reviews (#4904) 8 years ago
Peter Sprygada 56758caf41 Merge pull request #4897 from skg-net/dellos6_facts
Dellos6 facts
8 years ago
Peter Sprygada 0ded4d7425 Merge pull request #4899 from skg-net/dellos6_config_bugfix
Updated the config module to use the new Parse method for OS6
8 years ago
Peter Sprygada 464203f71e Merge pull request #4898 from skg-net/dellos6_template
Added support for template module for Dell OS6 devices
8 years ago
Peter Sprygada 39edfbb68b Merge pull request #4674 from GGabriele/nxos_vxlan_vtep_vni
Adding nxos_vxlan_vtep_vni
8 years ago
Peter Sprygada 765b014119 Merge pull request #4861 from GGabriele/nxos_vtp_domain
Adding nxos_vtp_domain
8 years ago
Peter Sprygada 68560ee0b5 Merge pull request #4863 from GGabriele/nxos_mtu
Adding nxos_mtu
8 years ago
Peter Sprygada 789af7527e Merge pull request #4872 from GGabriele/nxos_udld_interface
Adding nxos_udld_interface
8 years ago
Peter Sprygada ae02517570 Merge pull request #4866 from GGabriele/nxos_pim_interface
Adding nxos_pim_interface
8 years ago
Peter Sprygada 244d3fbb5c Merge pull request #4875 from GGabriele/nxos_aaa_server_host
Adding nxos_aaa_server_host
8 years ago
Peter Sprygada c94acd9df4 Merge pull request #4862 from GGabriele/nxos_vtp_version
Adding nxos_vtp_version
8 years ago
Peter Sprygada 79e2fbce68 Merge pull request #4858 from GGabriele/nxos_udld
Adding nxos_udld
8 years ago
Peter Sprygada 55b071d083 Merge pull request #4859 from GGabriele/nxos_vtp_password
Adding nxos_vtp_password
8 years ago
Peter Sprygada e65df42368 Merge pull request #4877 from GGabriele/nxos_igmp_snooping
Adding nxos_igmp_snooping
8 years ago
Peter Sprygada a78f92a854 Merge pull request #4870 from GGabriele/nxos_snmp_user
Adding nxos_snmp_user
8 years ago
Peter Sprygada 31fbb8484d Merge pull request #4856 from GGabriele/nxos_ntp_options
Adding nxos_ntp_options
8 years ago
Peter Sprygada 5f43981efb Merge pull request #4853 from GGabriele/nxos_ntp_auth
Adding nxos_ntp_auth
8 years ago
Peter Sprygada 7e85ffe606 Merge pull request #4851 from GGabriele/nxos_aaa_server
Adding nxos_aaa_server
8 years ago
Peter Sprygada 4fe4d084b8 Merge pull request #4841 from GGabriele/nxos_snmp_traps
Adding nxos_snmp_traps
8 years ago
Peter Sprygada 338528d644 Merge pull request #4843 from GGabriele/nxos_ntp
Adding nxos_ntp
8 years ago