8 Commits (33f3612e5c089936603a58f9cb5f5688bec2e91b)

Author	SHA1	Message	Date
Andrea Scarpino	38cb5c6130	The enable parameter is a boolean, then convert to a boolean. (#1607) ... At the moment, this only works when 'enable' is equals to 'yes' or 'no'. While I'm on it, I also fixed a typo in the example and added a required parameter.	9 years ago
liquidat	e8916a6491	correct win_firewall state parameter ... - original parameter comment was probably copy&paste error - new comment highlights that firewall rules can be added or removed altering this parameter	9 years ago
Dreamcat4	ece9c2b43a	fix: Add 'enable:' flag for enabling existing rules which are disabled by default. ... This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens. Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now. But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.	9 years ago
Dreamcat4	dcaa794949	fix: update documentation with new module name "win_firewall_rule"	9 years ago
Dreamcat4	469d22df97	fix: The names of firewall profiles are different on win10 & win2008r2 ... Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version). For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself. Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done. Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.	9 years ago
Timothy Vandenbrande	b0a637086f	add version_added: "2.0"	10 years ago
Timothy Vandenbrande	97d8273558	windows default to current instead of all	10 years ago
Timothy Vandenbrande	2a0df8ec04	renamed the module	10 years ago