273 Commits (30c8f514a23d103d17899d599ee11c130a11d097)

Author	SHA1	Message	Date
Michael Scherer	ddd582269c	increase test coverage of inventory by around 5% according to nose	11 years ago
Stoned Elipot	f0743fc32a	Introduce the 'always_run' task clause. ... The 'always_run' task clause allows one to execute a task even in check mode. While here implement Runner.noop_on_check() to check if a runner really should execute its task, with respect to check mode option and 'always_run' clause. Also add the optional 'jinja2' argument to check_conditional() : it allows to give this function a jinja2 expression without exposing the 'jinja2_compare' implementation mechanism.	11 years ago
Petr Svoboda	e3adfbf5f8	Add tests for undefined variable detection ... Tests `test_playbook_undefined_varsX_fail` check if ansible detects undefined variables when `error_on_undefined_vars` is enabled. These tests fail without "Improve behavior with error_on_undefined_vars enabled" patch. Tests `test_playbook_undefined_varsX_ignore` check if ansible ignores undefined variables when `error_on_undefined_vars` is disabled. Also modify PlayBook._run_task_internal() so error_on_undefined_vars is testable.	11 years ago
Michael Scherer	b655d5798b	add tests for the -i option when used with raw string for ipv4 ... and ipv6 addresses.	11 years ago
Michael Scherer	498a550f01	add test for the disabling of callback plugins	11 years ago
Michael DeHaan	4bdbe4dc4f	Remove some test prints	11 years ago
Michael DeHaan	76fd769704	Merge pull request #3685 from mspaulding06/indexed_items ... Indexed items lookup plugin	11 years ago
Michael DeHaan	3ebbb56479	Merge pull request #3654 from MaxIV-KitsControls/devel ... Fix nested loop for more than 3 elements	11 years ago
Matt Spaulding	b7154cf2cf	Add tests for indexed_items lookup plugin	12 years ago
Vincent Hardion	09ef7751e1	Fix nested loop for more than 3 elements ... - combine flatten list for each nested level instead once at the end	12 years ago
Stoned Elipot	a1503c4d59	stringify conditional before handing it to Jinja2 for evaluation. ... This should fix simple conditionals like: when: ansible_selinux While here add tests for ansible.utils.check_conditional() in "jinja2_compare mode".	12 years ago
Michael DeHaan	88720516a1	Merge branch 'changed_when' of git://github.com/stoned/ansible into changed_when	12 years ago
Tin Tvrtkovic	4a732c1e9f	Enabled the use of extra vars in playbook file paths when including playbooks from other playbooks.	12 years ago
Stoned Elipot	eb45f07ae3	Introduce 'changed_when' keyword to override a task's changed status with the evaluation of a Jinja2 expression	12 years ago
Stoned Elipot	baf868f825	Add test for 'ignore_errors:'	12 years ago
Dale Sedivec	b32131c867	expanduser on each component of plug-in paths ... ansible.constants was calling expanduser (by way of shell_expand_path) on the entire configured value for the library and *_plugins configuration values, but these values have always been interpreted as multiple directories separated by os.pathsep. Thus, if you supplied multiple directories for one of these values, typically only the first (at least on *nix) would have e.g. "~" expanded to HOME. Now PluginLoader does expansion on each individual path in each of these variables.	12 years ago
George Miroshnykov	c642ba77ae	Added basic support for hash_behaviour=merge in roles ... Dict vars passed to roles are now properly merged instead of simply overriding dict vars that are coming from vars_files.	12 years ago
Michael DeHaan	4ae3ef8af9	Disable inventory test	12 years ago
Pol Llovet	4432c01ceb	Handle '#' in var strings by splitting on ' #' ... If someone has a " #" in a quoted var string, it will interpret that as a comment and refuse to load the inventory file due to an unbalanced quote. Noisy failure > unexpected behavior.	12 years ago
Pol Llovet	ba78360c52	Remove inline comments from inventory tokenizing.	12 years ago
Michael DeHaan	a9fcea5893	Merge branch 'escape' of git://github.com/ngrilly/ansible into repr	12 years ago
Dale Sedivec	611d56dc4c	Plug-ins loaded from top-level plug-in directory ... PluginLoader._get_paths, as of 391fb98e, was only finding plug-ins that were in a subdirectory of one of the basedirs (i.e. in a category directory). For example, action_plugins/foo.py would never be loaded, but action_plugins/bar/foo.py would work. This makes it so that "uncategorized" plug-ins in the top level of a directory such as action_plugins will be loaded, though plug-ins in a "category" subdirectory will still be preferred. For example, action_plugins/bar/foo.py would be preferred over action_plugins/foo.py.	12 years ago
Nicolas Grilly	75ceb80572	Escape args injected in new style modules	12 years ago
David Simon	190ce16bab	Dealing with invalid symlinks and symlink permissions	12 years ago
Dale Sedivec	515fd9e915	copy action plug-in check mode respects force=no ... The copy action accepts force=no, which tells it not to replace an existing file even if it differs from the source. The copy action plug-in wasn't respecting this option when operated in check mode, so it would report that changes are necessary in check mode even though copy would make no changes when run normally. Runner._remote_md5 was changed to make the logic for setting rc perhaps a little more clear, and to make sure that rc=0 when the file does not exist.	12 years ago
Michael DeHaan	7c6341718e	Merge branch 'combine_vars' of git://github.com/laggyluke/ansible into exp ... Conflicts: lib/ansible/inventory/vars_plugins/group_vars.py lib/ansible/runner/__init__.py lib/ansible/utils/__init__.py test/TestPlayBook.py	12 years ago
willthames	377bc31311	Prevent premature substitution of variables into tasks ... As documented in #2623, early variable substitution causes when_ tests to fail and possibly other side effects. I can see the reason for this early substitution, likely introduced in 1dfe60a6, to allow many playbook parameters to be templated. This is a valid goal, but the recursive nature of the utils.template function means that it goes too far. At this point removing tasks from the list of parameters to be substituted seems sufficient to make my tests pass. It may be the case that other parameters should be excluded, but I suspect not. Adding a test case. I would prefer to analyse not just the aggregate statistics but also whether the results are as expected - I can't see an easy way to do that with the available callbacks at present.	12 years ago
Michael DeHaan	81a926547c	Some continued work on new-style templates and associated test code changes. Legacy template functions ... are marked with "legacy_" for possible future removal.	12 years ago
Michael DeHaan	b09ef21ec9	Add code to flag legacy templating like $foo.{bar} as deprecated in favor of Jinja2 {{ foo.bar }} so we ... can remove the legacy system at a later date.	12 years ago
Michael DeHaan	e8085ad40c	Since we removed the (undocumented) playbook include + with_items code, fix the tests to ... compensate.	12 years ago
willthames	9d87733f98	Test case and fix for shlex.split unicode bug ... When operating on a unicode string in python 2.6, shlex.split returns a result that does not work with the file constructor. To reproduce this requires a task include that is templated (this is because the templated string is a unicode result, whereas a non- templated string is a non-unicode string) [will@centos6.3] $ python Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23) [GCC 4.4.6 20120305 (Red Hat 4.4.6-4)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import shlex >>> shlex.split(u'abc') ['a\x00\x00\x00b\x00\x00\x00c\x00\x00\x00'] [will@fedora17] $ python Python 2.7.3 (default, Jul 24 2012, 10:05:38) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import shlex >>> shlex.split(u'abc') ['abc'] The proposed fix (coercing the include parameters to string before the shlex.split) may not be ideal but it does fix the bug for my test case.	12 years ago
George Miroshnykov	6826aa7360	Tweaked merge_hash to also affect Runner behavior	12 years ago
Michael DeHaan	7116c83c4a	Standardize test output	12 years ago
Michael DeHaan	2c783c7145	Disable a test temporarily	12 years ago
Michael DeHaan	cdaa2085ee	Preliminary ability to use Jinja2 {{ }} to replace ${foo.bar} in playbooks. Can't use both at the same time per line.	12 years ago
tin	ca581840ef	Added additional lineinfile documentation. ... A little more unit testing.	12 years ago
tin	f9b70822d2	Fixed to the lineinfile module. ... Added the backrefs parameter to the lineinfile module. Added tests for the backrefs functionality of the lineinfile module.	12 years ago
Javier Candeira	ca6c36e1ac	password lookup plugin, with working tests and documentation	12 years ago
Michael DeHaan	839dff8eae	Disable filter test for now since it should really be testing at a lower level.	12 years ago
Daniel Hokka Zakrisson	1f8805d9e0	Add some tests for directory-based inventory	12 years ago
Devin Bayer	fca1167a0e	add to_nice_yaml|json filters	12 years ago
Yves Dorfsman	cff8cdd428	Using the _get_test and _get_stage methods.	12 years ago
Yves Dorfsman	943829c9b7	Added test cases for lineinfile.	12 years ago
Mike Grozak	171a01deac	Cron module upgrades ... - added cron_file attribute: if specified, the file with appropriate job is created in /etc/cron.d directory. Also, you can store multiple jobs in one file. state='absent' attribute is handled in the following way in this case: if after the deletion of the job from the file specified by cron_file variable the file is empty, the file is deleted, otherwise not. - fixed the behaviour, when the backupfile is saved forever in /tmp folder, even if the backup= atribute is not set (os.unlink() is called if backup is not True). - added some comments to the unobvious places	12 years ago
Rune Kaagaard	7a8b27f716	Fixing bug with unicode templates. ... The utils.md5s() function would break when calculating checksums for non-ascii characters. Convert to utf-8 first.	12 years ago
Daniel Hokka Zakrisson	a79373f6b2	Make template_ds the only templater ... Instead of having to remember when to use which one, rename template_ds to template and move the last bit of code from template to varReplace (which gets used for all string replacements, in the end). This means that you can template any data type without worrying about whether it's a string or not, and the right thing will happen.	12 years ago
Juha Litola	2796603c92	Removed apt_key tests, as they didn't test the real functionality. ... Tests used heavily mocked version of the apt_key code, which meant that it didn't properly test real life scenario.	12 years ago
Jayson Vantuyl	ad6373430b	add apt_key module ... Pretty straightforward. Give it a URL with an exported GPG key for signing an Apt repository. It downloads it and will install it using apt-key. It's even smart enough to tell if it's already there (i.e. actually tells you if it changed or not).	12 years ago
Jayson Vantuyl	13ddd39db9	add with_sequence lookup plugin ... Plugin allows you to do easy counts for items.	12 years ago
Daniel Hokka Zakrisson	87b2378e22	Resolve variable references inside variables ... Fixes the case where variable x is '$y' and y is a dict(foo='bar') and an attempt to access ${x.foo} is made.	12 years ago
Michael DeHaan	04195e202d	Merge pull request #1747 from njharman/alpharange ... Alphabetic inventory hostname patterns.	12 years ago
Michael DeHaan	4bcdd24688	Merge pull request #1776 from junegunn/inventory-group-var-ws ... Allows whitespaces around assignment operators when defining group variables	12 years ago
Michael DeHaan	dede11750c	Merge pull request #1775 from dagwieers/boolean-yes-no ... Make use of yes/no booleans in playbooks	12 years ago
Junegunn Choi	7fbb7e079a	Fix hostname expansion bug in inventory parser	12 years ago
Junegunn Choi	daf797804b	Allows whitespaces around assignment operators ... when defining group variables	12 years ago
Dag Wieers	66fb7fd9de	Make use of yes/no booleans in playbooks ... At the moment Ansible prefers yes/no for module booleans, however booleans in playbooks are still using True/False, rather than yes/no. This changes modifies boolean uses in playbooks (and man pages) to favor yes/no rather than True/False. This change includes: - Adaptation of documentation and examples to favor yes/no - Modification to manpage output to favor yes/no (the docsite output already favors yes/no)	12 years ago
Michael DeHaan	70bb7d1e54	Merge pull request #1696 from gregorg/enhance_limit ... Allow regex to be used to select hosts in addition to fnmatch pattern	12 years ago
Daniel Hokka Zakrisson	54b45e9bd4	Allow intersecting host patterns by using & ... This allows patterns such as webservers:!debian:&datacenter1 to target hosts in the webservers group, that are not in the debian group, but are in the datacenter1 group. It also parses patterns left to right.	12 years ago
Norman J. Harman Jr	6603737e4d	Alphabetic inventory hostname patterns. ... - Code, docs, tests. - Also added test of large range 000-142 to verify alpha range did not break this.	12 years ago
Gregory Duchatelet	8bc1b69c58	Add a unit test to subset limiting via a regex, and some doc in man ... page.	12 years ago
Brian Coca	6a1e2aaff5	moved override matching string to variable changed test template to match Signed-off-by: Brian Coca <briancoca+ansible@gmail.com> ... Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
Brian Coca	d751d88b48	added test for template overrides Signed-off-by: Brian Coca <briancoca+ansible@gmail.com> ... Signed-off-by: Brian Coca <briancoca+dev@gmail.com>	12 years ago
Daniel Hokka Zakrisson	0c70abfaa9	Make sure any existing groups gets reused	12 years ago
Michael DeHaan	0c4b30a471	Aliased node test doesn't make sense locally, so remove it.	12 years ago
Michael DeHaan	9985995a9d	Make tests use the local connection type, fix missing callback in tests.	12 years ago
Daniel Hokka Zakrisson	e74ffd6764	Lookup plugin arguments need to be templated	12 years ago
Daniel Hokka Zakrisson	eebbbd3f0e	Make parameterized playbook includes work with vars as a list ... Fixes #1610.	12 years ago
Daniel Hokka Zakrisson	5752d2a850	Fix lookup plugin test properly	12 years ago
Daniel Hokka Zakrisson	d2dce1d63f	Make lookup plugin replacements part of the main variable logic	12 years ago
Daniel Hokka Zakrisson	f91fa9f765	Fix lookup plugin test	12 years ago
Daniel Hokka Zakrisson	9c095b72b9	Add parameterized playbook includes ... Also makes with_* work with them. Fixes #1162.	12 years ago
Daniel Hokka Zakrisson	383dc30560	Rename varReplaceWithItems to template_ds	12 years ago
Daniel Hokka Zakrisson	43419d7b20	Add tests for lookup plugins	12 years ago
Daniel Hokka Zakrisson	47082a9171	Add $LOOKUP(<lookup plugin>,<data>) as a templating option ... Also moves file and pipe to lookup_plugins.	12 years ago
Daniel Hokka Zakrisson	40af8eff14	Add testcase for first_available_file	12 years ago
Daniel Hokka Zakrisson	56314f7225	Add test case for non-existing variable in varReplaceWithItems	12 years ago
Daniel Hokka Zakrisson	fbda2d4628	Use default port if ansible_ssh_port is not set for the delegated node ... Also add testcase for it.	12 years ago
Daniel Hokka Zakrisson	efe83daf19	Fix ${var.$other_var} and add test cases for it	12 years ago
Michael DeHaan	6ba30170dd	Make group_vars and host_vars available to usr/bin/ansible, and make vars_plugins exist	12 years ago
Michael DeHaan	e04dab904a	Use previous proven multiprocessing logic as the simplification didn't have the same Ctrl-C handling and may ... be subject to race issues, though still don't pass Runner to each. Still seems performant.	12 years ago
Michael DeHaan	f8e946b71d	Merge branch 'varfind-cleanups' of git://github.com/dhozac/ansible into devel	12 years ago
Daniel Hokka Zakrisson	1449c8ac67	Fix ansible_ssh_host again ... This time with unit tests to ensure it keeps working.	12 years ago
Daniel Hokka Zakrisson	c9c5fc1456	Merge varFind and varLookup	12 years ago
Michael DeHaan	cbc12f0dba	Various performance streamlining and making the file features usable in all modules without daisy chaining.	12 years ago
Michael DeHaan	6fa1a49037	Fix the basic templating system such that when the template ends in '$', life continues as normal.	12 years ago
willthames	5a769a5a4d	Fixed tests to reflect desired configuration behaviour ... Test for when environment variable and configuration file variable both set now tests that the environment variable takes precedence Removed logic that would never be triggered from lib/ansible/constants.py	12 years ago
Michael DeHaan	0837a29e51	Only expand lists in templating inside of module action lines, to avoid breaking usage with with_items and "in" statements, etc	12 years ago
Michael DeHaan	7583704144	"force=" code under the file module is problematic, remove it	12 years ago
Michael DeHaan	c5d2f6b0d3	implement lookup plugins for arbitrary enumeration over arbitrary things. See the mailing list for some cool examples.	12 years ago
Jeroen Hoekx	23a62f5a78	Return multiple groups from inventory API.	12 years ago
Jeroen Hoekx	30c019447b	Fix typo in inventory API test script.	12 years ago
Daniel Hokka Zakrisson	695b4bcb46	Allow non-string types in with_items variables	12 years ago
Daniel Hokka Zakrisson	6477bdc6fc	Use a regexp to filter out arguments instead ... pipes.quote is a bit overzealous for what we want to do, quoting ; and other characters that you most likely want to use in your shell invocations. The regexp is the best I could come up with to be able to only replace the parts of the arguments that shouldn't be executed.	12 years ago
Michael DeHaan	22f3aef4dc	remove test for private function that is no longer present	12 years ago
Daniel Hokka Zakrisson	dfee6e19ca	Replace lists with a comma-separated join	12 years ago
Daniel Hokka Zakrisson	4b29c2cf74	Revert pull request #1091 ... Automatic quoting of variables in only_if breaks existing playbooks where entire statements are put in a variable, and other cases. See issue #1120 for details.	12 years ago
Michael DeHaan	06cfc52afd	fix tests and change nosetests flags so asserts show what comparisons failed	12 years ago
Daniel Hokka Zakrisson	9e4fac5ebd	Create a string parser for varReplace instead of using re ... This fixes a few issues, - ${foo}${bar} would be parsed as a variable named foo}${bar, which wouldn't be easily fixed without breaking ${foo.${bar}} - allows escaping . in variable parts so e.g. ${hostvars.{test.example.com}.foo} works This is slower than using re. 3 million templating calls take about about twice as long to complete with this compared to the regexp, from ~65 seconds to ~115 seconds on my laptop.	12 years ago
Daniel Hokka Zakrisson	b55ef665ba	Fix only_if statements referencing non-string types ... This fixes e.g. only_if: ${task.changed} which would always evaluate to true due to it having been replaced by a string for its boolean value. Also adds a test case to ensure it doesn't get missed again.	12 years ago
Daniel Hokka Zakrisson	51216dcfae	Add tests for varReplace repr	12 years ago