Commit Graph

730 Commits (30c8c8e17ed18935c9df7b01302a12b0202f6c01)

Author SHA1 Message Date
Abhijit Menon-Sen 55d51b3946 Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741)
Before this, all spot instance requests would fail because the code
_always_ called module.fail_json when the parameter was set (which it
always was, because the module parameter's default was set to 'stop').

As the comment said, this parameter doesn't make sense for spot
instances at all, so the error message was also misleading.
8 years ago
Florian Dambrine aac55fcc62 Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243) 8 years ago
Matt Ferrante 624f813f60 Properly support tag updates on CloudFormation stack-update actions (#3638) 8 years ago
Kenny Woodson 269c06a4c9 Fix for validate rule. Ensure rule is a dict. (#4640) 8 years ago
Kenny Woodson 9b37dcb593 Getting rid of a None type error when no resource tags are defined. (#4638) 8 years ago
Ryan Brown 0c37949941 Remove spurious `changed` state on iam_policy module (#4381)
Due to a mixup of the group/role/user and policy names, policies with
the same name as the group/role/user they are attached to would never be
updated after creation. To fix that, we needed two changes to the logic
of policy comparison:

- Compare the new policy name to *all* matching policies, not just the
  first in lexicographical order
- Compare the new policy name to the matching ones, not to the IAM
  object the policy is attached to
8 years ago
Rick Mendes 02c47f5b0c Fixes #3144 (#4305) 8 years ago
Ilja Bauer acb7d873f8 Replaced use of bare variables with full variable syntax (#4149) 8 years ago
Richard Adams c8ca1a6211 Add parameter to `ec2` module to control instance shutdown behavior (stop|terminate) 8 years ago
Ryan Brown 8da5e2cb88 Merge pull request #4275 from shaunbrady/ec2_elb_lb_respect_vpc
Make ec2_elb_lb respect VPCs when resolving groups
8 years ago
Ryan Brown a2a6b5247f Merge pull request #4286 from rickmendes/fix-issue-4227
Clarify docs that led to #4227
8 years ago
Shawn Siefkas ec87c517c1 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
8 years ago
Shawn Siefkas 380dbd4369 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
8 years ago
Shawn Siefkas 528f9a1d0b Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Rick Mendes 8287002f14 Fixes #4227: just changing messaging 8 years ago
Rick Mendes 72655fe4c8 Fix #3549, failure to reference `module` in `ec2_eip` module 8 years ago
Ryan Brown 81c663ff71 Merge pull request #4288 from rickmendes/rm-me
please remove me as maintainer
8 years ago
Lyle Mantooth 50abfd5e27 Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Rick Mendes 203b332cdb please remove me as maintainer 8 years ago
Rick Mendes 9cf83ab764 Fixes #4227 8 years ago
Jasmine Hegman a3bae3e6ce Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Shaun Brady de29bafc1e Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
8 years ago
Shaun Brady 8fa56c16ee Remove trailing white space 8 years ago
Shaun Brady 890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Ryan Brown d288ef2abc Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation
Improve `ec2_lc` documentation on security_groups option
8 years ago
Ryan Brown a960f01bf3 Merge pull request #4234 from chrisweaver/patch-1
Enforce `bool` type for dup_ok option on AWS `iam_cert` module
8 years ago
Ryan Brown 95c67dc72a Merge pull request #4231 from phy1729/cfn-iam-capabilities
Support CAPABILITY_NAMED_IAM in AWS CloudFormation module
8 years ago
chrisweaver 8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Matthew Martin 34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 07383c40d7
fixes issues where iam_policy incorrected reported changed 8 years ago
Ryan Brown f61ddbc8a9 Merge pull request #3863 from ryansb/iam-pass-module
Bugfix: IAM group modules need `module` passed
8 years ago
Kai Kousa 7632bc1ecb Improve documentation on security_groups-option 8 years ago
Adrian Moisey 74285d6a53 Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
8 years ago
Matt Davis 0ee7b9896d Merge pull request #4080 from talonx/devel
Fix for #16518 - added missing regions
8 years ago
Ryan Brown 4845c96b00 Remove double-assignment of EC2 parameters (#4081)
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
8 years ago
Hrishikesh Barua 718471e302 Fix for #16518 - added missing regions 8 years ago
Javier M. Mellid a88d6d9a53 Add s3_url requirement in doc when rgw support is enabled in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
Javier M. Mellid a52ff221f7 Add proper version_added for rgw option in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
Javier M. Mellid b1724344d5 Add Ceph RGW S3 compatibility
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:

http://docs.ceph.com/docs/master/radosgw/

This patch adds the required bits to use the RGW S3 RESTful API properly.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
Adam Butler 1c41b6fdb2 Fixes incorrect key name protocols -> protocol (#3963) 9 years ago
Toshio Kuratomi 1d0f408897 Finish python3 syntax compilation fixing for core repo 9 years ago
Bradley Phipps 4a8930f886 added missing colons to documentation (#3913) 9 years ago
Matt Davis a8e5f27b2c Iam trust policy (#3885)
* added support for trust policies

* added version_added to new params in DOC string

* update version_added on new iam args to 2.2
9 years ago
mansunkuo 91e9223a76 Add an example to delete Route53 alias record set (#3834) 9 years ago
Ryan Brown 878cdb10f9 Merge pull request #3847 from washingtoneg/postgres9.5-rds-param-group-support
Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846)
9 years ago
Ryan Brown f54e39450c Merge pull request #2555 from jsternberg/paginate-iam-results
Paginate the results from `boto.iam`
9 years ago
Ryan S. Brown 1b9e28cc68 IAM group modules need `module` passed
The IAM group modules were not receiving the `module` object, but they
use `module.fail_json()` in their exception handlers. This patch passes
through the module object so the real errors from boto are exposed,
rather than errors about "NoneType has no method `fail_json`".
9 years ago
Michael Pappas d26bb2eb41 Prevent ec2group from deleting sgs during check_mode runs 9 years ago
Jonathan A. Sternberg 969471f2ab Paginate the results from `boto.iam`
The default pagination is every 100 items with a maximum of 1000 from
Amazon. This properly uses the marker returned by Amazon to concatenate
the various pages from the results.

This fixes #2440.
9 years ago
Elena Washington e1d7d78fcc Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846) 9 years ago