Commit Graph

35464 Commits (2f7d207d7a98dcd84b66d6531c7a7191291ddb9f)
 

Author SHA1 Message Date
Paul B 9302e8d2a4 contrib(inventory): adds a dynamic inventory for Scaleway cloud (#30313)
provider

Provides a dynamic inventory plugin for Scaleway cloud provider with
the following features:

- Configurable scaleway.ini file
- Cache API responses
- Choose public or private IPs
- Create groups per Scaleway 'tags'
- Create groups per Scaleway regions
7 years ago
Ricardo Carrillo Cruz a56de25df5
Fix persistent command timeout handling (#34791)
* Fix persistent command timeout handling

We were using play context timeout on ansible-connect to set
the persistent command timeout handler. Thus, we were ignoring
the persistent_command_timeout setting.
Moreover, even by changing that on ansible-connection, were again
overriding it on cliconf send_command, since in a same process we can
just set a single alarm and cliconf send_command alarm setup is executed
after ansible-connection alarm setup.

* Remove alarm setting on cliconf send_command

The alarm is set regardless before it is executed by ansible-connection.
Setting an alarm again, overrides/disables the previous ones as a single
process can just have a single alarm set.

* Move the setting of persistent command timeout to network_cli

We do also use ansible-connection for connection local, so if a
user provides a timeout via provider that would be ignored if we
set the value on ansible-connection.
Moving that logic to network_cli plugin constructor makes both
connections to work.

* Remove debug statements

* Set the persistent command timeout on task_executor

We can't set the timeout on ansible-connection nor network_cli,
otherwise tasks using provider timeout won't work.
7 years ago
Tim Rupp c548ab0f18
Refactors and deprecation removals (#34830)
This patch is primarily a refactor to make the validate-modules arg-spec
no longer generate a traceback. It additionally includes removal of deprecated
code in the virtual server module.
7 years ago
Tim Rupp a10aee0fc3
Adds refactors for more f5 modules (#34824)
The main patch is to remove the traceback generating code. There are
other small fixes that were made in addition to doing that.

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg.
* Minor bug fixes made during this refactor.
7 years ago
Tim Rupp 0e4e7de000
Various F5 related fixes for traceback raising (#34820)
The main purpose of this patch is to do the refactor that
supports replacing tracebacks with fail_json. Additionally, the
following was done.

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg.
* Minor bug fixes made during this refactor.
7 years ago
Matt Martz 86e4619dcf
Update echo ansible-vault example with -n as without this, you get a newline. Fixes #34795 (#34823) 7 years ago
René Moser 7bdbe9ab87
vultr: new module vr_startup_script (#34374)
* vultr: new module vr_startup_script

* add integration tests
7 years ago
Tim Rupp eace686044
Various fixes and changes for F5 (#34817)
Primarily, this patch contains refactors to remove tracebacks that
are generated when libraries are missing. There is also,

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg. Minor bug fixes made during this refactor.
7 years ago
dpassante 085a250575 Add new Cloudstack module cs_vpc_offering (#34797)
* Add new Cloudstack module cs_vpc_offering

* fix documentation

* fix returns list

* state=absent example minimalization
7 years ago
Tim Rupp 44a5b3abb4
Various fixes (#34815)
This patch was primarily an effort to reduce traceback errors for
work that sivel was doing. Part of (and in some cases in addition to)
that, the following was done.

* Removed re-def of cleanup_tokens.
* Changed parameter args to be keywords.
* Changed imports to include new module_util locations.
* Imports also include developing (sideband) module_util locations.
* Changed to using F5Client and plain AnsibleModule to prevent tracebacks caused by missing libraries.
* Removed init and update methods from most Parameter classes (optimization) as its now included in module_utils.
* Changed module and module param references to take into account the new self.module arg.
* Minor bug fixes made during this refactor.
7 years ago
Tim Rupp 18d33eeb89
Adds the AFM address list module (#34814)
This module can be used to manage address lists on a BIG-IP running
AFM.
7 years ago
Tim Rupp 9314607c38
Adds selective assignment of kwargs (#34813)
For the f5 module utils, the parameters base class needs to selectively
get args from kwargs
7 years ago
Abhijeet Kasurde 82a0253059
VMware: Add new module: vmware_host_service_facts (#34731)
This adds module to gather facts about VMware host service facts.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Abhijeet Kasurde eabd7eafad VMware: Refactor vmware_host module (#33916)
This fix refactor vmware_host module to use PyVmomi.
Also, handle SSLVerifyFault exception to get hostsystem's certificate
thumbprint.

Fixes: #20819

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Matt Clay d8673ed72a Preserve `test/results/data/` in Shippable jobs. 7 years ago
Matt Martz 2b66d9966c
Add a config toggle for agnostic become prompts, defaulting to False for the 2.5 release. Fixes #33999 (#34761) 7 years ago
Dag Wieers 7957ba7aad
Fix small typo 7 years ago
Bruno 545650c3b1 aci_switch_leaf_selector module (#34041)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* added examples

* Fix pylint errors

* Fix trailing whitespace issue

* Fix one more pylint issue
7 years ago
Bruno 61d50a12e5 aci_access_port_to_interface_policy_leaf_profile module (#34398)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* adding aci_interface_policy_leaf_profile module

* removing unwanted module.. man I always make this mistake

* add aci_access_port_to_interface_policy_leaf_profile module

* added example and integration tests

* Fix pylint errors
7 years ago
Dag Wieers d23d290be8
aci_aep: Add infrastructure_vlan support (infra:ProvAcc) (#33996)
This is a needed enhancement.
7 years ago
Bruno 393c5bea67 aci_switch_leaf_policy_profile module (#33955)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* fixing PR errors

* removing unwanted module from this branch for PR

* removing unwanted module again, rookie git mistakes

* correcting wrong module name

* added examples

* Fix pylint errors

* Fix trailing whitespace
7 years ago
Bruno 837a05fca4 aci_interface_selector_to_switch_policy_leaf_profile module (#34098)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* added new module aci_switch_leaf_selector_node_block for PR

* fixed pep8 issues

* fixed from and to parameter setup in arg spec

* fixed pep8 doc errors

* fixed pep8 indentation error

* adding new aci_interface_selector_to_switch_policy_leaf_profile module for  PR

* removed unwanted module

* added examples

* Fix pylint errors

* Remove whitespace introduced by Github editor
7 years ago
Bruno 007c19095d aci_interface_policy_leaf_profile module (#34364)
* added aci_switch_leaf_policy_profile module WIP

* fixed pep8 errors for PR

* fixed unwanted modifications and fixed pep8 errors

* fixed suggested errors for PR

* adding WIP aci_switch_leaf_selector module

* fixed for pull request

* fixing pep8 errors, bad indents

* improved initial description

* fixed pep8 doc errors

* updated module to include infra:NodeBlk and infra:RsAccNodePGrp instead of having seperate modules for the latter

* fixing pep8

* adding 'name' alias to leaf_selector

* updating example

* updating aliases, forgot 'name' again

* adding aci_interface_policy_leaf_profile module

* removing unwanted module.. man I always make this mistake

* added examples

* Fix pylint errors
7 years ago
Dag Wieers d7d13b48e5
aci_aep_to_domain: New module to bind AEP to domain (#33942)
* aci_aep_to_domain: New module to bind AEP to domain

* Changes to bring in line with aci_domain

* Rename aep_domain to domain_dn, add types

* Fix pylint errors
7 years ago
Matt Clay 3c72161da5 Enable tests which pass on Python 3. 7 years ago
Matt Clay 6969d492d8 Split Windows tests into 4 groups. 7 years ago
Dag Wieers 628eca85c3
ACI: Fixing new pylint issue (#34775) 7 years ago
René Moser e3b5be0887
vr_server: fix assumption returned id is an int (#34765) 7 years ago
Adam Miller d860e13ae1 Add validate_certs to jira module (#34756)
The jira module uses ansible.module_utils.urls.fetch_url which will
attempt to get that value of the validate_certs parameter from the
module; if present it will honor it's value, otherwise it defaults
to True.

This patch adds that parameter to jira so that it can be specified
by the user and honored by ansible.module_utils.urls.fetch_url

Signed-off-by: Adam Miller <admiller@redhat.com>
7 years ago
Ganesh Nalawade 85f300e02b
Fix junos_netconf integration test failure (#34744)
* Fix junos_netconf integration test failure

Set ansible_connection to netconf for junos_command module
in junos_netconf integration test

* Fix review comments
7 years ago
Dag Wieers 83b7ec69fc
Fix pylint issue (#34773) 7 years ago
Dag Wieers 03dd3214b4
Fix new pylint issue (#34772)
Is it all worth it ?
7 years ago
Pilou 00332a49d5 ec2_win_password: fix broken import and minor updates (#34479)
* fix broken import

* ansible.module_utils.ec2.HAS_BOTO is already used

* wait_timeout parameter: use 'int' type

* wait is always True there

* doc: use formatting function
7 years ago
Michael Gugino 607c66f80a Validate apache2 mpm module switching for bug #5328
This patchset updates module integration testing to
validate the changes in PR #5454

This patchset instructs apache2_module to disable all
mpm modules, enable mpm_event, then disable mpm_event
and enable mpm_worker.

This patchset instructs apache2_module to disable all
mpm modules with `ignore_configcheck` set to False
and then disable all mpm modules with `ignore_configcheck`
set to True.

SuSe family of distributions do not ship apache2 with
mpm modules other than prefork. mpm_event and mpm_worker
checks are skipped for SuSe family of distributions.

Fixes: #5328
7 years ago
Matt Martz dcc05093db Validate modules arg spec fixes (#34477)
* Update validate-modules arg_spec introspection to be faster, by only mocking the imports we explicitly list
* The use of types.MethodType in redhat_subscription wasn't py3 compatible, use partial instead
* Remove argument_spec import hacks, make them errors, we can ignore them with ansible-test
* Enable the --arg-spec flag for validate-modules
7 years ago
Matt Martz 42a0d71413
Catch exception comparing role versions, and provide a user friendly error message. Fixes #32301 (#34427) 7 years ago
Matt Clay 96e5cce5ea Ignore pylint errors. 7 years ago
Dag Wieers c3909460d4
aci_domain_to_vlan_pool: Add domain to VLAN pool (#34402)
* aci_domain_to_vlan_pool: Add domain to VLAN pool

A new ACI module to bind a domain to a VLAN pool.

This module still needs integration tests once it is formally review and
accepted.

* Add examples to documentation
7 years ago
Dag Wieers f3193f272c
aci_domain_to_encap_pool: Add domain to encap pool (#34123)
* aci_domain_to_encap_pool: Add domain to encap pool

A new ACI module to bind a domain to an encap pool.

This module still needs integration tests once it is formally review and
accepted.

* Fix domain RN and attributes
7 years ago
Dag Wieers 3127be0e3d
aci_domain: Manage phys, vmm, l2ext, l3ext and FC domain profiles (#34011)
* aci_domain: Manage phys, vmm, l2ext, l3ext and FC domain profiles

A new ACI module from the high priority list.

* Add RHEV VMM provider as Redhat

* PEP compliancy

* Make variables specific to domain

* Add examples
7 years ago
Dag Wieers 0d84e27d0c
aci_firmware_source: Manage firmware image sources on ACI (#34670) 7 years ago
Dag Wieers e0214ece57
aci_vlan_pool_encap_block: New module to manage VLAN encap blocks (#34653)
* aci_vlan_pool_encap_block: New module to manage VLAN encap blocks

This module is a simplified version of the aci_encap_pool_range module.

* PEP8 fixes (closer to the original)

* Add integration tests
7 years ago
Samer Deeb f8884f12bc Mellanox OS name change: MLNXOS changed to ONYX (#34753)
* Mellanox OS name change: MLNXOS changed to ONYX

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* Fix alphabetical order of modules metadata

Signed-off-by: Samer Deeb <samerd@mellanox.com>
7 years ago
David Vilar Benet 57ff84251e Implemented Trigger Repetition (#32938)
* Implemented Trigger Repetition

* Refactorings and integration tests for Trigger Repetition

* Suggestions of first review

* Changes of second review
7 years ago
Nathaniel Case bd989b3088
Report invalid connection types for network modules (#34755)
* Emit error on wrong connection type
7 years ago
Matt Clay 74ac1c2e4a Test cleanup. 7 years ago
chriskarel bb9dcb0d2b Adding "-SyncWindow 0" flag to Compare-Object call (#34656)
Adding "-SyncWindow 0" flag to the Compare-Object call used to determine if the existing and proposed IP address lists are the same.  This makes the array comparison mark changes in order as a difference.

Fix for bug #34651
7 years ago
Matt Clay 2d4a43bb0a
Add file+rule ignore support to validate-modules. (#34757)
* Clean up code.
* Add file+rule ignore support to validate-modules.
7 years ago
René Moser 476030a49c
vr_server: implement startup_script (#34565)
* simplify

* vr_server: implement startup_script
7 years ago
Dag Wieers fbffcb36bf
aci_vlan_pool: Module to manage VLAN pools (#34650)
* aci_vlan_pool: Module to manage VLAN pools

This is a simplified version of the aci_encap_pool module.

* Add integration tests, based on aci_encap_pool
7 years ago