Commit Graph

647 Commits (2d096ea425def32973dbc85cdbd47f37eb3495ed)
 

Author SHA1 Message Date
Lorin Hochstein 9eb12a2b81 Fix postgresql_user bug
If I create a database from scratch and assign permissions by doing:

      - name: ensure database is created
        action: postgresql_db db=$dbname

      - name: ensure django user has access
        action: postgresql_user db=$dbname user=$dbuser priv=ALL password=$dbpassword

Then it fails with the error:

  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 565, in <module>
    main()
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 273, in main
    changed = grant_privileges(cursor, user, privs) or changed
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 174, in grant_privileges
    changed = grant_func(cursor, user, name, privilege)\
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 132, in grant_database_privilege
    prev_priv = get_database_privileges(cursor, user, db)
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 118, in get_database_privileges
    r = re.search('%s=(C?T?c?)/[a-z]+\,?' % user, datacl)
  File "/usr/lib/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or buffer

This fix fixes the problem by not executing the regex if the
db query on pg_database returns None.
12 years ago
Seth Vidal 7c4bbb0a77 add import sys to virt module b/c it needs it if the libvirt python
module is missing
12 years ago
Michael DeHaan 3df57c699e Merge pull request #1000 from mavimo/patch-1
Add support to removes control param
12 years ago
Michael DeHaan e84ba53a45 Merge pull request #1003 from bladypirat/devel
added support for custom port definition for postgresql_* modules
12 years ago
Michael DeHaan a3b67ec039 Merge pull request #1005 from dagwieers/cmdline
Add /proc/cmdline information to the default facts
12 years ago
Jan-Piet Mens cbcd04b692 Add support for RSA/DSA SSH host key detection in setup module for OS/X
s/<8spaces>/<4spaces>/g
12 years ago
Dag Wieers cabbb9fce7 Add /proc/cmdline information to the default facts
The use-case here is that based on information in the /proc/cmdline certain actions can be taken.

A practical example in our case is that we have a play at the end of the provisioning phase that reboots the system. Since we don't want to accidentally reboot a system (or restart the network) on a production machine, having a way to separate an Anaconda post-install (sshd in chroot) with a normal system is a good way to make that distinction.

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "not '${ansible_cmdline.BOOT_IMAGE}'.startswith('$')"

A practical problem here is the fact that we cannot simply check whether it is set or empty:

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "'${ansible_cmdline.BOOT_IMAGE}'"

If ansible_cmdline was a string, a simple only_if: "'${ansible_cmdline}'.find(' BOOT_IMAGE=')" was an option, but still not very "beautiful" :-/

This implementation uses shlex.split() and uses split(sep, maxsplit=1).
12 years ago
Piotr Kweclich 41fde07e98 added support for custom port definition 12 years ago
Marco Vito Moscaritolo c5ee1e7ec9 Add support to removes control param
Execute action only if specified file using param removes exist (execute reverse control of creates).

Some usage eg.:

```yaml
- name: enable apache2 default websites
  action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl

- name: disable apache2 default websites
  action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl
```
12 years ago
Michael DeHaan 08a3079166 Check for ipv6 12 years ago
Michael DeHaan 4223442992 backuplocal => backup_local for API standardization reasons 12 years ago
Michael DeHaan de96d04093 Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel 12 years ago
Michael DeHaan cbb23201b7 Merge pull request #995 from mattupstate/devel
Use `get_bin_path` properly for supervisorctl module
12 years ago
Daniel Hokka Zakrisson aa7feb076e Add backup to assemble 12 years ago
Daniel Hokka Zakrisson 25b34ddb60 Add backups to lineinfile 12 years ago
Daniel Hokka Zakrisson 14eaf79773 Move backup to module_common 12 years ago
willthames 65a0f60c30 Allow ~ expansion in chdir argument of command module
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
12 years ago
willthames 42ed10820b Subversion dest should allow ~ expansion
Used os.path.expanduser on dest to allow e.g. ~/svn/repo as
a destination
12 years ago
Michael DeHaan b0dc015a13 Always pipe stderr in the setup module to avoid JSON interference. 12 years ago
Matt Wright d145e043c7 Use `get_bin_path` properly 12 years ago
Matt Wright 6a67572e83 Fix supervisorctl module after merge issue 12 years ago
Michael DeHaan 2c2113430f chmod +x 12 years ago
Michael DeHaan 47ead9349b Merge branch 'binpath' of https://github.com/sfromm/ansible into devel
Conflicts:
	library/supervisorctl
12 years ago
Michael DeHaan c02e4a0b5a Merge pull request #970 from mattupstate/devel
Improve apt_repository and supervisorctl
12 years ago
Michael DeHaan d622f53c48 Merge pull request #971 from sfromm/seboolean
Add seboolean module
12 years ago
Michael DeHaan a101a532a7 make parameter required 12 years ago
Michael DeHaan 4826341508 Merge pull request #974 from goozbach/add_selinux_module
add selinux module
12 years ago
Derek Carter 33edaf9663 add selinux module 12 years ago
Stephen Fromm 1222cf8de9 Add option required=(True|False) to get_bin_path and update modules
Added required as optional argument to get_bin_path(). It defaults to
false.  Updated following modules to use required=True when calling
get_bin_path():  apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
12 years ago
Matt Wright d36d926bba Update handling of state changes 12 years ago
Matt Wright 46f962210a Move conditional that accounts for variances in distros/versions to work when removing and adding. 12 years ago
Stephen Fromm 5c7828415b Add seboolean module
Will manage values of seboolean on a host.  Options are name (name of
boolean), state (on or off), and persistent (on or off).  Persistent
defaults to no.
12 years ago
Stephen Fromm f0da6b191a Migrate remaining modules to use get_bin_path in module_common.py
* Migraed easy_install, pip, service, setup, and user.
* Updated fail_json message in apt_repository
* Fixed easy_install to not hardcode location of virtualenv in
  /usr/local/bin/.
* Made handling of virtualenv more consistent between easy_install and
  pip.
12 years ago
Stephen Fromm a284228e10 Migrate apt_repository, group, and supervisorctl to use module.get_bin_path 12 years ago
Daniel Hokka Zakrisson 61bc4bc0ed Add a lineinfile module 12 years ago
Michael DeHaan d426afcfb2 Merge branch 'setup-no-dash-facts' of https://github.com/tima/ansible into devel
Conflicts:
	library/setup
12 years ago
Matt Wright b4a091b419 fix bug in supervisorctl module 12 years ago
Timothy Appnel d170c51545 Replace - with _ in setup module key names to avoid variable access problems reported in #954 12 years ago
Michael DeHaan 2d1696f7f7 Remove obsolete comment 12 years ago
Michael DeHaan 9ac906e0fb Merge pull request #951 from gottwald/devel-git-sudo-fix
Added cwd to tempdir in git clone method. Fixes usage with sudo.
12 years ago
Ingo Gottwald 80e53a82d4 Added cwd to tempdir in git clone method. Fixes usage with sudo. 12 years ago
Tim Bielawa a176180693 Change from a module config file to brute force locating the nagios configs so we can find the command file. 12 years ago
Tim Bielawa 7d5b965b32 Nagios is executable now 12 years ago
Tim Bielawa 7e7d6ee7e8 Fix copying that special character 12 years ago
Tim Bielawa 7e5ab54b7f In-line docs. 12 years ago
Tim Bielawa 9a14871cc4 Now reading from a config file actually works. 12 years ago
Tim Bielawa c486930ca8 Services iterate correctly now
Cleaned up return methods
12 years ago
Tim Bielawa d9139020e9 Groundwork for nagios module. 12 years ago
Florian Diebold 8b19fc0ef9 Remove ternary operator to fix python 2.4 compatibility. 12 years ago
Florian Diebold fa2a65588d Support systemd in the service module.
Most of it worked already, except for the enable parameter, because it
tried to use chkconfig which only sees SysV services. First look for
systemctl and use that if it exists.
12 years ago