Commit Graph

5221 Commits (2c433cb707b462e955fdd59854f5ac117bc94ed2)
 

Author SHA1 Message Date
Scott Sturdivant b274fb9774 Fixes #2991: Service module pattern argument ignored. 12 years ago
Lorin Hochstein dbd9d92861 OpenStack Identity (keystone) user module
Module for managing users, tenants, and roles within OpenStack.
12 years ago
Kent Frazier 4c6583bd00 Fix bug with include-level vars and sudo_user.
If a variable was provided for an include, in either of these ways:

    ---
    - hosts: all
      tasks:
      - include: included.yml param=www-data
      - include: included.yml
        vars:
          param: www-data

and then that param was used as the value of sudo_user in the included
tasks:

    ---
    - name: do something as a parameterized sudo_user
      command: whoami
      sudo: yes
      sudo_user: $param

you would receive a "failed to parse: usage: sudo" error back and the
command would not execute.

This seemed to be due to a missing call to template.template somewhere,
because the final value being passed through ssh was still `$param`.
After some digging, the issue seems to instead have been a problem with
providing the wrong context to the template for expansion. Inside the
`Task` logic, it was passing `play.vars` as the context, where
`module_vars` seemed more appropriate. After replacing it, my test case
above ran without issue. There was a comment above suggesting that the
template call might be unnecessary, but removing it made the original
error return, since it is not getting escaped later down the line. I
removed the comment since it was inaccurate.

I tried to actually incorporate my test case above into the test suite
as a regression test, but was unable to figure out how to structure it.
The existing test infrastructure seemed to only be testing for correct
number of counts in things (ok vs. changed, etc.), without regard for
whether the content generated by the command is correct. If there is an
example of a test similar to this one (where I would want to check the
JSON generated to make sure sudo_user had been converted), please let me
know and I will be happy to submit an additional patch.
12 years ago
William Bowling 222f004bfa Fixes apt_repository always reporting file uri repos as changed 12 years ago
bennojoy b16e2a1d48 OpenStack Modules 12 years ago
Bryan Larsen f629baef11 add basename and dirname to the core jinja2 filters 12 years ago
Stoned Elipot d4d0753e03 Allow virtualenv_command argument of the pip module to be a pathname 12 years ago
Stoned Elipot 83cce7d2e0 Fix pip module documentation (YAML quoting) 12 years ago
Michael DeHaan 8f3b2b281f Merge pull request #2967 from jonEbird/devel
Inventory script for Spacewalk servers based on the spacewalk-reports pa...
12 years ago
Jon Miller dc8feb799c Do not need to chmod cache file each time
This is particularly important if you've manually ensured you have write
access via group permissions and not by owner.
12 years ago
Michael DeHaan aecc954aa4 Merge pull request #2965 from bpennypacker/devel
newrelic_deployment bug fix to support both python 2.4 and 2.6
12 years ago
Jon Miller 5111e0c2f7 Inventory script for Spacewalk servers based on the spacewalk-reports package 12 years ago
Bruce Pennypacker d4429fcb91 Fixed handling of urlopen result to work properly under both python 2.4 and python 2.6 12 years ago
Michael DeHaan 753ebea186 Prefer categorized modules to uncategorized, such that if someone does an install on top of old content
the categorized modules will win over the 1.1 uncategorized modules, as the packages may not automatically
clean up the old content.
12 years ago
Michael DeHaan cd57d59913 If ansible is configured to use a log file but cannot write to it, exit, but don't traceback. 12 years ago
Michael DeHaan 496f06c3c9 Pass variables to lookup function for those that want to use them. 12 years ago
Michael DeHaan 16709ecd76 Replace tab with spaces. 12 years ago
Dimos Alevizos e96bc981ce Set paramiko's logging level
Excplicity set paramiko's logging level to WARNING.
By default it inherits ansible's DEBUG logging level (set in
callbacks.py) and fills the log file with useless debug messages.
Obviously it only applies if log_path is set in ansible.cfg
12 years ago
Les Aker 1179d1bbd8 corrected indentation 12 years ago
Les Aker 2adc335481 ignore unicode errors in stdout 12 years ago
Michael DeHaan 14aa54172c Merge pull request #2955 from jarv/devel
pip module blowing up when name is not included in arg list
12 years ago
John Jarvis daf4c358f7 fixes case where name is omitted from pip arg list
This code:
```
    if name.endswith('.tar.gz') or name.endswith('.tar.bz2') or
name.endswith('.zip'):
        is_tar = True
```
was not checking whether name is defined since it is an
optional param.
12 years ago
Michael DeHaan 7dfb29f8f9 Merge pull request #2952 from mmoya/bug-fixes
Don't hardcode chroot path
12 years ago
Michael DeHaan e53a9e5743 Merge pull request #2954 from jarv/devel
fixing syntax error
12 years ago
John Jarvis 423fe82d94 fixing syntax error 12 years ago
Maykel Moya 60f24bb077 Remove unused modules 12 years ago
Maykel Moya f52e3dee70 Don't hardcode chroot executable path 12 years ago
Michael DeHaan 9db256adce Merge pull request #2951 from DazWorrall/vim_swp
Add vim swap files to gitignore
12 years ago
Darren Worrall 0a28d26d6e Add vim swap files to gitignore 12 years ago
Michael DeHaan 5f98c6c246 Merge pull request #2948 from jcbagneris/devel
Fixes in apt module doc: typos, examples
12 years ago
Michael DeHaan 206b34783f Merge pull request #2942 from stoned/doc-requirements
Fix empty requirements specifications in modules documentation
12 years ago
Michael DeHaan 328065506e Merge pull request #2941 from bcoca/setup_bin
no uses get_bin_path for 2nd use of ip tool
12 years ago
Michael DeHaan 39673fe8c0 Merge pull request #2940 from madema/patch-3
-o and -r option don't exist on AIX
12 years ago
Ben Ritcey 0938d4d89a Allow the remote MD5 checks to be run via sudo 12 years ago
Michael DeHaan 8475a92dec Merge pull request #2939 from mmoya/lookup-crypted-passwds
Add support for crypted passwords to password lookup
12 years ago
Michael DeHaan fee3d9004f Merge pull request #2934 from j2sol/git-update
Add an update option to the git module
12 years ago
Michael DeHaan 223e4e2349 Merge pull request #2932 from bcoca/apt_getbins
apt now uses module function to find bin paths
12 years ago
Michael DeHaan 3ecae5f21a Merge pull request #2931 from caredotcom/flowdock_nochange
flowdock module returns changed=false on succes
12 years ago
Michael DeHaan 3cb3c58548 Merge pull request #2926 from stoned/doc-fix
Fix registered variable usage example
12 years ago
Michael DeHaan d4dbb8e96b Merge pull request #2923 from benjixx/fix-package-mentioned-twice
fix package mentioned twice in setup.py
12 years ago
Michael DeHaan 40d2e247ff Merge pull request #2922 from gtmanfred/devel
update archlinux PKGBUILD for pacman 4.1
12 years ago
Michael DeHaan 439c2ef684 Merge pull request #2921 from lwade/ec2_fact_doc
Added a helpful example to the ec2_facts doc.
12 years ago
Michael DeHaan d6048425e3 Merge pull request #2919 from fabulops/campfire_notification_fixes
Campfire Notification Module: Typo fixes, tighter error handling, corrected check mode support
12 years ago
Ton Kersten 8926684942 Fix issue 2906 12 years ago
Michael DeHaan 56e3cef60c Merge pull request #2918 from bcoca/jabber_notchanged
jabber module returns changed=false on success
12 years ago
Michael DeHaan f8a99335dd Merge pull request #2914 from jpmens/notif_unchanged
notification modules irc, mqtt now exit with changed=False
12 years ago
Michael DeHaan e389b00050 Merge pull request #2905 from kjkuan/bugfix-apt-version-comparison
Make package version comparison use globbing.
12 years ago
Michael DeHaan 9a19e8a8ae Merge pull request #2875 from yeukhon/devel
Pip's name key can now accept remote package address.
12 years ago
Yeukhon Wong 08a486fe31 Pip can now accept vcs or tarball as name. Prevented adding mirrors when name is vcs.
**Summary**:

There was a bug in the previous commit; pip module would add --use-mirrors options to a source package when state is absent. The bug is resolved in this commit by checking ``not is_package`` in the if branch.

Furthermore, in order to support non-vcs source name like tarballs, we must not add -e option to the arg list. Given this circumstance, this commit have is_tar and is_vcs and the latter is checked to add -e option. Since mirrors do not make sense with vcs or tarball source, this commit will not add --use-mirrors (default to True) as always.
12 years ago
JcB 33ba919e5f Fixes in apt module doc: typos, examples 12 years ago