Commit Graph

913 Commits (29daa6ffe08c138f09fac3702f8fbe71863eb583)

Author SHA1 Message Date
Brian Coca 89284bcce0 now also captrure OSErrors on temp file
fixes #360
10 years ago
Brian Coca 21fce8ac73 Merge pull request #217 from wimnat/issue-197
Convert symlinks specified in pvs to actual path
10 years ago
Brian Coca d4d5d7cf73 Merge pull request #190 from yuriks/patch-1
crypttab: Fix parameter checking with state=absent
10 years ago
Brian Coca f901fd0160 glusterbin needs to be global 10 years ago
Matthew Vernon 30cf73e83a Fix for issue #353 (handle change in ssh-keygen behaviour)
Prior to openssh 6.4, ssh-keygen -F returned 0 (and no output) when no
host was found. After then, it instead returned 1 and no output. This
revised code behaves correctly with either behaviour. There is
currently no other code path that results in exit(1) and no output.
10 years ago
Brian Coca 7794042cf6 fixed missing parens 10 years ago
Brian Coca 4c0b1b42bc minor fixes to gluster:
- removed functions from main scope
- renamed rebalance function to disambiguate from variable
- updated docs with defaults
- added exception handling to command execution
10 years ago
Tyler Kellen c08ce5b30d correct version_added for known_hosts
It was added in 1.9, not 1.6.
10 years ago
Toshio Kuratomi 2b192c7f8e remove non-ascii quotes from message string
Fixes https://github.com/ansible/ansible/pull/8564
10 years ago
Brian Coca 3f247e2d78 Merge pull request #313 from DavidWittman/12-alternatives-fixes
Fix multiple issues with alternatives module
10 years ago
Brian Coca 09fc1eefe5 Merge pull request #114 from rndmh3ro/patch-1
Added documentation and example for port ranges.
10 years ago
Dustin C. Hatch f8d04bec1b system/lvol: Suppress prompts from lvcreate
Occasionally, `lvcreate` will prompt on stdin for confirmation. In
particular, this may happen when the volume is being created close to
the location on disk where another volume existed previously. When this
happens, Ansible will hang indefinitely with no indication of the
problem. To work prevent this problem, the `--yes` command-line argument
can be passed to `lvcreate`, which will instruct it not to prompt.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
10 years ago
David Wittman 34e7d9c938 Fix multiple issues with alternatives module
- Changes are no longer erroneously reported on RHEL (#12)
 - Adding new link groups on Debian works again.
   - This was broken in a previous commit by assuming the OS was RHEL
     if `update-alternatives --query <name>` had a return code of 2
 - Prefer `--display` over `--query` for determining available
   alternatives
   - --display is more distro-agnostic and simplifies the code
 - Fix missing `msg=` in `fail_json` call when `link` is missing
 - Document that `link` is required on RHEL-based distros

Tested on Ubuntu 12.04+ and CentOS 6/7
10 years ago
Toshio Kuratomi 8baba98ebe Don't know why but the 1.8.x branch didn't include the commit for crypttab.
Update documentation to show it is new in 1.9 as a result of that
oversight.
10 years ago
Dmitry Bashkatov 19d51a51db gluster_volume: remove redundant code 10 years ago
Dmitry Bashkatov 26c2080dcf gluster_volume: use force option during add-brick 10 years ago
Dmitry Bashkatov c6448660a3 gluster_volume: fixes, new "force" option 10 years ago
Richard Gray 7c40201c3d Set default for locale_gen state parameter
Fix the state parameter for the locale_gen module to be non-mandatory
with a default value of 'present', as indicated by the module
documentation.
10 years ago
Matthew Vernon 7a9e6aee90 Changes from Brian Coca's review of this module
These are all the code changes from Brian's review:
* change #! line
* rename "host" to "name" [keep as alias]
* make documentation clearer
* imports 1 per line
* use get_bin_path to find ssh-keygen
* key not actually required when removing host
10 years ago
Matthew Vernon d821a39131 known_hosts: manage ssh known_hosts files with ansible.
The known_hosts module lets you add or remove a host from the
known_hosts file. This is useful if you're going to want to use the
git module over ssh, for example. If you have a very large number of
host keys to manage, you will find the template module more useful.

This was pull request 7840 from the old ansible repo, which was
accepted-in-principle but not yet merged. The mailing list thread
reading it is:

https://groups.google.com/forum/#!topic/ansible-devel/_e7H_VT6UJE/discussion
10 years ago
Brian Coca 41ddb689db Merge pull request #182 from misho-kr/devel
fix lvol module to properly query the size of logical volumes
10 years ago
Brian Coca 405bb040f8 Merge pull request #285 from fuglu/devel
svc: Add kill command (svc -k)
10 years ago
Brian Coca 650d740a3a Merge pull request #196 from alxgu/lvol_fix_casesensitivity
Bugfix PR for lvol: Cast size(LogicalVolumeSize) to lower .
10 years ago
Benjamin Kluck 8a5297c535 svc: Add kill command (svc -k) 10 years ago
Brian Coca 9f11d10135 Merge pull request #181 from sterfield/devel
Allow every type of locales + archlinux fix
10 years ago
SkaveRat 8eabcdcbc6 Fix missing restart method
Script was missing the restart command
10 years ago
Kai de Haan e4f57eae44 svc: Ensure python 2.5 compatibility
* eg. debian lenny
10 years ago
Brian Coca 9219797bb5 Revert "Add listsnapshots property to zfs" 10 years ago
Brian Coca 5148a88e2c Merge pull request #88 from queeno/facter_should_return_puppet_custom_facts
Facter module should return custom facts
10 years ago
Brian Coca 83c051dfd5 Merge pull request #248 from bcoca/fix_alternatives
now properly checks that link is suplied before trying to use it
10 years ago
Brian Coca c7e3aee0f0 now properly checks that link is suplied before trying to use it
should fix #46
10 years ago
Kelley Reynolds 92c30c7c41 Add listsnapshots property to zfs 10 years ago
Brian Coca 3f78475cae daemontools module 10 years ago
Misho Krastev d11e36589a Merge branch 'upstream_devel' into devel
Conflicts:
	system/lvol.py
10 years ago
Sebastien ROHAUT 9cb97b2898 Add "-" to ulimit type
Just edited pam_types to add the '-', as explained in man 5 limits.conf
10 years ago
Giovanni Tirloni cb46aab3d1 add createparent option to zfs create 10 years ago
Hiroshi Umehara 759e032473 Generalize locale name normalization 10 years ago
Rob White adb1f0a1c8 Convert symlinks specified in pvs to actual path 10 years ago
Hiroshi Umehara 42f79478a7 Add EUC-JP locale name normalization
The function normalizes checks for UTF-8, but the same issue exists for
other locales as well.  This fix adds normalization for EUC-JP, a Japanese
locale.
10 years ago
Pierre-Louis Bonicoli 40298a8f24 remove unused variable 10 years ago
Pierre-Louis Bonicoli 25f595c2ba Avoid to use the builtin 'echo'
By default, the interpretation of escape characters could be disabled (bash)
or enabled (dash).
10 years ago
Alexander Gubin e15fba5156 lvol: Cast size(LogicalVolumeSize) to lower to fix the difference between lvs and lvcreate 10 years ago
Brian Coca ffa8abf979 Merge pull request #120 from alxgu/lvol_fix_path
Fix lvol: Find LVM commands in PATH env - Bugfix Pull Request
10 years ago
Yuri Kunde Schlesner 1d60d33dc1 crypttab: Fix parameter checking with state=absent
Only the `name` parameter is required when removing an entry, but the module tried to ensure at least one other parameter was set.
10 years ago
Bert Mertens 3981872375 Fix getent behaviour with fail_key=False 10 years ago
Toshio Kuratomi d4f5b6d41a Fixes for docs building 10 years ago
Misho Krastev 5acc634549 fix lvol module to properly query the size of logical volumes 10 years ago
Sterfield 48ecbd037e Missing import re
I don't even know how it magically worked, but the fact is the code was
correct, and ran OK without the import re.
10 years ago
Sterfield c9656ff3b4 Now allow every type of locales + archlinux fix
The previous version of this code was supporting only locales using the
format "<language>_<territory>.<charset>". But all the locales that
doesn't have this format were not installable (such as "fr_FR" or
"fr_FR@euro").
Also, if an invalid locales was provided, the module kept sending a
"changed" status.

Now :
 * if the user provides an invalid locales, the module failed. Locales
   are verified using /etc/locale.gen or /usr/share/i18n/SUPPORTED if
   Ubuntu
 * Every types of valid locales are now supported.
 * The locale module was not working on Archlinux, as there's no space
   between the "#" and the locale. This is now supported. Credits goes
   to danderson189, this is his code.

This module was tested on debian jessie, ubuntu 14 LTS and last
Archlinux.
10 years ago
Nicolas Brisac 5462748553 Merge remote-tracking branch 'upstream/devel' into devel 10 years ago
Brian Coca 3e7da5366b Merge pull request #176 from bcoca/gluster_volume_docfix
fixed doc bug
10 years ago
John Barker 9efac37b1b Add a note about debconf passwords always being recorded as changed 10 years ago
Brian Coca 2e6b94047d fixed doc bug 10 years ago
Sebastien ROHAUT 4c22ee75b1 Update pam_limits.py
- Comments are now managed correctly
- Cannot use use_min and use_max at the same time
10 years ago
Timothy Vandenbrande b365fc4464 added a source/network add/remove to/from zone for firewalld - removed useless comment 10 years ago
Timothy Vandenbrande 6fab8f49a9 added a source/network add/remove to/from zone for firewalld 10 years ago
Nikolai Lifanov 1be1aacadf fix at.py module on non-glibc systems 10 years ago
Cosmo Petrich 443d7683a0 Remove default from 'permanent' and 'state' docs
These fields are both required, and thus do not actually have defaults.
10 years ago
Brian Coca 108db556a0 Merge pull request #136 from bcoca/gluster_revamp
revamp of gluster volume management
10 years ago
Brian Coca fdd41fb95c Merge pull request #1 from mscherer/devel
Add a new option immediate= to immediately apply a permanent change
10 years ago
Brian Coca 6725d5188d revamp of gluster volume management
also implemented deleting a volume
10 years ago
Toshio Kuratomi 19e688b017 Fixes to documentation 10 years ago
Michael Scherer 62cae242cf Add a new option immediate= to immediately apply a permanent change
Currently, either you apply the change in the configuration
of firewalld ( without permanent=True ), or you apply it live.
I most of the time want to do the 2 at the same time, ie open the
port ( so I can use the service ) and make sure it stay open on reboot.
10 years ago
Brian Coca 9e798ec6bc Merge pull request #48 from rosmo/glusterfs-module
Added GlusterFS module.
10 years ago
Brian Coca 52f526c360 Merge pull request #17 from abompard/devel
Module alternatives: support RedHat-based OSes
10 years ago
Brian Coca cbfabba9e3 Merge pull request #7 from groks/crypttab-module
New crypttab module for editing Linux /etc/crypttab file
10 years ago
Alexander Gubin 20ef2696bc Fix lvol: Find LVM commands in PATH env 10 years ago
Brian Coca e64751b0eb Merge pull request #53 from bcoca/getent_doc_fixes
corrected and made better docs for getent
10 years ago
Sebastian Gumprich 040135dbba Added documentation and example for port ranges.
Also added punctuation marks.
10 years ago
Nicolas Brisac 1e3645a9e3 Allow filtering of routed/forwarded packets
MAN page states the following :

    Rules for traffic not destined for the  host  itself  but  instead  for
    traffic  that  should  be  routed/forwarded through the firewall should
    specify the  route  keyword  before  the  rule  (routing  rules  differ
    significantly  from  PF  syntax and instead take into account netfilter
    FORWARD chain conventions). For example:

        ufw route allow in on eth1 out on eth2

This commit introduces a new parameter "route=yes/no" to allow just that.
10 years ago
Brian Coca 664858ec20 Merge pull request #56 from filipenf/fix-lvg
LVG module fix when using multiple devices (string to list)
10 years ago
Sebastien ROHAUT 722d810ef2 Update pam_limits.py
Change path
10 years ago
Sebastien ROHAUT c8fbac0ff2 Update pam_limits.py 10 years ago
Sebastien ROHAUT b845c0ef56 Update pam_limits.py 10 years ago
Sebastien ROHAUT 8122edd727 Update pam_limits.py
Tabs...
10 years ago
Sebastien ROHAUT e5939fffdd Create pam_limits.py
The pam_limits module modify PAM limits, default in /etc/security/limits.conf.
 For the full documentation, see man limits.conf(5).
10 years ago
Taneli Leppä 2d495f7e6e Added .py extension to glusterfs module. 10 years ago
Simon Aquino 4dd6c8204a Facter module should return custom facts
The ansible facter module should also return puppet custom facts by
default.
10 years ago
Franck Nijhof 130bd670d8 Small fix for boolean when boolean type was set via a variable (somehow changes the behaviour of Ansible because of YAML as it seems. Booleans then become represented as a string). 10 years ago
Franck Nijhof 2c43cdb123 Renamed module from mac_defaults to osx_defaults so the naming is more up to par with existing modules (e.g. osx_say) 10 years ago
Chris West 613b3bdda0 Enable "ufw default allow routed"
* The policy is shown in `status verbose`, so all the check mode stuff should keep working.
 * `--dry-run` works as expected.
 * No idea whether it's legal as an argument to `interface`
10 years ago
Franck Nijhof a55035c558 Added module for managing Apple Mac OSX user defaults 10 years ago
Filipe Niero Felisbino 6cfb97a1c8 Replace dev_string to dev_list 10 years ago
Brian Coca b0d5733fd0 corrected and made better docs for getent 10 years ago
Taneli Leppa 6dc09c966c Added GlusterFS module. 10 years ago
Baptiste Mispelon 827da3ae1a Fixed typo in locale_gen documentation. 10 years ago
Dan Keder 838d05ba42 Add module system/seport.py
Module for managing SELinux network port type definitions
10 years ago
jravetch c89ce9e8d7 mkfs.xfs uses -f instead of -F flag
mkfs.xfs uses the -f instead of -F flag to force creating a filesystem on a devices that have an existing filesystem
10 years ago
Aurélien Bompard 6b5aa62854 Module alternatives: support RedHat-based OSes
RedHat-based OSes have a version of update-alternatives which comes from
the chkconfig package and does not support the --query parameter. Work
around that.
10 years ago
Aurélien Bompard b645dd330c Module alternatives: support check mode 10 years ago
Steve 26f58a8eb7 New crypttab module for editing Linux /etc/crypttab file 10 years ago
Michael DeHaan 110250d344 package files 10 years ago
Michael DeHaan b1e789968b File extensions! 10 years ago
Michael DeHaan 50f105578a Restructuring. 10 years ago
Michael DeHaan 73123b69fa Move modules into subdirectory. 10 years ago
Toshio Kuratomi 8b81062be0 The fix for gh-7284 causes problems for initscripts which have the
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
10 years ago
Michael Scherer c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 10 years ago
Toshio Kuratomi 7b100dd389 Be more specific in checking if a job restarted successfully.
Fixes: #9056
10 years ago
Toshio Kuratomi 36083c3b90 Failure to enable a service now fails the task
Fixes: 8855
10 years ago
Toshio Kuratomi a50258d26a remove debugging that was causing failure 10 years ago
Toshio Kuratomi 2e16bd3a44 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi 104401805b Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
10 years ago
Toshio Kuratomi c362902f50 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi a9928492f7 Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
10 years ago
James Cammarata 7edcf21bdc Move initscript rc check to later in service status check
Fixes #7284
10 years ago
Michael DeHaan 5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 10 years ago
Patrik Lundin 0abf14ff19 service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
10 years ago
James Cammarata 30d6713bf0 Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
10 years ago
Eri Bastos 6f8a29dc3d Proposed fix for issue #7757 10 years ago
James Cammarata c8376e296f Tweaking change to documentation language for cron name param 10 years ago
James Cammarata 509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 10 years ago
James Cammarata 07e77c5bed Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
10 years ago
James Cammarata 1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
10 years ago
Matt Parker 6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
10 years ago
Matt Parker 5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
10 years ago
Johann Schmitz 7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 10 years ago
Ding Deng 85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 10 years ago
Michael DeHaan 60ce2d3853 Fix documentation builds. 10 years ago
Michael DeHaan f21d6c7980 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
10 years ago
Michael DeHaan 185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
10 years ago
Michael DeHaan 66ec9089bd Update docs. 10 years ago
Michael DeHaan f6f184b36d Updating docs. 10 years ago
Brian Coca aeeefd046f bumped to 1.7 10 years ago
Brian Coca 5aa2ca762a added control to fail or not on missing key
made split 'smarter' but still overridable
10 years ago
Brian Coca 391f8ec600 added getent module to get system data as facts 10 years ago
Serge van Ginderachter 961d4b0d6c execute the mount after path validation
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
10 years ago
Jonathan Mainguy 650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 10 years ago
Michael DeHaan e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
10 years ago
Michael DeHaan bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
10 years ago
Michael DeHaan 2212b64fd9 Cleaning up explanation of mount module states. 10 years ago
Bjorn Neergaard cbc417ca1b Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
10 years ago
Michael DeHaan 99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 10 years ago
Michael DeHaan caba7ac6a6 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
10 years ago
James Cammarata 03f0d6bec8 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
10 years ago
Robin Roth 7920f4eaf5 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
10 years ago
Robin Roth a26bc9c926 Extended distributions list for hostname module
Implementations already present
10 years ago
Tom Lazar d89adce760 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
10 years ago
Philip Jay bb7b290ed8 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
10 years ago
Berend de Boer f46c4ee093 Default for fstab missing, causing KeyError: 'fstab' 11 years ago
James Cammarata 6879e4ff0a Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
11 years ago
Sébastien Gross e0f7b3f39c [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
11 years ago
Sébastien Gross 806052a9e5 [mount] Add documentation for fstab option 11 years ago
Hector Acosta 60edb6b04b Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
11 years ago
Yasser Nabi 8cc894bef2 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
11 years ago
Michael DeHaan 96fe275946 Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
11 years ago
Ruggero Marchei ae95ebd075 fix LooseVersion exception with empty distribution_version 11 years ago
Peter Hall ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group
key
11 years ago
Ruggero Marchei 8d01986617 fix issue #8102 11 years ago
Cristian Ciupitu 72d6e6d805 Remove useless code 11 years ago
Michael Leer 39b34b008c add interfact documentation #7704 11 years ago
Prune afb358af77 added missing force flag on mkfs commandline
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
11 years ago
Markus Amalthea Magnuson a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
11 years ago
James Cammarata 936daf6f63 Updating the other classes in the group module to match #7249 11 years ago
James Cammarata 4ca9ebf084 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
Allow group module to handle check_mode properly when group.state=present and group already exists
11 years ago
James Cammarata 236a2989cc Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names 11 years ago
James Cammarata ad4926e090 Update authors for modprobe module 11 years ago
James Cammarata 974693882e Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name 11 years ago
James Cammarata 6ad83bb5ce Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 11 years ago
Michael DeHaan 4fbc2a83e0 Merge pull request #7861 from cchurch/devel
Windows Remote Support
11 years ago
David Stygstra cae41d0931 Added author and copyright lines to modules I contributed 11 years ago
Michael DeHaan 8b262d775b Slight tweak to windows wording. 11 years ago
Matt Martz cab68bc579 Mention that with windows target hosts, fact_path and filter are not currently supported 11 years ago
James Cammarata 2c22cf46cf Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763 11 years ago
James Cammarata 34405ea905 Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix 11 years ago
Ilya Rusalowski b1a31ebb84 Set default vg_options to empty string 11 years ago
Ruggero Marchei f522425415 move get_distribution_version() to basic.py 11 years ago
Ruggero Marchei bd69e9f265 use different strategy for RHEL >= 7. Fixes 7763 11 years ago
James Cammarata d35d5ac9d1 Merge pull request #7741 from mgcrea/devel
Add support for Linaro distribution in hostname module
11 years ago
James Cammarata 3e04d8c70c Merge pull request #7737 from toddmowen/zfs-fix-7696
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
11 years ago
Olivier Louvignes 158d6276eb Add support for Linaro distribution in hostname module 11 years ago
Todd Owen 34517b0836 zfs: work around incompatibility by renaming share.nfs to sharenfs
Fixes #7696
11 years ago
rgbkrk 5591e8838d Error checking and reporting on interface ufw rule 11 years ago
Ron Gomes 73246a49dc Fix incorrect argument ordering in error message, which provokes a
printf-related TypeError.
11 years ago
Yann Coleu f378ed643c Add primary group in the first user module doc example 11 years ago
Nicolas Brisac ecda1455bf open_iscsi module: support RC 21 when listing logged-in target 11 years ago
Brian Coca 5c87e97a45 now module searches for update-alternatives vs hardcoding it 11 years ago
James Cammarata 3a8ebd4325 Pull the link out of the alternatives output when not specified
Fixes #7414
11 years ago
Adam Chainz 6b10cf756a Fix grammar and value errors in cron documentation 11 years ago
Luca Berruti eca36953c8 Make alternatives module python 5 compatible 11 years ago
Jean-Francois Chevrette 8756612599 this should return 0 to indicate a non-failure when check_mode is True 11 years ago
Antti Salminen a6b482c500 Switch to mapper device name if pvs returns the wrong one. 11 years ago
Carlos E. Garcia 4dcaa9d9fb multiple spelling error changes 11 years ago
Michael Scherer 4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
11 years ago
Chris Lamb b123b648a0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
11 years ago
Michael Scherer cf3365b99e Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
Hernandes B. de Sousa 780b5e0bbf Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
11 years ago
James Cammarata 0c96e2f33b Check to make sure the firewalld client is connected before proceeding
Fixes #6911
11 years ago
Jonathan Davila a90aa46ed2 Added example demonstrating other functionality 11 years ago
James Tanner 0025273fca Fixes syntax error in cron module caused by #6870 11 years ago
Eric Lake 58dccfbc29 Adding bold to service doc to call up state and enabled. 11 years ago
MorrisA ac72d44219 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
11 years ago
Serge van Ginderachter 867702b26a lvg module bugfix on vg_options patch
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
11 years ago
Michael DeHaan 3d8997d219 Name is not required, update docs. 11 years ago
Michael DeHaan 7258c15ce1 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
11 years ago
Andrew Resch 32e5383bef Fix _parse_value always returning 0 when not true, false or None. 11 years ago
Joshua Lund 74962a0e35 Update cron module documentation. The 'name' parameter is required. 11 years ago
Michael DeHaan 5826e1354a Slightly revise wording. 11 years ago
Michael DeHaan ff2177442b Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 11 years ago
Michael DeHaan 4917f4a48f Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
11 years ago
James Cammarata 57adad7097 Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
11 years ago
Michael DeHaan 05551cfe51 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
11 years ago
James Cammarata 09c998f104 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
11 years ago
John Barker ed4717a978 debconf correctly quote strings 11 years ago
John Barker e4a779d4dd debconf detail requirements and fix typos 11 years ago
Tim G 32d48d75e9 Bugfix, fix crontab commands on HP-UX 11 years ago
Michael Scherer ba9f910ec9 fix typo in the capabilities module description 11 years ago
Adam Nielsen b35086c7a3 More descriptive error message if init system is unknown 11 years ago
Ahti Kitsik 74fa705e20 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
11 years ago
Michael DeHaan 85320532d4 Rename vgoptions to vg_options. 11 years ago
Michael DeHaan 07423c1714 Merge branch 'devel' of git://github.com/chamill/ansible into devel
Conflicts:
	library/system/lvg
11 years ago
Michael DeHaan 9fa0ec57fb Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 11 years ago
Michael DeHaan 073d34b40e Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
11 years ago
Michael DeHaan d3d1c8ce9a Merge pull request #6630 from bigl0af/devel
Modified library/system/user so that password change date is set on Sola...
11 years ago
Michael DeHaan 1e747e00e5 Merge pull request #6296 from jdauphant/devel
Add linux module parameters for the modprobe module
11 years ago
Cristian Ciupitu 7a4270184a Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Ahti Kitsik c757b6624f Fixed ufw module doc tags, it's reset everywhere, not reseted. 11 years ago
Seth Woodworth 21b7c358ee adds missing `'` to debconf examples 11 years ago
Pierre-Louis Bonicoli 9a140881be Fix ValueError when selection contains a colon 11 years ago
David Fox 01acd73e30 Modified library/system/user so that password change date is set on Solaris when updating password 11 years ago
Till Maas 35f9e62422 service module: Properly disable Debian services
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
11 years ago
Till Maas a063987d0e authorized_key: Be more specific about manage_dir
- Explain which properties are managed when manage_dir is True.
11 years ago
Michael DeHaan 7f36630dd5 Add capabilities module. 11 years ago
nate@bx.psu.edu 2daee9ed20 Bugfix for xattrless files and the capabilities module. 11 years ago
nate@bx.psu.edu c19e4a7d0b Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8). 11 years ago
James Cammarata 9f9c077878 Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 11 years ago
James Tanner 4028f55c04 Fixes #6519 Properly handle state=absent in sysctl module 11 years ago
Michael DeHaan ba99056948 Version bump for alternatives module, changelog. 11 years ago
Gabe Mulley 4c132c11f7 add a module for update-alternatives 11 years ago
Michael DeHaan 29a3a1d516 Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
license -- so usage of facts code in modules will be limited to GPLv3 modules.
11 years ago
Michael DeHaan c914e9e462 Update setup module signature from merge commit. 11 years ago
Michael DeHaan cac81b1ad9 Merge pull request #6339 from threatgrid/systemd-template-svc-fix
systemd template services must not discard template part
11 years ago
Michael DeHaan 790a38e25d Merge conflict. 11 years ago
Michael DeHaan 201297cbfe Merge pull request #6175 from AdmiralNemo/fix-filesystem
filesystem: Ignore blkid cache
11 years ago
Michael DeHaan d4de77fd45 Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name
Normalise the module name when comparing against the module names in /proc/modules
11 years ago
Michael DeHaan bf33be20e1 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
11 years ago
Cristian Ciupitu a416dba3d1 hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
James Tanner 59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 11 years ago
Michael DeHaan 29138b1872 More shell updates 11 years ago
Richard C Isaacson 9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 11 years ago
Ryan 3494d67f30 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
11 years ago
Michael DeHaan 65c4e388eb Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
11 years ago
James Laska cb63352aff Fix issue#6430 by instantiating Network() with expected arguments 11 years ago
Richard C Isaacson 7d83f64bae Fix docstring issue. 11 years ago
Richard Isaacson 19d77ada25 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
11 years ago
James Tanner e63e909d6f Fix name in locale_gen docstring 11 years ago
James Tanner 4fae7da5e8 Fix snippet imports and version_added in ufw module 11 years ago
James Cammarata 6a81debb0a Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
11 years ago
James Tanner 820c328ca8 Set version_added for locale_gen 11 years ago
James Tanner 3763008d15 Rename locale module to locale_gen 11 years ago
James Cammarata 52d14d0fee Merge pull request #5411 from AugustusKling/locale
locale module
11 years ago
Michael DeHaan e767de4978 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
11 years ago
James Tanner fc33860e5d Force command action to not be executed by the shell unless specifically enabled 11 years ago
Matthew Riedel d21a8f6ddc Returning 'NA' when no virtualization found 11 years ago
Richard C Isaacson 3188429105 Some cleanup. 11 years ago
Charles Duffy 532cda524f #6341: use shared function for parsing systemd status; check rc code 11 years ago
Charles Duffy fd5083fe71 #6341: check systemd service status with show subcommand 11 years ago
Jarno Keskikangas 19fb807824 Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
11 years ago
Jarno Keskikangas 9abdacc725 Insert rule to a specific num. 11 years ago
Jarno Keskikangas 76eb4969fb Fix typo: 'reseted' -> 'reset'. 11 years ago
Jarno Keskikangas b8f37df8e7 Add protocol options 'esp' and 'ah'. 11 years ago
Jarno Keskikangas 767cfcb0bd Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
11 years ago
Aleksey Ovcharenko 4754bf47be New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
11 years ago
Richard C Isaacson ce98edfc87 Cleaning up pep8 alerts. 11 years ago
Richard C Isaacson bdfb2de7fc Documentation cleanup. 11 years ago
Richard C Isaacson a94e1e5477 Refactored a few things to be more inline with the Ansible way. Passing testing. 11 years ago
Charles Duffy 32620cab4d systemd template services must not discard template part 11 years ago
jctanner b105942654 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
11 years ago
Julien DAUPHANT 7ce4eba507 Add version_added 1.6 for the params modprobe option 11 years ago
Julien DAUPHANT c95b358694 Add linux module parameters for the modprobe module 11 years ago
anatoly techtonik 63f0a644ac setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 11 years ago
James Tanner 87f17e7e94 Fix debconf docstring indentation 11 years ago
James Tanner b07e5742b3 Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 11 years ago
Brian Coca a4f6a12181 didnt make 1.5 ... lets see 11 years ago
Brian Coca a7444f5178 added better gentoo/funtoo support 11 years ago
Michael DeHaan d71921492b Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
11 years ago
Laurens Van Houtven c50b772e61 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
11 years ago
James Cammarata 08fca488f3 Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
11 years ago
Dustin C. Hatch d2dc260e98 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
11 years ago
Chris Church 09b076e39c Fix setup module to gather facts from PowerPC Macs. 11 years ago
James Cammarata 8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
C. Morgan Hamill c29f2fb888 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
11 years ago
Nils Pascal Illenseer 7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden c892f51002 Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca 01a1482f1a hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca 4b0c2d839e made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca 8a6a2aba75 changes names to name in example 11 years ago
Brian Coca ddb191f208 fixes as per feedback 11 years ago
Tom Dymond c9e7541e60 Reworked PR to avoid repeating the command 11 years ago
jctanner 4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond 16edbd3181 Add option to enable the sysctl -e option 11 years ago
kustodian 405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 931f8e4c5b Add move_home option to user module 11 years ago
Richard C Isaacson cc20868bfb Tested implementation adding action option for (add, delete, unique). 11 years ago