ansible

Commit Graph

Author	SHA1	Message	Date
Toshio Kuratomi	52449cc01a	AnsiballZ improvements Now that we don't need to worry about python-2.4 and 2.5, we can make some improvements to the way AnsiballZ handles modules. * Change AnsiballZ wrapper to use import to invoke the module We need the module to think of itself as a script because it could be coded as: main() or as: if __name__ == '__main__': main() Or even as: if __name__ == '__main__': random_function_name() A script will invoke all of those. Prior to this change, we invoked a second Python interpreter on the module so that it really was a script. However, this means that we have to run python twice (once for the AnsiballZ wrapper and once for the module). This change makes the module think that it is a script (because __name__ in the module == '__main__') but it's actually being invoked by us importing the module code. There's three ways we've come up to do this. * The most elegant is to use zipimporter and tell the import mechanism that the module being loaded is __main__: * `5959f11c9d/lib/ansible/executor/module_common.py (L175)` * zipimporter is nice because we do not have to extract the module from the zip file and save it to the disk when we do that. The import machinery does it all for us. * The drawback is that modules do not have a __file__ which points to a real file when they do this. Modules could be using __file__ to for a variety of reasons, most of those probably have replacements (the most common one is to find a writable directory for temporary files. AnsibleModule.tmpdir should be used instead) We can monkeypatch __file__ in fom AnsibleModule initialization but that's kind of gross. There's no way I can see to do this from the wrapper. * Next, there's imp.load_module(): * https://github.com/abadger/ansible/blob/340edf7489/lib/ansible/executor/module_common.py#L151 * imp has the nice property of allowing us to set __name__ to __main__ without changing the name of the file itself * We also don't have to do anything special to set __file__ for backwards compatibility (although the reason for that is the drawback): * Its drawback is that it requires the file to exist on disk so we have to explicitly extract it from the zipfile and save it to a temporary file * The last choice is to use exec to execute the module: * https://github.com/abadger/ansible/blob/f47a4ccc76/lib/ansible/executor/module_common.py#L175 * The code we would have to maintain for this looks pretty clean. In the wrapper we create a ModuleType, set __file__ on it, read the module's contents in from the zip file and then exec it. * Drawbacks: We still have to explicitly extract the file's contents from the zip archive instead of letting python's import mechanism handle it. * Exec also has hidden performance issues and breaks certain assumptions that modules could be making about their own code: http://lucumr.pocoo.org/2011/2/1/exec-in-python/ Our plan is to use imp.load_module() for now, deprecate the use of __file__ in modules, and switch to zipimport once the deprecation period for __file__ is over (without monkeypatching a fake __file__ in via AnsibleModule). * Rename the name of the AnsiBallZ wrapped module This makes it obvious that the wrapped module isn't the module file that we distribute. It's part of trying to mitigate the fact that the module is now named __main)).py in tracebacks. * Shield all wrapper symbols inside of a function With the new import code, all symbols in the wrapper become visible in the module. To mitigate the chance of collisions, move most symbols into a toplevel function. The only symbols left in the global namespace are now _ANSIBALLZ_WRAPPER and _ansiballz_main. revised porting guide entry Integrate code coverage collection into AnsiballZ. ci_coverage ci_complete	6 years ago
Matt Clay	72f1a6cc1f	Fix bug preventing coverage of setup module.	6 years ago
Matt Martz	a19a21d715	Add --include and --omit options to ansible-test coverage report (#38061 ) * Support --include and --omit with ansible-test coverage report * Code format change	7 years ago
Matt Clay	5ea8a5e34b	Add support for setup targets to ansible-test. (#28544 ) * Add support for setup targets to ansible-test. * Code cleanup.	7 years ago
Matt Clay	869e90e12a	Don't fail coverage reporting due to parse errors.	7 years ago
Matt Clay	45e377566c	Refactor ansible-test config classes. (#26505 ) * Move Config classes from executor.py to config.py. * Move Environment and Test config to config.py. * Move Coverage/CoverageReport Config to config.py. * Clean up type hints.	7 years ago
Matt Clay	fba76444e0	Add `ansible-test coverage report --show-missing`.	7 years ago
Matt Clay	4daa16f9ce	Add --all and --stub coverage options. ci_coverage ci_complete	8 years ago
Matt Clay	6a2a7a2392	Enable codecov.io and add coverage grouping.	8 years ago
Matt Clay	dfd19a812f	Miscellaneous bug fixes for ansible-test. - Overhauled coverage injector to fix issues with non-local tests. - Updated integration tests to work with the new coverage injector. - Fix concurrency issue by using random temp files for delegation. - Fix handling of coverage files from root user. - Fix handling of coverage files without arcs. - Make sure temp copy of injector is world readable and executable.	8 years ago
Matt Clay	c87ebb6215	Deduplicate arcs when combining coverage data. (#22022 )	8 years ago
Matt Clay	2804d2e848	Split up unit tests on Shippable. (#21931 ) * Add more verbose output to coverage combine. * Run unit tests on CI separately by version.	8 years ago
Matt Clay	4ba9f63afe	Use multiple AWS regions in ansible-test. (#20429 ) * Move ansible-test EnvironmentConfig to util. * Use multiple AWS regions in ansible-test.	8 years ago
Matt Clay	6bbd92e422	Initial ansible-test implementation. (#18556 )	8 years ago

14 Commits (27c10fa502ca5ba95ffd80ac602ca49965a1936b)