Commit Graph

469 Commits (27b1310ec6fb11b27d2bbe9b4e261355f6eaedfa)

Author SHA1 Message Date
James Cammarata 30a7658b90 Merge pull request #7914 from hacosta/devel
Correctly handle .repo files in zypper_repository module
11 years ago
Michael DeHaan d0006f0d2a Merge pull request #8118 from oxyrox/devel
Typo
11 years ago
Michael DeHaan cc4c7b1d56 Merge pull request #8111 from hfinucane/gh-8108
Fix pip failure when version is parsed as a float
11 years ago
Michael DeHaan e138613db9 Merge pull request #8106 from muff1nman/pacman-update-checkmode-fix
Fix #8047
11 years ago
Aladin Jaermann 8dc0328fed Correct typo 11 years ago
Henry Finucane ec221ae59a Ensure version is a string 11 years ago
Andrew DeMaria 65e27c3375 Fix #8047
Ensure that json is returned when only updating the cache and in check mode
11 years ago
Dustin C. Hatch fbcf39e1e1 Correct regex in is_keyid
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
11 years ago
Hector Acosta b5fe46d48c Correctly handle .repo files in zypper_repository module
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
11 years ago
James Cammarata 8e6a60dfd6 Merge pull request #7942 from sidred10/devel
Fixed FreeBSD ports install issue
11 years ago
sid 2f02d27744 Fixed FreeBSD ports install issue 11 years ago
Maxim Odinintsev f4c183f5b8 Successfull exit if sync=yes and no package provided 11 years ago
Maxim Odinintsev f4774a71b7 Success exit if sync=yes and no package provided 11 years ago
James Cammarata 1320f862de Merge pull request #7930 from trbs/apt_key_fetch_url_failure_codes
apt_key clear message when downloading key returns an (http) error code
11 years ago
George Yoshida 284476d4ec In the yum module example, use present/absent instead of installed/removed 11 years ago
trbs e12d09861f apt_key clear message when downloading key returns an (http) error code 11 years ago
Sam Hanes ed1aef3fa5 Restore #6484 reverted by c751168. 11 years ago
James Cammarata 46100f5bc4 Merge branch 'upgrade-release' of https://github.com/amenonsen/ansible into amenonsen-upgrade-release 11 years ago
yuyak 54fdd5416b Fix typo in apt module documentation 11 years ago
James Cammarata 9e8bbd8eac Merge pull request #7801 from koenpunt/npm-rbenv-exec
Allow gem executable to contain spaces
11 years ago
Koen Punt 6c20fa0d6f Allow gem executable to contain spaces
rbenv has a special exec function which loads the correct ruby version before executing a command.
The syntax for this is `/usr/local/rbenv/bin/rbenv exec gem ...` for example.
But previously when specifying executable='/usr/local/rbenv/bin/rbenv exec gem' this would not work because the string was treated as one executable. This PR fixes that by splitting the executable on spaces.
11 years ago
Koen Punt ec9e6e1cd6 Allow executable to contain spaces
NVM has a special script which loads the correct node version before executing a command.
The syntax for this is `/usr/local/nvm/nvm-exec ...`, so `nvm-exec npm list --json` for example.
But previously when specifying `executable='/usr/local/nvm/nvm-exec nvm'` this would not work because the string was treated as one executable.
11 years ago
James Cammarata 1bec2e7eb7 Minor cleanup of openbsd_pkg example comment 11 years ago
James Cammarata adb9feaf83 Merge pull request #7774 from mwpher/devel
[openbsd-pkg] Add note regarding package flavors
11 years ago
Todd Owen 198048c356 Fix in pkgutil: don't call pipes.quote() on None.
In this function, 'site' may be None, which will cause an exception
if it is passed to pipes.quote().
11 years ago
Matthew Pherigo 09e7cc2aa6 [openbsd-pkg] Add note regarding package flavors
This adds a note to the openbsd-pkg module which explains how to specify
package flavors as well as how to avoid ambiguity errors on a package
with multiple flavors.

Technically, this is not Ansible-specific, but it's pretty likely the
user will encounter this problem.
11 years ago
James Cammarata 9d86d41741 Cleaning up svr4pkg commit fix for #7645 11 years ago
James Cammarata eb57ceee96 Merge branch '7645' of https://github.com/kcghost/ansible into kcghost-7645 11 years ago
Casey Fitzpatrick 6a5ad84656 fix for svr4pkg module failure reporting, issue #7645 11 years ago
Jean-Frédéric ea78ad9906 Fix documentation of deb option in apt module
The apt module may install a .deb package on the remote machine, not on the local.
Fix the misleading documentation.
11 years ago
Andrew Resch da7835da1d Fix typo in variable name 11 years ago
Andrew Resch 5016dc40fc Replace CommandException with Exception 11 years ago
Daniel Jaouen 3b38077246 Add `upgrade_all` option to homebrew module. 11 years ago
James Cammarata 792298f114 Default use_proxy to True for fetch_url()
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.

Fixes #7322
11 years ago
Abhijit Menon-Sen 9eebdd1edb Allow '-t ' to be passed to apt: upgrade 11 years ago
James Cammarata 289170bd2d Merge branch 'yum_module_typos' of https://github.com/mpeters/ansible into mpeters-yum_module_typos 11 years ago
Michael Peters 098513a8a5 slight language change based on feedback from jimi-c 11 years ago
Michael Peters 715f059c5a fixing some typos in the docs of the yum module 11 years ago
Alan Pearce 332909a956 Update composer example
Remove unsupported 'install' argument
11 years ago
Yuichi TANIKAWA 41fbdd9421 Add dots to valid path characters 11 years ago
James Cammarata bf3079c77a Make sure distro variable is set if python-apt is installed
Fixes #7295
11 years ago
Michael DeHaan 594e5dcdd7 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 11 years ago
mkosmach cfc8b1c561 add simplejson as alternative to json 11 years ago
Michael DeHaan a9b4fcf703 Add missing license headers to two modules and standardize formatting of another. 11 years ago
James Cammarata 33c1f697d2 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 11 years ago
James Cammarata 6468b72d59 Merge pull request #7022 from jjshoe/patch-1
apt_key lists all keys in uppercase
11 years ago
James Cammarata 2725538515 Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
11 years ago
Radek Simko 08befa9c86 Prevention for catching unrelated exceptions added 11 years ago
Radek Simko 7d47f46807 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
11 years ago
Andreas Fleig cef705d04f apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
11 years ago