Commit Graph

3249 Commits (2769098fe7fcb51302cc8fabe9a1ff3f51aeec6f)

Author SHA1 Message Date
James Cammarata c3612e08f9 Move delegate_to out of runner module_vars to prevent bleeding across runs
Previously, the delegate_to value was stored in the module_vars of runner,
which could lead to bleeding that value across runs and incorrect hosts
being delegated to. This patch moves the value to a local variable in
the Runner class with some related refactoring of _compute_delegate() in
Runner (since the value is no longer required to be a parameter).

Fixes #8705
10 years ago
James Cammarata ed3c9c40ca Redoing patch for hostvars fix, since the previous one broke other tests 10 years ago
James Cammarata 3180a37457 Revert "Revert to using just the combined_cache for HostVars"
This reverts commit e9229cfeaa.
10 years ago
James Cammarata e9229cfeaa Revert to using just the combined_cache for HostVars 10 years ago
James Cammarata 4a9cf3f3f2 Allow hostvars variables to be templated
Fixes #7844
10 years ago
James Cammarata b376e208c7 Adding "follow" param for file/copy options
Also modifies the template action plugin to use this new param
when executing the file/copy modules for templating so that links
are preserved correctly.

Fixes #8998
10 years ago
Will Thames 2303044ffc Applied fix for sudo with no prompt to paramiko
Effectively reproduces @sivel's work from #8900 but for
the paramiko connection. Fixes #8418 when using paramiko

This allows `_remote_md5` to work if a sudo password is
passed in when no sudo password is required.
10 years ago
Matt Martz de77f33796 Don't throw away useful stdout and stderr. Fixes #8418
When supplying a sudo password to a server that uses passwordless sudo,
we should not throw away useful stdout and stderr. This is particularly
important for modules that perform md5 checks as part of the pre module
execution.
10 years ago
James Cammarata cdf938f2c2 Ensure remote files are chmod'd properly for su/su_user too
Fixes #8594
10 years ago
James Cammarata 0c4a7492bf Ensure checkmode is honored for templates that haven't changed
Fixes #8998
10 years ago
Michael DeHaan fb13e2bf2e Merge pull request #8853 from kvar/devel
zypper: handle lists of packages efficiently
10 years ago
James Cammarata 503f7afbd8 Merge branch 'hfinucane-gh-7432' into devel 10 years ago
James Cammarata 61c76245da Don't printout async callbacks when the task is skipped 10 years ago
James Cammarata 178075489b Merge branch 'gh-7432' of https://github.com/hfinucane/ansible into hfinucane-gh-7432 10 years ago
Michael DeHaan d6e6d2a6ca Remove regex related to baby-JSON parsing only. 10 years ago
Michael DeHaan d9e0a5ed22 Use correct keyword for this function. 10 years ago
Michael DeHaan 26cdddaebf Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 10 years ago
James Cammarata e54178f904 Catch additional errors in fetch_url
Fixes #8971
10 years ago
James Cammarata dacb6b8561 Use utils.merge_hash() instead of update for cache merging
Fixes #8968
10 years ago
James Cammarata 317ab06bc6 Fixing multiline parsing to preserve newlines
Fixes #8813
10 years ago
James Cammarata a571fd4efe Convert boolean strings from set_fact to proper boolean values
Also adds integration tests for booleanification of strings

Fixes #8629
10 years ago
James Cammarata 8708a00cbd Fix typo in redis cache change from 10afaee1 10 years ago
Michael DeHaan 2064d26085 Add documentation about bin_ansible_callbacks setting. Standardization and cleanup. 10 years ago
Will Thames d6a725659e Allow github style ssh repo names 10 years ago
Will Thames 537472f42c Make ansible-galaxy work as expected
This change fixes hg galaxy roles
Roles also get installed if roles path is missing, which
the tests currently require (fixes #8950)
10 years ago
James Cammarata 10afaee108 Fixing new caching related issue with host vars
The vars_cache was not being properly merged with the setup_cache
for all hosts, which was previously not noticed when registered
variables were stored in the setup_cache.

Fixes #8944
10 years ago
James Cammarata dc1f233e8d Merge pull request #8923 from nfelger/devel
Fixing issue with symlinked vaults
10 years ago
James Cammarata c610783f90 Merge pull request #8911 from bbasleeper/devel
Adding a new 'load_callback_plugins' config option, defaults to False
10 years ago
Niko Felger fa74a5c806 Fixing issue with symlinked vaults 10 years ago
James Cammarata 1711df3b75 Allow complex_args to be None 10 years ago
Bruno BAILLUET 16108e4a99 Adding a new 'load_callback_plugins' config option, defaults to False
This option, when set to True, allows "ansible" command to load callback plugins
10 years ago
James Cammarata 8cc3543918 Re-allow templating of complex_args, but count params to prevent injection
Fixes #8810
10 years ago
James Cammarata 8bafc646cb Disable custom https handler for fetch_url on older pythons
Fixes #8898
10 years ago
Toshio Kuratomi 8233522a7a Reduce commenting as basic.py is copied to the remote host with every module transfer.
Move some comments to the unittest as we might look at that if we decide
to refactor the code.
10 years ago
Toshio Kuratomi 1afc8161a1 New password obfuscation in syslog messages that:
* makes speed acceptable for some datasets
* obfuscates multiple detected passwords
* obfuscates more characters to account for some corner cases when
  trying to detect passwords.

Fixes #8364
10 years ago
Toshio Kuratomi 4f55bcc298 Standardize on bytes internally to _log_invocation 10 years ago
Michael Scherer 53830123fd Make ssh debug easier to read and paste
Currently, ansible -vvvv show the following:

    hostname EXEC ['ssh', '-C', '-vvv', '-o', 'ControlMaster=auto',

This is not good if someone want to cut and paste it to see if something
is wrong with the command line, so join the dictionnary strings with spaces
to have 1 string in the output.
10 years ago
James Cammarata cd99821f8a Fix py26 difference in ssl socket connect call from 99ba9d6 10 years ago
James Cammarata 14b8e2cf01 Make sure set_fact variables go into VARS_CACHE
Fixes #8758
10 years ago
James Cammarata 893f15b30b Merge pull request #8856 from sivel/memcached-factcache-improvements
Memcached factcache improvements
10 years ago
Matt Martz 9bc9145abd Compress all data inserted into memcached to avoid memcached size limits 10 years ago
Matt Martz 2a4079eeb6 Update format fields to work with python2.6 10 years ago
James Cammarata b827f791e1 Merge pull request #8832 from sivel/rax-validate-regions
rax modules: Perform region validation early
10 years ago
James Cammarata f44957de5c Merge pull request #8818 from Erethon/devel
Handle exceptions during config file parsing
10 years ago
James Cammarata 35dfbff2e1 Merge pull request #8817 from meatballhat/support-sunos-certs-location
Supporting SSL cert location on SunOS (SmartOS, really)
10 years ago
Matt Martz 55ed4489e3 Perform region validation early to be more explicit about invalid region failures 10 years ago
Kristofor Varhus acd37c87a9 zypper: handle lists of packages efficiently 10 years ago
Henry Finucane 36632c9529 Ensure ansible_job_id exists even for not-started jobs 10 years ago
Dionysis Grigoropoulos f948b4f293 Handle exceptions during config file parsing
Handle uncaught exceptions during config file parsing
10 years ago
Dan Buch 290f2759e1 Supporting SSL cert location on SunOS (SmartOS, really) 10 years ago
Trond Hindenes 72760f5999 All changes referenced in PRs #8767 , #8768 , #8769 :
This changes the get-attr function slightly, and lets the module specify whether a param is needed and auto-fails if it is not present. A module can now verify params like so::
 $params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -resultobj $result

or

$params = Parse-Args $args;
 $result = New-Object psobject;
 Set-Attr $result "changed" $false;
 $path = Get-Attr -obj $params -name path -failifempty $true -emptyattributefailmessage "Oh man. You forgot the main part!" -resultobj $result

slight tweak in how the powershell module converts to json in order to support nested objects (allows for more complex facts, among others)

This script gathers some extended facts on windows hosts in a json array attribute called "ansible_interfaces". This info is needed for some network-related modules I'm working on. Required the update to powershell.ps1 to return deeply nested json objects.
10 years ago
James Cammarata dbc980eaf4 Merge branch 'mischapeters-devel' into devel 10 years ago
Chris Church 2ddab7affc Merge pull request #8793 from cchurch/powershell3_compat
Replace Get-FileHash with MD5 code that works on PowerShell 3.
10 years ago
James Cammarata 70ff6d35aa A10 module improvements
* moved common code to an module_util snippet
* rewrote logic to make each module idempotent
* added new capabilities like the write_config option
10 years ago
Michael DeHaan b7082677de Merge pull request #8790 from sivel/issue/8784
Don't use ternary if statements. Fixes #8784
10 years ago
James Cammarata 7fbdbcdec7 Default fetch_url to use TLSv1 instead of SSLv2/3 10 years ago
James Cammarata ab495d1916 Set the shell variable on the ssh connection type for accelerated mode
Fixes #8799
10 years ago
James Cammarata 99ba9d6e24 Default fetch_url to use TLSv1 instead of SSLv2/3 10 years ago
Chris Church 0d1197a995 Replace Get-FileHash with MD5 code that works on PowerShell 3. 10 years ago
Matt Martz 2b307985bc Don't use ternary if statements. Fixes #8784 10 years ago
James Cammarata a6ad374668 Use split_args directly to check for omitted params 10 years ago
James Cammarata 04da466c7b Fixing up serialize_args utility function 10 years ago
James Cammarata e99db078b4 Additional fixes for the new omit parameter variable 10 years ago
Victor Lin fe88ba7c8d Undo changes to filter module 10 years ago
Victor Lin 559c04f324 Implement omit for module args, also add tests for it 10 years ago
Victor Lin bce6642ab6 Implement default omit correctly 10 years ago
Victor Lin 0b4d7f1574 Implement default omit filter 10 years ago
James Cammarata ed34cee36f Atomically move known hosts file into place for paramiko connections
Redo of original patch, which adds an additional check to ensure the
known_hosts file isn't trampled when host_key_checking is disabled.

Fixes #8169
10 years ago
James Cammarata 811ff49f78 Updating CHANGELOG for new symbolic mode feature and updating file docs 10 years ago
James Cammarata c21c66c740 Merge branch 'file_symbolic_mode' of https://github.com/pbitty/ansible into pbitty-file_symbolic_mode 10 years ago
y_nk affdadda25 handling case of space in path (given would start with single quote) 10 years ago
Chris Church 57dee4545b Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9. 10 years ago
Michael DeHaan a419ffdf41 Make command warnings off by default to minimize surprises. 10 years ago
Michael DeHaan b44e22aa68 Merge pull request #8722 from cmbaughman/devel
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
10 years ago
Michael DeHaan fcb610dec4 Slightly trim down the warnings list based on some things being pretty common
for local usage.
10 years ago
Will Thames ab8490d003 Added warnings to command module
Generate warnings when users are shelling out to commands
rather than using modules

Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.

Print out warnings using the standard playbook callbacks.

Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
10 years ago
Chris Baughman 07f12539ee Bugfix: #8720 winrm.py: protocol.send_message() crashes with https 10 years ago
Michael DeHaan 8a0045baad Update tests for ansible-galaxy CLI additions. 10 years ago
Michael DeHaan d87830e1cc Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel
Conflicts:
	lib/ansible/utils/__init__.py
10 years ago
James Cammarata d01188033f Checking for localized versions of the su password prompt
Fixes #8681
10 years ago
Michael DeHaan 0286c31e85 Assume master branch for downloads if not specified. 10 years ago
Michael DeHaan 0cd40fc372 Remove debug 10 years ago
Will Thames 850963790d Allow roles to be installed from archives on github
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.

Handling .zip archives is left as an exercise for the interested reader
10 years ago
James Cammarata 3b19b83806 Add GovCloud region to list of regions for AWS
Fixes #8604
10 years ago
Michael DeHaan bcb44276fe Assume github.com URLs are git protocol if not specified. 10 years ago
Michael DeHaan 68e21aa4b0 Add comments about what these new functions do. 10 years ago
Will Thames 6e9abefc11 Corrected bug where role_path was wrong for roles in subdirectories
Fixed role name for
    - { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
10 years ago
Will Thames ada9074276 Allow installation of roles from yaml roles file
Added docs
Added more tests
Improved how roles are returned from the parsers
10 years ago
Will Thames 46b59b02ed Friendly Role Names and roles from URLs
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
10 years ago
Will Thames 4803e923ff Improved handling of role_version in repo_url_to_role_name 10 years ago
Will Thames 1803976a40 Ensured that role version can be specified in role dependencies 10 years ago
Will Thames c2fe33f9f4 Tidied up a little, added tests
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
10 years ago
Will Thames b550cb9bc3 Need to take URLs into account when running playbooks too
Ensure that if meta/main.yml has dependencies containing URLs
these are correctly resolved at playbook runtime.

Update role_name during run time so that output of e.g. task names
look sensible
10 years ago
James Cammarata bae73e5793 Merge branch 'alozovskoy-alozovskoy-debug-ascii-patch' into devel 10 years ago
James Cammarata 4fafd3baa8 Add error checking around json.dumps when not forcing ascii mode 10 years ago
James Cammarata ea5db1818d Merge branch 'role_path_var' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-role_path_var 10 years ago
James Cammarata 24c4277479 Remove tabs added from 677de07 10 years ago
James Cammarata 5e240fec71 Merge branch 'devel' of https://github.com/l1k/ansible into l1k-devel
Conflicts:
	test/integration/roles/test_copy/tasks/main.yml
10 years ago
James Cammarata b81e77cfec Tweak error language in dict validation 10 years ago
Serge van Ginderachter 3a228b9d55 InventoryScript: better syntax checking for json stream 10 years ago