Commit Graph

24522 Commits (2744fde7c99d8550fb5757cf7733eaa0f761cc86)
 

Author SHA1 Message Date
Michael Scherer c9da5e98a9 Remove the wide try/expect clause
This doesn't catch anything precise, and none of the methods should
throw a expection for anything. This also hide python 3 errors.
8 years ago
Ryan S. Brown adc56e52d8 Fix `fail_json` invocation in `cloudformation` module 8 years ago
Steven de Vries 054fe53b43 Move job parameter to meet expected requirements (#5151)
closes #5273
8 years ago
Ricardo Carrillo Cruz 10d662ea1b Refactor domain/project handling on os_user module (#5212)
The keys returned by user objects for default domain and
default project are respectively default_domain_id and
default_project_id.
We need to gather those IDs in case the user passed names, so we
can then compare with the user object on the needs_update helper
function.
8 years ago
Alfredo Solano 88d7f0c692 apt: doc: use yaml syntax in examples (#5070) 8 years ago
Michael Scherer a567942405 Fix unarchive on python3
Since handler.files_in_archive is a list of files coming from
various executables output, that's a bytes list, and we use it
with dest who is a str. So we need to convert that to native
type.
8 years ago
Michael Scherer 7a0ef069fa Convert name to bytes to compare it to bools
On python 3, bools is a list of bytes:

    >>> rc,bools = selinux.security_get_boolean_names()
    >>> 'virt_use_nfs' in bools
    False
    >>> bools
    [b'abrt_anon_write', b'abrt_handle_event', ...]
8 years ago
Davis Phillips 37008e1da1 vsphere_guest: Set extra config and powerstate after template deploy (#4266)
* Fixes #1381
* Fixes #2971
* Fixes #3056
8 years ago
Michael Scherer 5e1dfa9485 Do not leak the password in log (#5189) 8 years ago
Michael Scherer 18b0920311 Do not leak the vtp_password in log (#5199) 8 years ago
Michael Scherer 3b2b33bf29 Do not leak the subversion password in log (#5200) 8 years ago
Michael Scherer 996ccca82f Do not leak various passwords in log (#5202) 8 years ago
Michael Scherer 8b7898e4ab Do not leak the password in log (#5203) 8 years ago
Michael Scherer 180977a727 Do not leak api_key or root password in log (#5201) 8 years ago
Peter Sprygada 2127459794 fixes bug introduced in 3670215 in junos_config (#5251)
The previous fix created a new bug that this PR resolves
8 years ago
John R Barker 25b6492d37 Bulk spelling improvement to modules-core (#5225)
* Correct spelling mistakes

* Correct more spelling issues

* merge conflict

* Revert typo in parms
8 years ago
Tom Melendez a4077537e0 Added libcloud guard for Managed Instance Groups. (#4911) 8 years ago
Tom Melendez 72635db94d GCE module examples update. Correct syntax, demonstrate other options and creation of multiple instances. (#5192) 8 years ago
Peter Sprygada 810040be05 fixes issue with collecting all filesystems in ios (#5248)
earlier versions of ios do not provide the all-filesystems argument.  This
fix will now only report on the flash filesystem for ios_facts

fixes #4712
8 years ago
Peter Sprygada f106ff9e77 ios_config will now explicitly disconnect from remote host (#5247)
The ios_config module will now explicitly send a disconnect to the
remote host at the conclusion of the module run

ref #5181
8 years ago
amitsi 522ed054f7 Update pn_vlan (#5223)
removed name from an older file which got left out
8 years ago
Peter Sprygada 43e6206559 removes automated backup of ios to flash due to errors (#5245)
The feature is extremely unstable right now and decision to pull
it out for 2.2.  Workaround is to do the same in the playbook
8 years ago
Peter Sprygada 25d00838a9 fixes issue with pushing config to versions that do not support sessions (#5236)
earlier versions of eos do not support configuration sessions.  this change
will now check if sessions are supported and if not will fallback to
not using config sessions

fixes #4909
8 years ago
John Barker bca8bbe7c2 Correct functional typos 8 years ago
Peter Sprygada 4dc09e19ea fixes bug with junos_config module not properly loading config (#5213)
This fixes two issues.  First, it fixes an issue with the junos_config
module not properly recognizing a file with set commands.  The second
bug would cause the diff_config() function to raise an exception due
to a blank line when splitting the config
8 years ago
Nathaniel Case 5a8ebf5953 nxos module cleanup (#5065)
* Fix imports on nxos_bgp* modules

* Fix imports on nxos_evpn* modules

* Cleanup issues for nxos_facts

* Shuffle imports for nxos_template

* Fix imports on nxos_ospf* modules

* Fix nxos_hsrp

As get_hsrp_groups_in_devices is not actually called anywhere, I presume this
change is reasonable.

* Fix imports on nxos_interface* modules

* Update nxos_static_route imports

* update nxos_vrf

* Update nxos_config imports
8 years ago
jjshoe 706bdbf284 Catch the rare condition where ami creation failed, this is critical when you have a 10-15 minute wait on ami creation. This rarely happens, and is tough to reproduce, but it does happen. (#5106) 8 years ago
Peter Sprygada 3fbae6f10f updates docstring for sros modules (#5197) 8 years ago
adejongh a89992f70f Fixed incorrect usage of user_data variable (#5194) 8 years ago
Bill Nottingham 765269e547 Fix deprecation notices. (#5180) 8 years ago
Elena Washington 91e433594a Make is so that the params param truly isn't required (fix for #3860) 8 years ago
Toshio Kuratomi 0fe99f20d9 Emit an error message if six is not installed.
dopy 0.3.7 makes use of six but doesn't list it as a requirement.  This
means that people installing with pip won't get six installed, leading
to errors.  Upstream released dopy-0.3.7a to address that but pip thinks
that is an alpha release.  pip does not install alpha releases by
default so users aren't helped by that.

This change makes ansible emit a good error message in this case.

Fixes #4613
8 years ago
Toshio Kuratomi 064c381608 Fix exception hierarchy for digital ocean and some cleanups of pep8 style
Fixes #4613
8 years ago
Chris Houseknecht 8e9befa5ba Surface Compose stdout on failure
Signed-off-by: Chris Houseknecht <chouseknecht@ansible.com>
8 years ago
Chris Houseknecht 63b6672ea5 Improved enumeration of actions 8 years ago
Chris Houseknecht 1e4b8c13a3 Improved build and pull error handling 8 years ago
Gabriele f8d2be407d Fixing docstring (#5130) 8 years ago
Peter Sprygada 56120433c9 checks commit comment to make sure it doesn't exceed 60 characters (#5155)
The comment argument can be at most 60 characters per the IOS XR command
line.  If a comment is > 60 characters, the module will now gracefully error
and return a well formed message.

fixes 5146
8 years ago
John R Barker efca39d4d4 Remove reference to parents parameter which doesn't exist (#5143) 8 years ago
John R Barker d12f2d2c72 Remove docs for commit which no longer exists (#5152) 8 years ago
Laurent Godet 336c9f9f35 Fix daemon_reload in systemd module 8 years ago
Toshio Kuratomi 283205d7b3 We've changed run_command to return native_strings
on python3, this means that we don't get bytes back by default.  We
probably do want bytes here so modify our call to run_command so we get
bytes instead of text.
8 years ago
Ryan Brown b091d39baf Handle termination_protection parameter when restarting instances (#5076)
* Restart EC2 instances with multiple network interfaces

A previous bug, #3234, caused instances with multiple ENI's to fail when being
started or stopped because sourceDestCheck is a per-interface attribute, but we
use the boto global access to it (which only works when there's a single ENI).

This patch handles a variant of that bug that only surfaced when restarting an
instance, and catches the same type of exception.

* Default termination_protection to None instead of False

AWS defaults the value of termination_protection to False, so we don't
need to explicitly send `False` when the user hasn't specified a
termination protection level. Before this patch, the below pair of tasks
would:

1. Create an instance (enabling termination_protection)
2. Restart that instance (disabling termination_protection)

Now, the default None value would prevent the restart task from
disabling termination_protection.

```
- name: make an EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    instance_type: t2.micro
    termination_protection: yes
    exact_count: 1
    count_tag:
       Name: TestInstance
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
- name: restart a protected EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    state: restarted
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
```
8 years ago
John R Barker 3333035ef4 Add matching quotes (#5133)
Will fix broken syntax highlighting
8 years ago
Matt Davis e2f66abe73 fixed windows setup to run in check_mode 8 years ago
Toshio Kuratomi 007b5f4c32 Fix assemble module for python3 8 years ago
Peter Sprygada 9c664f424e adds exception handling for adding an invalid condition (#5125)
This change will now handle a problem adding a condition that raises
an AddConditionError and return a well formed error to the user.
8 years ago
Pradeep b405931e8b Typo Fix 8 years ago
Gabriele b4565b6667 Adding more details on DOCSTRING about how to use the module (#5121) 8 years ago
Peter Sprygada 9707ae6490 adds exception handling for AddConditionError (#5124)
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
8 years ago