Commit Graph

1033 Commits (271e300745b7200fc57383916d87efd6640d093e)

Author SHA1 Message Date
Adrian Likins ae6b3ac71d Merge pull request #2225 from rusaksoft/iptables-add-icmp-type
Iptables add icmp type
9 years ago
Dag Wieers 7618fd8749 Fix check-mode incorrectly returning changed (#2220)
The lvol module has a different logic in check-mode for knowing when a change is induced. And this logic is *only* based on a size check. However during a normal run, it is the lvreduce or lvextend tool that decides when a change is performed (or when the requested and existing sizes differ). So while in check-mode the module reports a change, in real run-mode it does not in fact changes anything an reports ok.

One solution would be to implement the exact size-comparison logic that is implemented in lvextend and lvreduce, but we opted to use the `--test` option to each command to verify if a change is induced or not. In effect both check-mode and run-mode use the exact same logic and conclusion.
9 years ago
Pavel Samokha a0566037b4 iptables module - icmp-type better doc style 9 years ago
Pavel Samokha 7092118119 fix icmp-type 9 years ago
Pavel Samokha 747f6f6736 iptables module - add icmp_type 9 years ago
Yannig bbd53572af New lvol option: shrink. (#2135)
If shrink is set to false and size is lower than current lv size, dont try to shrink logical volume.
9 years ago
Michael Scherer 557d37d3f1 Use type='path' rather than str, so path is expanded correctly 9 years ago
Kevin Hildebrand 9f2bc2853d Fix the interface handling code to allow permanent and non-permanent operations.
Also avoid using add_interface because it breaks in cases where the interface is already bound to a different zone.
9 years ago
Brian Coca fbd00675f0 updated version added for pvs 9 years ago
Matt Davis 238af47a9d Merge pull request #2007 from p53/devel
Added pvs parameter to lvol module
9 years ago
Toshio Kuratomi 71d83b77bc Recategorize git_config and shift version to 2.1 9 years ago
Brian Coca 09a1015bd7 updated version added 9 years ago
Matthew d91baee7c9 Add git_config module (#1945)
* Add git_config module

This module can be used for reading and writing git configuration at all
three scopes (local, global and system). It supports --diff and --check
out of the box.

This module is based off of the following gist:
https://gist.github.com/mgedmin/b38c74e2d25cb4f47908
I tidied it up and added support for the following:
- Reading values on top of writing them
- Reading and writing values at any scope
The original author is credited in the documentation for the module.

* Respond to review feedback

- Improve documentation by adding choices for parameters, requirements
  for module, and add missing description for scope parameter.
- Fail gracefully when git is not installed (followed example of puppet
  module).
- Remove trailing whitespace.

* Change repo parameter to type 'path'

This ensures that all paths are automatically expanded appropriately.

* Set locale to C before running commands to ensure consistent error messages

This is important to ensure error message parsing occurs correctly.

* Adjust comment
9 years ago
René Moser 344dff4350 docs: fix make docs (#2107) 9 years ago
Chris Lamb 8d7d070201 system/ufw.py: Add security warning re. removing ufw application prof…
It's not particularly obvious that removing an application will remove it
from ufw's own state, potentially leaving ports open on your box if you
upload your configuration.

Whilst this applies to a lot of things in Ansible, firewall rules might
cross some sort of line that justifies such a warning in his instance.

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
9 years ago
p53 706cbf69ca Add pvs parameter to documentation
Add pvs parameter to documentation
9 years ago
codehopper-uk aa29a4fd9c Basic ability to set masquerade options from ansible, according to current code design/layout (mostly) (#2017)
* Support for masquerade settings

Ability to enable and disable masquerade settings from ansible via:
- firewalld: mapping=masquerade state=disabled permanent=true zone=dmz

Placeholder added (mapping) to support masquerade and port_forward
choices initially - port_forward not implemented yet.

* Permanent and Immediate zone handling differentiated

* Corrected naming abstraction for masquerading functionality

Removed mapping tag with port_forward choices - not applicable!

* Added version info for new masquerade option

Pull Request #2017 failing due to missing version info
9 years ago
Pavol Ipoth 14057da87c Removing, unwanted pull 9 years ago
Pavol Ipoth e3ca2c7aeb Adding new ansible module lvol_cache 9 years ago
Pavol Ipoth 2be58bf100 Merge branch 'devel' of https://github.com/ansible/ansible-modules-extras into devel 9 years ago
Michael Scherer ff74fc0072 Remove the +x from crypttab and cronvar (#2039)
While this change nothing, it is better to enforce consistency
9 years ago
Jasper Lievisse Adriaanse 2b8debbc2b Sprinkle some LANG/LC_* where command output is parsed (#2019) 9 years ago
Michael Scherer 2dbfdaa88b Remove dead code (#1303)
The review on https://github.com/ansible/ansible-modules-extras/pull/1303
show the problem was already fixed, so we just need to remove the
code.
9 years ago
Pavol Ipoth 7be55e188a Fixes #2008 Lvol module is not indempodent for cache lv's 9 years ago
Pavol Ipoth ac9a48ad1e Added pvs parameter to lvol module 9 years ago
kubilus1 773d402eac Unchecked index causes IndexError. 9 years ago
Monty Taylor 38c8fec277 Merge pull request #1149 from Jmainguy/puppet_stdout
Enable stdout and stderr on sucessful runs, making show_diff useable
9 years ago
René Moser fc79c8820e Merge pull request #1971 from insom/devel
Add `to_destination` parameter to iptables
9 years ago
Vlad Gusev f1175693f6 system/puppet: add --tags parameter (#1916)
* system/puppet: add --tags parameter

--tags [1] is used to apply a part of the node’s catalog.

In puppet:
puppet agent --tags update,monitoring

In ansible:
puppet: tags=update,monitoring

[1] https://docs.puppetlabs.com/puppet/latest/reference/lang_tags.html#restricting-catalog-runs

* Add example of tag usage.

* system/puppet: add list type for a tags dict.
9 years ago
Aaron Brady e2138c7e14 Add `to_destination` parameter 9 years ago
Chulki Lee f3c168594a osx_defaults: fix datetime
Fix #1742
9 years ago
René Moser daddc7caf4 Merge pull request #1478 from m0/firewalld_interface
Extends firewalld module with ability to add/remove interfaces to/from zones
9 years ago
David Hocky 031f98e86c fix dscp marking documentation in iptables module 9 years ago
René Moser 241dba1ee7 Merge pull request #1555 from LuckyGeck/devel
Added reject_with and uid_owner support to iptables module
9 years ago
Linus Unnebäck 7def4b01f5 make: move down ansible import 9 years ago
Linus Unnebäck b328feccb1 make: add empty return docs 9 years ago
Linus Unnebäck a0aef208b6 module: system/make 9 years ago
Pavel Sychev eda178a988 Added version restriction for uid_owner and reject_with. 9 years ago
Pavel Sychev c15dcf888b Added docs for reject_with and uid_owner. 9 years ago
Pavel Sychev 12890b14b2 Added reject_with and uid_owner support. 9 years ago
René Moser 0a65ddb3b1 Merge pull request #1641 from EmilienM/puppet/execute
system/puppet: allow to run puppet -e
9 years ago
Brian Coca 10e70b5f48 Merge pull request #1874 from mscherer/better_verif_alternatives
Add proper type to path and link
9 years ago
Michael Scherer 8c53e654f7 Add proper type to path and link
Since both of them are path, it should be checked using the
proper type.
9 years ago
Rene Moser 87599fd2ee osx_defaults: doc fix, add version_added for host agrument
See #1364
9 years ago
René Moser 4543d5838f Merge pull request #1364 from wincent/os-x-defaults-host
osx_defaults: add "host" attribute
9 years ago
Rene Moser f80865d32a lvol: remove unused import
See #1425
9 years ago
René Moser d159e6af34 Merge pull request #1425 from jonasvermeulen/devel
Added resizing code based on %-values
9 years ago
Michael Scherer 6b2bc9df04 Fix #1809, use the proper method to fail 9 years ago
Emilien Macchi c289aa4cb9 system/puppet: allow to run puppet -e
-e or --execute [1] allows to execute a specific piece of Puppet code
such a class.

For example, in puppet you would run:
puppet apply -e 'include ::mymodule'

Will be in ansible:
puppet: execute='include ::mymodule'

[1] http://docs.puppetlabs.com/puppet/latest/reference/man/apply.html#OPTIONS
9 years ago
René Moser aeb82091a6 Merge pull request #1634 from EmilienM/puppet/certname
system/puppet: add --certname parameter
9 years ago
René Moser 074c179793 Merge pull request #1787 from dougluce/cronvar-root-cron
cronvar.py: support absolute destinations
9 years ago
Rene Moser cd3daf5763 iptables: add defaults to docs 9 years ago
René Moser f479db69a4 Merge pull request #1822 from Comcast/feature/iptables_dscp_update
add support for setting dscp marks with iptables module
9 years ago
René Moser 186a68a382 Merge pull request #1597 from yta/fix_check_mode_issue_in_osx_defaults
osx_defaults: Do not make any changes in check mode
9 years ago
Brian Coca df217fe892 added new puppet path to bin search
fixes #1835
9 years ago
David Hocky 404267b064 add version added to new params 9 years ago
David Hocky b89f0f44d0 fix doc issue 9 years ago
David Hocky c9e3c57ee9 add support for setting dscp marks with iptables module 9 years ago
Jonas Vermeulen b5d75234a3 Added resizing based on %values. Included support for VG|PVS|FREE 9 years ago
Jonathan Mainguy deb72106d2 fixes bug where puppet fails if logdest is not specified 9 years ago
Doug Luce 0298dac401 Use os module for checking absolute/joining paths 9 years ago
Doug Luce 84def4398f cronvar.py: support absolute destinations
Mainly so /etc/crontab can be written to.
9 years ago
Brian Coca 479f99678b Merge pull request #1719 from bborysenko/lvol-doc-fix
The size option is required for lvol module
9 years ago
Borys Borysenko a3641cac4e The size option is required for lvol module with state=present 9 years ago
Michael Scherer f63ef1fee8 Add documentation to explain that pvs will be created if needed
Fix #1720
9 years ago
Emilien Macchi 6193ed4b0d system/puppet: add --certname parameter
certname [1] can be a useful parameter when we need to specify a
certificate name different from the default value [2] in Puppet.

Ex: the hosts have different names, in advanced network isolation
setups.

Also, it can be used when we want to run Puppet with a specific node
definition and not using hostname or fqdn to match the nodes where we want to
run Puppet [3] (not recommended by Puppetlabs though).

[1] https://docs.puppetlabs.com/puppet/latest/reference/configuration.html#certname
[2] Defaults to the node’s fully qualified domain name
[3] http://docs.puppetlabs.com/puppet/latest/reference/lang_node_definitions.html#naming
9 years ago
Travis J Parker 1862a813db fixes documented command for svc sending SIGUSR1 9 years ago
Matt Martz f881eb10d9 Add actual version to version_added for svc module 9 years ago
Ton Kersten 362760413f Fix facter path 9 years ago
James Cammarata 816d3bff6f Adding version_added field to logdest field for puppet module 9 years ago
Monty Taylor e704525d46 Add option to send puppet apply logs to syslog
While returning puppet logs as ansible stdout is useful in some cases,
there are also cases where it's more destructive than helpful. For
those, local logging to syslog so that the ansible logging makes sense
is very useful.

This defaults to stdout so that behavior does not change for people.
9 years ago
yta 2e9797ca8c osx_defaults: Do not make any changes in check mode 9 years ago
Toshio Kuratomi ec5c03381b Merge pull request #1378 from johanwiren/fix_properties_handling
Fix zfs properties handling
9 years ago
Brian Coca 14f0ad07ab Merge pull request #1548 from vvanholl/devel
Do not fail when action is delete and volume is not present
9 years ago
Brian Coca 284032efff Merge pull request #1538 from bibliotechy/patch-1
Doc wrongly indicates firewalld permanent flag is required
9 years ago
Brian Coca cd64f20034 added missing version_added 9 years ago
Brian Coca ff554a76d7 Merge pull request #1402 from doalitic/iptables-add-limit-burst
Add limit-burst support to iptables module
9 years ago
Dale Smith 27cd172900 Fix regression of #821 in puppet of show_diff
Issue #821 fix: 1382576100
Regressed since: 6912ca0aca

Issue: #821
9 years ago
Brian Coca ffefe5dde8 Merge pull request #1505 from Yannig/devel_fix_pvcreate
Use -f when pvcreate to avoid interactive input.
9 years ago
Brian Coca 98eeb689ce Merge pull request #1514 from doalitic/iptables-fix-append_csv
iptables: fix param check in append_csv function
9 years ago
Brian Coca a7ad0bc7be Merge pull request #1499 from specnazzz/fix-seport-ports
seport module fails when the `ports` argument is a integer
9 years ago
Brian Coca ec8bf56448 Merge pull request #1493 from abulimov/filesystem_recreate_with_force
Allow recreation of same FS with force=yes in filesystem module
9 years ago
Brian Coca 1f2b6bf3fd Merge pull request #1492 from alxgu/filesystem_idemponent
Make fileystem module idemponent. Compare devicesize and filesystemsize.
9 years ago
Vincent VAN HOLLEBEKE ce3e972ce8 Do not fail when action is delete and volume is not present
This prevents failing when a playbook describes a volume deletion and
is launched more that once.

Without this fix, if you run the playbook a second time, it will fail.
9 years ago
colynn.liu 9b981cecc6 fixed python 2.4 compatibility
nf=tempfile.NamedTemporaryFile(delete=False)
TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete'
9 years ago
Chad Nelson 0c2f602788 Doc wrongly indicates permanent is required
But it isn't. :)
9 years ago
Brian Coca 174bef08ae Merge pull request #1133 from lightblu/devel
Check to make sure the firewalld client is connected before proceeding
9 years ago
Daniel Vigueras 16d17d287f iptables: fix param check in append_csv function 9 years ago
Daniel Vigueras ece6872b81 iptables: add --limit-burst option 9 years ago
Mo 23aa66a48e firewalld: fixes documentation
- removes warning, aligning to existing documentation
- adds version
9 years ago
Alexander Gubin 8d7b1b0bd6 Make fileystem module idemponent. Compare devicesize and filesystemsize. 9 years ago
Yannig Perré c276d9f621 Use -f when pvcreate to avoid interactive input.
Fix https://github.com/ansible/ansible-modules-extras/issues/1504
9 years ago
Tom X. Tobin 4c4a58e77b osx_defaults: Fix boolean value parsing
Values for boolean types were being unconditionally treated as strings
(by calling `.lower()`), thus breaking value parsing for actual boolean
and integer objects.

It looks like the bug was introduced in:

- 130bd670d8

Fixes #709.
9 years ago
Brian Coca aae5847064 Merge pull request #1403 from LinusU/linusu-iptables-cleanup
iptables: cleanup
9 years ago
Michal Mach ee2c730b7e Fix seport module issue when ports argument is interpolated from a variable and is a int 9 years ago
Jeroen Geusebroek e088c9f819 Fix documentation default value for gluster_volume start_on_create 9 years ago
Alexander Bulimov ab9b0558d3 Allow recreation of same FS with force=yes 9 years ago
Brian Coca a42203bdb3 Merge pull request #1476 from jarrpa/jarrpa-patch-1
gluster_volume: allow probing ourselves
9 years ago
Brian Coca 5f8b288c31 Merge pull request #1389 from brwilson/devel
Properly handle adding multiple bricks to volume
9 years ago
Brian Coca 3aa2d3744d Merge pull request #1482 from ansible/json-imports-fallback
Update for modules which import json.
9 years ago