trbs
6567e40b6d
In check mode if a symlink does not exist there is no need to check the ownership properties (which causes an exception)
11 years ago
James Cammarata
abe3655cec
Double check whether the parent directory really exists using stat()
...
Fixes #7760
11 years ago
James Cammarata
bdf84b4e73
Merge branch 'unarchive-fix-7777-simple' of https://github.com/toddmowen/ansible into toddmowen-unarchive-fix-7777-simple
11 years ago
James Cammarata
2ac27fbbea
Use file documentation fragement for the copy module
11 years ago
Todd Owen
dc7e1fe21e
unarchive: do not assume tar supports -C
...
Fixes #7777
(But don't rewrite the tar invocation in is_unarchived(), since a
tar that supports "--diff" certainly supports "-C" as well).
11 years ago
Todd Owen
2b9402dc5c
unarchive: improve failure detection and reporting
...
Related to #7777
11 years ago
James Cammarata
0c028ad881
Merge branch 'fix-lineinfile-eof-newline' of https://github.com/ahtik/ansible into ahtik-fix-lineinfile-eof-newline
11 years ago
Aleksey Khudyakov
a1d76ca8d1
Escape backslash in assemble module docs
11 years ago
James Cammarata
8d9da7e89f
Merge pull request #7377 from mikhailguru/devel
...
Fixed handling of paths containing whitespaces in the synchronize module
11 years ago
Ahti Kitsik
6341cc23fb
Bugfix to lineinfile to properly handle files with no newline at EOF when using insertafter=EOF.
...
Looks like #6881 is also affected by this bug.
Currently when using lineinfile insertafter=EOF for a file that has no newline then the added line is not prefixed with a newline.
As a concrete example, ubuntu distro default /etc/ssh/sshd_config has no newline so lineinfile module cannot be used to add a new line to the end of the file.
11 years ago
James Cammarata
c276dec487
Fix issue with symlink path detection
...
Fixes #7627
Fixes #7664
11 years ago
James Cammarata
090fd0a224
Fix linking issue to directories in file module
...
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.
Fixes #7657
11 years ago
Brian Coca
ffb87adbc2
Correctly examine path for relative links in file module
...
Fixes #7515
Fixes #7537
11 years ago
Kit Westneat
aab77b46d8
Fixed documentation for etype parameter on acl module.
...
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
11 years ago
Brian Coca
ac14a8d6ad
unified calls to fs function vs duplicate functions for file and
...
directory
11 years ago
James Cammarata
5ec0297c04
Fixing absolute path calculation for file module when linking
...
Fixes #7403
11 years ago
telsacolton
ee60f8f710
Make file hardlink error message reasonble
...
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
11 years ago
telsacolton
133cbee473
Give reasonable error when symlink fails
...
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
11 years ago
James Cammarata
8c7aafd5ae
Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms
11 years ago
Mikhail Emelchenkov
cadb57f446
Fixed incorrect handling of paths contaiin whitespaces
11 years ago
James Cammarata
7faf766305
Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel
11 years ago
James Cammarata
261fe0ea96
Merge pull request #7013 from orgoj/replace-patch-changed
...
module replace - report changed only if contents is changed
11 years ago
Brian Coca
6cad8620d5
reworded copy option docs to be clearer
11 years ago
James Cammarata
5ce5ba5e58
Refuse to convert a non-empty directory into a link with the file module
...
Also adds an integration test for the above.
Fixes #7254
11 years ago
someda
5bb888af4b
fix #7244 recursive copy fails when setting directory attributes
...
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
11 years ago
Michael DeHaan
f57f9c950f
Merge pull request #7119 from jjshoe/patch-4
...
Finish reverting a broken commit in #5679
11 years ago
James Cammarata
b53bf7c8b1
Minor tweak to rsync_path construction in synchronize module
...
Fixes #7182
11 years ago
Carlos E. Garcia
4dcaa9d9fb
multiple spelling error changes
11 years ago
Skyler Leigh Amador
6eb8759ec5
Remove --timeout option to rsync from synchronize defaults
...
The current 10-second default timeout for rsync seems to be behind issue #6809 .
As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Joel Schuweiler
aed596088b
Finish reverting #b73cddc
11 years ago
jjshoe
6f0808b23b
Ensure the validation string has %s in it
11 years ago
Brian Coca
1e3860c47b
now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
...
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi
40e7c6eddc
Possible docs error: 'path' instead of 'src'
...
I came to this example today (line 50), and when I tried it, I got an error:
`msg: src and dest are required for creating links`
So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Michael Heca
6618c1e8b5
module replace - report changed only if contents is changed
11 years ago
James Cammarata
39356bd83b
Get the bin path for commands in the unarchive module
...
Fixes #6927
11 years ago
James Tanner
0f82a2b53c
Addresses #6702 Remove version_added from description string
11 years ago
James Tanner
f2c9c2c141
Addresses #6702 set version_added for rsync_opts
11 years ago
jctanner
7a6267690e
Merge pull request #6702 from jjshoe/devel
...
Allow you to pass in arbitrary rsync options
11 years ago
James Tanner
fec4c797d9
Fixes #6929 remote file module doc fragments from copy and template
11 years ago
James Tanner
199992adb6
Fixes #6894 create docs fragment for files
11 years ago
James Cammarata
8f325afe38
Fixing newline escapes in lineinfile
...
Fixes #5679
11 years ago
James Cammarata
7a03cc69e1
Revert "Fix #5679 again after recent changes in core"
...
This reverts commit 2bfaacd170
.
Fixes #6821
11 years ago
Richard C Isaacson
465b97be7e
assemble module: fix insertion of newlines when not needed.
...
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
11 years ago
Peter Gehres
53c1d25c70
Fix for #6353 adding a newline between assembled files
11 years ago
Michael DeHaan
63a1330263
Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
...
Application to other cloud providers would make very good sense.
11 years ago
James Tanner
7b72004eb4
Merge #5903 from rhaido/ansible
...
Update files documentation for usage of force=True and hardlinks
11 years ago
cgtx
bb3fed67aa
backreferences should be double escaped
11 years ago
Michael DeHaan
a8b345ad38
Repairs for documentation build.
11 years ago
Michael DeHaan
f596ee8850
Slight docs tweak, split lines according to code standards
11 years ago
Andrea.Mandolo
2a66f356b1
correct documentation comment and version_added in "synchronize" module
11 years ago
Andrea.Mandolo
7cd21a47ef
Add STDOUT lines in response of "synchronize" module
11 years ago
Andrea.Mandolo
33b440ac9f
Add "checksum" option support to 'synchronize' module
11 years ago
Michael DeHaan
d1975c906f
Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
...
Conflicts:
library/files/template
11 years ago
Michael DeHaan
38c3332b8a
Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
...
Handle missing symlink tempfile
11 years ago
jjshoe
a5794f5d8c
Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in.
11 years ago
Jeff Geerling
177bf3eb20
Fixed template validation docs and example.
11 years ago
jjshoe
e62b38c250
Show argument dependency
...
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
11 years ago
James Cammarata
68327fa172
Cleanup from merge of replace module and CHANGELOG update
11 years ago
James Cammarata
2c05e337cb
Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel
11 years ago
James Cammarata
d6a2befb0d
Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg
11 years ago
Robert Wehner
406317371b
Update 'validate=' parameter documentation to make clear that the command
...
passed via this paramter is not passed via shell and so all shell features
will not work.
11 years ago
James Tanner
7c263fcdad
Fixes #6590 add set_remote_user parameter to synchronize
...
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
11 years ago
Steve Smith
5b5af14921
Only unlink the symlink tempfile on error if it was created in the
...
previous operation.
11 years ago
Brian Coca
a395eb3aba
fixed issue with tmp file (path can include filename) and added missing
...
else which made it try to link x2
11 years ago
Brian Coca
4fd957620a
now correctly checks absolute path for src= existance for links
...
also updated docs to be a bit clearer on symlink behaviour
11 years ago
Brian Coca
402cd11c52
fixed issue with directory permissions on copy #6552
11 years ago
James Cammarata
d60ac967b9
Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean
11 years ago
Michael DeHaan
4ec2a79aae
Merge pull request #6515 from lotia/fix-acl-doc-and-error
...
Fix acl doc and error
11 years ago
Ali Asad Lotia
fc5aa9ac28
Whitespace fixes in incompatible param check
...
- Remove extra whitespace in conditional that checks if etype, entity or
permissions are also set when entry is set.
11 years ago
Michael DeHaan
ec14b25e23
Merge pull request #6448 from jirutka/fix-5679-2
...
Fix #5679 again after recent changes in core
11 years ago
Cristian Ciupitu
7f681c33a2
Micro-optimization: replace s.find(x)!=-1 with x in s
...
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Ali Asad Lotia
77e6dded62
Fix acl module doc and error messages
...
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
11 years ago
Brian Coca
7ca6343ca3
Fixes and cleanup to file functions and module
...
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
11 years ago
Michael DeHaan
4f1ccfd66f
Merge pull request #6504 from follower/patch-2
...
Fix typo
11 years ago
follower
5beee66d1d
Fix typo
...
"resort" -> "result"
11 years ago
Brian Coca
5dd041ae7e
fixed bad detection of change on default and premature break
11 years ago
Jakub Jirutka
f39b8cae95
Fix #5679 again after recent changes in core
11 years ago
Brian Coca
3b98ed15bc
now stat skips md5 if file isn't readable
11 years ago
James Tanner
fc33860e5d
Force command action to not be executed by the shell unless specifically enabled
11 years ago
Dolph Mathews
289f8f7ed9
spelling correction for "separate"
...
s/seperate/separate/
http://en.wiktionary.org/wiki/separate
11 years ago
Richard C Isaacson
7fff5abd5b
unarchive module: Add creates functionality.
...
Closes GH-5354.
Forklift copy logic into unarchive. Provides integration unit tests.
11 years ago
Michael DeHaan
87677c96c6
Merge pull request #6308 from muffl0n/file_fix_documentation
...
Module "file": Fix link to "path" in documentation
11 years ago
James Cammarata
bdd3ccec65
Un-escape newlines in delimiters for assemble module
11 years ago
Sven Schliesing
b55f99b803
Fix link in documentation
...
c(dest) -> c(path)
11 years ago
Michael DeHaan
2f12c6ddf6
Simplify file module parameter description.
11 years ago
Richard C Isaacson
7263148156
Typo fix.
11 years ago
Richard C Isaacson
1e2eb88926
Replace mode with octal renaming to mode.
...
Closes GH-6176
This way for mode we return in an octal format which is immediately usable compared to transforming it later.
11 years ago
Richard Isaacson
6ffeaa7ddd
Merge pull request #1 from bcoca/stat_updaates
...
added octal representation of mode and made md5 checksumming optional
11 years ago
Richard C Isaacson
a707e858cd
Minor cleanup.
11 years ago
Richard C Isaacson
3ca9fc64d5
copy module: cleanup and if directory_mode not set default to umask
11 years ago
Richard C Isaacson
326ed4eeeb
Copy Module: Add the ability to set directory attributes on recursive copy.
...
Closes GH-6194.
These changes pass attribute modifications through to new directories during a recursive copy with an addition allowing for the directory mode to be set independantly.
11 years ago
James Cammarata
b667e1d404
Add expanduser calls on src/dest in the module too
11 years ago
James Cammarata
1762557ff4
Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel
11 years ago
Brian Coca
21854d54d4
added octal representation of mode and made md5 checksumming optional
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata
6283754340
Fixing several bugs in assemble and updating tests
...
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
resulting in it never being used by the module as the default behavior
was remote_src=True (issue #5581 )
* the remote_src param was not listed in the generic file params, leading
to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
fragments do not run together on one line
Fixes #5581
11 years ago
James Cammarata
33d9a662ee
Adding new tests for assemble role
11 years ago
James Cammarata
d80b9ac137
Adding the backup destination to the resut dictionary for lineinfile
11 years ago
muffl0n
68bef304c8
already call expanduser in action_plugin
11 years ago
Michael DeHaan
62f8ebe51e
Merge pull request #6036 from mxxcon/patch-1
...
docs_pull_request: Add parameters highlighting
11 years ago
James Cammarata
f1ba67e547
Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679
11 years ago