Commit Graph

24781 Commits (21a03152dcff0f9c56ec99003929c264a3310fa2)
 

Author SHA1 Message Date
Toshio Kuratomi 283205d7b3 We've changed run_command to return native_strings
on python3, this means that we don't get bytes back by default.  We
probably do want bytes here so modify our call to run_command so we get
bytes instead of text.
8 years ago
Ryan Brown b091d39baf Handle termination_protection parameter when restarting instances (#5076)
* Restart EC2 instances with multiple network interfaces

A previous bug, #3234, caused instances with multiple ENI's to fail when being
started or stopped because sourceDestCheck is a per-interface attribute, but we
use the boto global access to it (which only works when there's a single ENI).

This patch handles a variant of that bug that only surfaced when restarting an
instance, and catches the same type of exception.

* Default termination_protection to None instead of False

AWS defaults the value of termination_protection to False, so we don't
need to explicitly send `False` when the user hasn't specified a
termination protection level. Before this patch, the below pair of tasks
would:

1. Create an instance (enabling termination_protection)
2. Restart that instance (disabling termination_protection)

Now, the default None value would prevent the restart task from
disabling termination_protection.

```
- name: make an EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    instance_type: t2.micro
    termination_protection: yes
    exact_count: 1
    count_tag:
       Name: TestInstance
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
- name: restart a protected EC2 instance
  ec2:
    vpc_subnet_id: {{ subnet  }}
    state: restarted
    instance_tags:
       Name: TestInstance
    group_id: {{ group }}
    image: ami-7172b611
    wait: yes
```
8 years ago
John R Barker 3333035ef4 Add matching quotes (#5133)
Will fix broken syntax highlighting
8 years ago
Matt Davis e2f66abe73 fixed windows setup to run in check_mode 8 years ago
Toshio Kuratomi 007b5f4c32 Fix assemble module for python3 8 years ago
Peter Sprygada 9c664f424e adds exception handling for adding an invalid condition (#5125)
This change will now handle a problem adding a condition that raises
an AddConditionError and return a well formed error to the user.
8 years ago
Pradeep b405931e8b Typo Fix 8 years ago
Gabriele b4565b6667 Adding more details on DOCSTRING about how to use the module (#5121) 8 years ago
Peter Sprygada 9707ae6490 adds exception handling for AddConditionError (#5124)
AddConditionErrors are now handled by nxos_command and a well formed error
is returned from the module
8 years ago
Peter Sprygada f5e72c6590 adds check for AddConditionError when adding conditional statements (#5123)
The Conditional instance will now raise the AddConditionError and this
change instructs eos_command to catch the error and return a nicely formed
error message
8 years ago
Matt Davis 48b0cb750c (re)add post-watchdog-launch sleep to Windows async_wrapper (#5122)
fixed apparent race where subprocess appears to never start
8 years ago
Gabriele d4c2a13325 Improving nxos_igmp_snooping (#5011) 8 years ago
Gabriele 3c257688bc Fixing nxos_igmp_interface (#5010) 8 years ago
Gabriele b6c07bc9e9 Fixing nxos_hsrp (#5009)
* Fixing nxos_hsrp

* Adding space after =
8 years ago
Senthil Kumar Ganesan 21ae84a04e Remove the dellosX_template module (#5110) 8 years ago
Matt Davis c07a2b49b6 add JSON junk filter to async_wrapper (#5107) 8 years ago
Peter Sprygada d58462949f roll up of unicode fixes in junos modules (#5113)
* fixes junos_template (fixes #3962)
* fixes junos_config
8 years ago
Gabriele 62bf8d0c78 Add ethernet-link-oam mapping to nxos_feature (#4956)
* Add ethernet-link-oam mapping

* Adding port-secutiry mapping

* Fixing command output format
8 years ago
Gabriele 67d6f2c0d6 Fixing nxos_vlan (#5005)
* Fixing nxos_vlan

* Fixing docstring

* Fixing docstring
8 years ago
Gabriele 43632951fe Fixing nxos_aaa_server (#5002)
* Fixing command output formatting

* Fixing cmds
8 years ago
Gabriele 7f861fb9ce Fixing nxos_acl (#5006)
* Fixing nxos_acl

* Fixing nxos_acl
8 years ago
Gabriele 272b20000f Fixing nxos_acl_interface (#5007) 8 years ago
Gabriele 75c4051933 Fixing nxos_interface (#5012) 8 years ago
Gabriele 1be7ca4f70 Fxing nxos_ip_interface (#5013) 8 years ago
Gabriele 6708874f1c Fixing nxos_mtu (#5014) 8 years ago
Gabriele 6934f11e1f Fixing nxos_ntp (#5015) 8 years ago
Gabriele 6201a57d83 Fixing nxos_ntp_auth (#5016) 8 years ago
Gabriele c50324fb08 Fixing nxos_ntp_options (#5017) 8 years ago
Gabriele 4b6ee73f8c Fixing nxos_pim_interface (#5018) 8 years ago
Gabriele 5b96fb1dac Fixing nxos_portchannel (#5019) 8 years ago
Gabriele ebb39a0151 Fixing nxos_smu (#5021) 8 years ago
Gabriele cda65cad18 Fixing nxos_snmp_community (#5022) 8 years ago
Gabriele f74275fc1d Fixing nxos_snmp_contact (#5023) 8 years ago
Gabriele 73d66e28ab Fixing nxos_snmp_host (#5024) 8 years ago
Gabriele 7c7eee94b2 Fixing nxos_snmp_location (#5025) 8 years ago
Gabriele 19769903e6 Fixing nxos_snmp_traps (#5026) 8 years ago
Gabriele bf59e458b1 Fixing nxos_snmp_user (#5027) 8 years ago
Gabriele 04e62346d1 Fixing nxos_udld_interface (#5030) 8 years ago
Gabriele 6bedeb28d8 Fixing nxos_switchport (#5028) 8 years ago
Gabriele 773f1703b7 Fixing nxos_udld (#5029) 8 years ago
Gabriele d61950d48c Fixing nxos_vpc_interface (#5032) 8 years ago
Gabriele 51c37e9f58 Fixing nxos_vrf (#5033) 8 years ago
Gabriele 8f331e01ca Fixing nxos_vpc (#5031) 8 years ago
Gabriele 9ff6070eb8 Fixing nxos_vrf_interface (#5034) 8 years ago
Gabriele e7286ed43c Fixing nxos_vtp_domain (#5036) 8 years ago
Gabriele c19e3b5924 Fixing nxos_vrrp (#5035) 8 years ago
Gabriele f89cb1717c Fixing nxos_vtp_password (#5037) 8 years ago
Gabriele b897b497c1 Fixing nxos_vtp_version (#5038) 8 years ago
Matt Davis 66a1b15f89 remove broken ansible_user_uid fact from Windows setup 8 years ago
Ryan Brown 135b92bf4e Check status of finished spot instance requests (#4990)
Per #3877, the code to wait for spot instance requests to finish would
hang for the full wait time if any spot request failed for any reason.
This commit introduces status checks for spot requests, so if the
request fails, finishes, or is cancelled the task will fail/succeed
accordingly.

One edge case introduced here is tha if a user terminates the instance
associated with the request manually it won't fail the play, under the
presumption that the user *wants* the instance terminated.
8 years ago