Commit Graph

11 Commits (2167be8fe9f693a38fe508ce256e46f1b9f97e15)

Author SHA1 Message Date
Bryan Larsen cea812c3a7 update_attr should wait for the full wait timeout before checking for a missing IP addres 11 years ago
Bryan Larsen 848b38fc7f digital_ocean doc update 11 years ago
Bryan Larsen bdbc963736 digital_ocean: don't run update_attr if wait=no
Sometimes when using digital_ocean with wait=no I get the error "No ip is found".  But with wait=no I wouldn't expect there to be any IP, that gets allocated later.   However, looking at the code, it turns out that with even with wait=no it waits up to 10 seconds for an IP to be allocated.  We could wait longer, but with wait=no that seems like the wrong choice; it's easy enough to grab an IP later with a wait=yes command.

To make this change I removed the call to update_attr in @classmethod add.  An add is always followed by an ensure_powered_on which will do the update_attr if wait=yes.   It would be possible to instead do a call to update_attr with no retries and ignore the errors but I figured it would be better to be consistently not return an IP than to sometimes return it and sometimes not.   Inconsistent behaviour makes debugging deployment scripts very difficult.
11 years ago
Benjamin Schwarze 31bc25063e fix wrong argument_spec in digital_ocean module
as 'required' and 'default' are mutually exclusive removed 'required' in preference of 'default'
12 years ago
Michael DeHaan 995ef374db Fixup versions of newly added modules. 12 years ago
Michael DeHaan 3f8aa8aec5 Fix up some module docs formatting errors. 12 years ago
Michael DeHaan 231d9b101d YAML fix 12 years ago
Michael DeHaan faaa90ed03 Merge branch 'ocean' into devel
Conflicts:
	library/cloud/digital_ocean
12 years ago
Michael DeHaan c9c45ac597 Reformat examples 12 years ago
Vincent Viallet cc1cb01540 Rename digital ocean module to digital_ocean, add documentation. 12 years ago
Vincent Viallet d4b5122ad9 Rename digital ocean module to digital_ocean, add documentation. 12 years ago