Commit Graph

62 Commits (1c3071af6138d560eb8bac2296a04115432e670d)

Author SHA1 Message Date
Brian Coca e5ed49d6c7 added patch to workaround some s3 connection faliures 10 years ago
Brian Coca 6570d48657 refactrored connection exception handling, added check to see if we actually get a connection before proceeding
Fixes #964
10 years ago
Alex Rowley 7d6cd3baaa cloud/amazon/s3: update documentation
update description to show that module can do more than just put files into s3
10 years ago
Toshio Kuratomi 974075277d Also don't fail if files are different and overwrite is false for uploads (this mimics copy and template).
Related to #489
10 years ago
Toshio Kuratomi 47c6dae9f3 Merge pull request #490 from pgehres/devel
Issue #489: s3 should not fail on checksum mismtach when overwrite=no
10 years ago
Michael Laccetti 5e7605475d Moving the import to the top of the file and getting rid of the redundancy
I sure do wish I knew where the whitespace change was coming from, though. Frustrating.
10 years ago
Michael Laccetti 60e2e43f00 Change s3 to use connect_to_region
* Allows us to use Ansible/s3 for GovCloud when accessing a pre-existing bucket
10 years ago
tedder c5fe40661d feature pull request: catch and retry recoverable errors
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
10 years ago
Peter Gehres 05ca85a172 Issue #489: s3 should not fail on checksum mismtach when overwrite=no 10 years ago
Michael DeHaan 9de0045d00 Remove potentially out of date or specific product references. 10 years ago
Michael DeHaan e7c92a6bc6 More EC2 doc tweaks 10 years ago
Brian Coca 0c4adcb2c6 made subcategories for cloud modules for better organization 10 years ago