Commit Graph

19 Commits (1b705a140375bd573d2bad5f76da18d2e06739b3)

Author SHA1 Message Date
Chao Luan 749e749c11 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
11 years ago
Richard C Isaacson 122917019c mysql_db module: typo fix
Tests clean.
11 years ago
Richard C Isaacson d9da5cf084 Shell updates. 11 years ago
Guido Kollerie 314e621671 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
11 years ago
Jim Kleckner 8ba9019797 Add quotes to password argument for dump/import
The password is passed on a command line for dump and import and needs
quoting.

Ideally, this would not be passed on a command line at all - any ideas?
Or at least have a stronger form of quoting so that embedded single
quotes will be escaped.
11 years ago
Jim Kleckner 59396d38e2 Fix mysql_db dump and import to use port argument
The code for mysql_db did not pass the port argument when state=dump or
state=import.
11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Michael DeHaan 4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan 9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
James Tanner f7db64d69b Merge pull request #4307 from damianmoore/mysql_gzip_bzip2_support
Add support for compressing mysql dumps and extracting during import.
11 years ago
James Tanner 3370aee870 Fixes #4720 Use mysql command to restore database instead of mysqldump 11 years ago
James Tanner f233e29386 mysql_db: if connection is a socket, do not specify hostname 11 years ago
James Tanner 9128862b3b Fixes #4301 Use module_common functions for mysqldump and return better errors 11 years ago
Damian Moore 85ed9af959 mysql_db now supports import and dump of gzip and bzip2 compressed files 11 years ago
Tom Dymond b3646176a9 Add option to specify the MySQL server port 11 years ago
Jan-Piet Mens 683e9e27c0 mysql_db small fix to docs 12 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago