ansible

Commit Graph

Author	SHA1	Message	Date
Matt Clay	3f387f225c	Fix safe_eval on Python 3.8.	7 years ago
Toshio Kuratomi	0633f73faf	Fix loader for filters (#37748 ) * Fix loading of filter and test plugins Filter and test plugins are different than other plugins in that they can have many plugins in a single file. Therefore they need to operate a little differently. They need to have all of the potential files returned. Then the caller takes care of passing those onto jinja2 in order for jinja2 to make use of them. This problem was (most recently) introduced with `f921369445` This commit also restructures how we deduplicate plugins to take paths into account. If we want to start scoping which set of modules are loaded (due to roles, for instance) we'll need to hang on to the path information. * add integration test for override * Fix style checks for bcoca code * Implement jinja2 plugin loader as a subclass Having a subclass allows us to customize the overriding of jinja plugins. We can then move common parts of common code into the Loader.	8 years ago
Matt Clay	68aeaa58a8	Fix dangerous default args. (#29839 )	8 years ago
Brian Coca	f921369445	Ansible Config part2 (#27448 ) * Ansible Config part2 - made dump_me nicer, added note this is not prod - moved internal key removal function to vars - carry tracebacks in errors we can now show tracebacks for plugins on vvv - show inventory plugin tracebacks on vvv - minor fixes to cg groups plugin - draft config from plugin docs - made search path warning 'saner' (top level dirs only) - correctly display config entries and others - removed unneeded code - commented out some conn plugin specific from base.yml - also deprecated sudo/su - updated ssh conn docs - shared get option method for connection plugins - note about needing eval for defaults - tailored yaml ext - updated strategy entry - for connection pliugins, options load on plugin load - allow for long types in definitions - better display in ansible-doc - cleaned up/updated source docs and base.yml - added many descriptions - deprecated include toggles as include is - draft backwards compat get_config - fixes to ansible-config, added --only-changed - some code reoorg - small license headers - show default in doc type - pushed module utils details to 5vs - work w/o config file - PEPE ATE! - moved loader to it's own file - fixed rhn_register test - fixed boto requirement in make tests - I ate Pepe - fixed dynamic eval of defaults - better doc code skip ipaddr filter tests when missing netaddr removed devnull string from config better becoem resolution * killed extra space with extreeme prejudice cause its an affront against all that is holy that 2 spaces touch each other! shippable timing out on some images, but merging as it passes most	8 years ago
Dag Wieers	5553b20828	Collated PEP8 fixes (#25293 ) - Make PEP8 compliant	9 years ago
Toshio Kuratomi	2fff690caa	Update module_utils.six to latest (#22855 ) * Update module_utils.six to latest We've been held back on the version of six we could use on the module side to 1.4.x because of python-2.4 compatibility. Now that our minimum is Python-2.6, we can update to the latest version of six in module_utils and get rid of the second copy in lib/ansible/compat.	9 years ago
Brian Coca	f078946ed3	no calls plz	9 years ago
Toshio Kuratomi	80357e07de	Add some comments about how we're cleaning callables	9 years ago
Toshio Kuratomi	027b126b42	Remove _clean_data_struct() advice as that was a 1.x design data now goes through this extra cleaning in the template rather than being an explicit other step.	9 years ago
Lumír 'Frenzy' Balhar	84544ee8fd	Fix AST nodes for Python 3 and enable dependent test_uri (#18597 ) * Enable tests on python 3 for uri * Added one more node type to SAFE_NODES into safe_eval module. ast.USub represents unary operators. This is necessary for parsing some unusual but still valid JSON files during testing with Python 3.	9 years ago
Dag Wieers	cd784cd345	Remove unnecessary warnings (#18121 )	9 years ago
Dag Wieers	d52a9cee46	Support late evaluation, suppress warnings on SyntaxError (#17462 ) See #14304 comments (https://github.com/ansible/ansible/pull/14304#issuecomment-245453209) for more information.	9 years ago
Dag Wieers	56148291e9	Emit warnings when safe_eval() raises a SyntaxError or other Exception (#14304 ) This change is related to reported issue #14291 and pull request #14293. Without the fix from #14293, this change will emit a warning as shown below, on the following playbook: ``yaml --- - hosts: localhost gather_facts: no vars: works: key1: 'string' key2: 1234 fails: key1: 'string' key2: 1234 key3: false tasks: - debug: msg={{ works \| to_json }} - debug: msg={{ fails \| to_json }} ``` On error, this results in a proper warning: ``` [dag@moria ansible.dag]$ ansible-playbook test49.yml PLAY ************************************************************************* TASK [debug] *************************************************************** ok: [localhost] => { "msg": { "key1": "string", "key2": 1234 } } TASK [debug] *************************************************************** [WARNING]: Error in expression "{"key3": false, "key2": 1234, "key1": "string"}". (name 'false' is not defined) ok: [localhost] => { "msg": "{\"key3\": false, \"key2\": 1234, \"key1\": \"string\"}" } PLAY RECAP ******************************************************************* localhost : ok=2 changed=0 unreachable=0 failed=0 ```	9 years ago
Dag Wieers	2e171610e0	Also add 'null' as a possible JSON value	10 years ago
Dag Wieers	dc48d27dd2	Defined JSON booleans in global context for python eval() We define 'false' and 'true' as variables so that python eval() recognizes them as False and True. This fixes #14291.	10 years ago
Toshio Kuratomi	baa309309d	Bundle a new version of python-six for compatibility along with some code to make it easy for distributions to override the bunndled copy if they have a new enough version.	10 years ago
Marius Gedminas	f91b28ef23	Fix safe_eval() of set literals There was code to support set literals (on Python 2.7 and newer), but it was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place, instead it returns a new set object that is then silently discarded. I added a unit test and fixed the code. I also changed the version check to use sys.version_tuple instead of a string comparison, for consistency with the subsequent Python 3.4 version check that I added in the previous commit.	10 years ago
Marius Gedminas	2b73002044	Python 3: make ansible.template.safe_eval() work Two things changed in Python 3.4: - 'basestring' is no longer defined, so use six.string_types - True/False are now special AST node types (NamedConstant) rather than just names (Good thing we had tests, or I wouldn't have noticed the 2nd thing!) I found only one place where safe_eval() is called inside the ansible codebase: in lib/template/__init__.py. The call to safe_eval(result, ...) is protected by result.startswith('...'), which means result cannot possibly be a byte string on Python 3 (or startswith() would raise, so six.string_types (which excludes byte strings on Python 3) is fine here.	10 years ago
James Cammarata	5434ed973b	Make sure locals in safe_eval is a plain dict when running eval Fixes #12206	10 years ago
James Cammarata	3a50c08c01	Merge branch 'pluggable_jinja_tests' of https://github.com/quixoten/ansible into quixoten-pluggable_jinja_tests	11 years ago
James Cammarata	ce3ef7f4c1	Making the switch to v2	11 years ago

21 Commits (1a8332d2cde376af8688d39e7da70f99dd5f747b)