Commit Graph

479 Commits (19a77228d3ee8d5038fae5813f7b17c87863878a)

Author SHA1 Message Date
Michael DeHaan bf33be20e1 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
11 years ago
Cristian Ciupitu a416dba3d1 hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
James Tanner 59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 11 years ago
Michael DeHaan 29138b1872 More shell updates 11 years ago
Richard C Isaacson 9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 11 years ago
Ryan 3494d67f30 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
11 years ago
Michael DeHaan 65c4e388eb Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
11 years ago
James Laska cb63352aff Fix issue#6430 by instantiating Network() with expected arguments 11 years ago
Richard C Isaacson 7d83f64bae Fix docstring issue. 11 years ago
Richard Isaacson 19d77ada25 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
11 years ago
James Tanner e63e909d6f Fix name in locale_gen docstring 11 years ago
James Tanner 4fae7da5e8 Fix snippet imports and version_added in ufw module 11 years ago
James Cammarata 6a81debb0a Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
11 years ago
James Tanner 820c328ca8 Set version_added for locale_gen 11 years ago
James Tanner 3763008d15 Rename locale module to locale_gen 11 years ago
James Cammarata 52d14d0fee Merge pull request #5411 from AugustusKling/locale
locale module
11 years ago
Michael DeHaan e767de4978 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
11 years ago
James Tanner fc33860e5d Force command action to not be executed by the shell unless specifically enabled 11 years ago
Matthew Riedel d21a8f6ddc Returning 'NA' when no virtualization found 11 years ago
Richard C Isaacson 3188429105 Some cleanup. 11 years ago
Charles Duffy 532cda524f #6341: use shared function for parsing systemd status; check rc code 11 years ago
Charles Duffy fd5083fe71 #6341: check systemd service status with show subcommand 11 years ago
Jarno Keskikangas 19fb807824 Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
11 years ago
Jarno Keskikangas 9abdacc725 Insert rule to a specific num. 11 years ago
Jarno Keskikangas 76eb4969fb Fix typo: 'reseted' -> 'reset'. 11 years ago
Jarno Keskikangas b8f37df8e7 Add protocol options 'esp' and 'ah'. 11 years ago
Jarno Keskikangas 767cfcb0bd Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
11 years ago
Aleksey Ovcharenko 4754bf47be New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
11 years ago
Richard C Isaacson ce98edfc87 Cleaning up pep8 alerts. 11 years ago
Richard C Isaacson bdfb2de7fc Documentation cleanup. 11 years ago
Richard C Isaacson a94e1e5477 Refactored a few things to be more inline with the Ansible way. Passing testing. 11 years ago
Charles Duffy 32620cab4d systemd template services must not discard template part 11 years ago
jctanner b105942654 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
11 years ago
Julien DAUPHANT 7ce4eba507 Add version_added 1.6 for the params modprobe option 11 years ago
Julien DAUPHANT c95b358694 Add linux module parameters for the modprobe module 11 years ago
anatoly techtonik 63f0a644ac setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 11 years ago
James Tanner 87f17e7e94 Fix debconf docstring indentation 11 years ago
James Tanner b07e5742b3 Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 11 years ago
Brian Coca a4f6a12181 didnt make 1.5 ... lets see 11 years ago
Brian Coca a7444f5178 added better gentoo/funtoo support 11 years ago
Michael DeHaan d71921492b Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
11 years ago
Laurens Van Houtven c50b772e61 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
11 years ago
James Cammarata 08fca488f3 Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
11 years ago
Dustin C. Hatch d2dc260e98 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
11 years ago
Chris Church 09b076e39c Fix setup module to gather facts from PowerPC Macs. 11 years ago
James Cammarata 8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
C. Morgan Hamill c29f2fb888 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
11 years ago
Nils Pascal Illenseer 7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden c892f51002 Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca 01a1482f1a hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca 4b0c2d839e made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca 8a6a2aba75 changes names to name in example 11 years ago
Brian Coca ddb191f208 fixes as per feedback 11 years ago
Tom Dymond c9e7541e60 Reworked PR to avoid repeating the command 11 years ago
jctanner 4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond 16edbd3181 Add option to enable the sysctl -e option 11 years ago
kustodian 405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 931f8e4c5b Add move_home option to user module 11 years ago
Richard C Isaacson cc20868bfb Tested implementation adding action option for (add, delete, unique). 11 years ago
Richard C Isaacson 855154226e Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson 4e4ba1f695 Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson c677056dfe Change to dynamically pick up the command from the PATH. 11 years ago
Richard C Isaacson 9dc98d9b66 Formating and syntax fixes that were pointed out during code review. 11 years ago
Richard C Isaacson eb9831cf62 Added user option. 11 years ago
Richard C Isaacson 7e1361d0e0 First commit of the at module being very basic. 11 years ago
Brian Coca fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Jakub Jirutka 1dc5ee00b6 sysctl: parse bool value as 0/1 and refactor a little bit 11 years ago
Thoai Nguyen 220b0f87d9 reorder usermod options 11 years ago
jctanner f14f6ebd44 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Augustus Kling de19375d1b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 11 years ago
Augustus Kling eabc9cd775 Merge remote-tracking branch 'upstream/devel' into locale 11 years ago
Augustus Kling 00ee613446 Handle install/uninstall of locales for Ubuntu, too. 11 years ago
Simon Zimmermann be69ca4ead correctly compare the values, better func name 11 years ago
Simon Zimmermann 45728d739c Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Simon Zimmermann 624c563e43 fix str format error due to missing '%' in sysctl module 11 years ago
James Tanner f3b86abc30 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 49b0db9819 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 921ae2134b Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 03aba39b59 Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 4ef5b60f3d Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
Scott Gilbert df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner a9c5aa8f78 Remove unused variable from authorized_key 11 years ago
James Tanner 30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
James Tanner 272c3634cd sysctl module: append newline character to lines in the file 11 years ago
Michael DeHaan cb6f7748d5 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
11 years ago
jctanner da9cd8e018 Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
11 years ago
jctanner 9779206142 Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
11 years ago
James Tanner 1b712ec48d sysctl module: fail if reloading the file did not succeed 11 years ago
James Tanner f0b842b28b Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
11 years ago
Tyler 5ce664b499 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler c073438d40 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Joshua Lund e0a720b8b2 Improved the documentation for password generation 11 years ago
James Tanner 154a99529c Fixes #5353 create etc/hostname file in debian if it does not exist 11 years ago