Commit Graph

635 Commits (184523ecac4020c0ce27bff6df4772fb4e10b6e9)

Author SHA1 Message Date
Michael DeHaan 335f136e71 Merge pull request #1023 from lorin/postgres-user-fix
Fix postgresql_user bug
12 years ago
Matt Coddington c0638842d8 make this python24 compatible 12 years ago
Lorin Hochstein b3b01bb7a3 Fix postgresql_user bug
If I create a database from scratch and assign permissions by doing:

      - name: ensure database is created
        action: postgresql_db db=$dbname

      - name: ensure django user has access
        action: postgresql_user db=$dbname user=$dbuser priv=ALL password=$dbpassword

Then it fails with the error:

  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 565, in <module>
    main()
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 273, in main
    changed = grant_privileges(cursor, user, privs) or changed
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 174, in grant_privileges
    changed = grant_func(cursor, user, name, privilege)\
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 132, in grant_database_privilege
    prev_priv = get_database_privileges(cursor, user, db)
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 118, in get_database_privileges
    r = re.search('%s=(C?T?c?)/[a-z]+\,?' % user, datacl)
  File "/usr/lib/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or buffer

This fix fixes the problem by not executing the regex if the
db query on pg_database returns None.
12 years ago
Seth Vidal 9d88b3eedd add import sys to virt module b/c it needs it if the libvirt python
module is missing
12 years ago
Michael DeHaan 4280e00d56 Merge pull request #1000 from mavimo/patch-1
Add support to removes control param
12 years ago
Michael DeHaan 7ef3e7dccb Merge pull request #1003 from bladypirat/devel
added support for custom port definition for postgresql_* modules
12 years ago
Michael DeHaan 49bef3f6c2 Merge pull request #1005 from dagwieers/cmdline
Add /proc/cmdline information to the default facts
12 years ago
Jan-Piet Mens b36aa61237 Add support for RSA/DSA SSH host key detection in setup module for OS/X
s/<8spaces>/<4spaces>/g
12 years ago
Dag Wieers d158218c3f Add /proc/cmdline information to the default facts
The use-case here is that based on information in the /proc/cmdline certain actions can be taken.

A practical example in our case is that we have a play at the end of the provisioning phase that reboots the system. Since we don't want to accidentally reboot a system (or restart the network) on a production machine, having a way to separate an Anaconda post-install (sshd in chroot) with a normal system is a good way to make that distinction.

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "not '${ansible_cmdline.BOOT_IMAGE}'.startswith('$')"

A practical problem here is the fact that we cannot simply check whether it is set or empty:

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "'${ansible_cmdline.BOOT_IMAGE}'"

If ansible_cmdline was a string, a simple only_if: "'${ansible_cmdline}'.find(' BOOT_IMAGE=')" was an option, but still not very "beautiful" :-/

This implementation uses shlex.split() and uses split(sep, maxsplit=1).
12 years ago
Piotr Kweclich 8360f9f46c added support for custom port definition 12 years ago
Marco Vito Moscaritolo 2dd430d9c0 Add support to removes control param
Execute action only if specified file using param removes exist (execute reverse control of creates).

Some usage eg.:

```yaml
- name: enable apache2 default websites
  action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl

- name: disable apache2 default websites
  action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl
```
12 years ago
Michael DeHaan eed031cd82 Check for ipv6 12 years ago
Michael DeHaan aa704a6111 backuplocal => backup_local for API standardization reasons 12 years ago
Michael DeHaan b97e2a6f5a Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel 12 years ago
Michael DeHaan c69c3d6e18 Merge pull request #995 from mattupstate/devel
Use `get_bin_path` properly for supervisorctl module
12 years ago
Daniel Hokka Zakrisson a5d63532d3 Add backup to assemble 12 years ago
Daniel Hokka Zakrisson 2a8b92954f Add backups to lineinfile 12 years ago
Daniel Hokka Zakrisson dfcb9d3c2d Move backup to module_common 12 years ago
willthames 8b8eae7d82 Allow ~ expansion in chdir argument of command module
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
12 years ago
willthames d4c4a51866 Subversion dest should allow ~ expansion
Used os.path.expanduser on dest to allow e.g. ~/svn/repo as
a destination
12 years ago
Michael DeHaan 8f220a4f77 Always pipe stderr in the setup module to avoid JSON interference. 12 years ago
Matt Wright d52f1d969b Use `get_bin_path` properly 12 years ago
Matt Wright a092eadbbb Fix supervisorctl module after merge issue 12 years ago
Michael DeHaan 8e02b165f1 chmod +x 12 years ago
Michael DeHaan b0ac7e07b0 Merge branch 'binpath' of https://github.com/sfromm/ansible into devel
Conflicts:
	library/supervisorctl
12 years ago
Michael DeHaan a454db5345 Merge pull request #970 from mattupstate/devel
Improve apt_repository and supervisorctl
12 years ago
Michael DeHaan 90f051f818 Merge pull request #971 from sfromm/seboolean
Add seboolean module
12 years ago
Michael DeHaan 092bd8e3da make parameter required 12 years ago
Michael DeHaan 4da4c31dfb Merge pull request #974 from goozbach/add_selinux_module
add selinux module
12 years ago
Derek Carter 2aa760a3fc add selinux module 12 years ago
Stephen Fromm 6742e9c3f4 Add option required=(True|False) to get_bin_path and update modules
Added required as optional argument to get_bin_path(). It defaults to
false.  Updated following modules to use required=True when calling
get_bin_path():  apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
12 years ago
Matt Wright b93df1fc60 Update handling of state changes 12 years ago
Matt Wright bdfccbfb34 Move conditional that accounts for variances in distros/versions to work when removing and adding. 12 years ago
Stephen Fromm 97c2e58081 Add seboolean module
Will manage values of seboolean on a host.  Options are name (name of
boolean), state (on or off), and persistent (on or off).  Persistent
defaults to no.
12 years ago
Stephen Fromm e5a635672c Migrate remaining modules to use get_bin_path in module_common.py
* Migraed easy_install, pip, service, setup, and user.
* Updated fail_json message in apt_repository
* Fixed easy_install to not hardcode location of virtualenv in
  /usr/local/bin/.
* Made handling of virtualenv more consistent between easy_install and
  pip.
12 years ago
Stephen Fromm bdb39058ae Migrate apt_repository, group, and supervisorctl to use module.get_bin_path 12 years ago
Daniel Hokka Zakrisson ed8e31d618 Add a lineinfile module 12 years ago
Michael DeHaan d0994cd169 Merge branch 'setup-no-dash-facts' of https://github.com/tima/ansible into devel
Conflicts:
	library/setup
12 years ago
Matt Wright a82928e7dc fix bug in supervisorctl module 12 years ago
Timothy Appnel 8c32aefc80 Replace - with _ in setup module key names to avoid variable access problems reported in #954 12 years ago
Michael DeHaan f9e9753141 Remove obsolete comment 12 years ago
Michael DeHaan d7eed66a06 Merge pull request #951 from gottwald/devel-git-sudo-fix
Added cwd to tempdir in git clone method. Fixes usage with sudo.
12 years ago
Ingo Gottwald 30fdd56560 Added cwd to tempdir in git clone method. Fixes usage with sudo. 12 years ago
Tim Bielawa 6b73907811 Change from a module config file to brute force locating the nagios configs so we can find the command file. 12 years ago
Tim Bielawa 98d3e2bfc8 Nagios is executable now 12 years ago
Tim Bielawa 8b8aaa7f76 Fix copying that special character 12 years ago
Tim Bielawa da2665bcd2 In-line docs. 12 years ago
Tim Bielawa 9829033a8a Now reading from a config file actually works. 12 years ago
Tim Bielawa 62ffeb93a5 Services iterate correctly now
Cleaned up return methods
12 years ago
Tim Bielawa 5d41fffa00 Groundwork for nagios module. 12 years ago
Florian Diebold 886fed5ae7 Remove ternary operator to fix python 2.4 compatibility. 12 years ago
Florian Diebold af17bab373 Support systemd in the service module.
Most of it worked already, except for the enable parameter, because it
tried to use chkconfig which only sees SysV services. First look for
systemctl and use that if it exists.
12 years ago
Michael DeHaan 4816644b22 Merge pull request #937 from jhoekx/wait-state
Add a state parameter to the wait_for module.
12 years ago
Michael DeHaan 165f4b514d Merge pull request #938 from skvidal/devel
fix up local_nvra and fix for a missing localinstall rpm file.
12 years ago
Maxim Burgerhout 3d44de284a Add working CPU model fact for some ARM devices
Works on Sheevaplug, probably works on Rasberry Pi as well
12 years ago
Jeroen Hoekx 81c9a0cb78 wait_for: remove restarted, add delay, rename name to host, make port required. 12 years ago
Jeroen Hoekx 18d5c875d0 Change wait_for return message to be machine readable. 12 years ago
Seth Vidal 5dbc85e8ad fix up local_nvra 12 years ago
Jeroen Hoekx 5ba34572d9 Add a state parameter to the wait_for module.
This takes started, stopped and restarted.

Started returns when connecting is possible.
Stopped when connecting is not possible.
Restarted first waits for connecting to be impossible and returns when it is
possible again.
12 years ago
Michael DeHaan 150a47c66c Merge pull request #922 from dsummersl/subversion
Subversion
12 years ago
Michael DeHaan b3b607ff5e Merge pull request #931 from elventear/postgresql_db
Allow change of ownership and checks for existing database
12 years ago
Michael DeHaan 7341ed241e Merge pull request #924 from elventear/postgresql_user
Change semantics of postgresql_user module
12 years ago
Jeroen Hoekx 8660fb074a Add the wait_for module.
This module waits until a specific port on a given host can be connected to.
12 years ago
Dane Summers 71cff25254 added force option to git - made both subversion and git default to force=true for backward compatibility with git's previous behavior 12 years ago
Dane Summers 6dd6a4c534 tested library - fixed several test cases, added 'force' option, and removed grep requirement 12 years ago
Pepe Barbe fdaf65282b bugfix in sql query 12 years ago
Pepe Barbe fdbc99dc28 Check for database ownership 12 years ago
Pepe Barbe 6d473df324 Typo 12 years ago
Pepe Barbe af5d67c496 Query for all active privileges instead
Use a different method to query for current 
privileges at the table and database level. 
This method is more robust if newer privileges 
are added in future versions and also supports the 
ALL wildcard.
12 years ago
Pepe Barbe 95169b75c4 Add fail_on_user option
fail_on_user option can be used to ignore silently
if the user cannot be removed because of remaining
privilege dependencies to other objects in the 
database. By default it will fail, so that this new 
behavior won't surprise unsuspecting users.
12 years ago
Pepe Barbe 4e833cf506 Initial commit of change of semantics for module
The postgresql_user module has several drawbacks:
* No granularity for privileges
* PostgreSQL semantics force working on one
  database at time, at least for Tables. Which
  means that a single call can't remove all the 
  privileges for a user, and a user can't be
  removed until all the privileges are removed, 
  forcing a module failure with no way to 
  work around the issue.

Changes:
* Added the ability to specify granular privileges
  for database and tables within the database
* Report if user was removed, and add an option to 
  disable failing if user is not removed.
12 years ago
Dane Summers 24c8c22e75 removed logger, removed superfluous mkdir 12 years ago
Dane Summers 157fa3868a added TODO for test scenarios to add 12 years ago
Dag Wieërs 9d4f70f0ad Handle special files just like normal files
As discussed in #923
12 years ago
Michael DeHaan 1ae018ce94 Adds a thirsty=yes|no to the get_url module, such that if downloading a large file from the internet you can decide
whether to download it every time or not -- will replace only on change, or decide to not download.  The default
is thirsty=no which will not download every time by default.
12 years ago
Tim Bielawa 3d3c8a004e Fix setup module explosion when a route is empty. Closes #909 12 years ago
Michael DeHaan 14c2e8de0c Fix invalid usage or fail_json in apt module 12 years ago
Michael DeHaan 798c35d83e Apt module should accept 'absent', and 'present' like the yum module does. 12 years ago
Michael DeHaan 8eda23f856 tweak service module pattern= logic so ./hacking/test-module does not give false positives 12 years ago
Michael DeHaan bc571ccb55 Merge pull request #902 from sfromm/issue719
Add pattern option to service module
12 years ago
Michael DeHaan 2b51cf04c7 Merge pull request #901 from dhozac/setup-ip
Work with tun and p2p interfaces
12 years ago
Michael DeHaan 705057b9a6 Merge pull request #900 from lorin/pip-venv-bug
Retrieve pip path after creating virtualenv
12 years ago
Michael DeHaan 229ab1582a Merge pull request #898 from elventear/postgresql_user_py24
Fixes for postgresql_user to make it work with postgresql defaults and under Python 2.4
12 years ago
Stephen Fromm 18f0302de8 Add pattern option to service module
Adds ability to check service status based on pattern.  The pattern
is a simple string.  If a pattern is provided, the output of ps is
checked first.
12 years ago
Daniel Hokka Zakrisson 121341833a Work with tun and p2p interfaces 12 years ago
Lorin Hochstein 8223d3ee3f Retrieve pip path after creating virtualenv
Retrieve the pip path after creating a non-existent virtualenv.
Prevents the problem of using the wrong pip if virtualenv doesn't
exist yet.
12 years ago
Pepe Barbe 3dd2c0700f Syntax change to make module compatible with Python 2.4 12 years ago
Lorin Hochstein 8af3403f65 Return both stdout and stderr on pip failures.
pip failure message sometimes (always?) go to standard out. Return
both standard out and standard error when there's a failure.
12 years ago
Michael DeHaan c93df29249 Make a more logical error when the command/shell module is used with no arguments. 12 years ago
Sundar Raman 3aff9396e8 (Re #882) Handle errors in get_interfaces
If there is an error in how interfaces are configured (or only one set, like IPv6),
the setup command should not error out.
12 years ago
Dane Summers 19686d549c support for subversion repositories 12 years ago
Jeremy Penner 09d5812cbb Make easy_install module actually work.
mpdehaan requested in ansible/ansible#795 that globals be removed.
The response was to remove the lines with the word 'global', but not
the actual use of global variables.  Which makes the module break silently.
Updated to use local variables.
12 years ago
Michael DeHaan ded0c61750 meaningless whitespace changes 12 years ago
Michael DeHaan de4b8dc53a Can use fail JSON here, remove debug statement 12 years ago
Michael DeHaan 58c975d621 Fix aliases, package not found is not an error 12 years ago
Michael DeHaan 07fd96acc9 Merge branch 'devel' of https://github.com/skvidal/ansible into devel 12 years ago
Michael DeHaan 731adc0eaf Merge pull request #866 from akhayyat/devel
setup: add type and default_ipv{4,6} to linux network facts
12 years ago
Michael DeHaan a2a8cfe099 Merge pull request #876 from elventear/postgresql_fix
Changes to postgresql to support defaults settings and older psycopg2
12 years ago
Pepe Barbe 7dcd1bd223 Autocommit support for psycopg2 < 2.4.2 12 years ago
Pepe Barbe 95fc5dd4a8 Fix using postgres default values
When initalizing a connection to psycopg2, in order to use the default
values, the keywords must be missing. So we use a dictionary as a kwarg
and include only the keywords that do not have an empty value on the
module parameters.
12 years ago
Seth Vidal 3175eacfc4 fixes to yum module
include local_nvra
change the remove behavior to pretty much NEVEr error out if the pkg is not there (or anywhere)
12 years ago
Seth Vidal 14479e6adc cover all of the edge cases with and without yum-utils installed.
it is possible those folks w/o yum-utils installed but with rhn-plugin
installed but w/o any rhn-certificates will still see an error msg.
they have 3 options:
1. remove rhn-plugin
2. enable some channels w/rhn certs
3. install yum-utils
12 years ago
Seth Vidal 2e3926d13f subprocess is already imported in module_common - no need for it here 12 years ago
Daniel Hokka Zakrisson ae964b97c4 Fix spelling of architecture for non-x86 12 years ago
Ahmad Khayyat c96c51a534 setup: add type and default_ipv{4,6} to linux network facts 12 years ago
Michael DeHaan 7ab0d60b1a update config code 12 years ago
Michael DeHaan 3b259ef5f6 Merge pull request #859 from zecrazytux/bugfix/apt_repository
Bugfix/apt repository
12 years ago
Michael DeHaan e29ee9db2b Merge pull request #860 from goozbach/broken_mount
fixed missing module argument for mount module
12 years ago
Pepe Barbe bce1d4da53 Use Python 2.4 compatible syntax 12 years ago
Derek Carter 556593bb18 fixed missing module argument for mount module 12 years ago
Sebastien Bocahu d95eddceb1 Quote the repository string when appending it to the command line in the apt_repository module. 12 years ago
Sebastien Bocahu 3e9bcd351d Add support for Debian in apt_repository 12 years ago
Sebastien Bocahu df269c72c1 Fixed scoping issue in apt_repository module. 12 years ago
Stephen Fromm c4ce5f9497 Try to find ip command in either /sbin or /usr/sbin
If ip is not found in either /sbin or /usr/sbin, this will return
an empty result.  It seems extremely unlikely that a linux system will
not have iproute2 installed
12 years ago
Stephen Fromm 84028c2339 Tweak invocation of ip in LinuxNetwork
Specify full path to ip and add third argument 'show' to be explicit
about requested action.  This goes from 'ip addr' to
'/sbin/ip addr show'.
12 years ago
Michael DeHaan 75bbd73173 Fix indentation 12 years ago
Michael DeHaan 67301c1015 rename variable 'pkg' in yum module such that the auto-handled error messages use the same key. 12 years ago
Michael DeHaan 1e4d45af1e Add module common code to allow it to be easier to indicate whether arguments are mutually exclusive, required in conjunction, or whether one of a list of arguments is required. This simplifies writing Python modules. 12 years ago
Michael DeHaan e9c9d8f523 tweak config mode check to just have a default 12 years ago
Michael DeHaan 477ca2ed1a Make pep8 tests run against the library directory as well, and associated tweaks (mostly to indentation) in the library
directory.
12 years ago
Michael DeHaan e0765be1ea Merge pull request #850 from akhayyat/virt-facts
Add openvz detection to virtualization facts, and some cleanup
12 years ago
Michael DeHaan 32922e404b Don't include local addresses in the all_ipv4/6 list 12 years ago
Ahmad Khayyat 916fcdb93b Add openvz detection to virtualization facts, and some cleanup 12 years ago
Ahmad Khayyat f0a8e13628 Update doc string and minor cleanup 12 years ago
Ahmad Khayyat 7950dd01e5 Recognize interface aliases in network facts, and add IP facts 12 years ago
Michael DeHaan 36527ca9d5 Merge pull request #838 from sfromm/issue825
Update file module to not recurse when setting ownership
12 years ago
Sébastien Bocahu 487d07a845 Fix variable scope 12 years ago
Stephen Fromm 94696fb88e Update file module to not recurse when setting ownership
This updates set_owner_if_different() and set_group_if_different()
to not implicitly recurse when setting ownership (whether user or
group).  It drops the os.system() call and replaces it with os.chown().
Resolves issue #825.

The recursion should be explicit.  A recurse=yes|no option should be
added to the file module.
12 years ago
Michael DeHaan 9e934acfca Relative symlinks don't really work (module bug) and would be confusing anyway, better to be explicit. 12 years ago
Michael DeHaan ef18f9d953 Fix a scoping issue that was fixing some non-repoquery-installed cases 12 years ago
Michael DeHaan 63641da225 Merge branch 'yum-wo-repoquery' of https://github.com/dhozac/ansible into devel
Conflicts:
	library/yum
12 years ago
Michael DeHaan 8e12440db4 Merge pull request #830 from cybertoast/feature/pip_module_py2.4
Feature/pip module py2.4
12 years ago
Michael DeHaan f311d685cb Merge pull request #828 from skvidal/devel
add backup= option to copy. makes a backup of the file on the target
12 years ago
Sundar Raman 66a6231922 Further syntax fix work on Python2.4
The `val if something else something-else` syntax does not work prior to 2.5.
12 years ago
Sundar Raman 9ad91d7369 Fix syntax to work on Python2.4
The `val if something else something-else` syntax does not work prior to 2.5
12 years ago
Seth Vidal 588b129018 fix case where destination does not yet exist - no backup can be made 12 years ago
Seth Vidal 28e9b1128f add backup= option to copy. makes a backup of the file on the target
in a file named: $filename.YYYY-MM-DD@HH:MM~

backup=False is default
12 years ago
Seth Vidal 5c458b9761 make yum module work with list=pkgspec 12 years ago
Daniel Hokka Zakrisson 5a7d271759 Allow using the yum module without repoquery
It is still required to use list=..., but the typical install and remove
won't need it.
12 years ago
Michael DeHaan c82f06258c Only run yum,apt through the with_items loop if there is a list of items. Just a cosmetic fix on return values
for the most part.
12 years ago
Michael DeHaan d451cc6463 Merge pull request #794 from mattupstate/apt_repository
add apt_repository module
12 years ago
Michael DeHaan b378a94b7b Merge pull request #796 from mattupstate/pip
add pip module
12 years ago
Michael DeHaan 82dfb11fb9 Merge pull request #807 from mattupstate/supervisorctl
Add supervisorctl module
12 years ago
Michael DeHaan 67205eb816 Merge pull request #795 from mattupstate/easy_install
Add easy_install module
12 years ago
Michael DeHaan 311d7c46ca Merge pull request #806 from skvidal/devel
fix up yum state=latest with pkg groups
12 years ago
Michael DeHaan fe65648ea5 Merge pull request #808 from sfromm/issue800
Make exception more specific (OSError) in setup module for selinux call
12 years ago
Seth Vidal 61e02d508c add show-duplicates to reqpoquery to keep people who
want to install an old package happy.
12 years ago
Stephen Fromm 0cc73c930b Make exception more specific (OSError) in setup module for selinux call 12 years ago
Matt Wright 34e0faaf4b Add supervisorctl module 12 years ago
Matt Wright 15e9f1e15a Update per ansible/ansible#794 12 years ago